homebridge-yoto 0.0.36 → 0.0.37

package/lib/accessory.js

@@ -129,15 +129,15 @@ export class YotoPlayerAccessory {
       : {}
 
     return {
-      playback: getBooleanSetting(serviceConfig.playback, getServiceDefault('playback')),
-      volume: getBooleanSetting(serviceConfig.volume, getServiceDefault('volume')),
-      temperature: getBooleanSetting(serviceConfig.temperature, getServiceDefault('temperature')),
-      nightlight: getBooleanSetting(serviceConfig.nightlight, getServiceDefault('nightlight')),
-      cardSlot: getBooleanSetting(serviceConfig.cardSlot, getServiceDefault('cardSlot')),
-      nightMode: getBooleanSetting(serviceConfig.nightMode, getServiceDefault('nightMode')),
-      sleepTimer: getBooleanSetting(serviceConfig.sleepTimer, getServiceDefault('sleepTimer')),
-      bluetooth: getBooleanSetting(serviceConfig.bluetooth, getServiceDefault('bluetooth')),
-      volumeLimits: getBooleanSetting(serviceConfig.volumeLimits, getServiceDefault('volumeLimits')),
+      playback: getBooleanSetting(serviceConfig['playback'], getServiceDefault('playback')),
+      volume: getBooleanSetting(serviceConfig['volume'], getServiceDefault('volume')),
+      temperature: getBooleanSetting(serviceConfig['temperature'], getServiceDefault('temperature')),
+      nightlight: getBooleanSetting(serviceConfig['nightlight'], getServiceDefault('nightlight')),
+      cardSlot: getBooleanSetting(serviceConfig['cardSlot'], getServiceDefault('cardSlot')),
+      nightMode: getBooleanSetting(serviceConfig['nightMode'], getServiceDefault('nightMode')),
+      sleepTimer: getBooleanSetting(serviceConfig['sleepTimer'], getServiceDefault('sleepTimer')),
+      bluetooth: getBooleanSetting(serviceConfig['bluetooth'], getServiceDefault('bluetooth')),
+      volumeLimits: getBooleanSetting(serviceConfig['volumeLimits'], getServiceDefault('volumeLimits')),
     }
   }
 
@@ -663,10 +663,6 @@ export class YotoPlayerAccessory {
             this.updateFirmwareVersionCharacteristic(status.firmwareVersion)
             break
 
-          case 'maxVolume':
-            this.updateVolumeLimitProps(status.maxVolume)
-            break
-
           case 'temperatureCelsius':
             if (this.#deviceModel.capabilities.hasTemperatureSensor && status.temperatureCelsius !== null) {
               this.updateTemperatureCharacteristic(status.temperatureCelsius)
@@ -687,8 +683,6 @@ export class YotoPlayerAccessory {
             if (this.#deviceModel.capabilities.hasColoredNightlight) {
               this.updateNightlightStatusCharacteristics()
             }
-            // Day/night mode affects which volume limit is active
-            this.updateVolumeLimitProps(status.maxVolume)
             break
 
           case 'cardInsertionState':
@@ -697,6 +691,7 @@ export class YotoPlayerAccessory {
 
           // Available but not yet mapped to characteristics
           case 'activeCardId':
+          case 'maxVolume':
           case 'powerSource':
           case 'wifiStrength':
           case 'freeDiskSpaceBytes':
@@ -873,12 +868,12 @@ export class YotoPlayerAccessory {
     })
 
     // Lifecycle events
-    this.#deviceModel.on('online', ({ reason }) => {
+    this.#deviceModel.on('online', ({ reason: _reason }) => {
       // Platform logs online/offline events to avoid duplicate output.
       this.updateOnlineStatusCharacteristic(true)
     })
 
-    this.#deviceModel.on('offline', ({ reason }) => {
+    this.#deviceModel.on('offline', ({ reason: _reason }) => {
       // Platform logs online/offline events to avoid duplicate output.
       this.updateOnlineStatusCharacteristic(false)
     })
@@ -926,6 +921,7 @@ export class YotoPlayerAccessory {
    * @returns {Promise<CharacteristicValue>}
    */
   async getVolume () {
+    this.#log.debug(LOG_PREFIX.ACCESSORY, `[${this.#device.name}] Get volume`)
     return this.#deviceModel.status.volume
   }
 
@@ -949,6 +945,10 @@ export class YotoPlayerAccessory {
       ? deviceModel.status.maxVolume
       : 16
     const steps = Math.max(0, Math.min(Math.round(requestedSteps), maxVolumeSteps))
+    this.#log.debug(
+      LOG_PREFIX.ACCESSORY,
+      `[${this.#device.name}] Set volume raw=${value} steps=${requestedSteps} -> ${steps} (max ${maxVolumeSteps}/16)`
+    )
 
     // Track last non-zero volume for unmute
     if (steps > 0) {
@@ -1560,6 +1560,10 @@ export class YotoPlayerAccessory {
    */
   async getDayMaxVolume () {
     const limit = this.#deviceModel.config.maxVolumeLimit
+    this.#log.debug(
+      LOG_PREFIX.ACCESSORY,
+      `[${this.#device.name}] Get day max volume limit: ${limit}`
+    )
     return Number.isFinite(limit) ? limit : 16
   }
 
@@ -1576,7 +1580,10 @@ export class YotoPlayerAccessory {
     }
 
     const limit = Math.max(0, Math.min(Math.round(requested), 16))
-    this.#log.debug(LOG_PREFIX.ACCESSORY, `Setting day max volume limit: ${limit}/16`)
+    this.#log.debug(
+      LOG_PREFIX.ACCESSORY,
+      `[${this.#device.name}] Set day max volume limit raw=${value} requested=${requested} -> ${limit}/16`
+    )
     await this.#deviceModel.updateConfig({ maxVolumeLimit: limit })
   }
 
@@ -1586,6 +1593,10 @@ export class YotoPlayerAccessory {
    */
   async getNightMaxVolume () {
     const limit = this.#deviceModel.config.nightMaxVolumeLimit
+    this.#log.debug(
+      LOG_PREFIX.ACCESSORY,
+      `[${this.#device.name}] Get night max volume limit: ${limit}`
+    )
     return Number.isFinite(limit) ? limit : 10
   }
 
@@ -1602,7 +1613,10 @@ export class YotoPlayerAccessory {
     }
 
     const limit = Math.max(0, Math.min(Math.round(requested), 16))
-    this.#log.debug(LOG_PREFIX.ACCESSORY, `Setting night max volume limit: ${limit}/16`)
+    this.#log.debug(
+      LOG_PREFIX.ACCESSORY,
+      `[${this.#device.name}] Set night max volume limit raw=${value} requested=${requested} -> ${limit}/16`
+    )
     await this.#deviceModel.updateConfig({ nightMaxVolumeLimit: limit })
   }
 
@@ -1634,30 +1648,15 @@ export class YotoPlayerAccessory {
       this.#lastNonZeroVolume = volumeSteps
     }
 
+    const normalizedVolume = Number.isFinite(volumeSteps) ? volumeSteps : 0
+    const clampedVolume = Math.max(0, Math.min(normalizedVolume, 16))
+    this.#log.debug(
+      LOG_PREFIX.ACCESSORY,
+      `[${this.#device.name}] Update volume characteristic raw=${volumeSteps} -> ${clampedVolume}`
+    )
     this.volumeService
       .getCharacteristic(Characteristic.Brightness)
-      .updateValue(volumeSteps)
-  }
-
-  /**
-   * Update volume limit props - adjusts max value based on day/night mode
-   * @param {number} maxVolume - Maximum volume limit (0-16)
-   */
-  updateVolumeLimitProps (maxVolume) {
-    if (!this.volumeService) return
-
-    const { Characteristic } = this.#platform
-    const maxVolumeSteps = Number.isFinite(maxVolume) ? maxVolume : 16
-    const clampedMaxVolume = Math.max(0, Math.min(maxVolumeSteps, 16))
-    this.volumeService
-      .getCharacteristic(Characteristic.Brightness)
-      .setProps({
-        minValue: 0,
-        maxValue: clampedMaxVolume,
-        minStep: 1,
-      })
-
-    this.#log.debug(`[${this.#device.name}] Volume max is ${clampedMaxVolume}/16`)
+      .updateValue(clampedVolume)
   }
 
   /**
@@ -1920,16 +1919,26 @@ export class YotoPlayerAccessory {
 
     if (this.dayMaxVolumeService) {
       const limit = Number.isFinite(config.maxVolumeLimit) ? config.maxVolumeLimit : 16
+      const clampedLimit = Math.max(0, Math.min(limit, 16))
+      this.#log.debug(
+        LOG_PREFIX.ACCESSORY,
+        `[${this.#device.name}] Update day max volume characteristic raw=${limit} -> ${clampedLimit}`
+      )
       this.dayMaxVolumeService
         .getCharacteristic(Characteristic.Brightness)
-        .updateValue(limit)
+        .updateValue(clampedLimit)
     }
 
     if (this.nightMaxVolumeService) {
       const limit = Number.isFinite(config.nightMaxVolumeLimit) ? config.nightMaxVolumeLimit : 10
+      const clampedLimit = Math.max(0, Math.min(limit, 16))
+      this.#log.debug(
+        LOG_PREFIX.ACCESSORY,
+        `[${this.#device.name}] Update night max volume characteristic raw=${limit} -> ${clampedLimit}`
+      )
       this.nightMaxVolumeService
         .getCharacteristic(Characteristic.Brightness)
-        .updateValue(limit)
+        .updateValue(clampedLimit)
     }
   }
 

package/lib/platform.js

@@ -70,7 +70,7 @@ export class YotoPlatform {
       return
     }
 
-    log.info('Authentication tokens found, initializing Yoto account...')
+    log.debug('Authentication tokens found, initializing Yoto account...')
 
     const { updateHomebridgeConfig, sessionId } = this
 
@@ -158,7 +158,7 @@ export class YotoPlatform {
     }
 
     try {
-      this.log.info('Starting Yoto account...')
+      this.log.debug('Starting Yoto account...')
 
       // Listen for devices being added
       this.yotoAccount.on('deviceAdded', async ({ deviceId }) => {

package/lib/sync-service-names.js

@@ -22,13 +22,16 @@ export function syncServiceNames ({
 
   service.updateCharacteristic(Characteristic.Name, sanitizedName)
 
-  // Set ConfiguredName on all services, not just ones that say they support it.
-  // This is the only way to set the service name inside an accessory.
-  // const hasConfiguredNameCharacteristic = service.characteristics.some(c => c.UUID === Characteristic.ConfiguredName.UUID)
-  // const hasConfiguredNameOptional = service.optionalCharacteristics.some(c => c.UUID === Characteristic.ConfiguredName.UUID)
-  // if (!hasConfiguredNameCharacteristic && !hasConfiguredNameOptional) {
-  //   service.addOptionalCharacteristic(Characteristic.ConfiguredName)
-  // }
+  // Add ConfiguredName when missing so we avoid HAP warnings on update.
+  const configuredNameUuid = Characteristic.ConfiguredName.UUID
+  const hasConfiguredNameCharacteristic = service.characteristics
+    .some((characteristic) => characteristic.UUID === configuredNameUuid)
+  const hasConfiguredNameOptional = service.optionalCharacteristics
+    .some((characteristic) => characteristic.UUID === configuredNameUuid)
+
+  if (!hasConfiguredNameCharacteristic && !hasConfiguredNameOptional) {
+    service.addOptionalCharacteristic(Characteristic.ConfiguredName)
+  }
 
   service.updateCharacteristic(Characteristic.ConfiguredName, sanitizedName)
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-yoto",
   "description": "Control your Yoto players through Apple HomeKit with real-time MQTT updates",
-  "version": "0.0.36",
+  "version": "0.0.37",
   "author": "Bret Comnes <bcomnes@gmail.com> (https://bret.io)",
   "bugs": {
     "url": "https://github.com/bcomnes/homebridge-yoto/issues"