homebridge-xiaomi-miot 1.2.1 → 1.2.2

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [1.2.2] - 2026-11-09
+
+### Fixed
+- **Offline detection no longer interferes with the MiOT library's reconnect cycle** — `pushOffline` previously set `miotDevice.localConnected = false` directly, which caused the vendored library to treat the device as disconnected and trigger an unnecessary handshake/reconnect cycle (~80 s downtime) even when the device was actually reachable. Now `localConnected` is left untouched; instead, `onSet` handlers are patched (the same way `onGet` handlers already were) so that both reads and writes correctly return `SERVICE_COMMUNICATION_FAILURE` while offline. Handlers are restored when the device comes back.
+- **Property set and action failures are now logged at `warn` level** — errors in `setProperty` and `executeAction` were previously swallowed into `debug`-only logs, making silent control failures invisible to users. They now appear as `warn` messages in the Homebridge log.
+
+---
+
 ## [1.2.1] - 2026-06-08
 
 ### Changed

package/index.js

@@ -12,7 +12,7 @@ const Events        = require(MIOT_ROOT + 'constants/Events.js');
 
 const PLUGIN_NAME = 'homebridge-xiaomi-miot';
 const PLATFORM_NAME = 'XiaomiMiot';
-const PLUGIN_VERSION = '1.2.1';
+const PLUGIN_VERSION = '1.2.2';
 
 /* ── Silence verbose MiOT startup logs ── */
 const MIOT_INFO_SUPPRESS = [
@@ -229,7 +229,6 @@ class XiaomiMiotDeviceController {
 
     /* ── Install error-throwing getHandler on every characteristic ── */
     const pushOffline = () => {
-      this.miotDevice.localConnected = false;
       eachChar(char => {
         /* Save original handler (once only) and replace with error thrower */
         if (!Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigGet')) {
@@ -238,13 +237,18 @@ class XiaomiMiotDeviceController {
             throw new HapStatusError(HAPStatus.SERVICE_COMMUNICATION_FAILURE);
           });
         }
+        if (!Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigSet') && char.setHandler !== undefined) {
+          char._xiaomiOrigSet = char.setHandler;
+          char.onSet(() => {
+            throw new HapStatusError(HAPStatus.SERVICE_COMMUNICATION_FAILURE);
+          });
+        }
       });
       this.logger.warn(`[OfflineDetect] ${this.name} — offline.`);
     };
 
-    /* ── Restore original getHandlers when device comes back ── */
+    /* ── Restore original get/set handlers when device comes back ── */
     const pushOnline = () => {
-      this.miotDevice.localConnected = true;
       eachChar(char => {
         if (Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigGet')) {
           if (char._xiaomiOrigGet) {
@@ -254,6 +258,10 @@ class XiaomiMiotDeviceController {
           }
           delete char._xiaomiOrigGet;
         }
+        if (Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigSet')) {
+          char.onSet(char._xiaomiOrigSet);
+          delete char._xiaomiOrigSet;
+        }
       });
     };
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-xiaomi-miot",
   "displayName": "Homebridge Xiaomi MiOT",
-  "version": "1.2.1",
+  "version": "1.2.2",
   "description": "Homebridge plugin for Xiaomi devices using the MiOT protocol — local and MiCloud",
   "main": "index.js",
   "scripts": {},

package/vendor/miot/lib/protocol/MiotDevice.js

@@ -1237,7 +1237,7 @@ class MiotDevice extends EventEmitter {
         throw new Error(`Error while setting property ${prop.getName()} to value ${value}! Invalid response. Response: ${JSON.stringify(result)}`);
       }
     } catch (err) {
-      this.logger.debug(err);
+      this.logger.warn(`Set property failed: ${err.message || err}`);
     }
   }
 
@@ -1262,7 +1262,7 @@ class MiotDevice extends EventEmitter {
         throw new Error(`Error while executing action ${action.getName()} with params ${paramValues}! Invalid response from device. Response: ${JSON.stringify(result)}`);
       }
     } catch (err) {
-      this.logger.debug(err);
+      this.logger.warn(`Execute action failed: ${err.message || err}`);
     }
   }