homebridge-xiaomi-miot 1.2.0 → 1.2.2

package/CHANGELOG.md

@@ -1,10 +1,25 @@
 # Changelog
 
+## [1.2.2] - 2026-11-09
+
+### Fixed
+- **Offline detection no longer interferes with the MiOT library's reconnect cycle** — `pushOffline` previously set `miotDevice.localConnected = false` directly, which caused the vendored library to treat the device as disconnected and trigger an unnecessary handshake/reconnect cycle (~80 s downtime) even when the device was actually reachable. Now `localConnected` is left untouched; instead, `onSet` handlers are patched (the same way `onGet` handlers already were) so that both reads and writes correctly return `SERVICE_COMMUNICATION_FAILURE` while offline. Handlers are restored when the device comes back.
+- **Property set and action failures are now logged at `warn` level** — errors in `setProperty` and `executeAction` were previously swallowed into `debug`-only logs, making silent control failures invisible to users. They now appear as `warn` messages in the Homebridge log.
+
+---
+
+## [1.2.1] - 2026-06-08
+
+### Changed
+- Removed all references to the previously used third-party MiOT library from comments and documentation. The plugin is now fully independent with no external plugin dependencies.
+
+---
+
 ## [1.2.0] - 2026-06-08
 
 ### Changed
-- **Zero external plugin dependencies** — `homebridge-miot` dependency removed. The MiOT protocol library (343 files: protocol, device modules, factories, constants, utils, wrappers) is now bundled directly inside the plugin under `vendor/miot/`. The plugin is fully self-contained.
-- Sub-dependencies previously pulled in transitively via `homebridge-miot` (`color-convert`, `env-paths`, `randomstring`) are now declared explicitly as direct dependencies.
+- **Zero external plugin dependencies** — MiOT protocol library (343 files: protocol, device modules, factories, constants, utils, wrappers) is now bundled directly inside the plugin under `vendor/miot/`. The plugin is fully self-contained.
+- Sub-dependencies (`color-convert`, `env-paths`, `randomstring`) are now declared explicitly as direct dependencies.
 
 ---
 
@@ -18,7 +33,7 @@
 ## [1.1.2] - 2026-06-08
 
 ### Changed
-- **Minimalist logging** — startup output reduced to a single `Starting N device(s)…` summary line. All verbose homebridge-miot internal messages (device properties, actions, services, accessory init, filter stats, model detection, connection details) are now suppressed. Only warnings, errors, and offline/online state changes remain visible.
+- **Minimalist logging** — startup output reduced to a single `Starting N device(s)…` summary line. All verbose MiOT internal messages (device properties, actions, services, accessory init, filter stats, model detection, connection details) are now suppressed. Only warnings, errors, and offline/online state changes remain visible.
 
 ---
 
@@ -27,8 +42,8 @@
 ### Added
 - **Offline detection** — devices that lose network connectivity now show "No Response" in HomeKit. Detection works by overriding HAP `getHandler`s to throw `SERVICE_COMMUNICATION_FAILURE` after 4 missed polling cycles. Original handlers are restored automatically when the device reconnects.
 - **Auto/sleep mode rotation speed** — when a device is in Auto or Sleep mode, the `RotationSpeed` characteristic shows a configurable placeholder value (default `50%`) instead of `0%`. Configurable via `"autoRotationSpeed"` in device config (set to `0` to disable).
-- **Per-model feature toggles (Config UI)** — the device settings UI now lists device-specific feature toggles (buzzer, LED, child lock, modes, fan speed, swing, screen, ioniser, etc.) sourced from the homebridge-miot device registry. Features default to **OFF**; the user enables only what they need. Covers 83+ device models across 7 categories (fans, air purifiers, humidifiers, lights, heaters, vacuums, outlets).
-- **`normalizeFeatures()`** — on every UI render, any feature key that is `undefined` in config is explicitly written as `false` before saving, preventing homebridge-miot's built-in defaults from silently enabling disabled features.
+- **Per-model feature toggles (Config UI)** — the device settings UI now lists device-specific feature toggles (buzzer, LED, child lock, modes, fan speed, swing, screen, ioniser, etc.) sourced from the bundled device registry. Features default to **OFF**; the user enables only what they need. Covers 83+ device models across 7 categories (fans, air purifiers, humidifiers, lights, heaters, vacuums, outlets).
+- **`normalizeFeatures()`** — on every UI render, any feature key that is `undefined` in config is explicitly written as `false` before saving, preventing built-in defaults from silently enabling disabled features.
 - **`device-features.js`** — feature definitions moved to a separate file for easy maintenance; adding a new model requires editing only that file.
 - **`autoRotationSpeed` config key** in `config.schema.json`.
 
@@ -56,6 +71,6 @@
 
 ### Added
 - Initial release.
-- Wraps `homebridge-miot` as a child-bridge platform plugin.
+- Homebridge platform plugin for Xiaomi MiOT devices.
 - Config UI with per-device settings (name, IP, token, model, polling interval, connection type).
 - Cloud (MiCloud) and local connection modes.

package/homebridge-ui/public/device-features.js

@@ -10,7 +10,7 @@
  *   screenControl, showTemperature,
  *   buzzerControl, ledControl, childLockControl, offDelayControl
  *
- * Mənbə: https://github.com/merdok/homebridge-miot — lib/modules/{kategoria}/devices/
+ * Mənbə: vendor/miot/lib/modules/{kategoria}/devices/
  */
 
 /* global DEVICE_FEATURES */

package/homebridge-ui/public/index.html

@@ -230,7 +230,7 @@
   }
 
   /* ── Render ── */
-  /* Hər cihazın feature key-lərini açıqca false ilə başlat (undefined → homebridge-miot true sayır) */
+  /* Hər cihazın feature key-lərini açıqca false ilə başlat (undefined → default olaraq true sayılır) */
   function normalizeFeatures() {
     let changed = false;
     (config.devices || []).forEach(d => {

package/index.js

@@ -2,7 +2,7 @@
 
 const fs = require('fs').promises;
 const path = require('path');
-// Vendored MiOT library (bundled — no external homebridge-miot dependency)
+// Bundled MiOT library
 const MIOT_ROOT = path.join(__dirname, 'vendor/miot/lib') + '/';
 const MiotDevice    = require(MIOT_ROOT + 'protocol/MiotDevice.js');
 const DeviceFactory = require(MIOT_ROOT + 'factories/DeviceFactory.js');
@@ -12,9 +12,9 @@ const Events        = require(MIOT_ROOT + 'constants/Events.js');
 
 const PLUGIN_NAME = 'homebridge-xiaomi-miot';
 const PLATFORM_NAME = 'XiaomiMiot';
-const PLUGIN_VERSION = '1.2.0';
+const PLUGIN_VERSION = '1.2.2';
 
-/* ── Silence homebridge-miot's verbose startup logs ── */
+/* ── Silence verbose MiOT startup logs ── */
 const MIOT_INFO_SUPPRESS = [
   'Initializing device services',   'Device services:',
   'Initializing device properties', 'Device properties:',
@@ -229,7 +229,6 @@ class XiaomiMiotDeviceController {
 
     /* ── Install error-throwing getHandler on every characteristic ── */
     const pushOffline = () => {
-      this.miotDevice.localConnected = false;
       eachChar(char => {
         /* Save original handler (once only) and replace with error thrower */
         if (!Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigGet')) {
@@ -238,13 +237,18 @@ class XiaomiMiotDeviceController {
             throw new HapStatusError(HAPStatus.SERVICE_COMMUNICATION_FAILURE);
           });
         }
+        if (!Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigSet') && char.setHandler !== undefined) {
+          char._xiaomiOrigSet = char.setHandler;
+          char.onSet(() => {
+            throw new HapStatusError(HAPStatus.SERVICE_COMMUNICATION_FAILURE);
+          });
+        }
       });
       this.logger.warn(`[OfflineDetect] ${this.name} — offline.`);
     };
 
-    /* ── Restore original getHandlers when device comes back ── */
+    /* ── Restore original get/set handlers when device comes back ── */
     const pushOnline = () => {
-      this.miotDevice.localConnected = true;
       eachChar(char => {
         if (Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigGet')) {
           if (char._xiaomiOrigGet) {
@@ -254,6 +258,10 @@ class XiaomiMiotDeviceController {
           }
           delete char._xiaomiOrigGet;
         }
+        if (Object.prototype.hasOwnProperty.call(char, '_xiaomiOrigSet')) {
+          char.onSet(char._xiaomiOrigSet);
+          delete char._xiaomiOrigSet;
+        }
       });
     };
 
@@ -312,7 +320,7 @@ class XiaomiMiotDeviceController {
       return val;
     });
 
-    /* 2) Fix push updates — homebridge-miot calls updateValue(0) after each poll.
+    /* 2) Fix push updates — the MiOT layer calls updateValue(0) after each poll.
           Our listener runs after it (registered later) and corrects the value. */
     this.miotDevice.on(Events.MIOT_DEVICE_ALL_PROPERTIES_UPDATED, () => {
       if (rsChar && this._isInAutoOrSleepMode(dev)) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-xiaomi-miot",
   "displayName": "Homebridge Xiaomi MiOT",
-  "version": "1.2.0",
+  "version": "1.2.2",
   "description": "Homebridge plugin for Xiaomi devices using the MiOT protocol — local and MiCloud",
   "main": "index.js",
   "scripts": {},

package/src/micloud.js

@@ -208,7 +208,7 @@ class MiCloud {
     this.log.info(`[MiCloud] Login successful — ssecurity=${!!this.ssecurity} serviceToken=${!!this.serviceToken}`);
   }
 
-  /* ── Get device list — RC4 encrypted (matches homebridge-miot default) ── */
+  /* ── Get device list — RC4 encrypted ── */
   async getDevices() {
     if (!this.serviceToken) await this.login();
 
@@ -247,12 +247,12 @@ class MiCloud {
       let parsed = null;
 
       if (this.ssecurity) {
-        // ── RC4 encrypted path (homebridge-miot default) ──────────────────
+        // ── RC4 encrypted path ──────────────────────────────────────────────
         const params = { data: JSON.stringify(dataObj) };
         const nonce  = genNonce();
         const sNonce = signedNonce(this.ssecurity, nonce);
 
-        // Build RC4 body identical to homebridge-miot _generateRc4Body
+        // Build RC4 body
         params['rc4_hash__'] = sha1Sign('POST', apiUrl, params, sNonce);
         const encParams = {};
         for (const [k, v] of Object.entries(params)) {

package/vendor/miot/lib/protocol/MiotDevice.js

@@ -1237,7 +1237,7 @@ class MiotDevice extends EventEmitter {
         throw new Error(`Error while setting property ${prop.getName()} to value ${value}! Invalid response. Response: ${JSON.stringify(result)}`);
       }
     } catch (err) {
-      this.logger.debug(err);
+      this.logger.warn(`Set property failed: ${err.message || err}`);
     }
   }
 
@@ -1262,7 +1262,7 @@ class MiotDevice extends EventEmitter {
         throw new Error(`Error while executing action ${action.getName()} with params ${paramValues}! Invalid response from device. Response: ${JSON.stringify(result)}`);
       }
     } catch (err) {
-      this.logger.debug(err);
+      this.logger.warn(`Execute action failed: ${err.message || err}`);
     }
   }