homebridge-xbox-tv 3.3.7-beta.3 → 3.3.7

package/CHANGELOG.md

@@ -10,6 +10,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - After update to 2.x.x the plugin settings (xboxLiveId) need to be updated
 - After update to v3.0.0 RESTFull and MQTT config settings need to be updated
 
+## [3.3.7] - (02.06.2025)
+
+## Changes
+
+- cleanup and optimizations of web api control
+
 ## [3.3.6] - (02.06.2025)
 
 ## Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "Xbox TV",
   "name": "homebridge-xbox-tv",
-  "version": "3.3.7-beta.3",
+  "version": "3.3.7",
   "description": "Homebridge plugin to control Xbox game consoles.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/xboxdevice.js

@@ -164,7 +164,7 @@ class XboxDevice extends EventEmitter {
             let set = false
             switch (key) {
                 case 'Power':
-                    switch (this.webApiPowerOnOff) {
+                    switch (this.webApiControl && this.webApiPowerOnOff) {
                         case true:
                             switch (value) {
                                 case true: //off
@@ -188,30 +188,30 @@ class XboxDevice extends EventEmitter {
                     break;
                 case 'App':
                     const payload = [{ 'oneStoreProductId': value }];
-                    set = await this.xboxWebApi.send('Shell', 'ActivateApplicationWithOneStoreProductId', payload);
+                    set = !this.webApiControl ? false : await this.xboxWebApi.send('Shell', 'ActivateApplicationWithOneStoreProductId', payload);
                     break;
                 case 'Volume':
                     switch (value) {
                         case 'up': //Up
-                            set = await this.xboxWebApi.send('Volume', 'Up');
+                            set = !this.webApiControl ? false : await this.xboxWebApi.send('Volume', 'Up');
                             break;
                         case 'down': //Down
-                            set = await this.xboxWebApi.send('Volume', 'Down');
+                            set = !this.webApiControl ? false : await this.xboxWebApi.send('Volume', 'Down');
                             break;
                     }
                     break;
                 case 'Mute':
                     switch (value) {
                         case true: //Mute
-                            set = await this.xboxWebApi.send('Audio', 'Mute');
+                            set = !this.webApiControl ? false : await this.xboxWebApi.send('Audio', 'Mute');
                             break;
                         case false: //Unmute;
-                            set = await this.xboxWebApi.send('Audio', 'Unmute');
+                            set = !this.webApiControl ? false : await this.xboxWebApi.send('Audio', 'Unmute');
                             break;
                     }
                     break;
                 case 'RcControl':
-                    set = await this.xboxWebApi.send('Shell', 'InjectKey', [{ 'keyType': value }]);
+                    set = !this.webApiControl ? false : await this.xboxWebApi.send('Shell', 'InjectKey', [{ 'keyType': value }]);
                     break;
                 default:
                     this.emit('warn', `${integration}, received key: ${key}, value: ${value}`);
@@ -428,6 +428,7 @@ class XboxDevice extends EventEmitter {
                 })
                 .onSet(async (activeIdentifier) => {
                     if (!this.webApiControl) {
+                        this.emit('warn', `web api control not enabled`);
                         return;
                     }
 
@@ -571,6 +572,7 @@ class XboxDevice extends EventEmitter {
             this.televisionService.getCharacteristic(Characteristic.PowerModeSelection)
                 .onSet(async (powerModeSelection) => {
                     if (!this.webApiControl) {
+                        this.emit('warn', `web api control not enabled`);
                         return;
                     }
 
@@ -610,6 +612,7 @@ class XboxDevice extends EventEmitter {
             this.speakerService.getCharacteristic(Characteristic.VolumeSelector)
                 .onSet(async (volumeSelector) => {
                     if (!this.webApiControl) {
+                        this.emit('warn', `web api control not enabled`);
                         return;
                     }
 
@@ -644,6 +647,7 @@ class XboxDevice extends EventEmitter {
                 })
                 .onSet(async (state) => {
                     if (!this.webApiControl) {
+                        this.emit('warn', `web api control not enabled`);
                         return;
                     }