homebridge-withings-environment-data 1.2.0 → 1.2.1

package/CHANGELOG.md

@@ -6,6 +6,22 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [1.2.1] - 2026-08-02
+
+### Changed
+- The stale-data log warning now logs on every poll while data remains
+  stale (matching how missed poll cycles are already logged), instead of
+  only once per stale streak.
+
+### Fixed
+- The stale-data ntfy notification no longer re-fires every time
+  Homebridge restarts while the same stale reading is still the newest one
+  on record. The "already notified about this" state, and the last-known
+  reading date it applies to, are now both persisted to disk instead of
+  living only in memory (a first fix persisted only the former, which
+  still misfired if the first poll after a restart happened to fail), and
+  still reset correctly once a fresher reading comes in.
+
 ## [1.2.0] - 2026-07-31
 
 ### Added

package/README.md

@@ -1,4 +1,4 @@
-# Homebridge Withings Environment Data v1.2.0
+# Homebridge Withings Environment Data v1.2.1
 
 **This Homebridge plugin has been 100% vibe coded with Claude.**
 
@@ -74,9 +74,10 @@ Fields:
   1500, 2000).
 - **Stale Data Warning Threshold (hours)**: if the newest reading from the
   scale itself (not the plugin's poll) is older than this many hours — e.g.
-  nobody's stood on the scale in a while — a warning is logged, the sensors
-  show "No Response" in the Home app, and (if ntfy Topic is set) a
-  notification is sent. Default 4. This is separate from poll failures.
+  nobody's stood on the scale in a while — a warning is logged on every
+  poll for as long as it stays stale, the sensors show "No Response" in the
+  Home app, and (if ntfy Topic is set) a single notification is sent for
+  that stale reading. Default 4. This is separate from poll failures.
 - **ntfy Topic (optional)**: if set, sends a push notification via
   [ntfy.sh](https://ntfy.sh) to this topic the first time a poll fails
   (not repeated on every subsequent failure in the same streak; only once

package/index.js

@@ -103,12 +103,6 @@ class WithingsEnvironmentDataPlatform {
     // missed poll — reset once a poll succeeds again.
     this.hasNotifiedFailure = false;
 
-    // Unix seconds of the newest reading actually seen so far (from the
-    // Withings measurement itself, not from a successful poll) — used to
-    // detect the scale going quiet rather than the plugin failing to poll.
-    // Warn/notify once per stale streak, reset once a fresher reading comes in.
-    this.lastReadingDate = null;
-    this.staleDataWarned = false;
     this.warnedMissingReadingDate = false;
 
     // The long-lived (~1 week) session_key that lets us skip email/password/2FA
@@ -117,26 +111,48 @@ class WithingsEnvironmentDataPlatform {
     // it, since repeatedly hitting the password endpoint appears to be heavily
     // throttled by Withings.
     this.sessionStatePath = path.join(this.api.user.storagePath(), SESSION_STATE_FILENAME);
-    this.sessionKey = this.loadSessionKey();
+    const state = this.loadPersistedState();
+    this.sessionKey = state.sessionKey ?? null;
+    // Unix seconds of the newest reading actually seen so far (from the Withings
+    // measurement itself, not from a successful poll) — used to detect the scale
+    // going quiet rather than the plugin failing to poll. Persisted and restored
+    // immediately on boot (rather than waiting on the first poll to repopulate
+    // it) so a restart can't be mistaken for "no reading yet" and wrongly clear
+    // an active stale-warning below.
+    this.lastReadingDate = state.lastReadingDate ?? null;
+    // The readingDate (unix seconds) we last sent a stale-data *notification* for,
+    // or null if not currently in a notified state. The log warning itself repeats
+    // every poll while data stays stale (like missed-poll-cycle failures do), but
+    // this gates the ntfy notification to once per distinct stale reading, and is
+    // persisted so a Homebridge restart doesn't re-notify about a reading we've
+    // already notified about — it only resets once a fresher reading comes in.
+    this.staleNotifiedForReadingDate = state.staleNotifiedForReadingDate ?? null;
 
     this.api.on('didFinishLaunching', () => this.discoverDevices());
   }
 
-  loadSessionKey() {
+  loadPersistedState() {
     try {
       const raw = fs.readFileSync(this.sessionStatePath, 'utf8');
-      return JSON.parse(raw).sessionKey ?? null;
+      return JSON.parse(raw);
     } catch (err) {
       if (err.code !== 'ENOENT') {
         this.log.warn(`Could not read session state file: ${err.message}`);
       }
-      return null;
+      return {};
     }
   }
 
-  saveSessionKey(sessionKey) {
+  persistState() {
     try {
-      fs.writeFileSync(this.sessionStatePath, JSON.stringify({ sessionKey }));
+      fs.writeFileSync(
+        this.sessionStatePath,
+        JSON.stringify({
+          sessionKey: this.sessionKey,
+          lastReadingDate: this.lastReadingDate,
+          staleNotifiedForReadingDate: this.staleNotifiedForReadingDate,
+        })
+      );
     } catch (err) {
       this.log.warn(`Could not persist session state file: ${err.message}`);
     }
@@ -161,7 +177,7 @@ class WithingsEnvironmentDataPlatform {
     if (result.sessionKey) {
       if (result.sessionKey !== this.sessionKey) {
         this.sessionKey = result.sessionKey;
-        this.saveSessionKey(result.sessionKey);
+        this.persistState();
         this.log.info('Withings full login succeeded; cached the new session for future polls.');
       } else {
         this.log.info('Withings full login succeeded; session token unchanged.');
@@ -354,16 +370,22 @@ class WithingsEnvironmentDataPlatform {
   async checkStaleData() {
     const stale = this.isDataStale();
 
-    if (stale && !this.staleDataWarned) {
-      this.staleDataWarned = true;
+    if (stale) {
       const { date, time } = this.formatStaleDateTime(this.lastReadingDate);
       this.log.warn(`Withings data is stale: last recorded at ${date} ${time}`);
-      await this.sendNtfyNotification(
-        `Temperature and/or CO2 readings haven't been updated since ${date} at ${time}.`,
-        'Homebridge: Withings Environment Data is out of date'
-      );
-    } else if (!stale && this.staleDataWarned) {
-      this.staleDataWarned = false;
+
+      const alreadyNotifiedForThisReading = this.staleNotifiedForReadingDate === this.lastReadingDate;
+      if (!alreadyNotifiedForThisReading) {
+        this.staleNotifiedForReadingDate = this.lastReadingDate;
+        this.persistState();
+        await this.sendNtfyNotification(
+          `Temperature and/or CO2 readings haven't been updated since ${date} at ${time}.`,
+          'Homebridge: Withings Environment Data is out of date'
+        );
+      }
+    } else if (this.staleNotifiedForReadingDate !== null) {
+      this.staleNotifiedForReadingDate = null;
+      this.persistState();
       this.log.info('Withings: fresh data has been recorded.');
     }
   }
@@ -411,8 +433,9 @@ class WithingsEnvironmentDataPlatform {
           'Withings measurement data has no recognizable date field; stale data detection is disabled until this is fixed.'
         );
       }
-    } else if (readingDate !== null && readingDate !== undefined) {
+    } else if (readingDate !== null && readingDate !== undefined && readingDate !== this.lastReadingDate) {
       this.lastReadingDate = readingDate;
+      this.persistState();
     }
 
     if (co2 !== null && co2 !== undefined) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-withings-environment-data",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "Homebridge plugin exposing ambient CO2/air-quality and room temperature readings from a Withings WS-50 scale as HomeKit sensors",
   "main": "index.js",
   "files": [