homebridge-tydom 0.32.1 → 0.32.3

package/dist/index.mjs

@@ -1,7 +1,7 @@
 import { n as PLUGIN_NAME, t as PLATFORM_NAME } from "./env-B2-Dw8C2.mjs";
 //#region src/index.ts
 process.setSourceMapsEnabled(true);
-const { default: TydomPlatform } = await import("./platform-BssMTVVc.mjs");
+const { default: TydomPlatform } = await import("./platform-d-jxZ1Nu.mjs");
 var src_default = (homebridge) => {
 	homebridge.registerPlatform(PLUGIN_NAME, PLATFORM_NAME, TydomPlatform);
 };

package/dist/{platform-BssMTVVc.mjs → platform-d-jxZ1Nu.mjs}

@@ -3021,6 +3021,15 @@ const parseDiscoveryResponse = (uri, schema, payload) => {
 * device is not the shape the accessory was built for — which is a bug in the
 * signature table, not a value HomeKit should be handed.
 */
+/**
+* The value of a property the hardware may simply not carry.
+*
+* `getTydomDataPropValue` asserts, which is right for a property the device
+* type guarantees. Delta Dore's HVAC range guarantees less than it looks: some
+* endpoints expose a thermic level and no numbers at all, no `setpoint` and no
+* `temperature`, and asserting on those turned every read into an error.
+*/
+const findTydomDataPropValue = (data, name) => data.find((prop) => prop.name === name)?.value;
 const getTydomDataPropValue = (data, name) => {
 	const item = data.find((prop) => prop.name === name);
 	assert(item, `Missing property with name="${name}" in endpoint data`);
@@ -4039,11 +4048,12 @@ var GarageDoorAccessory = class extends BaseAccessory {
 		this.#computedPosition = doorState === CurrentDoorState.OPEN ? 100 : 0;
 	}
 	#setDoorState(doorState) {
-		const { CurrentDoorState } = this.platform.Characteristic;
+		const { CurrentDoorState, TargetDoorState } = this.platform.Characteristic;
 		debug(`assignCurrentDoorState=${styleString(this.#label(doorState))}`);
 		this.#currentDoorState = doorState;
 		this.#settleTarget(doorState);
 		this.#service.updateCharacteristic(CurrentDoorState, doorState);
+		if (doorState === CurrentDoorState.OPEN || doorState === CurrentDoorState.CLOSED) this.#service.updateCharacteristic(TargetDoorState, this.#targetDoorState);
 	}
 	/** A door at rest, open or closed, was headed exactly there. */
 	#settleTarget(doorState) {
@@ -4381,19 +4391,28 @@ const isZoneArmed = (alarmData, zoneProp) => {
 	if (alarmMode === "ON") return true;
 	return alarmData.find((prop) => prop.name === zoneProp)?.value === "ON";
 };
+/**
+* The arming mode a data snapshot describes, ignoring whether the siren is on.
+*
+* This is what `SecuritySystemTargetState` asks for, and the reason it cannot
+* share `getStateForAlarmData`: the target has no `ALARM_TRIGGERED`, so the
+* return type excludes it and HAP can never be handed a value it would reject.
+*/
+const getTargetStateForAlarmData = (alarmData, aliases, settings) => {
+	const alarmMode = alarmData.find((prop) => prop.name === "alarmMode")?.value;
+	if (alarmMode === "ON") return ALARM_STATE.AWAY_ARM;
+	if (typeof alarmMode === "string" && ["ZONE", "PART"].includes(alarmMode)) return getStateForActiveZones(getActiveZones(alarmData, settings), aliases);
+	return ALARM_STATE.DISARMED;
+};
 /** The HomeKit state for a full alarm data snapshot. */
 const getStateForAlarmData = (alarmData, aliases, settings) => {
-	const find = (name) => alarmData.find((prop) => prop.name === name)?.value;
-	const alarmState = find("alarmState");
-	const alarmMode = find("alarmMode");
+	const alarmState = alarmData.find((prop) => prop.name === "alarmState")?.value;
 	if (typeof alarmState === "string" && [
 		"DELAYED",
 		"ON",
 		"QUIET"
 	].includes(alarmState)) return ALARM_STATE.ALARM_TRIGGERED;
-	if (alarmMode === "ON") return ALARM_STATE.AWAY_ARM;
-	if (typeof alarmMode === "string" && ["ZONE", "PART"].includes(alarmMode)) return getStateForActiveZones(getActiveZones(alarmData, settings), aliases);
-	return ALARM_STATE.DISARMED;
+	return getTargetStateForAlarmData(alarmData, aliases, settings);
 };
 //#endregion
 //#region src/accessories/security-system-accessory.ts
@@ -4449,7 +4468,7 @@ var SecuritySystemAccessory = class extends BaseAccessory {
 		});
 		service.getCharacteristic(SecuritySystemTargetState).onGet(async () => {
 			debugGet(SecuritySystemTargetState, service);
-			const nextValue = await this.#currentState();
+			const nextValue = await this.#targetState();
 			debugGetResult(SecuritySystemTargetState, service, nextValue);
 			return nextValue;
 		}).onSet(async (value) => {
@@ -4475,6 +4494,17 @@ var SecuritySystemAccessory = class extends BaseAccessory {
 		const data = await this.#read();
 		return getStateForAlarmData(data, this.#settings.aliases ?? {}, this.#settings);
 	}
+	/**
+	* The mode the panel is set to, which is what the target characteristic asks.
+	*
+	* Deliberately not `#currentState`: that one answers `ALARM_TRIGGERED` while
+	* the siren is going, and the target has no such value, so HAP rejected it.
+	* A ringing alarm says nothing about what the panel was armed to anyway.
+	*/
+	async #targetState() {
+		const data = await this.#read();
+		return getTargetStateForAlarmData(data, this.#settings.aliases ?? {}, this.#settings);
+	}
 	async #readZoneLabels() {
 		if (this.#legacy) {
 			this.platform.log.warn(`Setting up legacy zones`);
@@ -4562,11 +4592,15 @@ var SecuritySystemAccessory = class extends BaseAccessory {
 			return;
 		}
 		const aliases = this.#settings.aliases ?? {};
-		const targetZones = target === SecuritySystemTargetState.STAY_ARM ? aliases.stay : aliases.night;
-		if (Array.isArray(targetZones) && targetZones.length > 0) {
-			await this.#setZones(targetZones, "ON");
-			if (this.#service) debugSetResult(SecuritySystemTargetState, this.#service, target, "ON");
+		const isStay = target === SecuritySystemTargetState.STAY_ARM;
+		const alias = isStay ? "stay" : "night";
+		const targetZones = aliases[alias];
+		if (!Array.isArray(targetZones) || targetZones.length === 0) {
+			this.platform.log.warn(`Cannot arm ${this.name} to ${isStay ? "Home" : "Night"}: no zones are configured for that mode, so nothing was sent and the Home app will report the change as failed. Add {"settings": {"${this.deviceId}": {"aliases": {"${alias}": [1]}}}} listing the zones it should arm, numbered as they are on the panel's keypad.`);
+			return;
 		}
+		await this.#setZones(targetZones, "ON");
+		if (this.#service) debugSetResult(SecuritySystemTargetState, this.#service, target, "ON");
 	}
 	async #setZones(zoneIds, value) {
 		if (!this.#legacy) {
@@ -4583,15 +4617,12 @@ var SecuritySystemAccessory = class extends BaseAccessory {
 		});
 	}
 	#handleData(updates) {
-		const { SecuritySystemCurrentState, ContactSensorState, On } = this.platform.Characteristic;
+		const { ContactSensorState, On } = this.platform.Characteristic;
 		const aliases = this.#settings.aliases ?? {};
 		for (const { name, value } of updates) {
 			if (name === "alarmMode") {
 				const nextValue = value === "OFF" ? ALARM_STATE.DISARMED : value === "ON" ? ALARM_STATE.AWAY_ARM : value === "PART" || value === "ZONE" ? getStateForActiveZones(getActiveZones(updates, this.#settings), aliases) : void 0;
-				if (nextValue !== void 0 && this.#service) {
-					debugSetUpdate(SecuritySystemCurrentState, this.#service, nextValue);
-					this.#service.updateCharacteristic(SecuritySystemCurrentState, nextValue);
-				}
+				if (nextValue !== void 0) this.#setState(nextValue);
 				if (value === "OFF") this.#syncZoneSwitches([]);
 				else if (value === "ON") this.#syncZoneSwitches(null);
 				continue;
@@ -4669,11 +4700,22 @@ var SecuritySystemAccessory = class extends BaseAccessory {
 			service.updateCharacteristic(On, nextValue);
 		}
 	}
+	/**
+	* Settle both arming characteristics from an authoritative mode.
+	*
+	* The target moves with the current state, so that arming from the panel's
+	* own keypad does not leave HomeKit showing the old mode — a stale target is
+	* what makes "arm away" in the Home app look like it did nothing. The
+	* parameter type excludes `ALARM_TRIGGERED`, so the target can never be
+	* handed a value it would reject.
+	*/
 	#setState(state) {
 		if (!this.#service) return;
-		const { SecuritySystemCurrentState } = this.platform.Characteristic;
+		const { SecuritySystemCurrentState, SecuritySystemTargetState } = this.platform.Characteristic;
 		debugSetUpdate(SecuritySystemCurrentState, this.#service, state);
 		this.#service.updateCharacteristic(SecuritySystemCurrentState, state);
+		debugSetUpdate(SecuritySystemTargetState, this.#service, state);
+		this.#service.updateCharacteristic(SecuritySystemTargetState, state);
 	}
 };
 const createSecuritySystemAccessory = (deps) => {
@@ -4781,6 +4823,14 @@ const EXPOSED_THERMIC_LEVELS = /* @__PURE__ */ new Set([
 	"ECO",
 	"COMFORT"
 ]);
+/**
+* What to report when the endpoint carries no temperature at all.
+*
+* HAP's own default for `CurrentTemperature`, so a device with no thermometer
+* looks the same as one that has not answered yet, rather than inventing a
+* reading.
+*/
+const UNKNOWN_TEMPERATURE = 0;
 /** An electric heating controller (Delta Dore RF4890, RF6600FP). */
 var ThermostatAccessory = class extends BaseAccessory {
 	#service;
@@ -4827,9 +4877,13 @@ var ThermostatAccessory = class extends BaseAccessory {
 			debugGet(CurrentHeatingCoolingState, this.#service);
 			const data = await this.#read();
 			const authorization = getTydomDataPropValue(data, "authorization");
-			const setpoint = getTydomDataPropValue(data, "setpoint");
-			const temperature = getTydomDataPropValue(data, "temperature");
+			const setpoint = findTydomDataPropValue(data, "setpoint");
+			const temperature = findTydomDataPropValue(data, "temperature");
 			let nextValue = CurrentHeatingCoolingState.OFF;
+			if (typeof setpoint !== "number" || typeof temperature !== "number") {
+				debugGetResult(CurrentHeatingCoolingState, this.#service, nextValue);
+				return nextValue;
+			}
 			if (authorization === "HEATING" && setpoint > temperature) nextValue = CurrentHeatingCoolingState.HEAT;
 			else if (authorization === "COOLING" && temperature > setpoint) nextValue = CurrentHeatingCoolingState.COOL;
 			debugGetResult(CurrentHeatingCoolingState, this.#service, nextValue);
@@ -4869,14 +4923,15 @@ var ThermostatAccessory = class extends BaseAccessory {
 		});
 		this.#service.getCharacteristic(CurrentTemperature).onGet(async () => {
 			debugGet(CurrentTemperature, this.#service);
-			const temperature = getTydomDataPropValue(await this.#read(), "temperature");
+			const data = await this.#read();
+			const temperature = findTydomDataPropValue(data, "temperature") ?? findTydomDataPropValue(data, "setpoint") ?? UNKNOWN_TEMPERATURE;
 			debugGetResult(CurrentTemperature, this.#service, temperature);
 			return temperature;
 		});
 		this.#service.getCharacteristic(TargetTemperature).onGet(async () => {
 			debugGet(TargetTemperature, this.#service);
 			const data = await this.#read();
-			const setpoint = getTydomDataPropValue(data, "setpoint") ?? getTydomDataPropValue(data, "temperature");
+			const setpoint = findTydomDataPropValue(data, "setpoint") ?? findTydomDataPropValue(data, "temperature") ?? UNKNOWN_TEMPERATURE;
 			debugGetResult(TargetTemperature, this.#service, setpoint);
 			return setpoint;
 		}).onSet(async (value) => {
@@ -5620,4 +5675,4 @@ var TydomPlatform = class {
 //#endregion
 export { TydomPlatform as default };
 
-//# sourceMappingURL=platform-BssMTVVc.mjs.map
+//# sourceMappingURL=platform-d-jxZ1Nu.mjs.map