homebridge-tydom 0.31.2 → 0.32.1

package/dist/index.mjs

@@ -1,7 +1,7 @@
 import { n as PLUGIN_NAME, t as PLATFORM_NAME } from "./env-B2-Dw8C2.mjs";
 //#region src/index.ts
 process.setSourceMapsEnabled(true);
-const { default: TydomPlatform } = await import("./platform-BjoGoTvF.mjs");
+const { default: TydomPlatform } = await import("./platform-BssMTVVc.mjs");
 var src_default = (homebridge) => {
 	homebridge.registerPlatform(PLUGIN_NAME, PLATFORM_NAME, TydomPlatform);
 };

package/dist/{platform-BjoGoTvF.mjs → platform-BssMTVVc.mjs}

@@ -3875,6 +3875,12 @@ var GarageDoorAccessory = class extends BaseAccessory {
 	/** Some drivers expose only TOGGLE and cannot be commanded to a state. */
 	#toggleOnly;
 	#currentDoorState;
+	/**
+	* Where the door was last asked to go. TargetDoorState only admits OPEN and
+	* CLOSED, so it cannot mirror the current state through OPENING, CLOSING or
+	* STOPPED.
+	*/
+	#targetDoorState;
 	#lastUpdatedAt = 0;
 	#computedPosition = 0;
 	#transition;
@@ -3888,6 +3894,7 @@ var GarageDoorAccessory = class extends BaseAccessory {
 		const levelCmdValues = metadata.find((m) => m.name === "levelCmd")?.enum_values;
 		this.#toggleOnly = levelCmdValues?.length === 1 && levelCmdValues[0] === "TOGGLE";
 		this.#currentDoorState = CurrentDoorState.CLOSED;
+		this.#targetDoorState = TargetDoorState.CLOSED;
 		const legacy = this.accessory.getService(this.platform.Service.Switch);
 		if (legacy) this.accessory.removeService(legacy);
 		this.#service = this.service(this.platform.Service.GarageDoorOpener);
@@ -3905,8 +3912,8 @@ var GarageDoorAccessory = class extends BaseAccessory {
 		this.#service.getCharacteristic(TargetDoorState).onGet(async () => {
 			debugGet(TargetDoorState, this.#service);
 			if (this.#toggleOnly) {
-				debugGetResult(TargetDoorState, this.#service, this.#currentDoorState);
-				return this.#currentDoorState;
+				debugGetResult(TargetDoorState, this.#service, this.#targetDoorState);
+				return this.#targetDoorState;
 			}
 			const next = await this.#readDoorState();
 			this.#lastUpdatedAt = Date.now();
@@ -3955,6 +3962,7 @@ var GarageDoorAccessory = class extends BaseAccessory {
 		const { CurrentDoorState } = this.platform.Characteristic;
 		this.#lastUpdatedAt = Date.now();
 		this.#computedPosition = this.#positionNow();
+		this.#targetDoorState = targetDoorState;
 		let next = this.#nextDoorState(targetDoorState);
 		if (next === this.#currentDoorState) {
 			debug(`nextCurrentDoorState=${styleNumber(next)} === currentDoorState, nothing to do`);
@@ -4026,6 +4034,7 @@ var GarageDoorAccessory = class extends BaseAccessory {
 	#applyKnownState(doorState) {
 		const { CurrentDoorState } = this.platform.Characteristic;
 		this.#currentDoorState = doorState;
+		this.#settleTarget(doorState);
 		this.#lastUpdatedAt = Date.now();
 		this.#computedPosition = doorState === CurrentDoorState.OPEN ? 100 : 0;
 	}
@@ -4033,8 +4042,15 @@ var GarageDoorAccessory = class extends BaseAccessory {
 		const { CurrentDoorState } = this.platform.Characteristic;
 		debug(`assignCurrentDoorState=${styleString(this.#label(doorState))}`);
 		this.#currentDoorState = doorState;
+		this.#settleTarget(doorState);
 		this.#service.updateCharacteristic(CurrentDoorState, doorState);
 	}
+	/** A door at rest, open or closed, was headed exactly there. */
+	#settleTarget(doorState) {
+		const { CurrentDoorState, TargetDoorState } = this.platform.Characteristic;
+		if (doorState === CurrentDoorState.OPEN) this.#targetDoorState = TargetDoorState.OPEN;
+		else if (doorState === CurrentDoorState.CLOSED) this.#targetDoorState = TargetDoorState.CLOSED;
+	}
 	/** Where the door has got to, given how long it has been travelling. */
 	#positionNow() {
 		const { CurrentDoorState } = this.platform.Characteristic;
@@ -4770,34 +4786,86 @@ var ThermostatAccessory = class extends BaseAccessory {
 	#service;
 	/** Thermic-level switches, by the Tydom value each one selects. */
 	#levelSwitches = /* @__PURE__ */ new Map();
+	/**
+	* Whether this device can cool as well as heat.
+	*
+	* Read from the endpoint's own metadata rather than configured: reversible
+	* hardware — a heat pump that runs in reverse — advertises `COOLING` among
+	* the values its `authorization` property accepts, and a radiator does not.
+	* Offering HomeKit a cool mode on a radiator would put a button in the Home
+	* app that silently does nothing.
+	*/
+	#canCool;
+	/**
+	* Which property carries the operating mode on this device.
+	*
+	* Delta Dore replaced `hvacMode` with `localMode` on newer thermostats — the
+	* Tybox 5100 and relatives carry no `hvacMode` at all. Reading a property
+	* that is not there throws, so on that hardware every
+	* `TargetHeatingCoolingState` query failed: the accessory was discovered and
+	* registered, then errored on every read. The values are the same apart from
+	* an added `ABSENCE`, so resolving the name is the whole fix.
+	*
+	* `hvacMode` wins when both are present, so nothing changes for hardware that
+	* already worked.
+	*/
+	#modeProp;
 	constructor(deps) {
 		super(deps);
+		const metadata = deps.accessory.context.metadata;
+		const hasProp = (name) => metadata.some((entry) => entry.name === name);
+		this.#modeProp = hasProp("hvacMode") ? "hvacMode" : hasProp("localMode") ? "localMode" : "hvacMode";
+		if (!hasProp("hvacMode") && !hasProp("localMode")) deps.platform.log.warn(`Thermostat ${deps.accessory.displayName} advertises neither "hvacMode" nor "localMode"; its mode controls will not work.`);
+		this.#canCool = Boolean(deps.accessory.context.metadata.find(({ name }) => name === "authorization")?.enum_values?.includes("COOLING"));
 		const { TargetHeatingCoolingState, CurrentHeatingCoolingState, TargetTemperature, CurrentTemperature } = this.platform.Characteristic;
 		this.#service = this.service(this.platform.Service.Thermostat);
-		this.#service.getCharacteristic(CurrentHeatingCoolingState).setProps({ validValues: [0, 1] }).onGet(async () => {
+		this.#service.getCharacteristic(CurrentHeatingCoolingState).setProps({ validValues: this.#canCool ? [
+			0,
+			1,
+			2
+		] : [0, 1] }).onGet(async () => {
 			debugGet(CurrentHeatingCoolingState, this.#service);
 			const data = await this.#read();
 			const authorization = getTydomDataPropValue(data, "authorization");
 			const setpoint = getTydomDataPropValue(data, "setpoint");
 			const temperature = getTydomDataPropValue(data, "temperature");
-			const nextValue = authorization === "HEATING" && setpoint > temperature ? CurrentHeatingCoolingState.HEAT : CurrentHeatingCoolingState.OFF;
+			let nextValue = CurrentHeatingCoolingState.OFF;
+			if (authorization === "HEATING" && setpoint > temperature) nextValue = CurrentHeatingCoolingState.HEAT;
+			else if (authorization === "COOLING" && temperature > setpoint) nextValue = CurrentHeatingCoolingState.COOL;
 			debugGetResult(CurrentHeatingCoolingState, this.#service, nextValue);
 			return nextValue;
 		});
-		this.#service.getCharacteristic(TargetHeatingCoolingState).setProps({ validValues: [0, 1] }).onGet(async () => {
+		this.#service.getCharacteristic(TargetHeatingCoolingState).setProps({ validValues: this.#canCool ? [
+			0,
+			1,
+			2
+		] : [0, 1] }).onGet(async () => {
 			debugGet(TargetHeatingCoolingState, this.#service);
 			const data = await this.#read();
-			const hvacMode = getTydomDataPropValue(data, "hvacMode");
-			const nextValue = getTydomDataPropValue(data, "authorization") === "HEATING" && hvacMode === "NORMAL" ? TargetHeatingCoolingState.HEAT : TargetHeatingCoolingState.OFF;
+			const hvacMode = getTydomDataPropValue(data, this.#modeProp);
+			const authorization = getTydomDataPropValue(data, "authorization");
+			let nextValue = TargetHeatingCoolingState.OFF;
+			if (hvacMode === "NORMAL" && authorization === "HEATING") nextValue = TargetHeatingCoolingState.HEAT;
+			else if (hvacMode === "NORMAL" && authorization === "COOLING") nextValue = TargetHeatingCoolingState.COOL;
 			debugGetResult(TargetHeatingCoolingState, this.#service, nextValue);
 			return nextValue;
 		}).onSet(async (value) => {
 			debugSet(TargetHeatingCoolingState, this.#service, value);
-			const shouldHeat = [TargetHeatingCoolingState.HEAT, TargetHeatingCoolingState.AUTO].includes(value);
-			const tydomValue = shouldHeat ? "NORMAL" : "STOP";
-			await this.#writeHvacMode(tydomValue);
-			debugSetResult(TargetHeatingCoolingState, this.#service, value, tydomValue);
-			this.#service.getCharacteristic(CurrentHeatingCoolingState).updateValue(shouldHeat ? CurrentHeatingCoolingState.HEAT : CurrentHeatingCoolingState.OFF);
+			const wantsCool = this.#canCool && value === TargetHeatingCoolingState.COOL;
+			const isOn = wantsCool || [TargetHeatingCoolingState.HEAT, TargetHeatingCoolingState.AUTO].includes(value);
+			const hvacMode = isOn ? "NORMAL" : "STOP";
+			const values = [{
+				name: this.#modeProp,
+				value: hvacMode
+			}];
+			if (this.#canCool) values.push({
+				name: "authorization",
+				value: isOn ? wantsCool ? "COOLING" : "HEATING" : "STOP"
+			});
+			await this.api.putDeviceData(this.deviceId, this.endpointId, values);
+			debugSetResult(TargetHeatingCoolingState, this.#service, value, hvacMode);
+			const current = wantsCool ? CurrentHeatingCoolingState.COOL : isOn ? CurrentHeatingCoolingState.HEAT : CurrentHeatingCoolingState.OFF;
+			this.#service.getCharacteristic(CurrentHeatingCoolingState).updateValue(current);
 		});
 		this.#service.getCharacteristic(CurrentTemperature).onGet(async () => {
 			debugGet(CurrentTemperature, this.#service);
@@ -4825,13 +4893,21 @@ var ThermostatAccessory = class extends BaseAccessory {
 		const { TargetHeatingCoolingState, CurrentHeatingCoolingState, TargetTemperature, CurrentTemperature } = this.platform.Characteristic;
 		for (const { name, value } of updates) switch (name) {
 			case "authorization":
-				if (value !== "STOP") break;
+				if (value !== "STOP") {
+					if (this.#canCool && (value === "COOLING" || value === "HEATING")) {
+						const next = value === "COOLING" ? TargetHeatingCoolingState.COOL : TargetHeatingCoolingState.HEAT;
+						debugSetUpdate(TargetHeatingCoolingState, this.#service, next);
+						this.#service.updateCharacteristic(TargetHeatingCoolingState, next);
+					}
+					break;
+				}
 				debugSetUpdate(CurrentHeatingCoolingState, this.#service, CurrentHeatingCoolingState.OFF);
 				this.#service.updateCharacteristic(CurrentHeatingCoolingState, CurrentHeatingCoolingState.OFF);
 				debugSetUpdate(TargetHeatingCoolingState, this.#service, TargetHeatingCoolingState.OFF);
 				this.#service.updateCharacteristic(TargetHeatingCoolingState, TargetHeatingCoolingState.OFF);
 				break;
-			case "hvacMode": {
+			case "hvacMode":
+			case "localMode": {
 				const hvacMode = value;
 				if (hvacMode === "NORMAL") break;
 				this.#service.updateCharacteristic(TargetHeatingCoolingState, TargetHeatingCoolingState.OFF);
@@ -4863,7 +4939,7 @@ var ThermostatAccessory = class extends BaseAccessory {
 	}
 	async #writeHvacMode(value) {
 		await this.api.putDeviceData(this.deviceId, this.endpointId, [{
-			name: "hvacMode",
+			name: this.#modeProp,
 			value
 		}]);
 	}
@@ -4904,7 +4980,7 @@ var ThermostatAccessory = class extends BaseAccessory {
 		service.getCharacteristic(On).onGet(async () => {
 			debugGet(On, service);
 			const data = await this.#read();
-			const nextValue = subtype === "hvacMode_absence" ? getTydomDataPropValue(data, "hvacMode") === "ANTI_FROST" : getTydomDataPropValue(data, "thermicLevel") === tydomValue;
+			const nextValue = subtype === "hvacMode_absence" ? getTydomDataPropValue(data, this.#modeProp) === "ANTI_FROST" : getTydomDataPropValue(data, "thermicLevel") === tydomValue;
 			debugGetResult(On, service, nextValue);
 			return nextValue;
 		}).onSet(async (value) => {
@@ -5544,4 +5620,4 @@ var TydomPlatform = class {
 //#endregion
 export { TydomPlatform as default };
 
-//# sourceMappingURL=platform-BjoGoTvF.mjs.map
+//# sourceMappingURL=platform-BssMTVVc.mjs.map