homebridge-tuya-plus 3.14.0-dev.17 → 3.14.0-dev.19

package/Changelog.md

@@ -16,6 +16,11 @@ All notable changes to this project will be documented in this file. This projec
 * [*] **IrrigationSystem: stop the valve toggle flickering after a press** — tapping a zone briefly snapped back to the old state before settling on the new one. The `Active` getters returned the raw `device.state`, which (for cloud devices) only advances once the realtime stream echoes the write back, so a read in that window reported the pre-press value. The getters now report the value HomeKit already shows (optimistic on press, then confirmed/corrected by device-side change events); they still surface "No Response" while disconnected.
 * [*] **Tuya Cloud: report real device online/offline status.** Cloud devices previously always showed as reachable. They now mirror Tuya's `online` flag (read from the device record on connect and re-checked when the realtime stream reconnects), so HomeKit shows **"No Response"** when the device is genuinely offline. If the lookup isn't permitted (the project lacks the device-management API), the device is assumed reachable so control is never blocked.
 * [*] **Signal unreachable devices with `HapStatusError`.** The shared getters (`getStateAsync` / `getDividedStateAsync`, used by nearly every accessory's read handlers, plus the irrigation `Active` getter) threw a plain `Error` to make HomeKit show "No Response". Newer Homebridge logs a characteristic warning for that before falling back to a generic status; they now throw `HapStatusError(SERVICE_COMMUNICATION_FAILURE)` directly — same "No Response", no warning spam. No behaviour change for users.
+* [*] **Surface write and connection failures to HomeKit, universally across device types.** Previously a command sent to an unreachable device was silently dropped while HomeKit still reported the tap as successful, and several accessories kept showing their last-known state instead of going "No Response" — the clearest example was a LAN gate that logged `skipping write, device not connected` yet still appeared online and "accepted" open/close taps. Now:
+  * **Writes** to a disconnected device (or a write the device/cloud rejects) fail the HomeKit operation instead of pretending success. The shared write helpers (`setState` / `setMultiState` / `setMultiStateLegacy` and their `*Async` variants) now signal a communication failure, so accessories whose set handlers swallowed it (garage door, switches/outlets, RGB hue + saturation, blinds, vertical-tilt blinds) report it on a tap.
+  * **Reads** that returned a cached/optimistic or constant value (brightness, colour, hue/saturation, blind position/state, garage-door state, valve in-use/duration, heater state, …) now report **"No Response"** when the device is unreachable — matching the read handlers that already did.
+  * **Cloud** commands that fail over HTTP (a network error, or a command Tuya rejects) are surfaced too: `TuyaCloudDevice.update()` now resolves to the real command result so the write helper can await it, rather than firing and forgetting.
+  * Internal/background writes (auto-shutoff timers, multi-step open/close sequences, debounced batches) stay non-fatal via dedicated non-throwing helpers (`setStateInBackground` / `setMultiStateInBackground` / `setMultiStateLegacyInBackground`), so an unreachable device can never crash Homebridge with an unhandled error.
 
 ## 2.0.1 (2021-03-25)
 This update includes the following changes:

package/config.schema.json

@@ -318,7 +318,7 @@
               "title": "Sync brightness to WLED (IP[:port])",
               "placeholder": "192.168.1.100",
               "condition": {
-                "functionBody": "return model.devices && model.devices[arrayIndices] && ['WledDimmer', 'SimpleDimmer'].includes(model.devices[arrayIndices].type);"
+                "functionBody": "return model.devices && model.devices[arrayIndices] && ['WledDimmer'].includes(model.devices[arrayIndices].type);"
               }
             },            
             "dpColorTemperature": {

package/index.js

@@ -18,6 +18,7 @@ const ConvectorAccessory = require('./lib/ConvectorAccessory');
 const GarageDoorAccessory = require('./lib/GarageDoorAccessory');
 const SimpleGarageDoorAccessory = require('./lib/SimpleGarageDoorAccessory');
 const WledDimmerAccessory = require('./lib/WledDimmerAccessory');
+const SimpleDimmerAccessory = require('./lib/SimpleDimmerAccessory');
 const SimpleDimmer2Accessory = require('./lib/SimpleDimmer2Accessory');
 const SimpleBlindsAccessory = require('./lib/SimpleBlindsAccessory');
 const SimpleHeaterAccessory = require('./lib/SimpleHeaterAccessory');
@@ -60,7 +61,7 @@ const CLASS_DEF = {
     convector: ConvectorAccessory,
     garagedoor: GarageDoorAccessory,
     simplegaragedoor: SimpleGarageDoorAccessory,
-    simpledimmer: WledDimmerAccessory,
+    simpledimmer: SimpleDimmerAccessory,
     wleddimmer: WledDimmerAccessory,
     simpledimmer2: SimpleDimmer2Accessory,
     simpleblinds: SimpleBlindsAccessory,

package/lib/BaseAccessory.js

@@ -76,7 +76,7 @@ class BaseAccessory {
     }
 
     getState(dp, callback) {
-        if (!this.device.connected) return callback(true);
+        if (!this.device.connected) return callback(this._commError());
         const _callback = () => {
             if (Array.isArray(dp)) {
                 const ret = {};
@@ -101,29 +101,30 @@ class BaseAccessory {
         //For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues.
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return callback && callback();
+            return callback && callback(this._commError());
         }
         const ret = this.device.update(dps);
-        callback && callback(!ret);
+        callback && callback(ret === false ? this._commError() : null);
     }
 
     setMultiState(dps, callback) {
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return callback && callback();
+            return callback && callback(this._commError());
         }
+        let failed = false;
         for (const dp in dps) {
             if (dps.hasOwnProperty(dp) && dps[dp] !== this.device.state[dp]){
-                this.__ret = this.device.update({[dp.toString()] : dps[dp]});
+                if (this.device.update({[dp.toString()] : dps[dp]}) === false) failed = true;
             }
         }
-        callback && callback(!this.__ret);
+        callback && callback(failed ? this._commError() : null);
     }
 
     getDividedState(dp, divisor, callback) {
         this.getState(dp, (err, data) => {
             if (err) return callback(err);
-            if (!isFinite(data)) return callback(true);
+            if (!isFinite(data)) return callback(this._commError());
 
             callback(null, this._getDividedState(data, divisor));
         });
@@ -143,24 +144,50 @@ class BaseAccessory {
         return this.setMultiStateAsync({[dp.toString()]: value});
     }
 
-    setMultiStateAsync(dps) {
+    // Throws a "No Response" HapStatusError when the device is unreachable or the
+    // write is rejected, so a get/set handler that returns this promise surfaces
+    // the failure to HomeKit instead of silently pretending the write succeeded.
+    // `device.update` returns a boolean for LAN devices and an awaitable boolean
+    // for cloud devices (false == the command did not go through).
+    async setMultiStateAsync(dps) {
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return;
+            throw this._commError();
         }
+        const writes = [];
         for (const dp in dps) {
             if (dps.hasOwnProperty(dp) && dps[dp] !== this.device.state[dp]) {
-                this.device.update({[dp.toString()]: dps[dp]});
+                writes.push(this.device.update({[dp.toString()]: dps[dp]}));
             }
         }
+        const results = await Promise.all(writes);
+        if (results.some(ok => ok === false)) throw this._commError();
     }
 
-    setMultiStateLegacyAsync(dps) {
+    async setMultiStateLegacyAsync(dps) {
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return;
+            throw this._commError();
         }
-        this.device.update(dps);
+        if (await this.device.update(dps) === false) throw this._commError();
+    }
+
+    // Non-throwing write helpers for callers that are NOT inside a HomeKit
+    // get/set handler — setTimeout callbacks, multi-step command sequences, etc.
+    // The async helpers above reject on a disconnected/failed write so HomeKit
+    // can show "No Response"; in a detached/background context there is no
+    // HomeKit request to fail and an unhandled rejection would crash Homebridge,
+    // so these swallow the error (the helper has already logged it).
+    setStateInBackground(dp, value) {
+        this.setStateAsync(dp, value).catch(() => {});
+    }
+
+    setMultiStateInBackground(dps) {
+        this.setMultiStateAsync(dps).catch(() => {});
+    }
+
+    setMultiStateLegacyInBackground(dps) {
+        this.setMultiStateLegacyAsync(dps).catch(() => {});
     }
 
     getDividedStateAsync(dp, divisor) {

package/lib/ConvectorAccessory.js

@@ -55,7 +55,7 @@ class ConvectorAccessory extends BaseAccessory {
         service.getCharacteristic(Characteristic.TargetHeaterCoolerState)
             .setProps({ minValue: 1, maxValue: 1, validValues: [Characteristic.TargetHeaterCoolerState.HEAT] })
             .updateValue(this._getTargetHeaterCoolerState())
-            .onGet(() => this._getTargetHeaterCoolerState())
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this._getTargetHeaterCoolerState(); })
             .onSet(() => this.setStateAsync(this.dpActive, true));
 
         const characteristicCurrentTemperature = service.getCharacteristic(Characteristic.CurrentTemperature)

package/lib/CustomMultiOutletAccessory.js

@@ -74,6 +74,7 @@ class CustomMultiOutletAccessory extends BaseAccessory {
     }
 
     setPower(dp, value) {
+        if (!this.device.connected) throw this._commError();
         if (!this._pendingPower) {
             this._pendingPower = {props: {}, resolvers: []};
         }
@@ -87,7 +88,7 @@ class CustomMultiOutletAccessory extends BaseAccessory {
             this._pendingPower.timer = setTimeout(() => {
                 const {props, resolvers} = this._pendingPower;
                 this._pendingPower = null;
-                this.setMultiStateAsync(props);
+                this.setMultiStateInBackground(props);
                 resolvers.forEach(r => r());
             }, 500);
         });

package/lib/MultiOutletAccessory.js

@@ -69,6 +69,7 @@ class MultiOutletAccessory extends BaseAccessory {
     }
 
     setPower(dp, value) {
+        if (!this.device.connected) throw this._commError();
         if (!this._pendingPower) {
             this._pendingPower = {props: {}, resolvers: []};
         }
@@ -82,7 +83,7 @@ class MultiOutletAccessory extends BaseAccessory {
             this._pendingPower.timer = setTimeout(() => {
                 const {props, resolvers} = this._pendingPower;
                 this._pendingPower = null;
-                this.setMultiStateAsync(props);
+                this.setMultiStateInBackground(props);
                 resolvers.forEach(r => r());
             }, 500);
         });

package/lib/OilDiffuserAccessory.js

@@ -203,8 +203,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
     }
 
     setBrightness(value) {
@@ -218,8 +218,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getColorTemperature() {
-        if (this.device.state[this.dpMode] !== this.cmdWhite) return 0;
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        if (this.getStateAsync(this.dpMode) !== this.cmdWhite) return 0;
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {
@@ -234,8 +234,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getHue() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return 0;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).h;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return 0;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).h;
     }
 
     setHue(value) {
@@ -243,7 +243,7 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getSaturation() {
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).s;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).s;
     }
 
     setSaturation(value) {
@@ -251,6 +251,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     _setHueSaturation(prop) {
+        if (!this.device.connected) throw this._commError();
+
         if (!this._pendingHueSaturation) {
             this._pendingHueSaturation = {props: {}, resolvers: []};
         }
@@ -266,7 +268,7 @@ class OilDiffuserAccessory extends BaseAccessory {
                 this._pendingHueSaturation = null;
 
                 const newValue = this.convertColorFromHomeKitToTuya(props);
-                this.setMultiStateAsync({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
+                this.setMultiStateInBackground({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
 
                 resolvers.forEach(r => r());
             }, 500);

package/lib/RGBTWLightAccessory.js

@@ -134,8 +134,8 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
     }
 
     setBrightness(value) {
@@ -145,8 +145,8 @@ class RGBTWLightAccessory extends BaseAccessory {
 
     getColorTemperature() {
         this.log.debug(`getColorTemperature`);
-        if (this.device.state[this.dpMode] !== this.cmdWhite) return this.minWhiteColor;
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        if (this.getStateAsync(this.dpMode) !== this.cmdWhite) return this.minWhiteColor;
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {
@@ -165,10 +165,10 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     getHue() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) {
-            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature])).h;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) {
+            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature))).h;
         }
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).h;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).h;
     }
 
     setHue(value) {
@@ -176,10 +176,10 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     getSaturation() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) {
-            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature])).s;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) {
+            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature))).s;
         }
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).s;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).s;
     }
 
     setSaturation(value) {
@@ -187,6 +187,8 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     _setHueSaturation(prop) {
+        if (!this.device.connected) throw this._commError();
+
         if (!this._pendingHueSaturation) {
             this._pendingHueSaturation = {props: {}, resolvers: []};
         }
@@ -208,7 +210,7 @@ class RGBTWLightAccessory extends BaseAccessory {
                 const newValue = this.convertColorFromHomeKitToTuya(props);
 
                 if (!(this.device.state[this.dpMode] === this.cmdWhite && isSham)) {
-                    this.setMultiStateAsync({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
+                    this.setMultiStateInBackground({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
                 }
                 this.characteristicColorTemperature.updateValue(this.minWhiteColor);
 

package/lib/RGBTWOutletAccessory.js

@@ -196,8 +196,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
     }
 
     setBrightness(value) {
@@ -206,8 +206,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getColorTemperature() {
-        if (this.device.state[this.dpMode] !== this.cmdWhite) return 0;
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        if (this.getStateAsync(this.dpMode) !== this.cmdWhite) return 0;
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {
@@ -221,8 +221,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getHue() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return 0;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).h;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return 0;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).h;
     }
 
     setHue(value) {
@@ -230,8 +230,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getSaturation() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return 0;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).s;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return 0;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).s;
     }
 
     setSaturation(value) {
@@ -239,6 +239,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     _setHueSaturation(prop) {
+        if (!this.device.connected) throw this._commError();
+
         if (!this._pendingHueSaturation) {
             this._pendingHueSaturation = {props: {}, resolvers: []};
         }
@@ -257,7 +259,7 @@ class RGBTWOutletAccessory extends BaseAccessory {
                 const newValue = this.convertColorFromHomeKitToTuya(props);
 
                 if (!(this.device.state[this.dpMode] === this.cmdWhite && isSham)) {
-                    this.setMultiStateAsync({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
+                    this.setMultiStateInBackground({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
                 }
                 this.characteristicColorTemperature.updateValue(0);
 

package/lib/SimpleBlindsAccessory.js

@@ -92,7 +92,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
 
         const characteristicPositionState = service.getCharacteristic(Characteristic.PositionState)
             .updateValue(this._getPositionState())
-            .onGet(() => this._getPositionState());
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this._getPositionState(); });
 
         this.device.on('change', changes => {
             this.log.debug('[TuyaAccessory] Blinds saw change to ' + changes[this.dpAction]);
@@ -176,7 +176,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
     }
 
     getCurrentPosition() {
-        return this._getCurrentPosition(this.device.state[this.dpAction]);
+        return this._getCurrentPosition(this.getStateAsync(this.dpAction));
     }
 
     _getCurrentPosition(dp) {
@@ -191,7 +191,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
     }
 
     getTargetPosition() {
-        return this._getTargetPosition(this.device.state[this.dpAction]);
+        return this._getTargetPosition(this.getStateAsync(this.dpAction));
     }
 
     _getTargetPosition(dp) {
@@ -234,7 +234,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
                 this.log.debug('[TuyaAccessory] Blinds will stop in ' + duration + 'ms');
                 this.changeTimeout = setTimeout(() => {
                     this.log.debug('[TuyaAccessory] Blinds asked to stop');
-                    this.setStateAsync(this.dpAction, this.cmdStop);
+                    this.setStateInBackground(this.dpAction, this.cmdStop);
                 }, duration);
             }
             return result;
@@ -246,7 +246,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
                 this.log.debug('[TuyaAccessory] Blinds will stop in ' + duration + 'ms');
                 this.changeTimeout = setTimeout(() => {
                     this.log.debug('[TuyaAccessory] Blinds asked to stop');
-                    this.setStateAsync(this.dpAction, this.cmdStop);
+                    this.setStateInBackground(this.dpAction, this.cmdStop);
                 }, duration);
             }
             return result;

package/lib/SimpleDimmer2Accessory.js

@@ -43,7 +43,7 @@ class SimpleDimmer2Accessory extends BaseAccessory {
     }
 
     getBrightness() {
-        return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
+        return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
     }
 
     setBrightness(value) {

package/lib/SimpleDimmerAccessory.js

@@ -25,25 +25,29 @@ class SimpleDimmerAccessory extends BaseAccessory {
         this.dpPower = this._getCustomDP(this.device.context.dpPower) || '1';
         this.dpBrightness = this._getCustomDP(this.device.context.dpBrightness) || this._getCustomDP(this.device.context.dp) || '2';
 
-        const characteristicOn = service.getCharacteristic(Characteristic.On)
+        this._characteristicOn = service.getCharacteristic(Characteristic.On)
             .updateValue(dps[this.dpPower])
             .onGet(() => this.getStateAsync(this.dpPower))
             .onSet(value => this.setStateAsync(this.dpPower, value));
 
-        const characteristicBrightness = service.getCharacteristic(Characteristic.Brightness)
+        this._characteristicBrightness = service.getCharacteristic(Characteristic.Brightness)
             .updateValue(this.convertBrightnessFromTuyaToHomeKit(dps[this.dpBrightness]))
             .onGet(() => this.getBrightness())
             .onSet(value => this.setBrightness(value));
 
+        this._registerChangeListener();
+    }
+
+    _registerChangeListener() {
         this.device.on('change', changes => {
-            if (changes.hasOwnProperty(this.dpPower) && characteristicOn.value !== changes[this.dpPower]) characteristicOn.updateValue(changes[this.dpPower]);
-            if (changes.hasOwnProperty(this.dpBrightness) && this.convertBrightnessFromHomeKitToTuya(characteristicBrightness.value) !== changes[this.dpBrightness])
-                characteristicBrightness.updateValue(this.convertBrightnessFromTuyaToHomeKit(changes[this.dpBrightness]));
+            if (changes.hasOwnProperty(this.dpPower) && this._characteristicOn.value !== changes[this.dpPower]) this._characteristicOn.updateValue(changes[this.dpPower]);
+            if (changes.hasOwnProperty(this.dpBrightness) && this.convertBrightnessFromHomeKitToTuya(this._characteristicBrightness.value) !== changes[this.dpBrightness])
+                this._characteristicBrightness.updateValue(this.convertBrightnessFromTuyaToHomeKit(changes[this.dpBrightness]));
         });
     }
 
     getBrightness() {
-        return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
+        return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
     }
 
     setBrightness(value) {

package/lib/SimpleGarageDoorAccessory.js

@@ -117,25 +117,25 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
 
         this.characteristicTargetDoorState = service.getCharacteristic(Characteristic.TargetDoorState)
             .updateValue(initialTarget)
-            .onGet(() => this.accessory.context.cachedTargetDoorState)
+            .onGet(() => this._reportDoorState(this.accessory.context.cachedTargetDoorState))
             .onSet(value => this.setTargetDoorState(value));
 
         this.characteristicCurrentDoorState = service.getCharacteristic(Characteristic.CurrentDoorState)
             .updateValue(this.currentDoorState)
-            .onGet(() => this.currentDoorState);
+            .onGet(() => this._reportDoorState(this.currentDoorState));
 
         // The controller exposes limit switches (l_open/l_close) but they don't
         // work in practice, and there's no obstruction sensor wired up, so this
         // is always reported clear.
         service.getCharacteristic(Characteristic.ObstructionDetected)
             .updateValue(false)
-            .onGet(() => false);
+            .onGet(() => this._reportDoorState(false));
 
         const partialSwitch = this.accessory.getServiceById(Service.Switch, 'partialOpen');
         if (partialSwitch) {
             const onChar = partialSwitch.getCharacteristic(Characteristic.On)
                 .updateValue(isOpen)
-                .onGet(() => this.currentDoorState === Characteristic.CurrentDoorState.OPEN)
+                .onGet(() => this._reportDoorState(this.currentDoorState === Characteristic.CurrentDoorState.OPEN))
                 .onSet(value => {
                     // Stateful: the switch mirrors CurrentDoorState (ON while
                     // the gate is open in HomeKit's view — see
@@ -197,7 +197,7 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
         if (this.pendingCloseTimer) return;
         const isOpen = this._mapDpState(changes[this.dpState]);
         if (isOpen === null) {
-            this.log.info(`[SimpleGarageDoor] ${this.device.context.name}: ignoring unknown state DP value ${JSON.stringify(changes[this.dpState])}`);
+            this.log.debug(`[SimpleGarageDoor] ${this.device.context.name}: ignoring unknown state DP value ${JSON.stringify(changes[this.dpState])}`);
             return;
         }
         this._applyReportedState(isOpen);
@@ -229,7 +229,19 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
         }
     }
 
+    // onGet helper: a cached/optimistic door value is fine to report while the
+    // gate is reachable, but when it's offline HomeKit must show "No Response"
+    // instead of a stale state that makes the gate look online and accept taps.
+    _reportDoorState(value) {
+        if (!this.device.connected) throw this._commError();
+        return value;
+    }
+
     setTargetDoorState(value) {
+        // Surface "No Response" for a tap on an unreachable gate instead of
+        // silently dropping the command (the write helpers would otherwise just
+        // log and skip, leaving HomeKit to believe the open/close succeeded).
+        if (!this.device.connected) throw this._commError();
         // A direct open/close (the GarageDoorOpener target, a Force switch, or
         // the partial switch tapped OFF) is manual control: cancel any pending
         // partial-open auto-stop so it can't halt this movement part-way.
@@ -254,8 +266,8 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
     // own, even mid-close. Abandon any pending stop-before-close.
     _sendOpen() {
         this._cancelPendingClose();
-        this.log.info(`[SimpleGarageDoor] ${this.device.context.name}: open (dp${this.dpOpen})`);
-        this.setMultiStateLegacyAsync({[this.dpOpen]: true});
+        this.log.debug(`[SimpleGarageDoor] ${this.device.context.name}: open (dp${this.dpOpen})`);
+        this.setMultiStateLegacyInBackground({[this.dpOpen]: true});
     }
 
     // Close is ignored while the gate is actively moving, so fire it directly
@@ -266,20 +278,20 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
         if (this.pendingCloseTimer) {
             // A stop-before-close is already running — don't restart it (and
             // push the close out) on a duplicate or retransmitted request.
-            this.log.info(`[SimpleGarageDoor] ${name}: close ignored — a stop-before-close is already running`);
+            this.log.debug(`[SimpleGarageDoor] ${name}: close ignored — a stop-before-close is already running`);
             return;
         }
         if (this._isStopped()) {
-            this.log.info(`[SimpleGarageDoor] ${name}: close (dp${this.dpClose}) — gate already stopped`);
-            this.setMultiStateLegacyAsync({[this.dpClose]: true});
+            this.log.debug(`[SimpleGarageDoor] ${name}: close (dp${this.dpClose}) — gate already stopped`);
+            this.setMultiStateLegacyInBackground({[this.dpClose]: true});
             return;
         }
-        this.log.info(`[SimpleGarageDoor] ${name}: stop-before-close — stop (dp${this.dpStop}) now, close (dp${this.dpClose}) in ${this.stopBeforeCloseMs}ms`);
-        this.setMultiStateLegacyAsync({[this.dpStop]: true});
+        this.log.debug(`[SimpleGarageDoor] ${name}: stop-before-close — stop (dp${this.dpStop}) now, close (dp${this.dpClose}) in ${this.stopBeforeCloseMs}ms`);
+        this.setMultiStateLegacyInBackground({[this.dpStop]: true});
         this.pendingCloseTimer = setTimeout(() => {
             this.pendingCloseTimer = null;
-            this.log.info(`[SimpleGarageDoor] ${name}: stop-before-close — firing close (dp${this.dpClose})`);
-            this.setMultiStateLegacyAsync({[this.dpClose]: true});
+            this.log.debug(`[SimpleGarageDoor] ${name}: stop-before-close — firing close (dp${this.dpClose})`);
+            this.setMultiStateLegacyInBackground({[this.dpClose]: true});
         }, this.stopBeforeCloseMs);
     }
 
@@ -305,21 +317,22 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
     _handlePartialOpen() {
         const {Characteristic} = this.hap;
         const name = this.device.context.name;
+        if (!this.device.connected) throw this._commError();
         if (!this.partialOpenMs) return;
         if (this.partialStopTimer) {
             // Re-entrant press while a partial is already armed (e.g. a
             // HomeKit/iOS WRITE retransmit) — ignore so the stop isn't pushed
             // out, which would let the gate run further than intended.
-            this.log.info(`[SimpleGarageDoor] ${name}: partial press ignored — a partial open is already running`);
+            this.log.debug(`[SimpleGarageDoor] ${name}: partial press ignored — a partial open is already running`);
             return;
         }
 
-        this.log.info(`[SimpleGarageDoor] ${name}: partial open — opening, will stop in ${this.partialOpenMs}ms`);
+        this.log.debug(`[SimpleGarageDoor] ${name}: partial open — opening, will stop in ${this.partialOpenMs}ms`);
         this._applyTarget(Characteristic.TargetDoorState.OPEN);
         this.partialStopTimer = setTimeout(() => {
             this.partialStopTimer = null;
-            this.log.info(`[SimpleGarageDoor] ${name}: partial open — firing stop (dp${this.dpStop})`);
-            this.setMultiStateLegacyAsync({[this.dpStop]: true});
+            this.log.debug(`[SimpleGarageDoor] ${name}: partial open — firing stop (dp${this.dpStop})`);
+            this.setMultiStateLegacyInBackground({[this.dpStop]: true});
         }, this.partialOpenMs);
     }
 

package/lib/SimpleHeaterAccessory.js

@@ -45,7 +45,7 @@ class SimpleHeaterAccessory extends BaseAccessory {
 
         const characteristicCurrentHeaterCoolerState = service.getCharacteristic(Characteristic.CurrentHeaterCoolerState)
             .updateValue(this._getCurrentHeaterCoolerState(dps))
-            .onGet(() => this.currentHeaterCoolerState);
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this.currentHeaterCoolerState; });
 
         service.getCharacteristic(Characteristic.TargetHeaterCoolerState)
             .setProps({
@@ -54,7 +54,7 @@ class SimpleHeaterAccessory extends BaseAccessory {
                 validValues: [Characteristic.TargetHeaterCoolerState.HEAT]
             })
             .updateValue(this._getTargetHeaterCoolerState())
-            .onGet(() => this._getTargetHeaterCoolerState())
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this._getTargetHeaterCoolerState(); })
             .onSet(() => this.setStateAsync(this.dpActive, true));
 
         const characteristicCurrentTemperature = service.getCharacteristic(Characteristic.CurrentTemperature)

package/lib/SwitchAccessory.js

@@ -69,6 +69,7 @@ class SwitchAccessory extends BaseAccessory {
     }
 
     setPower(dp, value) {
+        if (!this.device.connected) throw this._commError();
         if (!this._pendingPower) {
             this._pendingPower = {props: {}, resolvers: []};
         }
@@ -82,7 +83,7 @@ class SwitchAccessory extends BaseAccessory {
             this._pendingPower.timer = setTimeout(() => {
                 const {props, resolvers} = this._pendingPower;
                 this._pendingPower = null;
-                this.setMultiStateAsync(props);
+                this.setMultiStateInBackground(props);
                 resolvers.forEach(r => r());
             }, 500);
         });