homebridge-tuya-plus 3.14.0-dev.16 → 3.14.0-dev.18

package/Changelog.md

@@ -16,6 +16,11 @@ All notable changes to this project will be documented in this file. This projec
 * [*] **IrrigationSystem: stop the valve toggle flickering after a press** — tapping a zone briefly snapped back to the old state before settling on the new one. The `Active` getters returned the raw `device.state`, which (for cloud devices) only advances once the realtime stream echoes the write back, so a read in that window reported the pre-press value. The getters now report the value HomeKit already shows (optimistic on press, then confirmed/corrected by device-side change events); they still surface "No Response" while disconnected.
 * [*] **Tuya Cloud: report real device online/offline status.** Cloud devices previously always showed as reachable. They now mirror Tuya's `online` flag (read from the device record on connect and re-checked when the realtime stream reconnects), so HomeKit shows **"No Response"** when the device is genuinely offline. If the lookup isn't permitted (the project lacks the device-management API), the device is assumed reachable so control is never blocked.
 * [*] **Signal unreachable devices with `HapStatusError`.** The shared getters (`getStateAsync` / `getDividedStateAsync`, used by nearly every accessory's read handlers, plus the irrigation `Active` getter) threw a plain `Error` to make HomeKit show "No Response". Newer Homebridge logs a characteristic warning for that before falling back to a generic status; they now throw `HapStatusError(SERVICE_COMMUNICATION_FAILURE)` directly — same "No Response", no warning spam. No behaviour change for users.
+* [*] **Surface write and connection failures to HomeKit, universally across device types.** Previously a command sent to an unreachable device was silently dropped while HomeKit still reported the tap as successful, and several accessories kept showing their last-known state instead of going "No Response" — the clearest example was a LAN gate that logged `skipping write, device not connected` yet still appeared online and "accepted" open/close taps. Now:
+  * **Writes** to a disconnected device (or a write the device/cloud rejects) fail the HomeKit operation instead of pretending success. The shared write helpers (`setState` / `setMultiState` / `setMultiStateLegacy` and their `*Async` variants) now signal a communication failure, so accessories whose set handlers swallowed it (garage door, switches/outlets, RGB hue + saturation, blinds, vertical-tilt blinds) report it on a tap.
+  * **Reads** that returned a cached/optimistic or constant value (brightness, colour, hue/saturation, blind position/state, garage-door state, valve in-use/duration, heater state, …) now report **"No Response"** when the device is unreachable — matching the read handlers that already did.
+  * **Cloud** commands that fail over HTTP (a network error, or a command Tuya rejects) are surfaced too: `TuyaCloudDevice.update()` now resolves to the real command result so the write helper can await it, rather than firing and forgetting.
+  * Internal/background writes (auto-shutoff timers, multi-step open/close sequences, debounced batches) stay non-fatal via dedicated non-throwing helpers (`setStateInBackground` / `setMultiStateInBackground` / `setMultiStateLegacyInBackground`), so an unreachable device can never crash Homebridge with an unhandled error.
 
 ## 2.0.1 (2021-03-25)
 This update includes the following changes:

package/lib/BaseAccessory.js

@@ -76,7 +76,7 @@ class BaseAccessory {
     }
 
     getState(dp, callback) {
-        if (!this.device.connected) return callback(true);
+        if (!this.device.connected) return callback(this._commError());
         const _callback = () => {
             if (Array.isArray(dp)) {
                 const ret = {};
@@ -101,29 +101,30 @@ class BaseAccessory {
         //For devices like the DETA Smart Fan Controller Switch that by default set the speed as 3 the new code in the setMultiState function causes issues.
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return callback && callback();
+            return callback && callback(this._commError());
         }
         const ret = this.device.update(dps);
-        callback && callback(!ret);
+        callback && callback(ret === false ? this._commError() : null);
     }
 
     setMultiState(dps, callback) {
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return callback && callback();
+            return callback && callback(this._commError());
         }
+        let failed = false;
         for (const dp in dps) {
             if (dps.hasOwnProperty(dp) && dps[dp] !== this.device.state[dp]){
-                this.__ret = this.device.update({[dp.toString()] : dps[dp]});
+                if (this.device.update({[dp.toString()] : dps[dp]}) === false) failed = true;
             }
         }
-        callback && callback(!this.__ret);
+        callback && callback(failed ? this._commError() : null);
     }
 
     getDividedState(dp, divisor, callback) {
         this.getState(dp, (err, data) => {
             if (err) return callback(err);
-            if (!isFinite(data)) return callback(true);
+            if (!isFinite(data)) return callback(this._commError());
 
             callback(null, this._getDividedState(data, divisor));
         });
@@ -143,24 +144,50 @@ class BaseAccessory {
         return this.setMultiStateAsync({[dp.toString()]: value});
     }
 
-    setMultiStateAsync(dps) {
+    // Throws a "No Response" HapStatusError when the device is unreachable or the
+    // write is rejected, so a get/set handler that returns this promise surfaces
+    // the failure to HomeKit instead of silently pretending the write succeeded.
+    // `device.update` returns a boolean for LAN devices and an awaitable boolean
+    // for cloud devices (false == the command did not go through).
+    async setMultiStateAsync(dps) {
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return;
+            throw this._commError();
         }
+        const writes = [];
         for (const dp in dps) {
             if (dps.hasOwnProperty(dp) && dps[dp] !== this.device.state[dp]) {
-                this.device.update({[dp.toString()]: dps[dp]});
+                writes.push(this.device.update({[dp.toString()]: dps[dp]}));
             }
         }
+        const results = await Promise.all(writes);
+        if (results.some(ok => ok === false)) throw this._commError();
     }
 
-    setMultiStateLegacyAsync(dps) {
+    async setMultiStateLegacyAsync(dps) {
         if (!this.device.connected) {
             this.log.debug(`${this.device.context.name}: skipping write, device not connected`);
-            return;
+            throw this._commError();
         }
-        this.device.update(dps);
+        if (await this.device.update(dps) === false) throw this._commError();
+    }
+
+    // Non-throwing write helpers for callers that are NOT inside a HomeKit
+    // get/set handler — setTimeout callbacks, multi-step command sequences, etc.
+    // The async helpers above reject on a disconnected/failed write so HomeKit
+    // can show "No Response"; in a detached/background context there is no
+    // HomeKit request to fail and an unhandled rejection would crash Homebridge,
+    // so these swallow the error (the helper has already logged it).
+    setStateInBackground(dp, value) {
+        this.setStateAsync(dp, value).catch(() => {});
+    }
+
+    setMultiStateInBackground(dps) {
+        this.setMultiStateAsync(dps).catch(() => {});
+    }
+
+    setMultiStateLegacyInBackground(dps) {
+        this.setMultiStateLegacyAsync(dps).catch(() => {});
     }
 
     getDividedStateAsync(dp, divisor) {

package/lib/ConvectorAccessory.js

@@ -55,7 +55,7 @@ class ConvectorAccessory extends BaseAccessory {
         service.getCharacteristic(Characteristic.TargetHeaterCoolerState)
             .setProps({ minValue: 1, maxValue: 1, validValues: [Characteristic.TargetHeaterCoolerState.HEAT] })
             .updateValue(this._getTargetHeaterCoolerState())
-            .onGet(() => this._getTargetHeaterCoolerState())
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this._getTargetHeaterCoolerState(); })
             .onSet(() => this.setStateAsync(this.dpActive, true));
 
         const characteristicCurrentTemperature = service.getCharacteristic(Characteristic.CurrentTemperature)

package/lib/CustomMultiOutletAccessory.js

@@ -74,6 +74,7 @@ class CustomMultiOutletAccessory extends BaseAccessory {
     }
 
     setPower(dp, value) {
+        if (!this.device.connected) throw this._commError();
         if (!this._pendingPower) {
             this._pendingPower = {props: {}, resolvers: []};
         }
@@ -87,7 +88,7 @@ class CustomMultiOutletAccessory extends BaseAccessory {
             this._pendingPower.timer = setTimeout(() => {
                 const {props, resolvers} = this._pendingPower;
                 this._pendingPower = null;
-                this.setMultiStateAsync(props);
+                this.setMultiStateInBackground(props);
                 resolvers.forEach(r => r());
             }, 500);
         });

package/lib/MultiOutletAccessory.js

@@ -69,6 +69,7 @@ class MultiOutletAccessory extends BaseAccessory {
     }
 
     setPower(dp, value) {
+        if (!this.device.connected) throw this._commError();
         if (!this._pendingPower) {
             this._pendingPower = {props: {}, resolvers: []};
         }
@@ -82,7 +83,7 @@ class MultiOutletAccessory extends BaseAccessory {
             this._pendingPower.timer = setTimeout(() => {
                 const {props, resolvers} = this._pendingPower;
                 this._pendingPower = null;
-                this.setMultiStateAsync(props);
+                this.setMultiStateInBackground(props);
                 resolvers.forEach(r => r());
             }, 500);
         });

package/lib/OilDiffuserAccessory.js

@@ -203,8 +203,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
     }
 
     setBrightness(value) {
@@ -218,8 +218,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getColorTemperature() {
-        if (this.device.state[this.dpMode] !== this.cmdWhite) return 0;
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        if (this.getStateAsync(this.dpMode) !== this.cmdWhite) return 0;
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {
@@ -234,8 +234,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getHue() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return 0;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).h;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return 0;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).h;
     }
 
     setHue(value) {
@@ -243,7 +243,7 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     getSaturation() {
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).s;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).s;
     }
 
     setSaturation(value) {
@@ -251,6 +251,8 @@ class OilDiffuserAccessory extends BaseAccessory {
     }
 
     _setHueSaturation(prop) {
+        if (!this.device.connected) throw this._commError();
+
         if (!this._pendingHueSaturation) {
             this._pendingHueSaturation = {props: {}, resolvers: []};
         }
@@ -266,7 +268,7 @@ class OilDiffuserAccessory extends BaseAccessory {
                 this._pendingHueSaturation = null;
 
                 const newValue = this.convertColorFromHomeKitToTuya(props);
-                this.setMultiStateAsync({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
+                this.setMultiStateInBackground({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
 
                 resolvers.forEach(r => r());
             }, 500);

package/lib/RGBTWLightAccessory.js

@@ -134,8 +134,8 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
     }
 
     setBrightness(value) {
@@ -145,8 +145,8 @@ class RGBTWLightAccessory extends BaseAccessory {
 
     getColorTemperature() {
         this.log.debug(`getColorTemperature`);
-        if (this.device.state[this.dpMode] !== this.cmdWhite) return this.minWhiteColor;
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        if (this.getStateAsync(this.dpMode) !== this.cmdWhite) return this.minWhiteColor;
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {
@@ -165,10 +165,10 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     getHue() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) {
-            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature])).h;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) {
+            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature))).h;
         }
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).h;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).h;
     }
 
     setHue(value) {
@@ -176,10 +176,10 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     getSaturation() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) {
-            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature])).s;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) {
+            return this.convertHomeKitColorTemperatureToHomeKitColor(this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature))).s;
         }
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).s;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).s;
     }
 
     setSaturation(value) {
@@ -187,6 +187,8 @@ class RGBTWLightAccessory extends BaseAccessory {
     }
 
     _setHueSaturation(prop) {
+        if (!this.device.connected) throw this._commError();
+
         if (!this._pendingHueSaturation) {
             this._pendingHueSaturation = {props: {}, resolvers: []};
         }
@@ -208,7 +210,7 @@ class RGBTWLightAccessory extends BaseAccessory {
                 const newValue = this.convertColorFromHomeKitToTuya(props);
 
                 if (!(this.device.state[this.dpMode] === this.cmdWhite && isSham)) {
-                    this.setMultiStateAsync({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
+                    this.setMultiStateInBackground({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
                 }
                 this.characteristicColorTemperature.updateValue(this.minWhiteColor);
 

package/lib/RGBTWOutletAccessory.js

@@ -196,8 +196,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).b;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).b;
     }
 
     setBrightness(value) {
@@ -206,8 +206,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getColorTemperature() {
-        if (this.device.state[this.dpMode] !== this.cmdWhite) return 0;
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        if (this.getStateAsync(this.dpMode) !== this.cmdWhite) return 0;
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {
@@ -221,8 +221,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getHue() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return 0;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).h;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return 0;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).h;
     }
 
     setHue(value) {
@@ -230,8 +230,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     getSaturation() {
-        if (this.device.state[this.dpMode] === this.cmdWhite) return 0;
-        return this.convertColorFromTuyaToHomeKit(this.device.state[this.dpColor]).s;
+        if (this.getStateAsync(this.dpMode) === this.cmdWhite) return 0;
+        return this.convertColorFromTuyaToHomeKit(this.getStateAsync(this.dpColor)).s;
     }
 
     setSaturation(value) {
@@ -239,6 +239,8 @@ class RGBTWOutletAccessory extends BaseAccessory {
     }
 
     _setHueSaturation(prop) {
+        if (!this.device.connected) throw this._commError();
+
         if (!this._pendingHueSaturation) {
             this._pendingHueSaturation = {props: {}, resolvers: []};
         }
@@ -257,7 +259,7 @@ class RGBTWOutletAccessory extends BaseAccessory {
                 const newValue = this.convertColorFromHomeKitToTuya(props);
 
                 if (!(this.device.state[this.dpMode] === this.cmdWhite && isSham)) {
-                    this.setMultiStateAsync({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
+                    this.setMultiStateInBackground({[this.dpMode]: this.cmdColor, [this.dpColor]: newValue});
                 }
                 this.characteristicColorTemperature.updateValue(0);
 

package/lib/SimpleBlindsAccessory.js

@@ -92,7 +92,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
 
         const characteristicPositionState = service.getCharacteristic(Characteristic.PositionState)
             .updateValue(this._getPositionState())
-            .onGet(() => this._getPositionState());
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this._getPositionState(); });
 
         this.device.on('change', changes => {
             this.log.debug('[TuyaAccessory] Blinds saw change to ' + changes[this.dpAction]);
@@ -176,7 +176,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
     }
 
     getCurrentPosition() {
-        return this._getCurrentPosition(this.device.state[this.dpAction]);
+        return this._getCurrentPosition(this.getStateAsync(this.dpAction));
     }
 
     _getCurrentPosition(dp) {
@@ -191,7 +191,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
     }
 
     getTargetPosition() {
-        return this._getTargetPosition(this.device.state[this.dpAction]);
+        return this._getTargetPosition(this.getStateAsync(this.dpAction));
     }
 
     _getTargetPosition(dp) {
@@ -234,7 +234,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
                 this.log.debug('[TuyaAccessory] Blinds will stop in ' + duration + 'ms');
                 this.changeTimeout = setTimeout(() => {
                     this.log.debug('[TuyaAccessory] Blinds asked to stop');
-                    this.setStateAsync(this.dpAction, this.cmdStop);
+                    this.setStateInBackground(this.dpAction, this.cmdStop);
                 }, duration);
             }
             return result;
@@ -246,7 +246,7 @@ class SimpleBlindsAccessory extends BaseAccessory {
                 this.log.debug('[TuyaAccessory] Blinds will stop in ' + duration + 'ms');
                 this.changeTimeout = setTimeout(() => {
                     this.log.debug('[TuyaAccessory] Blinds asked to stop');
-                    this.setStateAsync(this.dpAction, this.cmdStop);
+                    this.setStateInBackground(this.dpAction, this.cmdStop);
                 }, duration);
             }
             return result;

package/lib/SimpleDimmer2Accessory.js

@@ -43,7 +43,7 @@ class SimpleDimmer2Accessory extends BaseAccessory {
     }
 
     getBrightness() {
-        return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
+        return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
     }
 
     setBrightness(value) {

package/lib/SimpleDimmerAccessory.js

@@ -43,7 +43,7 @@ class SimpleDimmerAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
+        return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
     }
 
     setBrightness(value) {

package/lib/SimpleGarageDoorAccessory.js

@@ -117,25 +117,25 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
 
         this.characteristicTargetDoorState = service.getCharacteristic(Characteristic.TargetDoorState)
             .updateValue(initialTarget)
-            .onGet(() => this.accessory.context.cachedTargetDoorState)
+            .onGet(() => this._reportDoorState(this.accessory.context.cachedTargetDoorState))
             .onSet(value => this.setTargetDoorState(value));
 
         this.characteristicCurrentDoorState = service.getCharacteristic(Characteristic.CurrentDoorState)
             .updateValue(this.currentDoorState)
-            .onGet(() => this.currentDoorState);
+            .onGet(() => this._reportDoorState(this.currentDoorState));
 
         // The controller exposes limit switches (l_open/l_close) but they don't
         // work in practice, and there's no obstruction sensor wired up, so this
         // is always reported clear.
         service.getCharacteristic(Characteristic.ObstructionDetected)
             .updateValue(false)
-            .onGet(() => false);
+            .onGet(() => this._reportDoorState(false));
 
         const partialSwitch = this.accessory.getServiceById(Service.Switch, 'partialOpen');
         if (partialSwitch) {
             const onChar = partialSwitch.getCharacteristic(Characteristic.On)
                 .updateValue(isOpen)
-                .onGet(() => this.currentDoorState === Characteristic.CurrentDoorState.OPEN)
+                .onGet(() => this._reportDoorState(this.currentDoorState === Characteristic.CurrentDoorState.OPEN))
                 .onSet(value => {
                     // Stateful: the switch mirrors CurrentDoorState (ON while
                     // the gate is open in HomeKit's view — see
@@ -229,7 +229,19 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
         }
     }
 
+    // onGet helper: a cached/optimistic door value is fine to report while the
+    // gate is reachable, but when it's offline HomeKit must show "No Response"
+    // instead of a stale state that makes the gate look online and accept taps.
+    _reportDoorState(value) {
+        if (!this.device.connected) throw this._commError();
+        return value;
+    }
+
     setTargetDoorState(value) {
+        // Surface "No Response" for a tap on an unreachable gate instead of
+        // silently dropping the command (the write helpers would otherwise just
+        // log and skip, leaving HomeKit to believe the open/close succeeded).
+        if (!this.device.connected) throw this._commError();
         // A direct open/close (the GarageDoorOpener target, a Force switch, or
         // the partial switch tapped OFF) is manual control: cancel any pending
         // partial-open auto-stop so it can't halt this movement part-way.
@@ -255,7 +267,7 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
     _sendOpen() {
         this._cancelPendingClose();
         this.log.info(`[SimpleGarageDoor] ${this.device.context.name}: open (dp${this.dpOpen})`);
-        this.setMultiStateLegacyAsync({[this.dpOpen]: true});
+        this.setMultiStateLegacyInBackground({[this.dpOpen]: true});
     }
 
     // Close is ignored while the gate is actively moving, so fire it directly
@@ -271,15 +283,15 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
         }
         if (this._isStopped()) {
             this.log.info(`[SimpleGarageDoor] ${name}: close (dp${this.dpClose}) — gate already stopped`);
-            this.setMultiStateLegacyAsync({[this.dpClose]: true});
+            this.setMultiStateLegacyInBackground({[this.dpClose]: true});
             return;
         }
         this.log.info(`[SimpleGarageDoor] ${name}: stop-before-close — stop (dp${this.dpStop}) now, close (dp${this.dpClose}) in ${this.stopBeforeCloseMs}ms`);
-        this.setMultiStateLegacyAsync({[this.dpStop]: true});
+        this.setMultiStateLegacyInBackground({[this.dpStop]: true});
         this.pendingCloseTimer = setTimeout(() => {
             this.pendingCloseTimer = null;
             this.log.info(`[SimpleGarageDoor] ${name}: stop-before-close — firing close (dp${this.dpClose})`);
-            this.setMultiStateLegacyAsync({[this.dpClose]: true});
+            this.setMultiStateLegacyInBackground({[this.dpClose]: true});
         }, this.stopBeforeCloseMs);
     }
 
@@ -305,6 +317,7 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
     _handlePartialOpen() {
         const {Characteristic} = this.hap;
         const name = this.device.context.name;
+        if (!this.device.connected) throw this._commError();
         if (!this.partialOpenMs) return;
         if (this.partialStopTimer) {
             // Re-entrant press while a partial is already armed (e.g. a
@@ -319,7 +332,7 @@ class SimpleGarageDoorAccessory extends BaseAccessory {
         this.partialStopTimer = setTimeout(() => {
             this.partialStopTimer = null;
             this.log.info(`[SimpleGarageDoor] ${name}: partial open — firing stop (dp${this.dpStop})`);
-            this.setMultiStateLegacyAsync({[this.dpStop]: true});
+            this.setMultiStateLegacyInBackground({[this.dpStop]: true});
         }, this.partialOpenMs);
     }
 

package/lib/SimpleHeaterAccessory.js

@@ -45,7 +45,7 @@ class SimpleHeaterAccessory extends BaseAccessory {
 
         const characteristicCurrentHeaterCoolerState = service.getCharacteristic(Characteristic.CurrentHeaterCoolerState)
             .updateValue(this._getCurrentHeaterCoolerState(dps))
-            .onGet(() => this.currentHeaterCoolerState);
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this.currentHeaterCoolerState; });
 
         service.getCharacteristic(Characteristic.TargetHeaterCoolerState)
             .setProps({
@@ -54,7 +54,7 @@ class SimpleHeaterAccessory extends BaseAccessory {
                 validValues: [Characteristic.TargetHeaterCoolerState.HEAT]
             })
             .updateValue(this._getTargetHeaterCoolerState())
-            .onGet(() => this._getTargetHeaterCoolerState())
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this._getTargetHeaterCoolerState(); })
             .onSet(() => this.setStateAsync(this.dpActive, true));
 
         const characteristicCurrentTemperature = service.getCharacteristic(Characteristic.CurrentTemperature)

package/lib/SwitchAccessory.js

@@ -69,6 +69,7 @@ class SwitchAccessory extends BaseAccessory {
     }
 
     setPower(dp, value) {
+        if (!this.device.connected) throw this._commError();
         if (!this._pendingPower) {
             this._pendingPower = {props: {}, resolvers: []};
         }
@@ -82,7 +83,7 @@ class SwitchAccessory extends BaseAccessory {
             this._pendingPower.timer = setTimeout(() => {
                 const {props, resolvers} = this._pendingPower;
                 this._pendingPower = null;
-                this.setMultiStateAsync(props);
+                this.setMultiStateInBackground(props);
                 resolvers.forEach(r => r());
             }, 500);
         });

package/lib/TWLightAccessory.js

@@ -72,7 +72,7 @@ class TWLightAccessory extends BaseAccessory {
     }
 
     getBrightness() {
-        return this.convertBrightnessFromTuyaToHomeKit(this.device.state[this.dpBrightness]);
+        return this.convertBrightnessFromTuyaToHomeKit(this.getStateAsync(this.dpBrightness));
     }
 
     setBrightness(value) {
@@ -80,7 +80,7 @@ class TWLightAccessory extends BaseAccessory {
     }
 
     getColorTemperature() {
-        return this.convertColorTemperatureFromTuyaToHomeKit(this.device.state[this.dpColorTemperature]);
+        return this.convertColorTemperatureFromTuyaToHomeKit(this.getStateAsync(this.dpColorTemperature));
     }
 
     setColorTemperature(value) {

package/lib/TuyaCloudDevice.js

@@ -173,7 +173,15 @@ class TuyaCloudDevice extends EventEmitter {
     // `this.state`: the accessory already reflects the user's intent in HomeKit
     // immediately, and leaving `state` untouched lets the realtime stream
     // confirm the real device state without a spurious "revert" while a sleepy
-    // device catches up. Returns truthy like TuyaAccessory.update().
+    // device catches up.
+    //
+    // Return contract mirrors TuyaAccessory.update() as far as a synchronous
+    // caller is concerned (truthy on a no-op, `false` when not connected) but,
+    // unlike the LAN class, the actual command travels over HTTP and only its
+    // outcome reveals a failure. So when a command IS dispatched we return the
+    // promise that resolves to the boolean result (and never rejects), letting
+    // `BaseAccessory.setMultiStateAsync` await it and surface a rejected cloud
+    // command to HomeKit instead of silently dropping it.
     update(dps) {
         if (!dps || typeof dps !== 'object') return true;
 
@@ -185,13 +193,15 @@ class TuyaCloudDevice extends EventEmitter {
             return false;
         }
 
-        this.api.sendCommands(this.context.id, commands)
+        return this.api.sendCommands(this.context.id, commands)
             .then(ok => {
                 if (!ok) this.log.warn(`${this.context.name}: Tuya Cloud rejected command ${JSON.stringify(commands)}`);
+                return ok;
             })
-            .catch(ex => this.log.error(`${this.context.name}: cloud command failed: ${ex.message}`));
-
-        return true;
+            .catch(ex => {
+                this.log.error(`${this.context.name}: cloud command failed: ${ex.message}`);
+                return false;
+            });
     }
 
     /* ------------------------------------------------------------------ *

package/lib/ValveAccessory.js

@@ -49,11 +49,11 @@ class ValveAccessory extends BaseAccessory {
             .onSet(value => this.setStateAsync(this.dpPower, value));
 
         const characteristicInUse = service.getCharacteristic(Characteristic.InUse)
-            .onGet(() => characteristicActive.value);
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return characteristicActive.value; });
 
         if (!this.noTimer) {
             service.getCharacteristic(Characteristic.SetDuration)
-                .onGet(() => this.setDuration)
+                .onGet(() => { if (!this.device.connected) throw this._commError(); return this.setDuration; })
                 .on('change', (data) => {
                     this.log.info('Water Valve Time Duration Set to: ' + data.newValue / 60 + ' Minutes');
                     this.setDuration = data.newValue;
@@ -66,7 +66,8 @@ class ValveAccessory extends BaseAccessory {
                         clearTimeout(this.timer);
                         this.timer = setTimeout(() => {
                             this.log.info('Water Valve Timer Expired. Shutting OFF Valve');
-                            service.getCharacteristic(Characteristic.Active).setValue(0);
+                            this.setStateInBackground(this.dpPower, 0);
+                            service.getCharacteristic(Characteristic.Active).updateValue(0);
                             service.getCharacteristic(Characteristic.InUse).updateValue(0);
                             this.lastActivationTime = null;
                         }, (data.newValue * 1000));
@@ -75,6 +76,7 @@ class ValveAccessory extends BaseAccessory {
 
             service.getCharacteristic(Characteristic.RemainingDuration)
                 .onGet(() => {
+                    if (!this.device.connected) throw this._commError();
                     let remainingTime = this.setDuration - Math.floor(((new Date()).getTime() - this.lastActivationTime) / 1000);
                     return (remainingTime && remainingTime > 0) ? remainingTime : 0;
                 });
@@ -97,7 +99,8 @@ class ValveAccessory extends BaseAccessory {
                             clearTimeout(this.timer);
                             this.timer = setTimeout(() => {
                                 this.log.info('Water Valve Timer Expired. Shutting OFF Valve');
-                                service.getCharacteristic(Characteristic.Active).setValue(0);
+                                this.setStateInBackground(this.dpPower, 0);
+                                service.getCharacteristic(Characteristic.Active).updateValue(0);
                                 service.getCharacteristic(Characteristic.InUse).updateValue(0);
                                 this.lastActivationTime = null;
                             }, (this.setDuration * 1000));
@@ -114,7 +117,8 @@ class ValveAccessory extends BaseAccessory {
                 clearTimeout(this.timer);
                 this.timer = setTimeout(() => {
                     this.log.info('Water Valve Timer Expired. Shutting OFF Valve');
-                    service.getCharacteristic(Characteristic.Active).setValue(0);
+                    this.setStateInBackground(this.dpPower, 0);
+                    service.getCharacteristic(Characteristic.Active).updateValue(0);
                     this.lastActivationTime = null;
                 }, (this.setDuration * 1000));
             }

package/lib/VerticalBlindsWithTilt.js

@@ -38,16 +38,16 @@ class VerticalBlindsWithTilt extends BaseAccessory {
 
         const characteristicCurrentPosition = service.getCharacteristic(Characteristic.CurrentPosition)
             .updateValue(this.currentPosition)
-            .onGet(() => this.currentPosition);
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this.currentPosition; });
 
         const characteristicTargetPosition = service.getCharacteristic(Characteristic.TargetPosition)
             .updateValue(this.currentPosition)
-            .onGet(() => this.currentPosition)
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return this.currentPosition; })
             .onSet(value => this.setPosition(value));
 
         const characteristicPositionState = service.getCharacteristic(Characteristic.PositionState)
             .updateValue(Characteristic.PositionState.STOPPED)
-            .onGet(() => Characteristic.PositionState.STOPPED);
+            .onGet(() => { if (!this.device.connected) throw this._commError(); return Characteristic.PositionState.STOPPED; });
 
         const characteristicCurrentHorizontalTilt = service.getCharacteristic(Characteristic.CurrentHorizontalTiltAngle)
             .updateValue(this._getTiltAngle(dps[this.dpTiltState] || dps[this.dpTilt]))
@@ -76,6 +76,7 @@ class VerticalBlindsWithTilt extends BaseAccessory {
 
     setPosition(value) {
         const {Characteristic} = this.hap;
+        if (!this.device.connected) throw this._commError();
 
         if (value === 0) {
             if (this.currentPosition === 0) {
@@ -205,6 +206,7 @@ class VerticalBlindsWithTilt extends BaseAccessory {
     }
 
     setTiltAngle(value) {
+        if (!this.device.connected) throw this._commError();
         const tuyaValue = Math.round((value / 1.8) + 50);
         const clampedValue = Math.max(0, Math.min(100, tuyaValue));
 

package/lib/WledDimmerAccessory.js

@@ -196,6 +196,7 @@ class WledDimmerAccessory extends BaseAccessory {
                         });
                     })
                     .on('get', cb => {
+                        if (!this.device.connected) return cb(this._commError());
                         cb(null, this.device.state[this.dpPower] && this._wledCurrentEffectIndex === (index + 1));
                     });
 
@@ -326,6 +327,7 @@ class WledDimmerAccessory extends BaseAccessory {
     }
 
     getBrightness() {
+        if (!this.device.connected) throw this._commError();
         if (this.syncBrightnessToWled) {
             // If we already have a cached WLED brightness, return it immediately.
             if (this._lastWledPercent != null) {
@@ -363,7 +365,7 @@ class WledDimmerAccessory extends BaseAccessory {
                     maxTuyaBrightness
                 );
                 // Fire-and-forget; don't tie HomeKit callback to Tuya I/O.
-                this.setStateAsync(this.dpBrightness, maxTuyaBrightness);
+                this.setStateInBackground(this.dpBrightness, maxTuyaBrightness);
             }
 
             // Compute desired WLED brightness once.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-tuya-plus",
-  "version": "3.14.0-dev.16",
+  "version": "3.14.0-dev.18",
   "description": "A community-maintained Homebridge plugin for controlling Tuya devices locally over LAN. Includes new features, fixes, and updated device support.",
   "main": "index.js",
   "scripts": {

package/test/BaseAccessory.test.js

@@ -181,10 +181,10 @@ describe('setStateAsync', () => {
         expect(device.update).not.toHaveBeenCalled();
     });
 
-    test('skips silently when device is not connected (issue #34)', () => {
+    test('rejects with a comm-failure HapStatusError when device is not connected', async () => {
         const { instance, device } = make({ '1': false });
         device.connected = false;
-        expect(() => instance.setStateAsync('1', true)).not.toThrow();
+        await expect(instance.setStateAsync('1', true)).rejects.toBeInstanceOf(HAP.HapStatusError);
         expect(device.update).not.toHaveBeenCalled();
     });
 });
@@ -204,12 +204,29 @@ describe('setMultiStateAsync', () => {
         expect(device.update).not.toHaveBeenCalled();
     });
 
-    test('skips silently when device is not connected (issue #34)', () => {
+    test('resolves when the device accepts the writes', async () => {
+        const { instance } = make({ '1': false });
+        await expect(instance.setMultiStateAsync({ '1': true })).resolves.toBeUndefined();
+    });
+
+    test('rejects with a comm-failure HapStatusError when device is not connected', async () => {
         const { instance, device } = make({ '1': false });
         device.connected = false;
-        expect(() => instance.setMultiStateAsync({ '1': true, '2': 50 })).not.toThrow();
+        await expect(instance.setMultiStateAsync({ '1': true, '2': 50 })).rejects.toBeInstanceOf(HAP.HapStatusError);
         expect(device.update).not.toHaveBeenCalled();
     });
+
+    test('rejects when the device write is not accepted (returns false)', async () => {
+        const { instance, device } = make({ '1': false });
+        device.update.mockReturnValue(false);
+        await expect(instance.setMultiStateAsync({ '1': true })).rejects.toBeInstanceOf(HAP.HapStatusError);
+    });
+
+    test('awaits an async device write result (cloud) and rejects on failure', async () => {
+        const { instance, device } = make({ '1': false });
+        device.update.mockResolvedValue(false);
+        await expect(instance.setMultiStateAsync({ '1': true })).rejects.toBeInstanceOf(HAP.HapStatusError);
+    });
 });
 
 describe('setMultiStateLegacyAsync', () => {
@@ -220,12 +237,34 @@ describe('setMultiStateLegacyAsync', () => {
         expect(device.update).toHaveBeenCalledWith({ '1': true, '3': '2' });
     });
 
-    test('skips silently when device is not connected (issue #34)', () => {
+    test('rejects with a comm-failure HapStatusError when device is not connected', async () => {
         const { instance, device } = make();
         device.connected = false;
-        expect(() => instance.setMultiStateLegacyAsync({ '1': true })).not.toThrow();
+        await expect(instance.setMultiStateLegacyAsync({ '1': true })).rejects.toBeInstanceOf(HAP.HapStatusError);
         expect(device.update).not.toHaveBeenCalled();
     });
+
+    test('rejects when the device write is not accepted (returns false)', async () => {
+        const { instance, device } = make();
+        device.update.mockReturnValue(false);
+        await expect(instance.setMultiStateLegacyAsync({ '1': true })).rejects.toBeInstanceOf(HAP.HapStatusError);
+    });
+});
+
+describe('background write helpers (never throw/reject)', () => {
+    test('setStateInBackground swallows a disconnected-device failure', async () => {
+        const { instance, device } = make({ '1': false });
+        device.connected = false;
+        expect(() => instance.setStateInBackground('1', true)).not.toThrow();
+        // Give the rejected inner promise a tick to settle; it must be caught.
+        await Promise.resolve();
+    });
+
+    test('setMultiStateLegacyInBackground still dispatches the write when connected', () => {
+        const { instance, device } = make();
+        instance.setMultiStateLegacyInBackground({ '1': true });
+        expect(device.update).toHaveBeenCalledWith({ '1': true });
+    });
 });
 
 describe('getDividedStateAsync', () => {
@@ -243,14 +282,48 @@ describe('getDividedStateAsync', () => {
     });
 });
 
+describe('getState (callback)', () => {
+    test('returns the DP value via the callback when connected', done => {
+        const { instance } = make({ '1': true });
+        instance.getState('1', (err, value) => {
+            expect(err).toBeNull();
+            expect(value).toBe(true);
+            done();
+        });
+    });
+
+    test('invokes the callback with a comm-failure error when not connected', () => {
+        const { instance, device } = make({ '1': true });
+        device.connected = false;
+        const cb = jest.fn();
+        instance.getState('1', cb);
+        expect(cb).toHaveBeenCalledWith(expect.any(HAP.HapStatusError));
+    });
+});
+
 describe('setMultiState (legacy callback)', () => {
-    test('skips silently and invokes callback without error when not connected (issue #34)', () => {
+    test('invokes the callback without error on a successful write', () => {
+        const { instance } = make({ '1': false });
+        const cb = jest.fn();
+        instance.setMultiState({ '1': true }, cb);
+        expect(cb).toHaveBeenCalledWith(null);
+    });
+
+    test('invokes the callback with a comm-failure error when not connected', () => {
         const { instance, device } = make({ '1': false });
         device.connected = false;
         const cb = jest.fn();
         instance.setMultiState({ '1': true }, cb);
         expect(device.update).not.toHaveBeenCalled();
-        expect(cb).toHaveBeenCalledWith();
+        expect(cb).toHaveBeenCalledWith(expect.any(HAP.HapStatusError));
+    });
+
+    test('invokes the callback with a comm-failure error when the write is not accepted', () => {
+        const { instance, device } = make({ '1': false });
+        device.update.mockReturnValue(false);
+        const cb = jest.fn();
+        instance.setMultiState({ '1': true }, cb);
+        expect(cb).toHaveBeenCalledWith(expect.any(HAP.HapStatusError));
     });
 
     test('tolerates a missing callback when not connected', () => {
@@ -261,13 +334,13 @@ describe('setMultiState (legacy callback)', () => {
 });
 
 describe('setMultiStateLegacy (legacy callback)', () => {
-    test('skips silently and invokes callback without error when not connected (issue #34)', () => {
+    test('invokes the callback with a comm-failure error when not connected', () => {
         const { instance, device } = make();
         device.connected = false;
         const cb = jest.fn();
         instance.setMultiStateLegacy({ '1': true }, cb);
         expect(device.update).not.toHaveBeenCalled();
-        expect(cb).toHaveBeenCalledWith();
+        expect(cb).toHaveBeenCalledWith(expect.any(HAP.HapStatusError));
     });
 });
 

package/test/MultiOutletAccessory.test.js

@@ -86,4 +86,16 @@ describe('MultiOutletAccessory.setPower — debounce batching', () => {
         await p;
         expect(device.update).not.toHaveBeenCalled();
     });
+
+    test('surfaces a comm-failure error (No Response) when disconnected', () => {
+        // A tap on an unreachable outlet must fail in HomeKit instead of being
+        // silently dropped after the debounce.
+        const { instance, device } = makeOutlet({ '1': false });
+        device.connected = false;
+        let err;
+        try { instance.setPower('1', true); } catch (e) { err = e; }
+        expect(err).toBeInstanceOf(HAP.HapStatusError);
+        expect(err.hapStatus).toBe(HAP.HAPStatus.SERVICE_COMMUNICATION_FAILURE);
+        expect(device.update).not.toHaveBeenCalled();
+    });
 });

package/test/RGBTWLightAccessory.test.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const RGBTWLightAccessory = require('../lib/RGBTWLightAccessory');
-const { makeInstance, makeMockCharacteristic } = require('./support/mocks');
+const { makeInstance, makeMockCharacteristic, HAP } = require('./support/mocks');
 
 function makeLight(state = {}, context = {}) {
     const result = makeInstance(RGBTWLightAccessory, state, { colorFunction: 'HEXHSB', ...context });
@@ -88,12 +88,12 @@ describe('RGBTWLightAccessory.getColorTemperature', () => {
 // setColorTemperature
 // ---------------------------------------------------------------------------
 describe('RGBTWLightAccessory.setColorTemperature', () => {
-    test('does not throw when device is not connected (issue #34)', () => {
+    test('rejects (No Response) and writes nothing when device is not connected', async () => {
         const { instance, device } = makeLight({ '2': 'white', '4': 255 });
         instance.characteristicHue = makeMockCharacteristic(0);
         instance.characteristicSaturation = makeMockCharacteristic(0);
         device.connected = false;
-        expect(() => instance.setColorTemperature(200)).not.toThrow();
+        await expect(instance.setColorTemperature(200)).rejects.toBeInstanceOf(HAP.HapStatusError);
         expect(device.update).not.toHaveBeenCalled();
     });
 

package/test/SimpleFanLightAccessory.test.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const SimpleFanLightAccessory = require('../lib/SimpleFanLightAccessory');
-const { makeInstance } = require('./support/mocks');
+const { makeInstance, HAP } = require('./support/mocks');
 
 // Mirror the state that _registerCharacteristics would establish (the mock
 // service shares a single characteristic, so wiring the fields manually keeps
@@ -290,10 +290,10 @@ describe('SimpleFanLightAccessory.getColorTemp / setColorTemp', () => {
         expect(device.update).toHaveBeenCalledWith({ '23': 1000 });
     });
 
-    test('setColorTemp does not write when the device is disconnected', () => {
+    test('setColorTemp rejects (No Response) and writes nothing when disconnected', async () => {
         const { instance, device } = makeFanLight({ '23': 500 });
         device.connected = false;
-        expect(() => instance.setColorTemp(370)).not.toThrow();
+        await expect(instance.setColorTemp(370)).rejects.toBeInstanceOf(HAP.HapStatusError);
         expect(device.update).not.toHaveBeenCalled();
     });
 });

package/test/SimpleGarageDoorAccessory.test.js

@@ -373,11 +373,13 @@ describe('SimpleGarageDoorAccessory.setTargetDoorState — close (stop-before-cl
 // Disconnect handling
 // ---------------------------------------------------------------------------
 describe('SimpleGarageDoorAccessory — disconnected', () => {
-    test('Skips writes when the device is disconnected', () => {
+    test('Surfaces a No Response error and writes nothing when disconnected', () => {
         const { instance, device } = makeSimpleGarage();
         device.connected = false;
 
-        instance.setTargetDoorState(TDS.OPEN);
+        // A tap on an unreachable gate must fail in HomeKit instead of being
+        // silently dropped while HomeKit believes the open/close succeeded.
+        expect(() => instance.setTargetDoorState(TDS.OPEN)).toThrow(HAP.HapStatusError);
 
         expect(device.update).not.toHaveBeenCalled();
     });

package/test/TuyaCloudDevice.test.js

@@ -56,10 +56,31 @@ describe('TuyaCloudDevice', () => {
         const api = makeApi();
         const dev = makeDevice(api);
         expect(dev.connected).toBe(false);
-        expect(() => dev.update({switch_1: true})).not.toThrow();
+        expect(dev.update({switch_1: true})).toBe(false);
         expect(api.sendCommands).not.toHaveBeenCalled();
     });
 
+    test('update resolves to the cloud command result so failures are awaitable', async () => {
+        const api = makeApi();
+        const dev = makeDevice(api);
+        await dev._connect();
+
+        api.sendCommands.mockResolvedValueOnce(true);
+        await expect(dev.update({switch_1: true})).resolves.toBe(true);
+
+        api.sendCommands.mockResolvedValueOnce(false);
+        await expect(dev.update({switch_1: true})).resolves.toBe(false);
+    });
+
+    test('update resolves to false (never rejects) when the cloud request throws', async () => {
+        const api = makeApi();
+        const dev = makeDevice(api);
+        await dev._connect();
+
+        api.sendCommands.mockRejectedValueOnce(new Error('network down'));
+        await expect(dev.update({switch_1: true})).resolves.toBe(false);
+    });
+
     test('applyStatus emits only the changed data-points', async () => {
         const api = makeApi();
         const dev = makeDevice(api);