homebridge-tuya-plus 3.14.0-dev.13 → 3.14.0-dev.15

package/Changelog.md

@@ -13,6 +13,8 @@ All notable changes to this project will be documented in this file. This projec
 * [*] **Fix cloud irrigation valves that could be turned on but not off** — the per-zone write coalescer was dropping any command that matched the last-known `device.state`. Cloud devices never optimistically advance `state` (it only moves once the realtime stream confirms the device), so an "off" issued before the "on" was echoed matched the stale "off" and was discarded — HomeKit showed the zone closed while it kept running. Queued commands are now sent as-is (callers already queue only genuine changes).
 * [*] **IrrigationSystem: remove the rain sensor.** It never reported reliably on these devices, and bundling a sensor (a different HomeKit category) in the same accessory forced the Home app to fragment the sprinkler into "sub-accessories" — blocking control from the main tile and hiding the system master on/off. The accessory is now a single, clean sprinkler tile (IrrigationSystem + valves + optional battery); any leftover Contact/Leak sensor service from a previous build is removed automatically on restart. The `noRainSensor`, `rainSensorType`, `rainInverted`, `dpRain` and `rainOnValue` options are gone.
 * [*] **IrrigationSystem: add the HAP Service Label service for multi-valve controllers** — an accessory that exposes a collection of same-type services (more than one `Valve`) must include a `ServiceLabel` service to anchor each valve's `ServiceLabelIndex`. It was missing, so stricter Home app clients (notably iOS) scattered the zones as separate tiles instead of nesting them under the single irrigation tile. The service is added automatically (with the Arabic-numerals namespace) whenever there is more than one valve; user-set zone names still take precedence.
+* [*] **IrrigationSystem: stop the valve toggle flickering after a press** — tapping a zone briefly snapped back to the old state before settling on the new one. The `Active` getters returned the raw `device.state`, which (for cloud devices) only advances once the realtime stream echoes the write back, so a read in that window reported the pre-press value. The getters now report the value HomeKit already shows (optimistic on press, then confirmed/corrected by device-side change events); they still surface "No Response" while disconnected.
+* [*] **Tuya Cloud: report real device online/offline status.** Cloud devices previously always showed as reachable. They now mirror Tuya's `online` flag (read from the device record on connect and re-checked when the realtime stream reconnects), so HomeKit shows **"No Response"** when the device is genuinely offline. If the lookup isn't permitted (the project lacks the device-management API), the device is assumed reachable so control is never blocked.
 
 ## 2.0.1 (2021-03-25)
 This update includes the following changes:

package/lib/IrrigationSystemAccessory.js

@@ -238,7 +238,7 @@ class IrrigationSystemAccessory extends BaseAccessory {
 
         this._systemActiveChar = irrigation.getCharacteristic(Characteristic.Active)
             .updateValue(this._anyValveOn() ? Characteristic.Active.ACTIVE : Characteristic.Active.INACTIVE)
-            .onGet(() => this._anyValveOn() ? Characteristic.Active.ACTIVE : Characteristic.Active.INACTIVE)
+            .onGet(() => this._reportCached(this._systemActiveChar))
             .onSet(value => this._setSystemActive(value));
 
         this._systemInUseChar = irrigation.getCharacteristic(Characteristic.InUse)
@@ -281,10 +281,10 @@ class IrrigationSystemAccessory extends BaseAccessory {
                 .updateValue(0)
                 .onGet(() => this._valveRemaining(cfg));
 
-            valve.getCharacteristic(Characteristic.Active)
+            const activeChar = valve.getCharacteristic(Characteristic.Active)
                 .updateValue(on ? Characteristic.Active.ACTIVE : Characteristic.Active.INACTIVE)
-                .onGet(() => (this.getStateAsync(cfg.dp) ? 1 : 0))
                 .onSet(value => this._setValveActive(cfg, value));
+            activeChar.onGet(() => this._reportCached(activeChar));
 
             valve.getCharacteristic(Characteristic.InUse)
                 .updateValue(on ? Characteristic.InUse.IN_USE : Characteristic.InUse.NOT_IN_USE);
@@ -364,6 +364,19 @@ class IrrigationSystemAccessory extends BaseAccessory {
         if (valveChanged) this._syncAggregate();
     }
 
+    // onGet handler for the system / valve Active characteristics. Returns the
+    // value HomeKit already shows — the optimistic value written on press and
+    // then confirmed (or corrected) by device-side change events — rather than
+    // the raw `device.state`. Cloud devices don't advance `device.state` until
+    // the realtime stream echoes the write back, so reading it here returned the
+    // pre-press value for a moment and made the Home app toggle visibly flicker
+    // back to the old state before settling. Throwing while disconnected keeps
+    // the HomeKit "No Response" behaviour.
+    _reportCached(char) {
+        if (!this.device.connected) throw new Error('Not connected');
+        return char.value;
+    }
+
     /* ------------------------------------------------------------------ *
      *  Valve activation + timer logic
      * ------------------------------------------------------------------ */

package/lib/TuyaCloudApi.js

@@ -214,6 +214,15 @@ class TuyaCloudApi {
         return (res && Array.isArray(res.result)) ? res.result : [];
     }
 
+    // Read the device record (name, product, and crucially `online`). Used to
+    // learn whether the device is currently reachable. Returns the raw `result`
+    // object or null. Requires the project to have the device-management API
+    // authorized; callers treat a failure as "online unknown".
+    async getDeviceInfo(deviceId) {
+        const res = await this.request('GET', `/v1.0/devices/${encodeURIComponent(deviceId)}`);
+        return (res && res.result && typeof res.result === 'object') ? res.result : null;
+    }
+
     // Issue one or more commands: [{code, value}, …].
     async sendCommands(deviceId, commands) {
         if (!Array.isArray(commands) || !commands.length) return true;

package/lib/TuyaCloudDevice.js

@@ -66,7 +66,7 @@ class TuyaCloudDevice extends EventEmitter {
         try {
             const status = await this.api.getStatus(this.context.id);
             this.state = this._statusToState(status);
-            this.connected = true;
+            this.connected = await this._readOnline();
 
             this._logDiscoveredCodes(status);
 
@@ -102,6 +102,11 @@ class TuyaCloudDevice extends EventEmitter {
     async _refreshState() {
         if (this._stopped) return;
         try {
+            const online = await this._readOnline();
+            if (this.connected !== online) {
+                this.connected = online;
+                this.log.info(`${this.context.name}: Tuya now reports the device ${online ? 'online' : 'offline'}.`);
+            }
             const status = await this.api.getStatus(this.context.id);
             this._applyStatus(status);
         } catch (ex) {
@@ -109,6 +114,20 @@ class TuyaCloudDevice extends EventEmitter {
         }
     }
 
+    // Resolve the device's reachability from Tuya's `online` flag, so HomeKit
+    // shows "No Response" when the device is genuinely offline. If the lookup
+    // isn't available (e.g. the project lacks the device-management API) fall
+    // back to reachable so control is never blocked.
+    async _readOnline() {
+        try {
+            const info = await this.api.getDeviceInfo(this.context.id);
+            if (info && typeof info.online === 'boolean') return info.online;
+        } catch (ex) {
+            this.log.debug(`${this.context.name}: online-status check failed: ${ex.message}`);
+        }
+        return true;
+    }
+
     /* ------------------------------------------------------------------ *
      *  State helpers
      * ------------------------------------------------------------------ */

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-tuya-plus",
-  "version": "3.14.0-dev.13",
+  "version": "3.14.0-dev.15",
   "description": "A community-maintained Homebridge plugin for controlling Tuya devices locally over LAN. Includes new features, fixes, and updated device support.",
   "main": "index.js",
   "scripts": {

package/test/IrrigationSystemAccessory.test.js

@@ -298,6 +298,38 @@ describe('IrrigationSystemAccessory — valve activation & timer', () => {
         jest.advanceTimersByTime(600 * 1000);
         expect(device.update.mock.calls.length).toBe(calls);
     });
+
+    test('valve Active onGet reports the optimistic value, not the lagging device state (no flicker)', () => {
+        // Cloud devices don't advance device.state until the realtime stream
+        // echoes the write back. Emulate that (update is a no-op on state) and
+        // confirm a freshly-pressed valve keeps reading ON instead of briefly
+        // reverting to the pre-press value.
+        const { accessory, device } = makeHarness({ '1': false }, { defaultDuration: 0 });
+        device.update.mockImplementation(() => true);
+        const v = valve(accessory, 1);
+
+        v.getCharacteristic(Characteristic.Active).triggerSet(1);
+        jest.advanceTimersByTime(500);
+
+        expect(device.state['1']).toBe(false); // not echoed yet
+        expect(v.getCharacteristic(Characteristic.Active).triggerGet()).toBe(Characteristic.Active.ACTIVE);
+    });
+
+    test('system Active onGet reports the cached aggregate, not the lagging device state', () => {
+        const { accessory, device } = makeHarness({ '1': false, '2': false }, { defaultDuration: 0 });
+        device.update.mockImplementation(() => true);
+        valve(accessory, 1).getCharacteristic(Characteristic.Active).triggerSet(1);
+        jest.advanceTimersByTime(500);
+
+        expect(irrigation(accessory).getCharacteristic(Characteristic.Active).triggerGet())
+            .toBe(Characteristic.Active.ACTIVE);
+    });
+
+    test('Active onGet still throws while disconnected (HomeKit shows "No Response")', () => {
+        const { accessory, device } = makeHarness({ '1': false });
+        device.connected = false;
+        expect(() => valve(accessory, 1).getCharacteristic(Characteristic.Active).triggerGet()).toThrow();
+    });
 });
 
 describe('IrrigationSystemAccessory — write batching (one Tuya command)', () => {

package/test/TuyaCloudApi.test.js

@@ -138,6 +138,14 @@ describe('TuyaCloudApi — endpoints', () => {
         await expect(api.getStatus('dev')).resolves.toEqual([{code: 'switch_1', value: true}]);
     });
 
+    test('getDeviceInfo returns the device record (with online status)', async () => {
+        const api = ready();
+        let path;
+        api._httpsRequest = async (method, p) => { path = p; return {success: true, result: {id: 'dev', online: false, name: 'X'}}; };
+        await expect(api.getDeviceInfo('dev')).resolves.toEqual({id: 'dev', online: false, name: 'X'});
+        expect(path).toBe('/v1.0/devices/dev');
+    });
+
     test('sendCommands posts the commands and reports success', async () => {
         const api = ready();
         let captured;

package/test/TuyaCloudDevice.test.js

@@ -9,6 +9,7 @@ function makeApi(status = [{code: 'switch_1', value: false}, {code: 'battery_per
     return {
         isConfigured: () => true,
         getStatus: jest.fn().mockResolvedValue(status),
+        getDeviceInfo: jest.fn().mockResolvedValue({online: true}),
         sendCommands: jest.fn().mockResolvedValue(true)
     };
 }
@@ -77,6 +78,34 @@ describe('TuyaCloudDevice', () => {
         expect(changes).toHaveLength(0);
     });
 
+    test('connect reflects the device online status (offline → not connected)', async () => {
+        const api = makeApi();
+        api.getDeviceInfo.mockResolvedValue({online: false});
+        const dev = makeDevice(api);
+        await dev._connect();
+        expect(api.getDeviceInfo).toHaveBeenCalledWith('dev1');
+        expect(dev.connected).toBe(false);
+    });
+
+    test('online lookup failure → assume reachable (never block control)', async () => {
+        const api = makeApi();
+        api.getDeviceInfo.mockRejectedValue(new Error('no device-management permission'));
+        const dev = makeDevice(api);
+        await dev._connect();
+        expect(dev.connected).toBe(true);
+    });
+
+    test('a state refresh re-checks online and flips connected', async () => {
+        const api = makeApi();
+        const dev = makeDevice(api);
+        await dev._connect();
+        expect(dev.connected).toBe(true);
+
+        api.getDeviceInfo.mockResolvedValue({online: false});
+        await dev._refreshState();
+        expect(dev.connected).toBe(false);
+    });
+
     test('subscribes to realtime and re-reads state when the stream (re)connects', async () => {
         const api = makeApi();
         const messaging = Object.assign(new EventEmitter(), {