homebridge-tuya-plus 3.11.3-beta.8 → 3.13.0

package/lib/AirConditionerAccessory.js

@@ -60,6 +60,17 @@ class AirConditionerAccessory extends BaseAccessory {
         this.dpTempUnits = this._getCustomDP(this.device.context.dpTempUnits) || '19';
         this.dpSwingMode = this._getCustomDP(this.device.context.dpSwingMode) || '104';
 
+        // temperatureDivisor is a default for both current and threshold reads.
+        // Some Tuya AC firmwares report temperatures scaled by 10 (e.g.
+        // temp_set = 170 means 17.0 °C). Use temperatureDivisor: 10 for those.
+        // currentTemperatureDivisor / thresholdTemperatureDivisor override
+        // the default per side, since the two DPs are not always scaled the
+        // same way (it's common for current temp to be unscaled while the
+        // setpoint is in tenths of a degree).
+        const baseDivisor = parseInt(this.device.context.temperatureDivisor) || 1;
+        this.currentTemperatureDivisor = parseInt(this.device.context.currentTemperatureDivisor) || baseDivisor;
+        this.thresholdTemperatureDivisor = parseInt(this.device.context.thresholdTemperatureDivisor) || baseDivisor;
+
         const characteristicActive = service.getCharacteristic(Characteristic.Active)
             .updateValue(this._getActive(dps[this.dpActive]))
             .onGet(() => this.getActive())
@@ -81,8 +92,8 @@ class AirConditionerAccessory extends BaseAccessory {
             .onSet(value => this.setTargetHeaterCoolerState(value));
 
         const characteristicCurrentTemperature = service.getCharacteristic(Characteristic.CurrentTemperature)
-            .updateValue(dps[this.dpCurrentTemperature])
-            .onGet(() => this.getStateAsync(this.dpCurrentTemperature));
+            .updateValue(this._scaleCurrent(dps[this.dpCurrentTemperature]))
+            .onGet(() => this._scaleCurrent(this.getStateAsync(this.dpCurrentTemperature)));
 
         let characteristicSwingMode;
         if (!this.device.context.noSwing) {
@@ -108,8 +119,8 @@ class AirConditionerAccessory extends BaseAccessory {
                     maxValue: this.device.context.maxTemperature || 35,
                     minStep: this.device.context.minTemperatureSteps || 1
                 })
-                .updateValue(dps[this.dpThreshold])
-                .onGet(() => this.getStateAsync(this.dpThreshold))
+                .updateValue(this._scaleThreshold(dps[this.dpThreshold]))
+                .onGet(() => this._scaleThreshold(this.getStateAsync(this.dpThreshold)))
                 .onSet(value => this.setTargetThresholdTemperature('cool', value));
         } else this._removeCharacteristic(service, Characteristic.CoolingThresholdTemperature);
 
@@ -121,8 +132,8 @@ class AirConditionerAccessory extends BaseAccessory {
                     maxValue: this.device.context.maxTemperature || 35,
                     minStep: this.device.context.minTemperatureSteps || 1
                 })
-                .updateValue(dps[this.dpThreshold])
-                .onGet(() => this.getStateAsync(this.dpThreshold))
+                .updateValue(this._scaleThreshold(dps[this.dpThreshold]))
+                .onGet(() => this._scaleThreshold(this.getStateAsync(this.dpThreshold)))
                 .onSet(value => this.setTargetThresholdTemperature('heat', value));
         } else this._removeCharacteristic(service, Characteristic.HeatingThresholdTemperature);
 
@@ -158,14 +169,18 @@ class AirConditionerAccessory extends BaseAccessory {
             }
 
             if (changes.hasOwnProperty(this.dpThreshold)) {
-                if (!this.device.context.noCool && characteristicCoolingThresholdTemperature && characteristicCoolingThresholdTemperature.value !== changes[this.dpThreshold])
-                    characteristicCoolingThresholdTemperature.updateValue(changes[this.dpThreshold]);
-                if (!this.device.context.noHeat && characteristicHeatingThresholdTemperature && characteristicHeatingThresholdTemperature.value !== changes[this.dpThreshold])
-                    characteristicHeatingThresholdTemperature.updateValue(changes[this.dpThreshold]);
+                const scaled = this._scaleThreshold(changes[this.dpThreshold]);
+                if (!this.device.context.noCool && characteristicCoolingThresholdTemperature && characteristicCoolingThresholdTemperature.value !== scaled)
+                    characteristicCoolingThresholdTemperature.updateValue(scaled);
+                if (!this.device.context.noHeat && characteristicHeatingThresholdTemperature && characteristicHeatingThresholdTemperature.value !== scaled)
+                    characteristicHeatingThresholdTemperature.updateValue(scaled);
             }
 
-            if (changes.hasOwnProperty(this.dpCurrentTemperature) && characteristicCurrentTemperature.value !== changes[this.dpCurrentTemperature])
-                characteristicCurrentTemperature.updateValue(changes[this.dpCurrentTemperature]);
+            if (changes.hasOwnProperty(this.dpCurrentTemperature)) {
+                const scaled = this._scaleCurrent(changes[this.dpCurrentTemperature]);
+                if (characteristicCurrentTemperature.value !== scaled)
+                    characteristicCurrentTemperature.updateValue(scaled);
+            }
 
             if (changes.hasOwnProperty(this.dpMode)) {
                 const newTargetHeaterCoolerState = this._getTargetHeaterCoolerState(changes[this.dpMode]);
@@ -304,7 +319,8 @@ class AirConditionerAccessory extends BaseAccessory {
     }
 
     async setTargetThresholdTemperature(mode, value) {
-        await this.setMultiStateLegacyAsync({[this.dpActive]: true, [this.dpThreshold]: value});
+        const raw = Math.round(value * this.thresholdTemperatureDivisor);
+        await this.setMultiStateLegacyAsync({[this.dpActive]: true, [this.dpThreshold]: raw});
         if (mode === 'cool' && !this.device.context.noHeat && this.characteristicHeatingThresholdTemperature) {
             this.characteristicHeatingThresholdTemperature.updateValue(value);
         } else if (mode === 'heat' && !this.device.context.noCool && this.characteristicCoolingThresholdTemperature) {
@@ -312,6 +328,18 @@ class AirConditionerAccessory extends BaseAccessory {
         }
     }
 
+    _scaleCurrent(raw) {
+        const v = parseFloat(raw);
+        if (!isFinite(v)) return 0;
+        return v / this.currentTemperatureDivisor;
+    }
+
+    _scaleThreshold(raw) {
+        const v = parseFloat(raw);
+        if (!isFinite(v)) return 0;
+        return v / this.thresholdTemperatureDivisor;
+    }
+
     getTemperatureDisplayUnits() {
         return this._getTemperatureDisplayUnits(this.getStateAsync(this.dpTempUnits));
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-tuya-plus",
-  "version": "3.11.3-beta.8",
+  "version": "3.13.0",
   "description": "A community-maintained Homebridge plugin for controlling Tuya devices locally over LAN. Includes new features, fixes, and updated device support.",
   "main": "index.js",
   "scripts": {