homebridge-tsvesync 1.5.1 → 1.5.2

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # Changelog
 
+## 1.5.2 (2026-07-26)
+
+### Fixed
+- **Auto Mode Honoured In Scenes And Automations** ([#42](https://github.com/mickgiles/homebridge-tsvesync/issues/42)): Setting a Vital 200S to Auto from an Apple Home automation landed in manual, sleep, or off depending purely on the slider position. HomeKit writes `Active`, `TargetAirPurifierState`, and `RotationSpeed` in a single HAP request and HAP-NodeJS dispatches them concurrently; because this accessory encodes sleep/manual/turbo into the speed slider, every speed write is implicitly a mode write and raced with the explicit Auto beside it. Writes are now buffered briefly and resolved into one intent — an explicit Auto beats the mode implied by the slider, `RotationSpeed` 0 only means "turn off" when nothing else in the batch asked for on or a mode, and an explicit `Active` 0 still wins outright.
+- **Overlapping Write Bursts No Longer Interleave**: Batches are applied one at a time. Dragging the slider produces a burst spaced beyond the coalesce window, and un-serialised those API calls interleaved so the device settled on whichever response happened to land last.
+- **Humidifier 0% Mist No Longer Cancels Power On**: The humidifier accessory had the same batching hazard — a 0% mist slider arriving alongside `Active` 1 turned the device straight back off. It now uses the same buffered-intent resolution as the air purifier.
+- **Mode Changes Reported Back Immediately**: A slider drag can move a device out of auto, but `TargetAirPurifierState` was never pushed, so the tile kept showing "Auto" until the next poll — and the poll interval has a two minute floor. Failed `manualMode()` calls were also discarded, so a speed could be sent to a device still in auto; the failure is now surfaced instead.
+- **Speed Readback No Longer Uses A Stale Cache**: The commanded speed is written through, so the slider stops snapping back to the previously reported value. Sleep was also gated on the device being off, so while running it reported the last manual speed instead of the sleep notch.
+- **Core 300S Speed Model Corrected To Three Speeds**: The library declared four fan levels for the Core 300S, but the hardware is Low/Med/High plus Sleep, so the top two slider notches were identical. The real maximum is now used, giving 0/25/50/75/100 mapped 1:1 to off/Sleep/Low/Med/High. Because that changes `minStep` and HomeKit caches characteristic metadata on the home hub, percentages are mapped by which range they fall into rather than by rounding against the new step — rounding put a stale 60% at Low instead of Medium — and the controller's own value is echoed back so the slider does not fight it. Upgrading users get correct speeds immediately; only the tick marks need the hub to catch up.
+
+### Dependencies
+- **tsvesync**: Updated to 1.5.2 for the corrected Core 200S/300S fan levels and the commanded-speed cache write-through that this accessory's readback path depends on.
+
+### Tests
+- **Batched Write Coverage**: Adds `src/__tests__/accessories/air-purifier-batch-write.test.ts` and `src/__tests__/accessories/humidifier-batch-write.test.ts` covering scene and automation write batches, explicit power off, mode readback, stale-mode override expiry, speed readback against a stale library cache, stale slider grids from a not-yet-updated hub, and burst serialisation.
+
 ## 1.5.1 (2026-07-25)
 
 ### Fixed

package/dist/accessories/air-purifier.accessory.d.ts

@@ -3,6 +3,13 @@ import { BaseAccessory } from './base.accessory';
 import { TSVESyncPlatform } from '../platform';
 import { DeviceCapabilities, VeSyncAirPurifier } from '../types/device.types';
 export declare class AirPurifierAccessory extends BaseAccessory {
+    /**
+     * How long to buffer characteristic writes before applying them. HAP-NodeJS
+     * dispatches every characteristic in one request within the same tick, so a
+     * short window is enough to see the whole batch; it stays far below HAP's
+     * 3s slow-write warning threshold.
+     */
+    private static readonly WRITE_COALESCE_MS;
     private readonly capabilities;
     protected readonly device: VeSyncAirPurifier;
     private isAirBypassDevice;
@@ -11,6 +18,13 @@ export declare class AirPurifierAccessory extends BaseAccessory {
     private lastSetSpeed;
     private lastSetPercentage;
     private skipNextUpdate;
+    private pendingWrite;
+    private pendingWriteTimer;
+    private pendingWritePromise;
+    private writeChain;
+    private static readonly COMMANDED_MODE_TTL_MS;
+    private _lastCommandedMode;
+    private _lastCommandedModeTime;
     constructor(platform: TSVESyncPlatform, accessory: PlatformAccessory, device: VeSyncAirPurifier);
     /**
      * Feature detection system
@@ -25,10 +39,36 @@ export declare class AirPurifierAccessory extends BaseAccessory {
      */
     private getMaxFanSpeed;
     private isCore200S;
+    private isCore300S;
+    /**
+     * The real number of manual fan speeds, which is not always what the library
+     * advertises. tsvesync declares `levels: [1,2,3,4]` for the Core 200S and
+     * Core 300S, but both hardware families only have three manual speeds -
+     * verified against a Core300S, where changeFanSpeed(4) reports success and
+     * the device settles at 3. Trusting the declared 4 produces a dead top notch
+     * where 80% and 100% both mean speed 3.
+     */
+    private getEffectiveMaxFanSpeed;
     /**
      * Calculate the appropriate step size for discrete speed levels
      */
     private calculateRotationSpeedStep;
+    /**
+     * Total slider notches: sleep, each manual speed, and turbo when supported.
+     */
+    private getTotalNotches;
+    /**
+     * Map a percentage to a slider notch by which equal-width range it falls in,
+     * rather than by rounding against our own step.
+     *
+     * This has to stay correct even when the controller disagrees with us about
+     * the step. HomeKit caches characteristic metadata on the home hub, so after
+     * an upgrade that changes minStep a controller can keep sending values on the
+     * *old* grid for an unknown period. Rounding against our step maps those to
+     * the wrong speed (a 60% on an old 20% grid became Low instead of Medium);
+     * range mapping gets it right on either grid.
+     */
+    private percentageToNotch;
     /**
      * Convert device speed to percentage
      */
@@ -98,23 +138,90 @@ export declare class AirPurifierAccessory extends BaseAccessory {
      * Update device states based on the latest details
      */
     protected updateDeviceSpecificStates(details: any): Promise<void>;
+    /**
+     * Buffer a characteristic write and return a promise that settles once the
+     * whole batch has been applied. Every characteristic in the batch shares the
+     * same promise, so HomeKit gets a success/failure per write as usual.
+     */
+    private queueWrite;
+    /**
+     * Turn one buffered batch of HomeKit writes into a single device intent.
+     *
+     * The ordering rules that matter (issue #42):
+     *  - An explicit AUTO write wins over the mode implied by the speed slider.
+     *    This accessory encodes sleep/manual/turbo into RotationSpeed, so every
+     *    speed write is implicitly a mode write; without this rule an automation
+     *    that sets "on + auto + 60%" ends up in manual.
+     *  - RotationSpeed 0 only means "turn off" when the same batch didn't also
+     *    ask for the device to be on or set a mode. Otherwise "on + auto + 0%"
+     *    turns the device on and straight back off.
+     */
+    private resolveWrite;
+    /**
+     * Write a commanded speed/mode back into the device's cached details.
+     *
+     * The bypass purifiers (Core series) don't update their own cache after a
+     * successful changeFanSpeed - unlike the bypassV2 models, which do - so
+     * device.speed stays stale until the next poll, and the poll interval has a
+     * two minute floor. That stale value makes getRotationSpeed() disagree with
+     * what we just set and snaps the slider back to the wrong notch.
+     */
+    private cacheCommandedSpeed;
+    /**
+     * Record a mode we just commanded so a stale API read can't undo it.
+     */
+    private rememberCommandedMode;
+    /**
+     * Resolve the mode to report to HomeKit, preferring what we last commanded
+     * over what the device currently reports. The override is dropped as soon as
+     * the device catches up, or once it expires - so a mode changed in the VeSync
+     * app still comes through.
+     */
+    private resolveEffectiveMode;
+    /**
+     * Map a VeSync mode to the HomeKit TargetAirPurifierState value.
+     * Pet is an automatic mode, so it surfaces as AUTO like auto itself.
+     */
+    private modeToTargetState;
+    /**
+     * Push the mode back to HomeKit immediately after we change it.
+     *
+     * The RotationSpeed slider implicitly carries a mode (sleep/manual/turbo),
+     * so dragging it can move the device out of auto. Without this the tile
+     * keeps showing the old mode until the next poll - and the poll interval has
+     * a two minute floor, so "Auto" would linger long after the device had
+     * actually switched to Manual.
+     */
+    private syncTargetStateToHomeKit;
     /**
      * Get target state (MANUAL = 0, AUTO = 1)
      */
     private getTargetState;
     /**
-     * Set target state (AUTO = 0, MANUAL = 1)
+     * Set target state (MANUAL = 0, AUTO = 1). Buffered so it can be reconciled
+     * with any Active/RotationSpeed writes sent in the same HomeKit request.
      */
     private setTargetState;
+    private applyTargetState;
     /**
      * Get rotation speed
      */
     private getRotationSpeed;
     /**
-     * Set rotation speed
+     * Set rotation speed. Buffered so it can be reconciled with any
+     * Active/TargetAirPurifierState writes sent in the same HomeKit request -
+     * the slider implicitly carries a mode, so it must not clobber an explicit
+     * AUTO written alongside it.
      */
     private setRotationSpeed;
+    private applyRotationSpeed;
     private getActive;
+    /**
+     * Set active state. Buffered so it can be reconciled with any
+     * RotationSpeed/TargetAirPurifierState writes sent in the same HomeKit
+     * request - notably so a 0% slider can't turn the device straight back off.
+     */
     private setActive;
+    private applyActive;
 }
 //# sourceMappingURL=air-purifier.accessory.d.ts.map

package/dist/accessories/air-purifier.accessory.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"air-purifier.accessory.d.ts","sourceRoot":"","sources":["../../src/accessories/air-purifier.accessory.ts"],"names":[],"mappings":"AAAA,OAAO,EAAuB,iBAAiB,EAAW,MAAM,YAAY,CAAC;AAC7E,OAAO,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjD,OAAO,EAAE,gBAAgB,EAAE,MAAM,aAAa,CAAC;AAC/C,OAAO,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAsC9E,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAqB;IAClD,SAAS,CAAC,QAAQ,CAAC,MAAM,EAAE,iBAAiB,CAAC;IAC7C,OAAO,CAAC,iBAAiB,CAAU;IACnC,OAAO,CAAC,iBAAiB,CAAU;IACnC,OAAO,CAAC,cAAc,CAAU;IAChC,OAAO,CAAC,YAAY,CAAa;IACjC,OAAO,CAAC,iBAAiB,CAAa;IACtC,OAAO,CAAC,cAAc,CAAkB;gBAGtC,QAAQ,EAAE,gBAAgB,EAC1B,SAAS,EAAE,iBAAiB,EAC5B,MAAM,EAAE,iBAAiB;IAiD3B;;OAEG;IACH,OAAO,CAAC,UAAU;IAqIlB;;OAEG;IACH,OAAO,CAAC,+BAA+B;IAmBvC;;OAEG;IACH,OAAO,CAAC,cAAc;IAiCtB,OAAO,CAAC,UAAU;IAIlB;;OAEG;IACH,OAAO,CAAC,0BAA0B;IAiBlC;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAsBzB;;;;;;;;;;;;OAYG;YACW,oCAAoC;IAoClD;;OAEG;IACH,OAAO,CAAC,iBAAiB;IA0BzB;;OAEG;IACH,SAAS,CAAC,YAAY,IAAI,IAAI;IAuI9B;;;;;;OAMG;IACH,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,qBAAqB,CAAc;IAE3D,OAAO,CAAC,kBAAkB;IA2B1B;;OAEG;YACW,UAAU;IAKxB;;;;OAIG;YACW,UAAU;IA0CxB;;OAEG;IACH,OAAO,CAAC,iBAAiB;IA0BzB;;OAEG;YACW,yBAAyB;IAOvC;;OAEG;YACW,kBAAkB;IAOhC;;OAEG;YACW,eAAe;IAI7B;;OAEG;IACH,SAAS,CAAC,qBAAqB,IAAI,kBAAkB;IAcrD;;OAEG;cACa,0BAA0B,CAAC,OAAO,EAAE,GAAG,GAAG,OAAO,CAAC,IAAI,CAAC;IAmIvE;;OAEG;YACW,cAAc;IAc5B;;OAEG;YACW,cAAc;IA2C5B;;OAEG;YACW,gBAAgB;IA6B9B;;OAEG;YACW,gBAAgB;YA0MhB,SAAS;YAIT,SAAS;CAoExB"}
+{"version":3,"file":"air-purifier.accessory.d.ts","sourceRoot":"","sources":["../../src/accessories/air-purifier.accessory.ts"],"names":[],"mappings":"AAAA,OAAO,EAAuB,iBAAiB,EAAW,MAAM,YAAY,CAAC;AAC7E,OAAO,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAC;AACjD,OAAO,EAAE,gBAAgB,EAAE,MAAM,aAAa,CAAC;AAC/C,OAAO,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,MAAM,uBAAuB,CAAC;AAgD9E,qBAAa,oBAAqB,SAAQ,aAAa;IACrD;;;;;OAKG;IACH,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,iBAAiB,CAAM;IAE/C,OAAO,CAAC,QAAQ,CAAC,YAAY,CAAqB;IAClD,SAAS,CAAC,QAAQ,CAAC,MAAM,EAAE,iBAAiB,CAAC;IAC7C,OAAO,CAAC,iBAAiB,CAAU;IACnC,OAAO,CAAC,iBAAiB,CAAU;IACnC,OAAO,CAAC,cAAc,CAAU;IAChC,OAAO,CAAC,YAAY,CAAa;IACjC,OAAO,CAAC,iBAAiB,CAAa;IACtC,OAAO,CAAC,cAAc,CAAkB;IAOxC,OAAO,CAAC,YAAY,CAA6B;IACjD,OAAO,CAAC,iBAAiB,CAA+B;IACxD,OAAO,CAAC,mBAAmB,CAA8B;IAMzD,OAAO,CAAC,UAAU,CAAoC;IAQtD,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,qBAAqB,CAAS;IACtD,OAAO,CAAC,kBAAkB,CAAuB;IACjD,OAAO,CAAC,sBAAsB,CAAK;gBAGjC,QAAQ,EAAE,gBAAgB,EAC1B,SAAS,EAAE,iBAAiB,EAC5B,MAAM,EAAE,iBAAiB;IAiD3B;;OAEG;IACH,OAAO,CAAC,UAAU;IAqIlB;;OAEG;IACH,OAAO,CAAC,+BAA+B;IAmBvC;;OAEG;IACH,OAAO,CAAC,cAAc;IAiCtB,OAAO,CAAC,UAAU;IAIlB,OAAO,CAAC,UAAU;IAIlB;;;;;;;OAOG;IACH,OAAO,CAAC,uBAAuB;IAO/B;;OAEG;IACH,OAAO,CAAC,0BAA0B;IAalC;;OAEG;IACH,OAAO,CAAC,eAAe;IAKvB;;;;;;;;;;OAUG;IACH,OAAO,CAAC,iBAAiB;IASzB;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAsBzB;;;;;;;;;;;;OAYG;YACW,oCAAoC;IAoClD;;OAEG;IACH,OAAO,CAAC,iBAAiB;IAyBzB;;OAEG;IACH,SAAS,CAAC,YAAY,IAAI,IAAI;IAuI9B;;;;;;OAMG;IACH,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,qBAAqB,CAAc;IAE3D,OAAO,CAAC,kBAAkB;IA2B1B;;OAEG;YACW,UAAU;IAKxB;;;;OAIG;YACW,UAAU;IA+CxB;;OAEG;IACH,OAAO,CAAC,iBAAiB;IA0BzB;;OAEG;YACW,yBAAyB;IAOvC;;OAEG;YACW,kBAAkB;IAOhC;;OAEG;YACW,eAAe;IAI7B;;OAEG;IACH,SAAS,CAAC,qBAAqB,IAAI,kBAAkB;IAcrD;;OAEG;cACa,0BAA0B,CAAC,OAAO,EAAE,GAAG,GAAG,OAAO,CAAC,IAAI,CAAC;IAiIvE;;;;OAIG;IACH,OAAO,CAAC,UAAU;IA4BlB;;;;;;;;;;;OAWG;YACW,YAAY;IAqD1B;;;;;;;;OAQG;IACH,OAAO,CAAC,mBAAmB;IAmB3B;;OAEG;IACH,OAAO,CAAC,qBAAqB;IAK7B;;;;;OAKG;IACH,OAAO,CAAC,oBAAoB;IAsB5B;;;OAGG;IACH,OAAO,CAAC,iBAAiB;IAKzB;;;;;;;;OAQG;IACH,OAAO,CAAC,wBAAwB;IAYhC;;OAEG;YACW,cAAc;IAc5B;;;OAGG;YACW,cAAc;YAId,gBAAgB;IA+C9B;;OAEG;YACW,gBAAgB;IAwC9B;;;;;OAKG;YACW,gBAAgB;YAUhB,kBAAkB;YA2MlB,SAAS;IAIvB;;;;OAIG;YACW,SAAS;YAIT,WAAW;CAoE1B"}