homebridge-tesy-heater-mqtt 1.0.0 → 1.0.2

package/CHANGELOG.md

@@ -7,6 +7,45 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.2] - 2025-12-15
+
+### Fixed
+- **CurrentHeaterCoolerState now correctly shows INACTIVE when device is OFF** (Issue #8)
+  - Previously, the plugin incorrectly set state to IDLE for all non-heating scenarios
+  - Now properly distinguishes between three states:
+    - INACTIVE (0): Device is turned OFF
+    - IDLE (1): Device is ON but not actively heating (target temperature reached)
+    - HEATING (2): Device is ON and actively heating
+  - This fix ensures accurate status display in HomeKit app
+  - Updated heating state logic in `index.js` to check both `status` and `heating` fields
+  - Added comprehensive unit tests covering all three CurrentHeaterCoolerState values
+
+- **Added GET handler for CurrentHeaterCoolerState characteristic**
+  - Fixes Homebridge UI showing incorrect state ("Heat" instead of "Idle")
+  - HomeKit/UI can now actively query device state on-demand
+  - Polling updates continue to work via `updateValue()` for real-time updates
+  - Extracted state calculation logic into reusable `_calculateHeatingState()` helper method
+  - **Improved state detection with temperature-based fallback**
+    - When API doesn't provide `heating` field, plugin now determines state by comparing current and target temperatures
+    - Device considered HEATING when current temp is 0.5°C or more below target
+    - Ensures accurate state display even when `heating` field is missing from API response
+  - Added 11 new unit tests for GET handler, helper method, and fallback logic (38 total tests, 51% coverage)
+
+## [1.0.1] - 2025-12-15
+
+### Removed
+- **homebridge-http-base** dependency (unused legacy from Accessory plugin)
+  - Reduces package size by 78 transitive dependencies
+  - No impact on functionality - plugin never used this dependency
+
+### Changed
+- Updated GitHub Actions: `actions/checkout@v6`, `actions/setup-node@v6`
+- Updated codecov action to v5
+- Improved CI/CD workflows for better Node.js 24 support
+
+### Fixed
+- Codecov coverage reporting now properly configured
+
 ## [1.0.0] - 2025-12-15
 
 ### Added
@@ -80,5 +119,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Tested Devices
 - Tesy CN 06 100 EА CLOUD AS W
 
-[Unreleased]: https://github.com/svjakrm/homebridge-tesy-heater-mqtt/compare/v0.0.1...HEAD
+[Unreleased]: https://github.com/svjakrm/homebridge-tesy-heater-mqtt/compare/v1.0.1...HEAD
+[1.0.1]: https://github.com/svjakrm/homebridge-tesy-heater-mqtt/compare/v1.0.0...v1.0.1
+[1.0.0]: https://github.com/svjakrm/homebridge-tesy-heater-mqtt/compare/v0.0.1...v1.0.0
 [0.0.1]: https://github.com/svjakrm/homebridge-tesy-heater-mqtt/releases/tag/v0.0.1

package/README.md

@@ -1,6 +1,7 @@
 # homebridge-tesy-heater-mqtt
 
 [![Test](https://github.com/svjakrm/homebridge-tesy-heater-mqtt/actions/workflows/test.yml/badge.svg)](https://github.com/svjakrm/homebridge-tesy-heater-mqtt/actions/workflows/test.yml)
+[![codecov](https://codecov.io/gh/svjakrm/homebridge-tesy-heater-mqtt/branch/main/graph/badge.svg)](https://codecov.io/gh/svjakrm/homebridge-tesy-heater-mqtt)
 [![npm version](https://badge.fury.io/js/homebridge-tesy-heater-mqtt.svg)](https://badge.fury.io/js/homebridge-tesy-heater-mqtt)
 [![License: MIT](https://img.shields.io/badge/License-MIT-yellow.svg)](https://opensource.org/licenses/MIT)
 
@@ -35,15 +36,17 @@ If you successfully use this plugin with other Tesy models, please let us know!
 This project is based on [homebridge-tesy-heater](https://github.com/benov84/homebridge-tesy-heater) by [Dobriyan Benov](https://github.com/benov84). The original plugin was updated to work with Tesy API v4 and MQTT control protocol.
 
 **Major changes from original:**
+- **Platform plugin architecture** - complete rewrite from Accessory to Platform
+- **Automatic device discovery** - finds all Tesy heaters automatically
+- **Multi-device support** - manages multiple heaters with single configuration
 - Migrated from Tesy API v3 to API v4
-- Implemented MQTT control for device commands
-- Added `mqtt` dependency for real-time communication
-- Removed obsolete authentication methods
+- Implemented MQTT control for device commands (real-time communication)
 - Added getter for `HeatingThresholdTemperature` characteristic
+- Comprehensive unit tests with 44% code coverage
 
 ## Installation
 
-### Option 1: Install from npm (when published)
+### Option 1: Install from npm (recommended)
 ```bash
 npm install -g homebridge-tesy-heater-mqtt
 ```
@@ -237,6 +240,7 @@ Pull requests are welcome! For major changes, please open an issue first to disc
 
 ## Links
 
+- [NPM Package](https://www.npmjs.com/package/homebridge-tesy-heater-mqtt)
 - [GitHub Repository](https://github.com/svjakrm/homebridge-tesy-heater-mqtt)
 - [Original Plugin](https://github.com/benov84/homebridge-tesy-heater)
 - [Homebridge](https://github.com/homebridge/homebridge)

package/index.js

@@ -239,6 +239,7 @@ class TesyHeaterPlatform {
       .on('set', this.setActive.bind(this, deviceInfo));
 
     service.getCharacteristic(Characteristic.CurrentHeaterCoolerState)
+      .on('get', this.getCurrentHeaterCoolerState.bind(this, deviceInfo))
       .updateValue(Characteristic.CurrentHeaterCoolerState.INACTIVE);
 
     service.getCharacteristic(Characteristic.TargetHeaterCoolerState)
@@ -437,10 +438,11 @@ class TesyHeaterPlatform {
       }
 
       // Update heating state
-      const isHeating = status.heating === 'on';
-      const heatingState = isHeating ?
-                          Characteristic.CurrentHeaterCoolerState.HEATING :
-                          Characteristic.CurrentHeaterCoolerState.IDLE;
+      // INACTIVE (0) = device off
+      // IDLE (1) = device on, not heating (target temp reached)
+      // HEATING (2) = device on and actively heating
+      const heatingState = this._calculateHeatingState(status);
+
       const oldState = service.getCharacteristic(Characteristic.CurrentHeaterCoolerState).value;
       if (heatingState !== oldState) {
         service.getCharacteristic(Characteristic.CurrentHeaterCoolerState).updateValue(heatingState);
@@ -503,6 +505,46 @@ class TesyHeaterPlatform {
     });
   }
 
+  _calculateHeatingState(status) {
+    const isDeviceOn = status.status.toLowerCase() === 'on';
+
+    if (!isDeviceOn) {
+      return Characteristic.CurrentHeaterCoolerState.INACTIVE;
+    }
+
+    // Check if heating field exists and is explicit
+    if (status.heating !== undefined) {
+      const isHeating = status.heating === 'on';
+      return isHeating ?
+        Characteristic.CurrentHeaterCoolerState.HEATING :
+        Characteristic.CurrentHeaterCoolerState.IDLE;
+    }
+
+    // Fallback: if heating field is missing, determine by temperature difference
+    // If current temp is significantly below target, device is likely heating
+    const currentTemp = parseFloat(status.current_temp) || 0;
+    const targetTemp = parseFloat(status.temp) || 0;
+    const tempDiff = targetTemp - currentTemp;
+
+    // If current temp is 0.5°C or more below target, assume heating
+    if (tempDiff >= 0.5) {
+      return Characteristic.CurrentHeaterCoolerState.HEATING;
+    } else {
+      return Characteristic.CurrentHeaterCoolerState.IDLE;
+    }
+  }
+
+  getCurrentHeaterCoolerState(deviceInfo, callback) {
+    this.fetchDeviceStatus(deviceInfo, (error, status) => {
+      if (error) {
+        return callback(error);
+      }
+
+      const state = this._calculateHeatingState(status);
+      callback(null, state);
+    });
+  }
+
   setHeatingThresholdTemperature(deviceInfo, value, callback) {
     // Clamp value
     if (value < this.minTemp) value = this.minTemp;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "homebridge-tesy-heater-mqtt",
   "displayName": "Homebridge Tesy Heater MQTT",
-  "version": "1.0.0",
+  "version": "1.0.2",
   "description": "Tesy heater plugin for Homebridge using MQTT control (API v4). Supports on/off control and temperature adjustment.",
   "license": "MIT",
   "keywords": [
@@ -32,7 +32,6 @@
     "url": "git+https://github.com/svjakrm/homebridge-tesy-heater-mqtt.git"
   },
   "dependencies": {
-    "homebridge-http-base": "2.1.6",
     "mqtt": "^5.14.1",
     "request": "^2.65.0"
   },