homebridge-tasmota-control 1.6.15-beta.1 → 1.6.15-beta.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (4) hide show
  1. package/config.schema.json +9 -3
  2. package/package.json +1 -1
  3. package/src/constants.js +0 -3
  4. package/src/mielhvac.js +366 -513
package/config.schema.json CHANGED
@@ -686,23 +686,29 @@
686
686
  ]
687
687
  },
688
688
  {
689
- "title": "AIR DIRECTION EVEN",
689
+ "title": "AIR DIRECTION INDIRECT",
690
690
  "enum": [
691
691
  40
692
692
  ]
693
693
  },
694
694
  {
695
- "title": "AIR DIRECTION INDIRECT",
695
+ "title": "AIR DIRECTION DIRECT",
696
696
  "enum": [
697
697
  41
698
698
  ]
699
699
  },
700
700
  {
701
- "title": "AIR DIRECTION DIRECT",
701
+ "title": "AIR DIRECTION EVEN",
702
702
  "enum": [
703
703
  42
704
704
  ]
705
705
  },
706
+ {
707
+ "title": "AIR DIRECTION OFF",
708
+ "enum": [
709
+ 43
710
+ ]
711
+ },
706
712
  {
707
713
  "title": "LOCK CONTROL All (only as sensor now)",
708
714
  "enum": [
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "displayName": "Tasmota Control",
3
3
  "name": "homebridge-tasmota-control",
4
- "version": "1.6.15-beta.1",
4
+ "version": "1.6.15-beta.2",
5
5
  "description": "Homebridge plugin to control Tasmota flashed devices.",
6
6
  "license": "MIT",
7
7
  "author": "grzegorz914",
package/src/constants.js CHANGED
@@ -62,9 +62,6 @@ export const MiElHVAC = {
62
62
  "right": "HVACSetSwingH%20right",
63
63
  "split": "HVACSetSwingH%20split",
64
64
  "swing": "HVACSetSwingH%20swing",
65
- "even": "HVACSetSwingH%20even",
66
- "indirect": "HVACSetSwingH%20indirect",
67
- "direct": "HVACSetSwingH%20direct",
68
65
  },
69
66
  "SetAirDirection": {
70
67
  "even": "HVACSetSwingH%20even",
package/src/mielhvac.js CHANGED
@@ -200,9 +200,6 @@ class MiElHvac extends EventEmitter {
200
200
  const statusSnsSupported = sensorStatusKeys.includes('StatusSNS');
201
201
  const statusSns = statusSnsSupported ? sensorStatus.StatusSNS : {};
202
202
 
203
- //power
204
- const power1 = powerStatus.POWER == 'ON' ? 1 : 0;
205
-
206
203
  //status SNS
207
204
  const time = statusSns.Time ?? '';
208
205
  const temperatureUnit = statusSns.TempUnit === 'C' ? '°C' : 'F';
@@ -285,7 +282,7 @@ class MiElHvac extends EventEmitter {
285
282
  hideVaneControls: hideVaneControls
286
283
  };
287
284
 
288
- //operation mode
285
+ // Map stages to index safely, fallback to 0 if not found
289
286
  const operationModeStageMap = {
290
287
  'manual': 0,
291
288
  'heat': 2,
@@ -300,37 +297,39 @@ class MiElHvac extends EventEmitter {
300
297
  'auto_cool': 3,
301
298
  'auto_leader': 4
302
299
  };
300
+
301
+ const stageIndex = operationModeStageMap[operationModeStage] ?? 0;
303
302
  switch (operationMode) {
304
303
  case 'heat':
305
- obj.currentOperationMode = [2, 1, 2, 3, 0][operationModeStageMap[operationModeStage]]; //INACTIVE, IDLE, HEATING, COOLING
306
- obj.targetOperationMode = 1; //AUTO, HEAT, COOL
304
+ obj.currentOperationMode = [2, 1, 2, 3, 0][stageIndex]; // INACTIVE, IDLE, HEATING, COOLING
305
+ obj.targetOperationMode = 1; // AUTO, HEAT, COOL
307
306
  break;
308
307
  case 'dry':
309
- obj.currentOperationMode = [1, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
308
+ obj.currentOperationMode = [1, 1, 2, 3, 0][stageIndex];
310
309
  obj.targetOperationMode = this.autoDryFanMode === 2 ? 0 : this.heatDryFanMode === 2 ? 1 : this.coolDryFanMode === 2 ? 2 : obj.targetOperationMode;
311
310
  break;
312
311
  case 'cool':
313
- obj.currentOperationMode = [3, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
312
+ obj.currentOperationMode = [3, 1, 2, 3, 0][stageIndex];
314
313
  obj.targetOperationMode = 2;
315
314
  break;
316
315
  case 'fan':
317
- obj.currentOperationMode = [1, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
316
+ obj.currentOperationMode = [1, 1, 2, 3, 0][stageIndex];
318
317
  obj.targetOperationMode = this.autoDryFanMode === 3 ? 0 : this.heatDryFanMode === 3 ? 1 : this.coolDryFanMode === 3 ? 2 : obj.targetOperationMode;
319
318
  break;
320
319
  case 'auto':
321
- obj.currentOperationMode = [2, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
320
+ obj.currentOperationMode = [2, 1, 2, 3, 0][stageIndex];
322
321
  obj.targetOperationMode = 0;
323
322
  break;
324
323
  case 'heat_isee':
325
- obj.currentOperationMode = [2, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
324
+ obj.currentOperationMode = [2, 1, 2, 3, 0][stageIndex];
326
325
  obj.targetOperationMode = 1;
327
326
  break;
328
327
  case 'dry_isee':
329
- obj.currentOperationMode = [1, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
328
+ obj.currentOperationMode = [1, 1, 2, 3, 0][stageIndex];
330
329
  obj.targetOperationMode = this.autoDryFanMode === 2 ? 0 : this.heatDryFanMode === 2 ? 1 : this.coolDryFanMode === 2 ? 2 : obj.targetOperationMode;
331
330
  break;
332
331
  case 'cool_isee':
333
- obj.currentOperationMode = [3, 1, 2, 3, 0][operationModeStageMap[operationModeStage]];
332
+ obj.currentOperationMode = [3, 1, 2, 3, 0][stageIndex];
334
333
  obj.targetOperationMode = 2;
335
334
  break;
336
335
  default:
@@ -338,392 +337,313 @@ class MiElHvac extends EventEmitter {
338
337
  return;
339
338
  }
340
339
 
340
+ // If power is off, force currentOperationMode to 0 (inactive)
341
341
  obj.currentOperationMode = !power ? 0 : obj.currentOperationMode;
342
+
343
+ // Set min/max/valid values for operation mode controls
342
344
  obj.operationModeSetPropsMinValue = modelSupportsAuto && modelSupportsHeat ? 0 : !modelSupportsAuto && modelSupportsHeat ? 1 : modelSupportsAuto && !modelSupportsHeat ? 0 : 2;
343
- obj.operationModeSetPropsMaxValue = 2
345
+ obj.operationModeSetPropsMaxValue = 2;
344
346
  obj.operationModeSetPropsValidValues = modelSupportsAuto && modelSupportsHeat ? [0, 1, 2] : !modelSupportsAuto && modelSupportsHeat ? [1, 2] : modelSupportsAuto && !modelSupportsHeat ? [0, 2] : [2];
345
347
 
348
+
346
349
  if (modelSupportsFanSpeed) {
347
- //fan speed mode
350
+ // Map fan speed string to index
348
351
  const fanSpeedMap = {
349
352
  'auto': 0,
350
353
  'quiet': 1,
351
354
  '1': 2,
352
355
  '2': 3,
353
356
  '3': 4,
354
- '4': 5
357
+ '4': 5,
358
+ '5': 6 // Added for completeness if needed
359
+ };
360
+
361
+ // Get mapped index, fallback to 0 if not found
362
+ const fanSpeedIndex = fanSpeedMap[fanSpeed] ?? 0;
363
+
364
+ // Function to generate speed arrays dynamically
365
+ const generateSpeedArray = (count, hasAuto) => {
366
+ // if hasAuto, first element is count+1 (offset), else 0
367
+ // Then numbers 1 .. count-1 (except 0 and auto)
368
+ // your original arrays always have [hasAuto ? count+1 : 0, 1, 2, ..., count-1]
369
+ // So let's build that:
370
+ const arr = [];
371
+ if (hasAuto) {
372
+ arr.push(count + 1); // e.g. 3+1=4 for 3 speeds
373
+ } else {
374
+ arr.push(0);
375
+ }
376
+ for (let i = 1; i < count; i++) {
377
+ arr.push(i);
378
+ }
379
+ return arr;
355
380
  };
356
381
 
357
382
  switch (numberOfFanSpeeds) {
358
- case 2: //Fan speed mode 2
359
- obj.fanSpeed = hasAutomaticFanSpeed ? [3, 1, 2][fanSpeedMap[fanSpeed]] : [0, 1, 2][fanSpeedMap[fanSpeed]];
383
+ case 2:
384
+ obj.fanSpeed = generateSpeedArray(3, hasAutomaticFanSpeed)[fanSpeedIndex];
360
385
  obj.fanSpeedSetPropsMaxValue = hasAutomaticFanSpeed ? 3 : 2;
361
386
  break;
362
- case 3: //Fan speed mode 3
363
- obj.fanSpeed = hasAutomaticFanSpeed ? [4, 1, 2, 3][fanSpeedMap[fanSpeed]] : [0, 1, 2, 3][fanSpeedMap[fanSpeed]];
387
+ case 3:
388
+ obj.fanSpeed = generateSpeedArray(4, hasAutomaticFanSpeed)[fanSpeedIndex];
364
389
  obj.fanSpeedSetPropsMaxValue = hasAutomaticFanSpeed ? 4 : 3;
365
390
  break;
366
- case 4: //Fan speed mode 4
367
- obj.fanSpeed = hasAutomaticFanSpeed ? [5, 1, 2, 3, 4][fanSpeedMap[fanSpeed]] : [0, 1, 2, 3, 4][fanSpeedMap[fanSpeed]];
391
+ case 4:
392
+ obj.fanSpeed = generateSpeedArray(5, hasAutomaticFanSpeed)[fanSpeedIndex];
368
393
  obj.fanSpeedSetPropsMaxValue = hasAutomaticFanSpeed ? 5 : 4;
369
394
  break;
370
- case 5: //Fan speed mode 5
371
- obj.fanSpeed = hasAutomaticFanSpeed ? [6, 1, 2, 3, 4, 5][fanSpeedMap[fanSpeed]] : [0, 1, 2, 3, 4, 5][fanSpeedMap[fanSpeed]];
395
+ case 5:
396
+ obj.fanSpeed = generateSpeedArray(6, hasAutomaticFanSpeed)[fanSpeedIndex];
372
397
  obj.fanSpeedSetPropsMaxValue = hasAutomaticFanSpeed ? 6 : 5;
373
398
  break;
399
+ default:
400
+ // Fallback for unexpected fan speed count
401
+ obj.fanSpeed = 0;
402
+ obj.fanSpeedSetPropsMaxValue = 0;
403
+ break;
374
404
  }
375
405
  }
406
+
376
407
  this.mielHvac = obj;
377
408
 
378
409
  //update characteristics
379
410
  if (this.miElHvacService) {
380
- this.miElHvacService
381
- .updateCharacteristic(Characteristic.Active, power)
411
+ const svc = this.miElHvacService;
412
+
413
+ svc.updateCharacteristic(Characteristic.Active, power)
382
414
  .updateCharacteristic(Characteristic.CurrentHeaterCoolerState, obj.currentOperationMode)
383
415
  .updateCharacteristic(Characteristic.TargetHeaterCoolerState, obj.targetOperationMode)
384
416
  .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
385
417
  .updateCharacteristic(Characteristic.LockPhysicalControls, lockPhysicalControl)
386
418
  .updateCharacteristic(Characteristic.TemperatureDisplayUnits, useFahrenheit)
387
419
  .updateCharacteristic(Characteristic.SwingMode, swingMode);
388
- const updateDefCool = obj.targetOperationMode === 0 || obj.targetOperationMode === 2 ? this.miElHvacService.updateCharacteristic(Characteristic.CoolingThresholdTemperature, obj.targetOperationMode === 0 ? defaultCoolingSetTemperature : setTemperature) : false;
389
- const updateDefHeat = obj.targetOperationMode === 0 || obj.targetOperationMode === 1 ? this.miElHvacService.updateCharacteristic(Characteristic.HeatingThresholdTemperature, obj.targetOperationMode === 0 ? defaultHeatingSetTemperature : setTemperature) : false;
390
- const updateRS = modelSupportsFanSpeed ? this.miElHvacService.updateCharacteristic(Characteristic.RotationSpeed, obj.fanSpeed) : false;
420
+
421
+ if (obj.targetOperationMode === 0 || obj.targetOperationMode === 2) {
422
+ svc.updateCharacteristic(
423
+ Characteristic.CoolingThresholdTemperature,
424
+ obj.targetOperationMode === 0 ? defaultCoolingSetTemperature : setTemperature
425
+ );
426
+ }
427
+
428
+ if (obj.targetOperationMode === 0 || obj.targetOperationMode === 1) {
429
+ svc.updateCharacteristic(
430
+ Characteristic.HeatingThresholdTemperature,
431
+ obj.targetOperationMode === 0 ? defaultHeatingSetTemperature : setTemperature
432
+ );
433
+ }
434
+
435
+ if (modelSupportsFanSpeed) {
436
+ svc.updateCharacteristic(Characteristic.RotationSpeed, obj.fanSpeed);
437
+ }
391
438
 
392
439
  if (this.frostProtectEnable) {
393
440
  if (roomTemperature <= this.frostProtectLowTemp && !power) {
394
- this.miElHvacService
395
- .setCharacteristic(Characteristic.Active, true)
441
+ svc.setCharacteristic(Characteristic.Active, true)
396
442
  .setCharacteristic(Characteristic.TargetHeaterCoolerState, 1)
397
443
  .setCharacteristic(Characteristic.HeatingThresholdTemperature, this.frostProtectHighTemp);
398
444
  this.frostProtectActive = true;
399
-
400
445
  }
401
446
 
402
447
  if (roomTemperature >= this.frostProtectHighTemp && this.frostProtectActive) {
403
- this.miElHvacService.setCharacteristic(Characteristic.Active, false);
448
+ svc.setCharacteristic(Characteristic.Active, false);
404
449
  this.frostProtectActive = false;
405
450
  }
406
451
  }
407
452
  }
408
453
 
409
- //update presets state
454
+ // Update presets state
410
455
  if (this.presetsConfiguredCount > 0) {
411
456
  this.presetsConfigured.forEach((preset, index) => {
412
-
413
457
  let iseeMode = operationMode;
414
- iseeMode = (operationMode === 'heat' || operationMode === 'heat_isee') ? 'heat' : iseeMode;
415
- iseeMode = (operationMode === 'dry' || operationMode === 'dry_isee') ? 'dry' : iseeMode;
416
- iseeMode = (operationMode === 'cool' || operationMode === 'cool_isee') ? 'cool' : iseeMode;
458
+ if (iseeMode === 'heat_isee') iseeMode = 'heat';
459
+ else if (iseeMode === 'dry_isee') iseeMode = 'dry';
460
+ else if (iseeMode === 'cool_isee') iseeMode = 'cool';
417
461
 
418
- preset.state = power ? (preset.mode === iseeMode
419
- && (preset.setTemp).toFixed(1) === parseFloat(setTemperature).toFixed(1)
420
- && preset.fanSpeed === fanSpeed
421
- && preset.swingV === vaneVerticalDirection
422
- && preset.swingH === vaneHorizontalDirection) : false;
462
+ const sameTemp = Number(preset.setTemp).toFixed(1) === Number(setTemperature).toFixed(1);
463
+ const sameFan = preset.fanSpeed === fanSpeed;
464
+ const sameSwingV = preset.swingV === vaneVerticalDirection;
465
+ const sameSwingH = preset.swingH === vaneHorizontalDirection;
466
+ const sameMode = preset.mode === iseeMode;
467
+
468
+ preset.state = power ? (sameMode && sameTemp && sameFan && sameSwingV && sameSwingH) : false;
423
469
 
424
470
  if (this.presetsServices) {
425
- const characteristicType = preset.characteristicType;
426
471
  this.presetsServices[index]
427
- .updateCharacteristic(characteristicType, preset.state);
472
+ .updateCharacteristic(preset.characteristicType, preset.state);
428
473
  }
429
474
  });
430
475
  }
431
476
 
432
- //update buttons state
433
477
  if (this.buttonsConfiguredCount > 0) {
478
+ const modeMap = {
479
+ 0: () => power === 1,
480
+ 1: () => power && ['heat', 'heat_isee'].includes(operationMode),
481
+ 2: () => power && ['dry', 'dry_isee'].includes(operationMode),
482
+ 3: () => power && ['cool', 'cool_isee'].includes(operationMode),
483
+ 4: () => power && operationMode === 'fan',
484
+ 5: () => power && operationMode === 'auto',
485
+ 6: () => power && operationMode === 'purify',
486
+ };
487
+
488
+ const vaneHMap = {
489
+ 11: 'left',
490
+ 12: 'left_middle',
491
+ 13: 'center',
492
+ 14: 'right_middle',
493
+ 15: 'right',
494
+ 16: 'split',
495
+ 17: 'swing',
496
+ };
497
+
498
+ const vaneVMap = {
499
+ 20: 'auto',
500
+ 21: 'up',
501
+ 22: 'up_middle',
502
+ 23: 'center',
503
+ 24: 'down_middle',
504
+ 25: 'down',
505
+ 26: 'swing',
506
+ };
507
+
508
+ const fanSpeedMap = {
509
+ 30: 'auto',
510
+ 31: 'quiet',
511
+ 32: '1',
512
+ 33: '2',
513
+ 34: '3',
514
+ 35: '4',
515
+ };
516
+
517
+ const airDirMap = {
518
+ 40: () => power && airDirection === 'indirect',
519
+ 41: () => power && airDirection === 'direct',
520
+ 42: () => power && airDirection === 'even',
521
+ 43: () => power && !['indirect', 'direct', 'even'].includes(airDirection),
522
+ };
523
+
524
+ const prohibitMap = {
525
+ 50: 'all',
526
+ 51: 'power',
527
+ 52: 'mode',
528
+ 53: 'temp',
529
+ };
530
+
434
531
  this.buttonsConfigured.forEach((button, index) => {
435
532
  const mode = button.mode;
436
- switch (mode) {
437
- case 0: //POWER ON,OFF
438
- button.state = power === 1;
439
- break;
440
- case 1: //OPERATING MODE HEAT
441
- button.state = power ? (operationMode === 'heat' || operationMode === 'heat_isee') : false;
442
- break;
443
- case 2: //OPERATING MODE DRY
444
- button.state = power ? (operationMode === 'dry' || operationMode === 'dry_isee') : false;
445
- break
446
- case 3: //OPERATING MODE COOL
447
- button.state = power ? (operationMode === 'cool' || operationMode === 'cool_isee') : false;
448
- break;
449
- case 4: //OPERATING MODE FAN
450
- button.state = power ? (operationMode === 'fan') : false;
451
- break;
452
- case 5: //OPERATING MODE AUTO
453
- button.state = power ? (operationMode === 'auto') : false;
454
- break;
455
- case 6: //OPERATING MODE PURIFY
456
- button.state = power ? (operationMode === 'purify') : false;
457
- break;
458
- case 11: //VANE H LEFT
459
- button.state = power ? (vaneHorizontalDirection === 'left') : false;
460
- break;
461
- case 12: //VANE H LEFT MIDDLE
462
- button.state = power ? (vaneHorizontalDirection === 'left_middle') : false;
463
- break;
464
- case 13: //VANE H CENTER
465
- button.state = power ? (vaneHorizontalDirection === 'center') : false;
466
- break;
467
- case 14: //VANE H RIGHT MIDDLE
468
- button.state = power ? (vaneHorizontalDirection === 'right_middle') : false;
469
- break;
470
- case 15: //VANE H RIGHT
471
- button.state = power ? (vaneHorizontalDirection === 'right') : false;
472
- break;
473
- case 16: //VANE H SPLIT
474
- button.state = power ? (vaneHorizontalDirection === 'split') : false;
475
- break;
476
- case 17: //VANE H SWING
477
- button.state = power ? (vaneHorizontalDirection === 'swing') : false;
478
- break;
479
- case 20: //VANE V AUTO
480
- button.state = power ? (vaneVerticalDirection === 'auto') : false;
481
- break;
482
- case 21: //VANE V UP
483
- button.state = power ? (vaneVerticalDirection === 'up') : false;
484
- break;
485
- case 22: //VANE V UP MIDDLE
486
- button.state = power ? (vaneVerticalDirection === 'up_middle') : false;
487
- break;
488
- case 23: //VANE V CENTER
489
- button.state = power ? (vaneVerticalDirection === 'center') : false;
490
- break;
491
- case 24: //VANE V DOWN MIDDLE
492
- button.state = power ? (vaneVerticalDirection === 'down_middle') : false;
493
- break;
494
- case 25: //VANE V DOWN
495
- button.state = power ? (vaneVerticalDirection === 'down') : false;
496
- break;
497
- case 26: //VANE V SWING
498
- button.state = power ? (vaneVerticalDirection === 'swing') : false;
499
- break;
500
- case 30: //FAN SPEED MODE AUTO
501
- button.state = power ? (fanSpeed === 'auto') : false;
502
- break;
503
- case 31: //FAN SPEED MODE 1
504
- button.state = power ? (fanSpeed === 'quiet') : false;
505
- break;
506
- case 32: //FAN SPEED MODE 2
507
- button.state = power ? (fanSpeed === '1') : false;
508
- break;
509
- case 33: //FAN SPEED MODE 3
510
- button.state = power ? (fanSpeed === '2') : false;
511
- break;
512
- case 34: //FAN SPEED MODE 4
513
- button.state = power ? (fanSpeed === '3') : false;
514
- break;
515
- case 35: //FAN SPEED MODE 5
516
- button.state = power ? (fanSpeed === '4') : false;
517
- break;
518
- case 40: //AIR DIRECTION EVEN
519
- button.state = power ? (airDirection === 'even') : false;
520
- break;
521
- case 41: //AIR DIRECTION INDIRECT
522
- button.state = power ? (airDirection === 'indirect') : false;
523
- break;
524
- case 42: //AIR DIRECTION DIRECT
525
- button.state = power ? (airDirection === 'direct') : false;
526
- break;
527
- case 50: //PHYSICAL LOCK CONTROLS ALL
528
- button.state = prohibit === 'all';
529
- break;
530
- case 51: //PHYSICAL LOCK CONTROLS POWER
531
- button.state = prohibit === 'power';
532
- break;
533
- case 52: //PHYSICAL LOCK CONTROLS MODE
534
- button.state = prohibit === 'mode';
535
- break;
536
- case 53: //PHYSICAL LOCK CONTROLS TEMP
537
- button.state = prohibit === 'temp';
538
- break;
539
- default: //Unknown button
540
- this.emit('warn', `Unknown button mode: ${mode} detected`);
541
- break;
533
+ let state = false;
534
+
535
+ if (modeMap[mode] !== undefined) {
536
+ state = modeMap[mode]();
537
+ } else if (vaneHMap[mode]) {
538
+ state = power && vaneHorizontalDirection === vaneHMap[mode];
539
+ } else if (vaneVMap[mode]) {
540
+ state = power && vaneVerticalDirection === vaneVMap[mode];
541
+ } else if (fanSpeedMap[mode]) {
542
+ state = power && fanSpeed === fanSpeedMap[mode];
543
+ } else if (airDirMap[mode]) {
544
+ state = airDirMap[mode]();
545
+ } else if (prohibitMap[mode] !== undefined) {
546
+ state = prohibit === prohibitMap[mode];
547
+ } else {
548
+ this.emit('warn', `Unknown button mode: ${mode} detected`);
542
549
  }
543
550
 
544
- //update services
551
+ button.state = state;
552
+
545
553
  if (this.buttonsServices) {
546
554
  const characteristicType = button.characteristicType;
547
555
  this.buttonsServices[index]
548
- .updateCharacteristic(characteristicType, button.state);
556
+ .updateCharacteristic(characteristicType, state);
549
557
  }
550
558
  });
551
559
  }
552
560
 
553
- //update sensors state
554
561
  if (this.sensorsConfiguredCount > 0) {
562
+ const powerOn = power === 1;
563
+
564
+ // Helper: match by value with power check
565
+ const is = (val, match) => powerOn && val === match;
566
+ const isOneOf = (val, matches) => powerOn && matches.includes(val);
567
+
555
568
  this.sensorsConfigured.forEach((sensor, index) => {
556
569
  const mode = sensor.mode;
557
- switch (mode) {
558
- case 0: //POWER ON,OFF
559
- sensor.state = power === 1;
560
- break;
561
- case 1: //OPERATING MODE HEAT
562
- sensor.state = power ? (operationMode === 'heat' || operationMode === 'heat_isee') : false;
563
- break;
564
- case 2: //OPERATING MODE DRY
565
- sensor.state = power ? (operationMode === 'dry' || operationMode === 'dry_isee') : false;
566
- break
567
- case 3: //OPERATING MODE COOL
568
- sensor.state = power ? (operationMode === 'cool' || operationMode === 'cool_isee') : false;
569
- break;
570
- case 4: //OPERATING MODE FAN
571
- sensor.state = power ? (operationMode === 'fan') : false;
572
- break;
573
- case 5: //OPERATING MODE AUTO
574
- sensor.state = power ? (operationMode === 'auto') : false;
575
- break;
576
- case 6: //OPERATING MODE PURIFY
577
- sensor.state = power ? (operationMode === 'purify') : false;
578
- break;
579
- case 10: //VANE H AUTO
580
- sensor.state = power ? (vaneHorizontalDirection === 'auto') : false;
581
- break;
582
- case 11: //VANE H LEFT
583
- sensor.state = power ? (vaneHorizontalDirection === 'left') : false;
584
- break;
585
- case 12: //VANE H LEFT MIDDLE
586
- sensor.state = power ? (vaneHorizontalDirection === 'left_middle') : false;
587
- break;
588
- case 13: //VANE H CENTER
589
- sensor.state = power ? (vaneHorizontalDirection === 'center') : false;
590
- break;
591
- case 14: //VANE H RIGHT MIDDLE
592
- sensor.state = power ? (vaneHorizontalDirection === 'right_middle') : false;
593
- break;
594
- case 15: //VANE H RIGHT
595
- sensor.state = power ? (vaneHorizontalDirection === 'right') : false;
596
- break;
597
- case 16: //VANE H SPLIT
598
- sensor.state = power ? (vaneHorizontalDirection === 'split') : false;
599
- break;
600
- case 17: //VANE H SWING
601
- sensor.state = power ? (vaneHorizontalDirection === 'swing') : false;
602
- break;
603
- case 20: //VANE V AUTO
604
- sensor.state = power ? (vaneVerticalDirection === 'auto') : false;
605
- break;
606
- case 21: //VANE V UP
607
- sensor.state = power ? (vaneVerticalDirection === 'up') : false;
608
- break;
609
- case 22: //VANE V UP MIDDLE
610
- sensor.state = power ? (vaneVerticalDirection === 'up_middle') : false;
611
- break;
612
- case 23: //VANE V CENTER
613
- sensor.state = power ? (vaneVerticalDirection === 'center') : false;
614
- break;
615
- case 24: //VANE V DOWN MIDDLE
616
- sensor.state = power ? (vaneVerticalDirection === 'down_middle') : false;
617
- break;
618
- case 25: //VANE V DOWN
619
- sensor.state = power ? (vaneVerticalDirection === 'down') : false;
620
- break;
621
- case 26: //VANE V SWING
622
- sensor.state = power ? (vaneVerticalDirection === 'swing') : false;
623
- break;
624
- case 27: //VANE H/V CONTROLS HIDE
625
- sensor.state = power ? (hideVaneControls === true) : false;
626
- break;
627
- case 30: //FAN SPEED MODE AUTO
628
- sensor.state = power ? (fanSpeed === 'auto') : false;
629
- break;
630
- case 31: //FAN SPEED MODE 1
631
- sensor.state = power ? (fanSpeed === 'quiet') : false;
632
- break;
633
- case 32: //FAN SPEED MODE 2
634
- sensor.state = power ? (fanSpeed === '1') : false;
635
- break;
636
- case 33: //FAN SPEED MODE 3
637
- sensor.state = power ? (fanSpeed === '2') : false;
638
- break;
639
- case 34: //FAN SPEED MODE 4
640
- sensor.state = power ? (fanSpeed === '3') : false;
641
- break;
642
- case 35: //FAN SPEED MODE 5
643
- sensor.state = power ? (fanSpeed === '4') : false;
644
- break;
645
- case 40: //AIR DIRECTION EVEN
646
- sensor.state = power ? (airDirection === 'even') : false;
647
- break;
648
- case 41: //AIR DIRECTION INDIRECT
649
- sensor.state = power ? (airDirection === 'indirect') : false;
650
- break;
651
- case 42: //AIR DIRECTION DIRECT
652
- sensor.state = power ? (airDirection === 'direct') : false;
653
- break;
654
- case 50: //PHYSICAL LOCK CONTROLS ALL
655
- sensor.state = prohibit === 'all';
656
- break;
657
- case 51: //PHYSICAL LOCK CONTROLS POWER
658
- sensor.state = prohibit === 'power';
659
- break;
660
- case 52: //PHYSICAL LOCK CONTROLS MODE
661
- sensor.state = prohibit === 'mode';
662
- break;
663
- case 53: //PHYSICAL LOCK CONTROLS TEMP
664
- sensor.state = prohibit === 'temp';
665
- break;
666
- case 60: //REMOTE TEMPERATURE STATE
667
- sensor.state = remoteTemperatureSensorState;
668
- break;
669
- case 70: //OPERATION STAGE NORMAL
670
- sensor.state = operationStage === 'normal';
671
- break;
672
- case 71: //OPERATION STAGE DEFROST
673
- sensor.state = operationStage === 'defrost';
674
- break;
675
- case 72: //OPERATION STAGE PREHEAT
676
- sensor.state = operationStage === 'preheat';
677
- break;
678
- case 73: //OPERATION STAGE STANDBY
679
- sensor.state = operationStage === 'standby';
680
- break;
681
- case 80: //FAN STAGE OFF
682
- sensor.state = fanSpeedStage === 'off';
683
- break;
684
- case 81: //FAN STAGE QUIET
685
- sensor.state = fanSpeedStage === 'quiet';;
686
- break;
687
- case 82: //FAN STAGE 1
688
- sensor.state = fanSpeedStage === '1';;
689
- break;
690
- case 83: //FAN STAGE 2
691
- sensor.state = fanSpeedStage === '2';;
692
- break;
693
- case 84: //FAN STAGE 3
694
- sensor.state = fanSpeedStage === '3';;
695
- break;
696
- case 85: //FAN STAGE 4
697
- sensor.state = fanSpeedStage === '4';;
698
- break;
699
- case 86: //FAN STAGE 5
700
- sensor.state = fanSpeedStage === '5';;
701
- break;
702
- case 90: //MODE STAGE AUTO OFF
703
- sensor.state = operationMode !== 'auto';
704
- break;
705
- case 91: //MODE STAGE AUTO FAN
706
- sensor.state = operationModeStage === 'auto_fan';
707
- break;
708
- case 92: //MODE STAGE AUTO HEAT
709
- sensor.state = operationModeStage === 'auto_heat';
710
- break;
711
- case 93: //MODE STAGE AUTO COOL
712
- sensor.state = operationModeStage === 'auto_cool';;
713
- break;
714
- case 94: //MODE STAGE AUTO LEADER
715
- sensor.state = operationModeStage === 'auto_leader';;
716
- break;
717
- default: //Unknown sensor
718
- this.emit('warn', `Unknown sensor mode: ${mode} detected`);
719
- break;
570
+
571
+ const sensorStates = {
572
+ 0: powerOn,
573
+ 1: isOneOf(operationMode, ['heat', 'heat_isee']),
574
+ 2: isOneOf(operationMode, ['dry', 'dry_isee']),
575
+ 3: isOneOf(operationMode, ['cool', 'cool_isee']),
576
+ 4: is(operationMode, 'fan'),
577
+ 5: is(operationMode, 'auto'),
578
+ 6: is(operationMode, 'purify'),
579
+
580
+ 11: is(vaneHorizontalDirection, 'left'),
581
+ 12: is(vaneHorizontalDirection, 'left_middle'),
582
+ 13: is(vaneHorizontalDirection, 'center'),
583
+ 14: is(vaneHorizontalDirection, 'right_middle'),
584
+ 15: is(vaneHorizontalDirection, 'right'),
585
+ 16: is(vaneHorizontalDirection, 'split'),
586
+ 17: is(vaneHorizontalDirection, 'swing'),
587
+
588
+ 20: is(vaneVerticalDirection, 'auto'),
589
+ 21: is(vaneVerticalDirection, 'up'),
590
+ 22: is(vaneVerticalDirection, 'up_middle'),
591
+ 23: is(vaneVerticalDirection, 'center'),
592
+ 24: is(vaneVerticalDirection, 'down_middle'),
593
+ 25: is(vaneVerticalDirection, 'down'),
594
+ 26: is(vaneVerticalDirection, 'swing'),
595
+
596
+ 27: is(hideVaneControls, true),
597
+
598
+ 30: is(fanSpeed, 'auto'),
599
+ 31: is(fanSpeed, 'quiet'),
600
+ 32: is(fanSpeed, '1'),
601
+ 33: is(fanSpeed, '2'),
602
+ 34: is(fanSpeed, '3'),
603
+ 35: is(fanSpeed, '4'),
604
+
605
+ 40: is(airDirection, 'indirect'),
606
+ 41: is(airDirection, 'direct'),
607
+ 42: is(airDirection, 'even'),
608
+ 43: powerOn && !['indirect', 'direct', 'even'].includes(airDirection),
609
+
610
+ 50: prohibit === 'all',
611
+ 51: prohibit === 'power',
612
+ 52: prohibit === 'mode',
613
+ 53: prohibit === 'temp',
614
+
615
+ 60: remoteTemperatureSensorState,
616
+
617
+ 70: operationStage === 'normal',
618
+ 71: operationStage === 'defrost',
619
+ 72: operationStage === 'preheat',
620
+ 73: operationStage === 'standby',
621
+
622
+ 80: fanSpeedStage === 'off',
623
+ 81: fanSpeedStage === 'quiet',
624
+ 82: fanSpeedStage === '1',
625
+ 83: fanSpeedStage === '2',
626
+ 84: fanSpeedStage === '3',
627
+ 85: fanSpeedStage === '4',
628
+ 86: fanSpeedStage === '5',
629
+
630
+ 90: operationMode !== 'auto',
631
+ 91: operationModeStage === 'auto_fan',
632
+ 92: operationModeStage === 'auto_heat',
633
+ 93: operationModeStage === 'auto_cool',
634
+ 94: operationModeStage === 'auto_leader',
635
+ };
636
+
637
+ if (mode in sensorStates) {
638
+ sensor.state = sensorStates[mode];
639
+ } else {
640
+ this.emit('warn', `Unknown sensor mode: ${mode} detected`);
720
641
  }
721
642
 
722
- //update services
643
+ // Update characteristic
723
644
  if (this.sensorsServices) {
724
645
  const characteristicType = sensor.characteristicType;
725
- this.sensorsServices[index]
726
- .updateCharacteristic(characteristicType, sensor.state);
646
+ this.sensorsServices[index]?.updateCharacteristic(characteristicType, sensor.state);
727
647
  }
728
648
  });
729
649
  }
@@ -1066,242 +986,175 @@ class MiElHvac extends EventEmitter {
1066
986
 
1067
987
  //presets services
1068
988
  if (this.presetsConfiguredCount > 0) {
1069
- const debug = this.enableDebugMode ? this.emit('debug', `Prepare presets services`) : false;
989
+ if (this.enableDebugMode) this.emit('debug', 'Prepare presets services');
1070
990
  this.presetsServices = [];
1071
991
 
1072
992
  this.presetsConfigured.forEach((preset, index) => {
1073
- //get preset name
1074
- const presetName = preset.name;
993
+ const { name: presetName, namePrefix, serviceType, characteristicType, mode, setTemp, fanSpeed, swingV, swingH } = preset;
994
+ const serviceName = namePrefix ? `${accessoryName} ${presetName}` : presetName;
1075
995
 
1076
- //get preset name prefix
1077
- const presetNamePrefix = preset.namePrefix;
1078
-
1079
- const serviceName = presetNamePrefix ? `${accessoryName} ${presetName}` : presetName;
1080
- const serviceType = preset.serviceType;
1081
- const characteristicType = preset.characteristicType;
1082
996
  const presetService = new serviceType(serviceName, `Preset ${index}`);
1083
997
  presetService.addOptionalCharacteristic(Characteristic.ConfiguredName);
1084
998
  presetService.setCharacteristic(Characteristic.ConfiguredName, serviceName);
999
+
1085
1000
  presetService.getCharacteristic(characteristicType)
1086
- .onGet(async () => {
1087
- const state = preset.state;
1088
- return state;
1089
- })
1001
+ .onGet(async () => preset.state)
1090
1002
  .onSet(async (state) => {
1091
1003
  try {
1092
- let data = '';
1093
- switch (state) {
1094
- case true:
1095
- const setPower = !this.mielHvac.power ? await this.axiosInstance(MiElHVAC.PowerOn) : false;
1096
- data = MiElHVAC.SetMode[preset.mode];
1097
- await this.axiosInstance(data);
1098
- data = `${MiElHVAC.SetTemp}${preset.setTemp}`;
1099
- await this.axiosInstance(data);
1100
- data = MiElHVAC.SetFanSpeed[preset.fanSpeed];
1101
- await this.axiosInstance(data);
1102
- data = MiElHVAC.SetSwingV[preset.swingV];
1103
- await this.axiosInstance(data);
1104
- data = MiElHVAC.SetSwingH[preset.swingH];
1105
- await this.axiosInstance(data);
1106
- break;
1107
- case false:
1108
- break;
1004
+ if (state) {
1005
+ // Power on if needed
1006
+ if (!this.mielHvac.power) {
1007
+ await this.axiosInstance(MiElHVAC.PowerOn);
1008
+ }
1009
+
1010
+ // Apply preset commands in sequence
1011
+ const commands = [
1012
+ MiElHVAC.SetMode[mode],
1013
+ `${MiElHVAC.SetTemp}${setTemp}`,
1014
+ MiElHVAC.SetFanSpeed[fanSpeed],
1015
+ MiElHVAC.SetSwingV[swingV],
1016
+ MiElHVAC.SetSwingH[swingH]
1017
+ ];
1018
+
1019
+ for (const cmd of commands) {
1020
+ await this.axiosInstance(cmd);
1021
+ }
1022
+
1023
+ if (!this.disableLogInfo) {
1024
+ this.emit('info', `Set: ${presetName}`);
1025
+ }
1026
+
1027
+ await new Promise(resolve => setTimeout(resolve, 250));
1109
1028
  }
1110
-
1111
- const info = this.disableLogInfo || !state ? false : this.emit('info', `Set: ${presetName}`);
1112
- await new Promise(resolve => setTimeout(resolve, 250));
1113
1029
  } catch (error) {
1114
1030
  this.emit('warn', `Set preset error: ${error}`);
1115
1031
  }
1116
1032
  });
1033
+
1117
1034
  this.presetsServices.push(presetService);
1118
1035
  accessory.addService(presetService);
1119
1036
  });
1120
1037
  }
1121
1038
 
1122
- //buttons services
1039
+
1123
1040
  if (this.buttonsConfiguredCount > 0) {
1124
- const debug = this.enableDebugMode ? this.emit('debug', `Prepare buttons services`) : false;
1041
+ if (this.enableDebugMode) this.emit('debug', 'Prepare buttons services');
1125
1042
  this.buttonsServices = [];
1126
1043
 
1127
1044
  this.buttonsConfigured.forEach((button, index) => {
1128
- //get button mode
1129
- const mode = button.mode;
1130
-
1131
- //get button name
1132
- const buttonName = button.name;
1133
-
1134
- //get button name prefix
1135
- const buttonNamePrefix = button.namePrefix;
1045
+ const { mode, name: buttonName, namePrefix, serviceType, characteristicType } = button;
1046
+ const serviceName = namePrefix ? `${accessoryName} ${buttonName}` : buttonName;
1136
1047
 
1137
- const serviceName = buttonNamePrefix ? `${accessoryName} ${buttonName}` : buttonName;
1138
- const serviceType = button.serviceType;
1139
- const characteristicType = button.characteristicType;
1140
1048
  const buttonService = new serviceType(serviceName, `Button ${index}`);
1141
1049
  buttonService.addOptionalCharacteristic(Characteristic.ConfiguredName);
1142
1050
  buttonService.setCharacteristic(Characteristic.ConfiguredName, serviceName);
1051
+
1143
1052
  buttonService.getCharacteristic(characteristicType)
1144
- .onGet(async () => {
1145
- const state = button.state;
1146
- return state;
1147
- })
1053
+ .onGet(async () => button.state)
1148
1054
  .onSet(async (state) => {
1149
1055
  try {
1150
- let data = '';
1151
- switch (mode) {
1152
- case 0: //POWER ON,OFF
1153
- data = state ? MiElHVAC.PowerOn : MiElHVAC.PowerOff;
1154
- break;
1155
- case 1: //OPERATING MODE HEAT
1156
- button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1157
- data = state ? MiElHVAC.SetMode.heat : button.previousValue;
1158
- break;
1159
- case 2: //OPERATING MODE DRY
1160
- button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1161
- data = state ? MiElHVAC.SetMode.dry : button.previousValue;
1162
- break
1163
- case 3: //OPERATING MODE COOL
1164
- button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1165
- data = state ? MiElHVAC.SetMode.cool : button.previousValue;
1166
- break;
1167
- case 4: //OPERATING MODE FAN
1168
- button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1169
- data = state ? MiElHVAC.SetMode.fan : button.previousValue;
1170
- break;
1171
- case 5: //OPERATING MODE AUTO
1172
- button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1173
- data = state ? MiElHVAC.SetMode.auto : button.previousValue;
1174
- break;
1175
- case 6: //OPERATING MODE PURIFY
1176
- button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1177
- data = state ? MiElHVAC.SetMode.purify : button.previousValue;
1178
- break;
1179
- case 11: //VANE H LEFT
1180
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1181
- data = state ? MiElHVAC.SetSwingH.left : button.previousValue;
1182
- break;
1183
- case 12: //VANE H LEFT MIDDLE
1184
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1185
- data = state ? MiElHVAC.SetSwingH.left_middle : button.previousValue;
1186
- break;
1187
- case 13: //VANE H CENTER
1188
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1189
- data = state ? MiElHVAC.SetSwingH.center : button.previousValue;
1190
- break;
1191
- case 14: //VANE H RIGHT MIDDLE
1192
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1193
- data = state ? MiElHVAC.SetSwingH.right_middle : button.previousValue;
1194
- break;
1195
- case 15: //VANE H RIGHT
1196
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1197
- data = state ? MiElHVAC.SetSwingH.right : button.previousValue;
1198
- break;
1199
- case 16: //VANE H SPLIT
1200
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1201
- data = state ? MiElHVAC.SetSwingH.split : button.previousValue;
1202
- break;
1203
- case 17: //VANE H SWING
1204
- button.previousValue = state ? MiElHVAC.SetSwingH[this.mielHvac.vaneHorizontalDirection] : button.previousValue;
1205
- data = state ? MiElHVAC.SetSwingH.swing : button.previousValue;
1206
- break;
1207
- case 20: //VANE V AUTO
1208
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1209
- data = state ? MiElHVAC.SetSwingV.auto : button.previousValue;
1210
- break;
1211
- case 21: //VANE V UP
1212
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1213
- data = state ? MiElHVAC.SetSwingV.up : button.previousValue;
1214
- break;
1215
- case 22: //VANE V UP MIDDLE
1216
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1217
- data = state ? MiElHVAC.SetSwingV.up_middle : button.previousValue;
1218
- break;
1219
- case 23: //VANE V CENTER
1220
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1221
- data = state ? MiElHVAC.SetSwingV.center : button.previousValue;
1222
- break;
1223
- case 24: //VANE V DOWN MIDDLE
1224
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1225
- data = state ? MiElHVAC.SetSwingV.down_middle : button.previousValue;
1226
- break;
1227
- case 25: //VANE V DOWN
1228
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1229
- data = state ? MiElHVAC.SetSwingV.down : button.previousValue;
1230
- break;
1231
- case 26: //VANE V SWING
1232
- button.previousValue = state ? MiElHVAC.SetSwingV[this.mielHvac.vaneVerticalDirection] : button.previousValue;
1233
- data = state ? MiElHVAC.SetSwingV.swing : button.previousValue;
1234
- break;
1235
- case 30: //FAN SPEED AUTO
1236
- button.previousValue = state ? MiElHVAC.SetFanSpeed[this.mielHvac.fanSpeed] : button.previousValue;
1237
- data = state ? MiElHVAC.SetFanSpeed.auto : button.previousValue;
1238
- break;
1239
- case 31: //FAN SPEED QUIET
1240
- button.previousValue = state ? MiElHVAC.SetFanSpeed[this.mielHvac.fanSpeed] : button.previousValue;
1241
- data = state ? MiElHVAC.SetFanSpeed.quiet : button.previousValue;
1242
- break;
1243
- case 32: //FAN SPEED 1
1244
- button.previousValue = state ? MiElHVAC.SetFanSpeed[this.mielHvac.fanSpeed] : button.previousValue;
1245
- data = state ? MiElHVAC.SetFanSpeed['1'] : button.previousValue;
1246
- break;
1247
- case 33: //FAN SPEED 2
1248
- button.previousValue = state ? MiElHVAC.SetFanSpeed[this.mielHvac.fanSpeed] : button.previousValue;
1249
- data = state ? MiElHVAC.SetFanSpeed['2'] : button.previousValue;
1250
- break;
1251
- case 34: //FAN 3
1252
- button.previousValue = state ? MiElHVAC.SetFanSpeed[this.mielHvac.fanSpeed] : button.previousValue;
1253
- data = state ? MiElHVAC.SetFanSpeed['3'] : button.previousValue;
1254
- break;
1255
- case 35: //FAN SPEED 4
1256
- button.previousValue = state ? MiElHVAC.SetFanSpeed[this.mielHvac.fanSpeed] : button.previousValue;
1257
- data = state ? MiElHVAC.SetFanSpeed['4'] : button.previousValue;
1258
- break;
1259
- case 40: //AIR DIRECTION EVEN
1260
- button.previousValue = state ? MiElHVAC.SetAirDirection[this.mielHvac.airDirection] : button.previousValue;
1261
- data = state ? MiElHVAC.SetAirDirection.even : button.previousValue;
1262
- break;
1263
- case 41: //AIR DIRECTION INDIRECT
1264
- button.previousValue = state ? MiElHVAC.SetAirDirection[this.mielHvac.airDirection] : button.previousValue;
1265
- data = state ? MiElHVAC.SetAirDirection.indirect : button.previousValue;
1266
- break;
1267
- case 42: //AIR DIRECTION DIRECT
1268
- button.previousValue = state ? MiElHVAC.SetAirDirection[this.mielHvac.airDirection] : button.previousValue;
1269
- data = state ? MiElHVAC.SetAirDirection.direct : button.previousValue;
1270
- break;
1271
- case 50: //PHYSICAL LOCK CONTROLS
1272
- button.previousValue = state ? MiElHVAC.SetProhibit[this.mielHvac.prohibit] : button.previousValue;
1273
- data = state ? MiElHVAC.SetProhibit.all : button.previousValue;
1274
- break;
1275
- case 51: //PHYSICAL LOCK CONTROLS POWER
1276
- button.previousValue = state ? MiElHVAC.SetProhibit[this.mielHvac.prohibit] : button.previousValue;
1277
- data = state ? MiElHVAC.SetProhibit.power : button.previousValue;
1278
- break;
1279
- case 52: //PHYSICAL LOCK CONTROLS MODE
1280
- button.previousValue = state ? MiElHVAC.SetProhibit[this.mielHvac.prohibit] : button.previousValue;
1281
- data = state ? MiElHVAC.SetProhibit.mode : button.previousValue;
1282
- break;
1283
- case 53: //PHYSICAL LOCK CONTROLS TEMP
1284
- button.previousValue = state ? MiElHVAC.SetProhibit[this.mielHvac.prohibit] : button.previousValue;
1285
- data = state ? MiElHVAC.SetProhibit.temp : button.previousValue;
1286
- break;
1287
- default:
1288
- this.emit('warn', `Unknown button mode: ${mode}`);
1289
- return;
1056
+ let data;
1057
+ const mappings = {
1058
+ 0: () => state ? MiElHVAC.PowerOn : MiElHVAC.PowerOff,
1059
+
1060
+ // Modes
1061
+ 1: () => getModeCommand('heat'),
1062
+ 2: () => getModeCommand('dry'),
1063
+ 3: () => getModeCommand('cool'),
1064
+ 4: () => getModeCommand('fan'),
1065
+ 5: () => getModeCommand('auto'),
1066
+ 6: () => getModeCommand('purify'),
1067
+
1068
+ // Horizontal Swing
1069
+ 11: () => getSwingCommand('SetSwingH', 'left'),
1070
+ 12: () => getSwingCommand('SetSwingH', 'left_middle'),
1071
+ 13: () => getSwingCommand('SetSwingH', 'center'),
1072
+ 14: () => getSwingCommand('SetSwingH', 'right_middle'),
1073
+ 15: () => getSwingCommand('SetSwingH', 'right'),
1074
+ 16: () => getSwingCommand('SetSwingH', 'split'),
1075
+ 17: () => getSwingCommand('SetSwingH', 'swing'),
1076
+
1077
+ // Vertical Swing
1078
+ 20: () => getSwingCommand('SetSwingV', 'auto'),
1079
+ 21: () => getSwingCommand('SetSwingV', 'up'),
1080
+ 22: () => getSwingCommand('SetSwingV', 'up_middle'),
1081
+ 23: () => getSwingCommand('SetSwingV', 'center'),
1082
+ 24: () => getSwingCommand('SetSwingV', 'down_middle'),
1083
+ 25: () => getSwingCommand('SetSwingV', 'down'),
1084
+ 26: () => getSwingCommand('SetSwingV', 'swing'),
1085
+
1086
+ // Fan Speeds
1087
+ 30: () => getSwingCommand('SetFanSpeed', 'auto'),
1088
+ 31: () => getSwingCommand('SetFanSpeed', 'quiet'),
1089
+ 32: () => getSwingCommand('SetFanSpeed', '1'),
1090
+ 33: () => getSwingCommand('SetFanSpeed', '2'),
1091
+ 34: () => getSwingCommand('SetFanSpeed', '3'),
1092
+ 35: () => getSwingCommand('SetFanSpeed', '4'),
1093
+
1094
+ // Air Direction
1095
+ 40: () => getSwingCommand('SetAirDirection', 'indirect'),
1096
+ 41: () => getSwingCommand('SetAirDirection', 'direct'),
1097
+ 42: () => getSwingCommand('SetAirDirection', 'even'),
1098
+ 43: () => getSwingCommand('SetAirDirection', 'off'),
1099
+
1100
+ // Prohibit
1101
+ 50: () => getSwingCommand('SetProhibit', 'all'),
1102
+ 51: () => getSwingCommand('SetProhibit', 'power'),
1103
+ 52: () => getSwingCommand('SetProhibit', 'mode'),
1104
+ 53: () => getSwingCommand('SetProhibit', 'temp')
1105
+ };
1106
+
1107
+ const getModeCommand = (target) => {
1108
+ button.previousValue = state ? MiElHVAC.SetMode[this.mielHvac.operationMode] : button.previousValue;
1109
+ return state ? MiElHVAC.SetMode[target] : button.previousValue;
1110
+ };
1111
+
1112
+ const getSwingCommand = (type, target) => {
1113
+ const current = this.mielHvac[getCurrentKey(type)];
1114
+ button.previousValue = state ? MiElHVAC[type][current] : button.previousValue;
1115
+ return state ? MiElHVAC[type][target] : button.previousValue;
1116
+ };
1117
+
1118
+ const getCurrentKey = (type) => {
1119
+ switch (type) {
1120
+ case 'SetSwingH': return 'vaneHorizontalDirection';
1121
+ case 'SetSwingV': return 'vaneVerticalDirection';
1122
+ case 'SetFanSpeed': return 'fanSpeed';
1123
+ case 'SetAirDirection': return 'airDirection';
1124
+ case 'SetProhibit': return 'prohibit';
1125
+ default: return '';
1126
+ }
1127
+ };
1128
+
1129
+ if (!mappings.hasOwnProperty(mode)) {
1130
+ this.emit('warn', `Unknown button mode: ${mode}`);
1131
+ return;
1132
+ }
1133
+
1134
+ data = mappings[mode]();
1135
+ if (!this.mielHvac.power && state && mode > 0 && mode < 50) {
1136
+ await this.axiosInstance(MiElHVAC.PowerOn);
1290
1137
  }
1291
1138
 
1292
- const setPower = !this.mielHvac.power && state && (mode > 0 && mode < 50) ? await this.axiosInstance(MiElHVAC.PowerOn) : false;
1293
1139
  await this.axiosInstance(data);
1294
- const info = this.disableLogInfo ? false : mode > 0 ? this.emit('info', `${state ? `Set: ${buttonName}` : `Unset: ${buttonName}, Set: ${button.previousValue}`}`) : `Set: ${buttonName}`;
1140
+
1141
+ if (!this.disableLogInfo) {
1142
+ const action = state ? `Set: ${buttonName}` : `Unset: ${buttonName}, Set: ${button.previousValue}`;
1143
+ if (mode > 0) this.emit('info', action);
1144
+ }
1145
+
1295
1146
  await new Promise(resolve => setTimeout(resolve, 250));
1296
1147
  } catch (error) {
1297
1148
  this.emit('warn', `Set button error: ${error}`);
1298
1149
  }
1299
1150
  });
1151
+
1300
1152
  this.buttonsServices.push(buttonService);
1301
1153
  accessory.addService(buttonService);
1302
1154
  });
1303
1155
  }
1304
1156
 
1157
+
1305
1158
  //sensors services
1306
1159
  if (this.sensorsConfiguredCount > 0) {
1307
1160
  const debug = this.enableDebugMode ? this.emit('debug', `Prepare sensors services`) : false;