homebridge-roborock-matter 3.4.8 → 3.4.9

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 3.4.9
+
+- **A live-room miss now says where the rooms actually are.** Two Q7s produced position cells around 22,000 while a Roborock map is a couple of thousand cells across at most — so those robots were never "between rooms", their computed position was nowhere near the map. One of them reported x exactly equal to y, which is arithmetic rather than a place a robot stood. The position on its own cannot separate a unit mismatch from a wrong origin, so the miss line now carries the range the room outlines occupy plus the map origin and resolution the transform used. This changes no behaviour; it turns the next log from a hypothesis into a measurement. The bounding box is computed only on the failure path, so a run that resolves every position pays nothing.
+
 ## 3.4.8
 
 **Selecting "Vacuum" and getting a vacuum-and-mop was not a display bug — one timed-out command cancelled the one that mattered.** skmzwanke reported in [#8](https://github.com/mathiashornbek/homebridge-roborock-matter/issues/8) that he selected Vacuum for a single room and the robot mopped it anyway, and his 3.4.5 log names the cause outright.

package/README.md

@@ -37,7 +37,7 @@ This is the most feature-packed, most thoroughly engineered Roborock plugin for
 - 📍 **See where it's cleaning — live.** Apple Home shows _"Cleaning — Kitchen"_ with the room the robot is actually inside, updating as it moves from room to room. Works even for cleans started from the robot's button or the Roborock app. No other Homebridge plugin does this.
 - 🧭 **One robot, one tile — and as many robots as you own.** Sign in once and your whole fleet comes along: every vacuum on your account appears as its own clean, native accessory in Apple Home. No clutter of fake fans and helper switches, and rooms appear with the names you gave them in the Roborock app.
 - ⚡ **Fast and reliable.** Commands go directly to the robot over your own network whenever possible, with the Roborock cloud as automatic backup — and built-in diagnostics in the settings if you ever want to look under the hood.
-- 🛡️ **Verified by Homebridge.** Reviewed and endorsed by the Homebridge team. 419 automated tests, zero known vulnerabilities, no analytics, and a startup designed to never crash your Homebridge — even when your Wi-Fi or the Roborock cloud has a bad day.
+- 🛡️ **Verified by Homebridge.** Reviewed and endorsed by the Homebridge team. 463 automated tests, zero known vulnerabilities, no analytics, and a startup designed to never crash your Homebridge — even when your Wi-Fi or the Roborock cloud has a bad day.
 
 ## Features
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-roborock-matter",
-  "version": "3.4.8",
+  "version": "3.4.9",
   "description": "The most complete Roborock plugin for Apple Home. Supports the entire Roborock lineup — from the classic S-series to the new 2025 Q7 series that no other plugin can control. Sign in with your Roborock account and get native start/stop, room cleaning, suction levels, battery, and live 'cleaning in the kitchen' room tracking. Verified by Homebridge.",
   "license": "MIT",
   "author": {

package/roborockLib/lib/b01Q7Adapter.js

@@ -504,7 +504,9 @@ function resolveLiveRoomId(liveState) {
  * @returns {{roomId: number | null,
  *            reason: "resolved" | "no-map-header" | "no-pose" | "no-room-outlines" | "pose-outside-outlines",
  *            outlineCount: number,
- *            cell: {x: number, y: number} | null}}
+ *            cell: {x: number, y: number} | null,
+ *            outlineBounds?: {minX: number, minY: number, maxX: number, maxY: number} | null,
+ *            head?: {minX: number, minY: number, resolution: number}}}
  */
 function describeLiveRoomResolution(liveState) {
   const head = liveState?.head;
@@ -541,9 +543,44 @@ function describeLiveRoomResolution(liveState) {
     reason: "pose-outside-outlines",
     outlineCount,
     cell,
+    outlineBounds: outlineBoundingBox(chains),
+    head: { minX: head.minX, minY: head.minY, resolution },
   };
 }
 
+/**
+ * Bounding box of every room outline, in the same cell space the
+ * point-in-polygon test uses.
+ *
+ * Field logs showed two Q7s reporting position cells around 22,000 while a
+ * Roborock map is at most a couple of thousand cells across — so the position
+ * is not "between rooms", it is nowhere near the map. Whether that is a unit
+ * mismatch (pose in millimetres against a resolution in metres) or a wrong
+ * origin cannot be told from the position alone: it needs the range the
+ * outlines actually occupy. Printing both next to each other turns a guess
+ * into a measurement.
+ *
+ * @param {Array<{points: Array<{x: number, y: number}>}>} chains
+ * @returns {{minX: number, minY: number, maxX: number, maxY: number} | null}
+ */
+function outlineBoundingBox(chains) {
+  let minX = Infinity;
+  let minY = Infinity;
+  let maxX = -Infinity;
+  let maxY = -Infinity;
+
+  for (const chain of chains) {
+    for (const point of chain.points || []) {
+      if (point.x < minX) minX = point.x;
+      if (point.y < minY) minY = point.y;
+      if (point.x > maxX) maxX = point.x;
+      if (point.y > maxY) maxY = point.y;
+    }
+  }
+
+  return Number.isFinite(minX) ? { minX, minY, maxX, maxY } : null;
+}
+
 /**
  * Standard ray-casting point-in-polygon test over a room boundary chain.
  * @param {number} x @param {number} y

package/roborockLib/roborockAPI.js

@@ -95,6 +95,34 @@ const B01_LIVE_ROOM_MISS_REASONS = {
     "the robot's position did not fall inside any known room outline (it may be between rooms, or the map may still be building)",
 };
 
+/**
+ * The outline range and map origin, appended to a live-room miss.
+ *
+ * A position cell on its own cannot distinguish "the robot is between rooms"
+ * from "the position was computed in the wrong units" — and the field logs
+ * showed cells near 22,000 where a Roborock map is a couple of thousand cells
+ * at most. Printing the range the outlines occupy, plus the origin and
+ * resolution the transform used, makes the difference measurable from one log
+ * line instead of inferable from none.
+ *
+ * @param {{outlineBounds?: {minX: number, minY: number, maxX: number, maxY: number} | null,
+ *          head?: {minX: number, minY: number, resolution: number}}} resolution
+ * @returns {string}
+ */
+function describeOutlineBounds(resolution) {
+  const bounds = resolution?.outlineBounds;
+  if (!bounds) {
+    return "";
+  }
+
+  const head = resolution.head;
+  const origin = head
+    ? `, map origin ${head.minX},${head.minY} at ${head.resolution}/cell`
+    : "";
+
+  return `, outlines span ${Math.round(bounds.minX)}-${Math.round(bounds.maxX)} x ${Math.round(bounds.minY)}-${Math.round(bounds.maxY)}${origin}`;
+}
+
 const B01_STATUS_TICK_MS = 15000;
 const B01_STATUS_FORCED_GAP_MS = 1500;
 const B01_STATUS_ACTIVE_GAP_MS = 12000;
@@ -4291,7 +4319,7 @@ class Roborock {
           // because they call for different fixes.
           liveState.unresolvedPoseCount =
             (liveState.unresolvedPoseCount || 0) + 1;
-          const message = `Live room for ${this.describeDevice(duid)}: ${B01_LIVE_ROOM_MISS_REASONS[resolution2.reason]} (attempt ${liveState.unresolvedPoseCount} this run, ${resolution2.outlineCount} room outline(s) in the map${resolution2.cell ? `, position cell ${Math.round(resolution2.cell.x)},${Math.round(resolution2.cell.y)}` : ""}).`;
+          const message = `Live room for ${this.describeDevice(duid)}: ${B01_LIVE_ROOM_MISS_REASONS[resolution2.reason]} (attempt ${liveState.unresolvedPoseCount} this run, ${resolution2.outlineCount} room outline(s) in the map${resolution2.cell ? `, position cell ${Math.round(resolution2.cell.x)},${Math.round(resolution2.cell.y)}` : ""}${describeOutlineBounds(resolution2)}).`;
           if (liveState.unresolvedPoseCount % 5 === 0) {
             this.log.info(message);
           } else {