homebridge-roborock-matter 3.4.1 → 3.4.2

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 3.4.2
+
+**Q7-series robots are no longer asked for things they cannot answer.** Every restart, each Q7-generation robot (`roborock.vacuum.sc05`, `ss07`, and the rest of the B01 family) logged an unsupported-method notice — most visibly for `get_water_box_custom_mode`, and also for `get_timer` and `get_carpet_clean_mode`. The message blamed the robot, and the robot was never involved: the plugin's own send path rejects v1-only requests for B01 devices before anything reaches the network, and the poller then recorded that self-rejection as though the robot had answered it.
+
+- **The periodic poller now consults the dialect before asking.** For a B01 robot it skips exactly the requests that have neither a Q7 translation nor a neutral placeholder, and says so once per robot at debug level instead of once per robot as a notice. Classic S- and Q-series robots poll precisely as before.
+- **The check derives from the translation table itself**, not from a hand-written list of method names — a second list would drift the first time a translation was added, and the drift would only ever show up as noise in somebody's log.
+- **The poll-profile line stops promising a water-box probe it will not perform** on a robot whose water tank is filled by hand and has no electronic level to read.
+- **A test enumerates the rule rather than the three reported methods:** for a B01 robot, no periodic poll may be one the dialect cannot answer. Probes added later are covered without anyone having to remember this.
+- Also fixed: the B01 full-chain simulation ran under Jest's 5-second default, which quietly made suite-wide CPU load an implicit assertion — it began failing on an unrelated new test file. Its wall-clock time was never what it set out to verify.
+
 ## 3.4.1
 
 **The Matter fault attribute is withdrawn.** Wazza151 ran three controlled tests on an S8 Pro Ultra with a genuinely empty clean water tank ([#5](https://github.com/mathiashornbek/homebridge-roborock-matter/issues/5)) and the result was unambiguous: Apple Home drew no warning with the fault published beside a Charging state, drew no warning with it published beside a forced Error state either, and the tile went into a stuck "Updating…" that needed a manual poke to clear. Everything off, and the tile behaved perfectly.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-roborock-matter",
-  "version": "3.4.1",
+  "version": "3.4.2",
   "description": "The most complete Roborock plugin for Apple Home. Supports the entire Roborock lineup — from the classic S-series to the new 2025 Q7 series that no other plugin can control. Sign in with your Roborock account and get native start/stop, room cleaning, suction levels, battery, and live 'cleaning in the kitchen' room tracking. Verified by Homebridge.",
   "license": "MIT",
   "author": {

package/roborockLib/lib/b01Q7Adapter.js

@@ -714,6 +714,31 @@ function neutralResponse(method) {
   return factory ? { value: factory() } : undefined;
 }
 
+/**
+ * True when a v1-shaped request has *any* answer on a Q7 robot — a real
+ * translation or a neutral placeholder. Everything else is rejected by the
+ * send choke point in messageQueueHandler with a B01_METHOD_UNSUPPORTED
+ * error, so the periodic poller can consult this instead of asking for
+ * something the plugin already knows will fail.
+ *
+ * Derived from the same two sources the choke point uses, deliberately: a
+ * separate hand-written list would drift the first time a translation is
+ * added, and the drift would only show up as noise in a user's log.
+ * @param {string} method
+ * @returns {boolean}
+ */
+function canAnswerV1Method(method) {
+  if (NEUTRAL_RESPONSES.has(method)) {
+    return true;
+  }
+
+  try {
+    return Boolean(translateOutgoing(method, []));
+  } catch {
+    return false;
+  }
+}
+
 /**
  * Map a Q7 `prop.get` status payload to v1-shaped status fields.
  * Fixture reference: {"status":4,"quantity":87,"fault":0,...}
@@ -796,5 +821,6 @@ module.exports = {
   createB01MessageId,
   translateOutgoing,
   neutralResponse,
+  canAnswerV1Method,
   mapStatusToV1,
 };

package/roborockLib/roborockAPI.js

@@ -201,6 +201,7 @@ class Roborock {
     // repeated warnings for requests they will never answer.
     this.unsupportedPollCommands = new Set();
     this.loggedPollProfiles = new Set();
+    this.skippedDialectPolls = new Set();
     this.baseURL = options.baseURL || "usiot.roborock.com";
 
     this.userData = options.userData || null;
@@ -2470,6 +2471,29 @@ class Roborock {
     return true;
   }
 
+  /**
+   * Poll one v1 parameter, unless the robot speaks a dialect that has no
+   * answer for it. Every periodic probe goes through here so the rule holds
+   * for probes added later, not just the three that were reported.
+   * @param {string} duid @param {any} vacuum @param {string} method
+   * @param {boolean} isB01
+   * @returns {Promise<any>}
+   */
+  async pollParameter(duid, vacuum, method, isB01) {
+    if (isB01 && !b01Q7Adapter.canAnswerV1Method(method)) {
+      const key = `${duid}:${method}`;
+      if (!this.skippedDialectPolls.has(key)) {
+        this.skippedDialectPolls.add(key);
+        this.log.debug(
+          `Not polling '${method}' for ${this.describeDevice(duid)}: the Q7/B01 dialect has no equivalent request, so the robot could only ever reject it.`
+        );
+      }
+      return undefined;
+    }
+
+    return vacuum.getParameter(duid, method);
+  }
+
   startMainUpdateInterval(duid, online) {
     if (!this.hasInitializedVacuum(duid)) {
       return;
@@ -2628,18 +2652,26 @@ class Roborock {
     this.log.debug(`Latest data requested`);
 
     if (this.isSupportedVacuumModel(robotModel)) {
+      // Q7-series robots speak the B01 dialect, where a good half of the v1
+      // poll chain has no equivalent request at all. Asking anyway produced
+      // an "unsupported" notice per robot per restart for a request the
+      // plugin itself rejected before it ever reached the robot.
+      const isB01 = b01Q7Adapter.isB01Protocol(
+        await this.getRobotVersion(duid)
+      );
+
       const refreshedServiceAreaRooms =
         await this.refreshMatterServiceAreaRoomMappings(duid, vacuum);
 
       if (!refreshedServiceAreaRooms) {
-        await vacuum.getParameter(duid, "get_room_mapping");
+        await this.pollParameter(duid, vacuum, "get_room_mapping", isB01);
       }
 
-      await vacuum.getParameter(duid, "get_consumable");
+      await this.pollParameter(duid, vacuum, "get_consumable", isB01);
 
-      await vacuum.getParameter(duid, "get_server_timer");
+      await this.pollParameter(duid, vacuum, "get_server_timer", isB01);
 
-      await vacuum.getParameter(duid, "get_timer");
+      await this.pollParameter(duid, vacuum, "get_timer", isB01);
 
       await this.checkForNewFirmware(duid);
 
@@ -2657,13 +2689,28 @@ class Roborock {
           //do nothing
           break;
         case "roborock.vacuum.s6":
-          await vacuum.getParameter(duid, "get_carpet_mode");
+          await this.pollParameter(duid, vacuum, "get_carpet_mode", isB01);
           break;
         case "roborock.vacuum.a27":
-          await vacuum.getParameter(duid, "get_dust_collection_switch_status");
-          await vacuum.getParameter(duid, "get_wash_towel_mode");
-          await vacuum.getParameter(duid, "get_smart_wash_params");
-          await vacuum.getParameter(duid, "app_get_dryer_setting");
+          await this.pollParameter(
+            duid,
+            vacuum,
+            "get_dust_collection_switch_status",
+            isB01
+          );
+          await this.pollParameter(duid, vacuum, "get_wash_towel_mode", isB01);
+          await this.pollParameter(
+            duid,
+            vacuum,
+            "get_smart_wash_params",
+            isB01
+          );
+          await this.pollParameter(
+            duid,
+            vacuum,
+            "app_get_dryer_setting",
+            isB01
+          );
           break;
         default: {
           // No dedicated poll profile for this model: derive it from the
@@ -2675,18 +2722,31 @@ class Roborock {
           const carpetSupported = featureList
             ? Boolean(featureList.isCarpetSupported)
             : true;
+          const waterBoxProbe =
+            !isB01 ||
+            b01Q7Adapter.canAnswerV1Method("get_water_box_custom_mode");
           const profileKey = `${duid}:${robotModel}`;
           if (!this.loggedPollProfiles.has(profileKey)) {
             this.loggedPollProfiles.add(profileKey);
             this.log.info(
-              `No dedicated poll profile for model '${robotModel}'; using ${featureList ? "capability-derived" : "generic"} polls (carpet=${carpetSupported ? "yes" : "no"}, water-box probe=yes). Requests the robot reports as unsupported are disabled automatically. If states look wrong for this model, please open a model report issue on GitHub.`
+              `No dedicated poll profile for model '${robotModel}'; using ${featureList ? "capability-derived" : "generic"} polls (carpet=${carpetSupported ? "yes" : "no"}, water-box probe=${waterBoxProbe ? "yes" : "no, the Q7/B01 dialect has no such request"}). Requests the robot reports as unsupported are disabled automatically. If states look wrong for this model, please open a model report issue on GitHub.`
             );
           }
           if (carpetSupported) {
-            await vacuum.getParameter(duid, "get_carpet_mode");
-            await vacuum.getParameter(duid, "get_carpet_clean_mode");
+            await this.pollParameter(duid, vacuum, "get_carpet_mode", isB01);
+            await this.pollParameter(
+              duid,
+              vacuum,
+              "get_carpet_clean_mode",
+              isB01
+            );
           }
-          await vacuum.getParameter(duid, "get_water_box_custom_mode");
+          await this.pollParameter(
+            duid,
+            vacuum,
+            "get_water_box_custom_mode",
+            isB01
+          );
         }
       }
     } else {