homebridge-roborock-matter 3.17.2 → 3.17.3

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 3.17.3
+
+**Q7- and Q10-series robots no longer spend a cloud request per poll on an answer the plugin cannot read.** Reported with a diagnostics export by [@niclasreich](https://github.com/niclasreich) in [#14](https://github.com/mathiashornbek/homebridge-roborock-matter/issues/14), whose Q10 S5 (`roborock.vacuum.ss07`) logged `Failed to execute get_room_mapping … method prop.get timed out after 10 seconds` while the MQTT connection was reported as up.
+
+The two method names in that line disagree, and that was the clue. `get_room_mapping` is the caller's label; `prop.get` is what actually went on the wire. The classic room-mapping routine opens by fetching `get_status` in order to read `map_status` and derive a floor number — and on these robots `get_status` translates to a real `prop.get`. `map_status` is a v1-only field that a Q7/Q10 status dictionary has never carried, so the reply could not have been used whatever it said. The request itself was already answered locally from the dialect's neutral table without touching the network, which is exactly why the existing skip did not catch this: the harmless call was making a second, expensive one.
+
+The classic flow is now skipped outright for these robots, which is where their room data was never coming from in the first place — it arrives over the protobuf map channel. That removes one cloud round-trip per poll cycle per robot, along with the `No room mappings returned` notice and the empty room-list announcement that repeated at the same rate. Robots on the classic protocol are unaffected and still read `map_status` exactly as before.
+
+**This does not by itself explain a robot that ignores commands from Apple Home**, which is the other half of that report; it removes a wasted request and the misleading error line it produced.
+
 ## 3.17.2
 
 **The Qrevo CurvX's dock can now offer the Empty Bin switch.** Reported with a diagnostics export, and then settled by hand, by [@jcoz00](https://github.com/jcoz00) in [#6](https://github.com/mathiashornbek/homebridge-roborock-matter/issues/6). His a185 reports `dock_type: 20`, and the dock table this plugin inherited stops at 9 — so the CurvX fell through to "unknown dock" and was treated as having no auto-empty capability, which kept the optional Empty Bin switch added in 3.17.0 from ever being offered for it. Dock type 20 is now a named, recognised auto-empty dock.

package/README.md

@@ -37,7 +37,7 @@ This is the most feature-packed, most thoroughly engineered Roborock plugin for
 - 📍 **See where it's cleaning — live.** Apple Home shows _"Cleaning — Kitchen"_ with the room the robot is actually inside, updating as it moves from room to room. Works even for cleans started from the robot's button or the Roborock app. No other Homebridge plugin does this.
 - 🧭 **One robot, one tile — and as many robots as you own.** Sign in once and your whole fleet comes along: every vacuum on your account appears as its own clean, native accessory in Apple Home. No clutter of fake fans and helper switches, and rooms appear with the names you gave them in the Roborock app.
 - ⚡ **Fast and reliable.** Commands go directly to the robot over your own network whenever possible, with the Roborock cloud as automatic backup — and built-in diagnostics in the settings if you ever want to look under the hood.
-- 🛡️ **Verified by Homebridge.** Reviewed and endorsed by the Homebridge team. 1438 automated tests, zero known vulnerabilities, no analytics, and a startup designed to never crash your Homebridge — even when your Wi-Fi or the Roborock cloud has a bad day.
+- 🛡️ **Verified by Homebridge.** Reviewed and endorsed by the Homebridge team. 1449 automated tests, zero known vulnerabilities, no analytics, and a startup designed to never crash your Homebridge — even when your Wi-Fi or the Roborock cloud has a bad day.
 
 ## Features
 
@@ -252,7 +252,7 @@ The complete path — robot → plugin → Homebridge → matter.js store — wa
 
 ## Contributing
 
-Model reports, diagnostics exports, and pull requests are very welcome. The codebase ships with 1438 tests (protocol fixtures verified against the [python-roborock](https://github.com/Python-roborock/python-roborock) reference), strict TypeScript checking, and CI across Node 22/24 × Homebridge 1.11/2.x — `npm test` before you push and you're set.
+Model reports, diagnostics exports, and pull requests are very welcome. The codebase ships with 1449 tests (protocol fixtures verified against the [python-roborock](https://github.com/Python-roborock/python-roborock) reference), strict TypeScript checking, and CI across Node 22/24 × Homebridge 1.11/2.x — `npm test` before you push and you're set.
 
 ## Support the project
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "homebridge-roborock-matter",
-  "version": "3.17.2",
+  "version": "3.17.3",
   "description": "The most complete Roborock plugin for Apple Home. Supports the entire Roborock lineup — from the classic S-series to the new 2025 Q7 series that no other plugin can control. Sign in with your Roborock account and get native start/stop, room cleaning, suction levels, battery, and live 'cleaning in the kitchen' room tracking. Verified by Homebridge.",
   "license": "MIT",
   "author": {

package/roborockLib/lib/vacuum.js

@@ -765,6 +765,19 @@ class vacuum {
           this.adapter.manageDeviceIntervals(duid);
         }
       } else if (parameter == "get_room_mapping") {
+        // Room data on B01/Q7 robots travels over the protobuf map channel,
+        // and `get_room_mapping` itself is answered from the dialect's neutral
+        // table without touching the network — so this branch looked free.
+        // It is not: it opens by fetching `get_status` to read `map_status`,
+        // a v1-only field that Q7 status dictionaries have never carried, and
+        // on B01 `get_status` translates to a real `prop.get`. That is one
+        // cloud round-trip per poll cycle per robot spent on an answer this
+        // code cannot read — reported under the caller's label, which is why
+        // #14's log line names `get_room_mapping` but times out on `prop.get`.
+        if (this.adapter.isB01Device?.(duid)) {
+          return;
+        }
+
         const deviceStatus = await sendParameterRequest("get_status", []);
         const mapStatus = Array.isArray(deviceStatus)
           ? deviceStatus[0]?.["map_status"]

package/roborockLib/roborockAPI.js

@@ -982,9 +982,7 @@ class Roborock {
   }
 
   getRoomMappingsForDevice(duid) {
-    if (
-      this.getVacuumDeviceInfo(duid, "pv") === b01Q7Adapter.B01_PROTOCOL_VERSION
-    ) {
+    if (this.isB01Device(duid)) {
       return this.getB01RoomCache(duid).map((room) => ({
         segmentId: room.roomId,
         mapId: 0,
@@ -1025,9 +1023,7 @@ class Roborock {
     // the canonical mapId 0. Reporting 0 here keeps the Matter room-clean
     // flow from attempting a map switch (load_multi_map has no Q7
     // equivalent) before sending the segment command.
-    if (
-      this.getVacuumDeviceInfo(duid, "pv") === b01Q7Adapter.B01_PROTOCOL_VERSION
-    ) {
+    if (this.isB01Device(duid)) {
       return 0;
     }
 
@@ -2308,10 +2304,7 @@ class Roborock {
       this.vacuums[duid].getStatusIntervall = () => {
         // B01/Q7 status is owned by the dedicated 15s loop; the per-device
         // tick would only burn cycles hitting the attempt throttle.
-        if (
-          this.getVacuumDeviceInfo(duid, "pv") ===
-          b01Q7Adapter.B01_PROTOCOL_VERSION
-        ) {
+        if (this.isB01Device(duid)) {
           return null;
         }
         this.clearInterval(this.vacuums[duid].getStatusIntervalHandle);
@@ -2396,9 +2389,7 @@ class Roborock {
     // with no electronic mop/water control, so Matter must never expose mop
     // modes for them regardless of what the generic cloud schema claims.
     // Suction (Q7 "wind") is controllable via the B01 adapter.
-    if (
-      this.getVacuumDeviceInfo(duid, "pv") === b01Q7Adapter.B01_PROTOCOL_VERSION
-    ) {
+    if (this.isB01Device(duid)) {
       return {
         // Q7 robots mop with a manually filled tank: expose the mop/vacuum
         // mode switch, but never water-level status or control.
@@ -5070,6 +5061,22 @@ class Roborock {
     }
   }
 
+  /**
+   * True when this robot speaks the B01/Q7 dialect rather than classic v1.
+   *
+   * Four places wrote this comparison out by hand before it had a name, and
+   * `vacuum.js` was about to need a fifth. It decides which wire protocol a
+   * robot speaks, so it gets one spelling.
+   *
+   * @param {string} duid
+   * @returns {boolean}
+   */
+  isB01Device(duid) {
+    return (
+      this.getVacuumDeviceInfo(duid, "pv") === b01Q7Adapter.B01_PROTOCOL_VERSION
+    );
+  }
+
   /**
    * A device's name for log messages, falling back to the duid.
    *