homebridge-nest-accfactory 0.0.4-a → 0.0.6

package/CHANGELOG.md

@@ -6,6 +6,17 @@ All notable changes to `homebridge-nest-accfactory` will be documented in this f
 
 Currently all releases are considered 'alpha' status, where things may or may not be working. Use at your own risk :-)
 
+## v0.0.6 (2024-09-14)
+
+- Fix for two/way audio starting on non-enabled HKSV camera/doorbells
+
+## v0.0.5 (2024-09-13)
+
+- General code cleanup and bug fixes
+- External dependancy reductions, dropped pbf and axios libraries
+- Nest Cam with Floodlight support with light on/off and brightness control
+- Fixed issued with setting range temperatures on Nest Thermostat(s)
+
 ## v0.0.4 (2024-09-07)
 
 - Camera/Doorbell support for snapshots and live video re-introduced
@@ -19,7 +30,7 @@ Currently all releases are considered 'alpha' status, where things may or may no
 - Cleanup fix for when removing a camera/doorbell from Nest/Google
 - Fix for virtual weather device when missing configured city and/or state details
 - Fix for retrieving data from Nest systems when using both a Nest and Google accounts
-- Initial support newer Nest/Google camera/doorbell devices (streaming/recording - coming)
+- Initial support for newer Nest/Google camera/doorbell devices (streaming/recording - coming)
 
 ## v0.0.1 (2024-08-27)
 

package/README.md

@@ -15,13 +15,13 @@ Formally known as [Nest_accfactory](https://github.com/n0rt0nthec4t/Nest_accfact
 
 ## Supported Devices
 
-The following Nest devices are supported
+The following Nest devices are known to be supported
 
-* Nest Thermostats (Gen 1, Gen 2, Gen 3, E, 2020, Gen 4)
-* Nest Protects (Gen 1, Gen 2)
-* Nest Temp Sensors (Gen 1)
-* Nest Cameras (Cam Indoor, IQ Indoor, Outdoor, IQ Outdoor)
-* Nest Doorbells (Gen 1)
+* Nest Thermostats (1st gen, 2nd gen, 3rd gen, E, 2020 mirror edition, 4th gen)
+* Nest Protects (1st and 2nd gen)
+* Nest Temp Sensors (1st gen)
+* Nest Cameras (Cam Indoor, IQ Indoor, Outdoor, IQ Outdoor, Cam with Floodlight)
+* Nest Doorbells (wired 1st gen)
 
 The accessory supports connection to Nest using a Nest account OR a Google (migrated Nest account) account.
 
@@ -118,4 +118,4 @@ The following options are available on a per-device level in the config.json dev
 
 ## Caveats
 
-Nest_accfactory is a hobby project of mine, provided as-is, with no warranty whatsoever. I've been running it successfully at my home, but your mileage might vary.
+homebridge-nest-accfactory and Nest_accfactory are both hobby projects of mine, provided as-is, with no warranty whatsoever. I've been running it successfully at my home, but your mileage might vary. If you do find an issue, please reachout and see what we can do

package/dist/HomeKitDevice.js

@@ -37,7 +37,7 @@
 // HomeKitDevice.updateServices(deviceData)
 // HomeKitDevice.messageServices(type, message)
 //
-// Code version 6/9/2024
+// Code version 13/9/2024
 // Mark Hulskamp
 'use strict';
 
@@ -104,7 +104,8 @@ export default class HomeKitDevice {
       this.#eventEmitter.addListener(this.deviceData.uuid, this.#message.bind(this));
     }
 
-    // Make copy of current data and store in this object
+    // Make a clone of current data and store in this object
+    // Important that we done have a 'linked' cope of the object data
     // eslint-disable-next-line no-undef
     this.deviceData = structuredClone(deviceData);
 
@@ -149,7 +150,10 @@ export default class HomeKitDevice {
       this.deviceData.model === '' ||
       typeof this.deviceData?.manufacturer !== 'string' ||
       this.deviceData.manufacturer === '' ||
-      (this.#platform === undefined && typeof this.deviceData?.hkPairingCode !== 'string' && this.deviceData.hkPairingCode === '') ||
+      (this.#platform === undefined &&
+        typeof this.deviceData?.hkPairingCode !== 'string' &&
+        (new RegExp(/^([0-9]{3}-[0-9]{2}-[0-9]{3})$/).test(this.deviceData.hkPairingCode) === true ||
+          new RegExp(/^([0-9]{4}-[0-9]{4})$/).test(this.deviceData.hkPairingCode) === true)) ||
       (this.#platform === undefined &&
         typeof this.deviceData?.hkUsername !== 'string' &&
         new RegExp(/^([0-9A-Fa-f]{2}[:-]){5}([0-9A-Fa-f]{2})$/).test(this.deviceData.hkUsername) === false)
@@ -239,7 +243,7 @@ export default class HomeKitDevice {
     }
   }
 
-  async remove() {
+  remove() {
     this?.log?.warn && this.log.warn('Device "%s" has been removed', this.deviceData.description);
 
     if (this.#eventEmitter === undefined && typeof this.deviceData?.uuid === 'string' && this.deviceData.uuid !== '') {
@@ -249,7 +253,7 @@ export default class HomeKitDevice {
 
     if (typeof this.removeServices === 'function') {
       try {
-        await this.removeServices();
+        this.removeServices();
       } catch (error) {
         this?.log?.error && this.log.error('removeServices call for device "%s" failed. Error was', this.deviceData.description, error);
       }
@@ -278,7 +282,7 @@ export default class HomeKitDevice {
     // delete this;
   }
 
-  async update(deviceData, forceUpdate) {
+  update(deviceData, forceUpdate) {
     if (typeof deviceData !== 'object' || typeof forceUpdate !== 'boolean') {
       return;
     }
@@ -357,7 +361,7 @@ export default class HomeKitDevice {
 
       if (typeof this.updateServices === 'function') {
         try {
-          await this.updateServices(deviceData); // Pass updated data on for accessory to process as it needs
+          this.updateServices(deviceData); // Pass updated data on for accessory to process as it needs
         } catch (error) {
           this?.log?.error && this.log.error('updateServices call for device "%s" failed. Error was', this.deviceData.description, error);
         }
@@ -381,6 +385,13 @@ export default class HomeKitDevice {
 
     // Send event with data to set
     this.#eventEmitter.emit(HomeKitDevice.SET, this.deviceData.uuid, values);
+
+    // Update the internal data for the set values, as could take sometime once we emit the event
+    Object.entries(values).forEach(([key, value]) => {
+      if (this.deviceData[key] !== undefined) {
+        this.deviceData[key] = value;
+      }
+    });
   }
 
   async get(values) {
@@ -394,7 +405,7 @@ export default class HomeKitDevice {
     }
 
     // Send event with data to get
-    // Once get has completed, we'll get an eevent back with the requested data
+    // Once get has completed, we'll get an event back with the requested data
     this.#eventEmitter.emit(HomeKitDevice.GET, this.deviceData.uuid, values);
 
     // This should always return, but we probably should put in a timeout?
@@ -402,7 +413,7 @@ export default class HomeKitDevice {
     return results?.[0];
   }
 
-  async #message(type, message) {
+  #message(type, message) {
     switch (type) {
       case HomeKitDevice.ADD: {
         // Got message for device add
@@ -428,7 +439,7 @@ export default class HomeKitDevice {
         // This is not a message we know about, so pass onto accessory for it to perform any processing
         if (typeof this.messageServices === 'function') {
           try {
-            await this.messageServices(type, message);
+            this.messageServices(type, message);
           } catch (error) {
             this?.log?.error &&
               this.log.error('messageServices call for device "%s" failed. Error was', this.deviceData.description, error);

package/dist/HomeKitHistory.js

@@ -8,6 +8,8 @@
 // -- Eve Degree/Weather2 history
 // -- Eve Water guard history
 //
+// Credit to https://github.com/simont77/fakegato-history for the work on starting the EveHome comms protocol decoding
+//
 // Version 29/8/2024
 // Mark Hulskamp
 
@@ -2073,15 +2075,6 @@ export default class HomeKitHistory {
       numberToEveHexString(1, 8),
     ); // first entry
 
-    if (this?.log?.debug) {
-      this.log.debug(
-        '#EveHistoryStatus: history for "%s:%s" (%s) - Entries %s',
-        this.EveHome.type,
-        this.EveHome.sub,
-        this.EveHome.evetype,
-        this.EveHome.count,
-      );
-    }
     return encodeEveData(value);
   }
 
@@ -2299,26 +2292,11 @@ export default class HomeKitHistory {
       }
       if (this.EveHome.entry > this.EveHome.count) {
         // No more history data to send back
-        this?.log?.debug &&
-          this.log.debug(
-            '#EveHistoryEntries: sent "%s" entries to EveHome ("%s") for "%s:%s"',
-            this.EveHome.send,
-            this.EveHome.evetype,
-            this.EveHome.type,
-            this.EveHome.sub,
-          );
         this.EveHome.send = 0; // no more to send
         dataStream += '00';
       }
     } else {
       // We're not transferring any data back
-      this?.log?.debug &&
-        this.log.debug(
-          '#EveHistoryEntries: no more entries to send to EveHome ("%s") for "%s:%s',
-          this.EveHome.evetype,
-          this.EveHome.type,
-          this.EveHome.sub,
-        );
       this.EveHome.send = 0; // no more to send
       dataStream = '00';
     }