homebridge-melcloud-control 4.7.3-beta.7 → 4.7.3-beta.8

package/homebridge-ui/public/index.html

@@ -142,7 +142,7 @@
         formElements.language.value = account.language || '0';
         formElements.accountType.value = account.type || 'disabled';
         formElements.logIn.disabled = !(account.name && account.user && account.passwd && account.language && account.type !== 'disabled');
-        formElements.configButton.disabled = !(account.ataDevices.length > 0 || account.atwDevices.length > 0 || account.ervDevices.length > 0);
+        formElements.configButton.disabled = !((account.ataDevices?.length ?? 0) > 0 || (account.atwDevices?.length ?? 0) > 0 || (account.ervDevices?.length ?? 0) > 0);
 
         this.account = account;
       });
@@ -160,7 +160,7 @@
       account.language = formElements.language.value;
       account.type = formElements.accountType.value;
       formElements.logIn.disabled = !(account.name && account.user && account.passwd && account.language && account.type !== 'disabled');
-      formElements.configButton.disabled = !(account.ataDevices.length > 0 || account.atwDevices.length > 0 || account.ervDevices.length > 0);
+      formElements.configButton.disabled = !((account.ataDevices?.length ?? 0) > 0 || (account.atwDevices?.length ?? 0) > 0 || (account.ervDevices?.length ?? 0) > 0);
 
       await homebridge.updatePluginConfig(pluginConfig);
       await homebridge.savePluginConfig();
@@ -233,20 +233,11 @@
       return map;
     }
 
-    // Helper to generate summary string
-    function summarizeChanges(type, ata, atw, erv) {
-      const parts = [];
-      if (ata.length) parts.push(`ATA: ${ata.length}`);
-      if (atw.length) parts.push(`ATW: ${atw.length}`);
-      if (erv.length) parts.push(`ERV: ${erv.length}`);
-      return parts.length ? `${type}: ${parts.join(', ')}` : '';
-    }
-
     // Login & Sync Logic
     document.getElementById('logIn').addEventListener('click', async () => {
       document.getElementById('logIn').disabled = true;
       const lightingMode = homebridge.userCurrentLightingMode();
-      const fontColor = lightingMode === 'dark' ? 'black' : 'white';
+      const fontColor = lightingMode === 'dark' ? 'white' : 'black';
 
       updateInfo('info', 'Connecting to MELCloud', fontColor);
       updateInfo('info1', '', fontColor);
@@ -270,11 +261,7 @@
         account.ervDevices = account.ervDevices ?? [];
 
         // Prepare MELCloud data
-        const newInMelCloud = {
-          ata: [], ataPresets: [], ataSchedules: [], ataScenes: [],
-          atw: [], atwPresets: [], atwSchedules: [], atwScenes: [],
-          erv: [], ervPresets: [], ervSchedules: [], ervScenes: []
-        };
+        const newInMelCloud = { ata: [], ataPresets: [], ataSchedules: [], ataScenes: [], atw: [], atwPresets: [], atwSchedules: [], atwScenes: [], erv: [], ervPresets: [], ervSchedules: [], ervScenes: [] };
         const devicesInMelCloudByType = { ata: [], atw: [], erv: [] };
         const scenesInMelCloud = response.Scenes ?? [];
 
@@ -415,23 +402,16 @@
         const removedPresetsCount = removedFromConfig.presets.length;
         const removedSchedulesCount = removedFromConfig.schedules.length;
         const removedScenesCount = removedFromConfig.scenes.length;
-        if (!newDevicesCount && !newPresetsCount && !newSchedulesCount && !newScenesCount && !removedDevicesCount && !removedPresetsCount && !removedSchedulesCount && !removedScenesCount) updateInfo('info', 'No changes detected.', fontColor);
-
-        // New items
-        const newParts = [];
-        if (newDevicesCount) newParts.push(summarizeChanges('Devices', newInMelCloud.ata, newInMelCloud.atw, newInMelCloud.erv));
-        if (account.type === 'melcloud' && newPresetsCount) newParts.push(summarizeChanges('Presets', newInMelCloud.ataPresets, newInMelCloud.atwPresets, newInMelCloud.ervPresets));
-        if (account.type === 'melcloudhome' && newSchedulesCount) newParts.push(summarizeChanges('Schedules', newInMelCloud.ataSchedules, newInMelCloud.atwSchedules, newInMelCloud.ervSchedules));
-        if (account.type === 'melcloudhome' && newScenesCount) newParts.push(summarizeChanges('Scenes', newInMelCloud.ataScenes, newInMelCloud.atwScenes, newInMelCloud.ervScenes));
-        if (newParts.length) updateInfo('info', `Found new: ${newParts.join('; ')}`, 'green');
-
-        // Removed items
-        const removedParts = [];
-        if (removedDevicesCount) removedParts.push(summarizeChanges('Devices', removedFromConfig.ata, removedFromConfig.atw, removedFromConfig.erv));
-        if (removedPresetsCount) removedParts.push(`Presets: ${removedPresetsCount}`);
-        if (removedSchedulesCount) removedParts.push(`Schedules: ${removedSchedulesCount}`);
-        if (removedScenesCount) removedParts.push(`Scenes: ${removedScenesCount}`);
-        if (removedParts.length) updateInfo('info1', `Removed old: ${removedParts.join('; ')}`, 'orange');
+
+        if (!newDevicesCount && !newPresetsCount && !newSchedulesCount && !newScenesCount && !removedDevicesCount && !removedPresetsCount && !removedSchedulesCount && !removedScenesCount) {
+          updateInfo('info', 'No changes detected.', fontColor);
+        }
+        if (newDevicesCount || newPresetsCount || newSchedulesCount || newScenesCount) {
+          updateInfo('info', `Found new ${newDevicesCount ? `devices:` : ''} ${newInMelCloud.ata.length ? `ATA: ${newInMelCloud.ata.length},` : ''} ${newInMelCloud.atw.length ? `ATW: ${newInMelCloud.atw.length},` : ''} ${newInMelCloud.erv.length ? `ERV: ${newInMelCloud.erv.length},` : ''} ${newPresetsCount ? `presets:` : ''} ${newInMelCloud.ataPresets.length ? `ATA: ${newInMelCloud.ataPresets.length},` : ''} ${newInMelCloud.atwPresets.length ? `ATW: ${newInMelCloud.atwPresets.length}, ` : ''} ${newInMelCloud.ervPresets.length ? `ERV: ${newInMelCloud.ervPresets.length},` : ''} ${newSchedulesCount ? `schedules:` : ''} ${newInMelCloud.ataSchedules.length ? `ATA: ${newInMelCloud.ataSchedules.length},` : ''} ${newInMelCloud.atwSchedules.length ? `ATW: ${newInMelCloud.atwSchedules.length},` : ''} ${newInMelCloud.ervSchedules.length ? `ERV: ${newInMelCloud.ervSchedules.length}, ` : ''} ${newScenesCount ? `scenes:` : ''} ${newInMelCloud.ataScenes.length ? `ATA: ${newInMelCloud.ataScenes.length},` : ''} ${newInMelCloud.atwScenes.length ? `ATW: ${newInMelCloud.atwScenes.length},` : ''} ${newInMelCloud.ervScenes.length ? `ERV: ${newInMelCloud.ervScenes.length}` : ''}.`, 'green');
+        }
+        if (removedDevicesCount || removedPresetsCount || removedSchedulesCount || removedScenesCount) {
+          updateInfo('info1', `Removed old ${removedDevicesCount ? `devices:` : ''} ${removedFromConfig.ata.length ? `ATA: ${removedFromConfig.ata.length},` : ''} ${removedFromConfig.atw.length ? `ATW: ${removedFromConfig.atw.length},` : ''} ${removedFromConfig.erv.length ? `ERV: ${removedFromConfig.erv.length},` : ''} ${removedPresetsCount ? `presets: ${removedPresetsCount},` : ''} ${removedSchedulesCount ? `schedules: ${removedSchedulesCount},` : ''} ${removedScenesCount ? `scenes: ${removedScenesCount}` : ''}.`, 'orange');
+        }
 
         await homebridge.updatePluginConfig(pluginConfig);
         await homebridge.savePluginConfig();

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.7.3-beta.7",
+  "version": "4.7.3-beta.8",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",