homebridge-melcloud-control 4.6.7-beta.8 → 4.7.0-beta.0

package/CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - add support for ATW, fix [#233](https://github.com/grzegorz914/homebridge-melcloud-control/issues/233), thanks @bastienb99
 - fix [#232](https://github.com/grzegorz914/homebridge-melcloud-control/issues/232)
+- prevent login to melcloud if account type is set to disable
 - config schema updated
 - bump dependencies
 - cleanup

package/homebridge-ui/public/index.html

@@ -117,8 +117,6 @@
 
     // Tworzenie przycisków
     accounts.forEach((account, i) => {
-      this.account = account;
-
       const button = document.createElement("button");
       button.type = "button";
       button.id = `button${i}`;
@@ -143,7 +141,7 @@
         formElements.passwd.value = account.passwd || '';
         formElements.language.value = account.language || '0';
         formElements.accountType.value = account.type || 'disabled';
-        formElements.logIn.disabled = !(account.name && account.user && account.passwd && account.language && account.type);
+        formElements.logIn.disabled = !(account.name && account.user && account.passwd && account.language && account.type !== 'disabled');
 
         this.account = account;
       });
@@ -155,15 +153,12 @@
     // Jeden listener input dla całego formularza
     document.getElementById('configForm').addEventListener('input', async () => {
       const account = this.account;
-      if (!account) return;
-
       account.name = formElements.name.value;
       account.user = formElements.user.value;
       account.passwd = formElements.passwd.value;
       account.language = formElements.language.value;
       account.type = formElements.accountType.value;
-
-      formElements.logIn.disabled = !(account.name && account.user && account.passwd && account.language && account.type);
+      formElements.logIn.disabled = !(account.name && account.user && account.passwd && account.language && account.type !== 'disabled');
 
       await homebridge.updatePluginConfig(pluginConfig);
       await homebridge.savePluginConfig();
@@ -247,7 +242,7 @@
 
     // Login & Sync Logic
     document.getElementById('logIn').addEventListener('click', async () => {
-      document.getElementById('logIn').className = "btn btn-primary";
+      document.getElementById('logIn').disabled = true;
       const lightingMode = homebridge.userCurrentLightingMode();
       const fontColor = lightingMode === 'dark' ? 'black' : 'white';
 
@@ -262,6 +257,7 @@
 
         if (!response.State) {
           updateInfo('info', response.Info, 'red');
+          document.getElementById('logIn').disabled = false;
           homebridge.hideSpinner();
           return;
         }
@@ -437,13 +433,12 @@
 
         await homebridge.updatePluginConfig(pluginConfig);
         await homebridge.savePluginConfig();
-
       } catch (error) {
         updateInfo('info', `Prepare config error`, "red");
         updateInfo('info1', `Error: ${JSON.stringify(error)}`, "red");
       } finally {
-        document.getElementById('logIn').className = "btn btn-secondary";
         homebridge.hideSpinner();
+        document.getElementById('logIn').disabled = false;
       }
     });
   })();

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.6.7-beta.8",
+  "version": "4.7.0-beta.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceatw.js

@@ -1807,7 +1807,7 @@ class DeviceAtw extends EventEmitter {
                         let currentOperationMode = 0;
                         let targetOperationMode = 0;
                         let roomTemperature = null;
-                        let setTemperature = 0;
+                        let setTemperature = null;
                         let lockPhysicalControl = 0;
                         let operationModeSetPropsMinValue = 0;
                         let operationModeSetPropsMaxValue = 0;
@@ -1925,7 +1925,8 @@ class DeviceAtw extends EventEmitter {
                                     { type: Characteristic.TemperatureDisplayUnits, value: obj.useFahrenheit }
                                 );
 
-                                if (heatCoolModes === 0 || heatCoolModes === 2) characteristics.push({ type: Characteristic.CoolingThresholdTemperature, value: setTemperature });
+                                if (heatCoolModes === 0 || heatCoolModes === 1) characteristics.push({ type: Characteristic.HeatingThresholdTemperature, value: setTemperature });
+                                if ((heatCoolModes === 0 || heatCoolModes === 2) && i !== caseHotWater) characteristics.push({ type: Characteristic.CoolingThresholdTemperature, value: setTemperature });
                                 break;
                             case 2: //Thermostat
                                 switch (i) {
@@ -2152,7 +2153,6 @@ class DeviceAtw extends EventEmitter {
                                 break;
                         }
 
-
                         //add every sensor to array
                         const sensor = {
                             name: name,

package/src/mqtt.js

@@ -38,10 +38,8 @@ class Mqtt extends EventEmitter {
                     }
                 });
 
-                // MQTT v5 subscription results contain reason codes
-                if (config.logDebug) this.emit('debug', `Subscribed to ${subscribeTopic}, reason codes: ${JSON.stringify(result)}`);
-                this.emit('subscribed', `MQTT Subscribe topic: ${subscribeTopic}`);
-
+                // MQTT v5 subscription results
+                this.emit('connected', `MQTT Subscribe topic: ${subscribeTopic}`);
             } catch (error) {
                 if (config.logWarn) this.emit('warn', `MQTT Subscribe error: ${error}`);
             }