homebridge-melcloud-control 4.4.1-beta.41 → 4.4.1-beta.43

package/homebridge-ui/public/index.html

@@ -272,7 +272,7 @@
         const scenesInMelCloud = response.Scenes ?? [];
 
         // Split devices by type
-        (response.Devices ?? []).forEach(device => {
+        response.Devices ?? [].forEach(device => {
           if (device.Type === 0) devicesInMelCloudByType.ata.push(device);
           if (device.Type === 1) devicesInMelCloudByType.atw.push(device);
           if (device.Type === 3) devicesInMelCloudByType.erv.push(device);
@@ -286,7 +286,6 @@
         const removedFromConfigAta = removeStaleEntities(account.ataDevices, devicesInMelCloudByType.ata, d => d.id, d => d.DeviceID);
         const removedFromConfigAtw = removeStaleEntities(account.atwDevices, devicesInMelCloudByType.atw, d => d.id, d => d.DeviceID);
         const removedFromConfigErv = removeStaleEntities(account.ervDevices, devicesInMelCloudByType.erv, d => d.id, d => d.DeviceID);
-
         const removedFromConfig = { ataPresets: [], atwPresets: [], ervPresets: [], ataSchedules: [], atwSchedules: [], ervSchedules: [], scenes: [] };
 
         // Map UnitId → Scenes
@@ -296,7 +295,7 @@
         const handleDevices = (devicesInMelCloud, devicesInConfig, deviceTypeString, newDevices, newPresets, newSchedules, newScenes) => {
           const configDevicesMap = new Map(devicesInConfig.map(dev => [String(dev.id), dev]));
 
-          (devicesInMelCloud ?? []).forEach(device => {
+          devicesInMelCloud.forEach(device => {
             const deviceId = String(device.DeviceID);
             let deviceInConfig = configDevicesMap.get(deviceId);
 
@@ -349,15 +348,15 @@
                 }
               });
 
+              // SCENES
               // SCENES
               deviceInConfig.scenes = deviceInConfig.scenes ?? [];
-              removedFromConfig.scenes.push(...removeStaleEntities(deviceInConfig.scenes, scenesInMelCloud, s => s.id, s => s.Id));
-              const sceneIds = new Set(deviceInConfig.scenes.map(s => String(s.id)));
               const scenesForDevice = unitIdToScenes.get(deviceId) ?? [];
-
+              removedFromConfig.scenes.push(...removeStaleEntities(deviceInConfig.scenes, scenesForDevice, s => s.id, s => s.Id));
+              const existingSceneIds = new Set(deviceInConfig.scenes.map(s => String(s.id)));
               scenesForDevice.forEach((scene, index) => {
                 const sceneId = String(scene.Id);
-                if (!sceneIds.has(sceneId)) {
+                if (!existingSceneIds.has(sceneId)) {
                   const sceneObj = {
                     id: sceneId,
                     displayType: 0,

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.4.1-beta.41",
+  "version": "4.4.1-beta.43",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",