homebridge-melcloud-control 4.4.0-beta.9 → 4.4.1-beta.0

package/CHANGELOG.md

@@ -28,13 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - added possibility to set frost protection min/max temperaure (ATA, ATW)
 - added possibility to set overheat protection min/max temperture (ATA)
-- bump dependencies
-- cleanup
-
-# [4.3.16] - (09.12.2025)
-
-## Changes
-
 - stability and performance improvements
 - moved MQTT to v5
 - bump dependencies

package/index.js

@@ -90,7 +90,7 @@ class MelCloudPlatform {
 										melcloud = new MelCloud(account, accountFile, buildingsFile, true);
 										break;
 									case 'melcloudhome':
-										timmers = [{ name: 'connect', sampling: 3300000 }, { name: 'checkDevicesList', sampling: 3000 }];
+										timmers = [{ name: 'connect', sampling: 3300000 }, { name: 'checkDevicesList', sampling: 5000 }];
 										melcloud = new MelCloudHome(account, accountFile, buildingsFile, true);
 										break;
 									default:

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.4.0-beta.9",
+  "version": "4.4.1-beta.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -934,7 +934,7 @@ class DeviceAta extends EventEmitter {
             }
 
             //holiday mode
-            if (this.holidayModeSupport && this.accessory.holidayModeEnabled !== null) {
+            if (this.holidayModeSupport && this.accessory.holidayMode.Enabled !== null) {
                 //control
                 if (this.logDebug) this.emit('debug', `Prepare holiday mode control service`);
                 this.holidayModeControlService = new Service.Switch(`${serviceName} Holiday Mode`, `holidayModeControlService${deviceId}`);
@@ -942,7 +942,7 @@ class DeviceAta extends EventEmitter {
                 this.holidayModeControlService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Holiday Mode`);
                 this.holidayModeControlService.getCharacteristic(Characteristic.On)
                     .onGet(async () => {
-                        const state = this.accessory.holidayModeEnabled;
+                        const state = this.accessory.holidayMode.Enabled;
                         return state;
                     })
                     .onSet(async (state) => {
@@ -962,7 +962,7 @@ class DeviceAta extends EventEmitter {
                 this.holidayModeControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Holiday Mode Control`);
                 this.holidayModeControlSensorService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.holidayModeEnabled;
+                        const state = this.accessory.holidayMode.Enabled;
                         return state;
                     })
                 accessory.addService(this.holidayModeControlSensorService);
@@ -974,7 +974,7 @@ class DeviceAta extends EventEmitter {
                 this.holidayModeSensorService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Holiday Mode`);
                 this.holidayModeSensorService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.holidayModeActive;
+                        const state = this.accessory.holidayMode.Active;
                         return state;
                     })
                 accessory.addService(this.holidayModeSensorService);
@@ -1506,15 +1506,14 @@ class DeviceAta extends EventEmitter {
 
                     //presets schedules
                     const presetsOnServer = deviceData.Presets ?? [];
-                    const scheduleEnabled = deviceData.ScheduleEnabled;
                     const schedulesOnServer = deviceData.Schedule ?? [];
+                    const scheduleEnabled = deviceData.ScheduleEnabled;
                     const scenesOnServer = deviceData.Scenes ?? [];
-                    const holidayModeEnabled = deviceData.HolidayMode?.Enabled;
-                    const holidayModeActive = deviceData.HolidayMode?.Active ?? false;
 
                     //protection
                     const frostProtection = deviceData.FrostProtection ?? {};
                     const overheatProtection = deviceData.OverheatProtection ?? {};
+                    const holidayMode = deviceData.HolidayMode ?? {};
 
                     //device control
                     const hideVaneControls = deviceData.HideVaneControls ?? false;
@@ -1569,7 +1568,11 @@ class DeviceAta extends EventEmitter {
                     const obj = {
                         presets: presetsOnServer,
                         schedules: schedulesOnServer,
+                        scheduleEnabled: scheduleEnabled,
                         scenes: scenesOnServer,
+                        frostProtection: frostProtection,
+                        overheatProtection: overheatProtection,
+                        holidayMode: holidayMode,
                         supportsAutomaticFanSpeed: supportsAutomaticFanSpeed,
                         supportsAirDirectionFunction: supportsAirDirectionFunction,
                         supportsSwingFunction: supportsSwingFunction,
@@ -1606,12 +1609,7 @@ class DeviceAta extends EventEmitter {
                         useFahrenheit: this.accountInfo.useFahrenheit ? 1 : 0,
                         temperatureUnit: TemperatureDisplayUnits[this.accountInfo.useFahrenheit ? 1 : 0],
                         isConnected: isConnected,
-                        isInError: isInError,
-                        frostProtection: frostProtection,
-                        overheatProtection: overheatProtection,
-                        holidayModeEnabled: holidayModeEnabled,
-                        holidayModeActive: holidayModeActive,
-                        scheduleEnabled: scheduleEnabled
+                        isInError: isInError
                     };
 
                     //characteristics array
@@ -1796,10 +1794,10 @@ class DeviceAta extends EventEmitter {
                     }
 
                     //holiday mode
-                    if (this.holidayModeSupport && holidayModeEnabled !== null) {
-                        this.holidayModeControlService?.updateCharacteristic(Characteristic.On, holidayModeEnabled);
-                        this.holidayModeControlSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayModeEnabled);
-                        this.holidayModeSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayModeActive);
+                    if (this.holidayModeSupport && holidayMode.Enabled !== null) {
+                        this.holidayModeControlService?.updateCharacteristic(Characteristic.On, holidayMode.Enabled);
+                        this.holidayModeControlSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayMode.Enabled);
+                        this.holidayModeSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayMode.Active);
                     }
 
                     //presets

package/src/deviceatw.js

@@ -1115,8 +1115,10 @@ class DeviceAtw extends EventEmitter {
                     })
                     .onSet(async (value) => {
                         try {
-                            deviceData.FrostProtection.Max = value;
-                            if (this.logInfo) this.emit('info', `Set frost protection max. temperature: ${value}${this.accessory.temperatureUnit}`);
+                            let { min, max } = await this.functions.adjustTempProtection(deviceData.FrostProtection.Min, deviceData.FrostProtection.Max, value, 'max', 4, 14, 6, 16);
+                            deviceData.FrostProtection.Min = min;
+                            deviceData.FrostProtection.Max = max;
+                            if (this.logInfo) this.emit('info', `Set frost protection max. temperature: ${max}${this.accessory.temperatureUnit}`);
                             await this.melCloudAta.send(this.accountType, this.displayType, deviceData, 'frostprotection');
                         } catch (error) {
                             if (this.logWarn) this.emit('warn', `Set frost protection max. temperature error: ${error}`);
@@ -1134,8 +1136,10 @@ class DeviceAtw extends EventEmitter {
                     })
                     .onSet(async (value) => {
                         try {
-                            deviceData.FrostProtection.Min = value;
-                            if (this.logInfo) this.emit('info', `Set frost protection min. temperature: ${value}${this.accessory.temperatureUnit}`);
+                            let { min, max } = await this.functions.adjustTempProtection(deviceData.FrostProtection.Min, deviceData.FrostProtection.Max, value, 'min', 4, 14, 6, 16);
+                            deviceData.FrostProtection.Min = min;
+                            deviceData.FrostProtection.Max = max;
+                            if (this.logInfo) this.emit('info', `Set frost protection min. temperature: ${min}${this.accessory.temperatureUnit}`);
                             await this.melCloudAta.send(this.accountType, this.displayType, deviceData, 'frostprotection');
                         } catch (error) {
                             if (this.logWarn) this.emit('warn', `Set frost protection min. temperature error: ${error}`);
@@ -1169,7 +1173,7 @@ class DeviceAtw extends EventEmitter {
             }
 
             //holiday mode
-            if (this.holidayModeSupport && this.accessory.holidayModeEnabled !== null) {
+            if (this.holidayModeSupport && this.accessory.holidayMode.Enabled !== null) {
                 //control
                 if (this.logDebug) this.emit('debug', `Prepare holiday mode control service`);
                 this.holidayModeControlService = new Service.Switch(`${serviceName} Holiday Mode`, `holidayModeControlService${deviceId}`);
@@ -1177,7 +1181,7 @@ class DeviceAtw extends EventEmitter {
                 this.holidayModeControlService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Holiday Mode`);
                 this.holidayModeControlService.getCharacteristic(Characteristic.On)
                     .onGet(async () => {
-                        const state = this.accessory.holidayModeEnabled;
+                        const state = this.accessory.holidayMode.Enabled;
                         return state;
                     })
                     .onSet(async (state) => {
@@ -1197,7 +1201,7 @@ class DeviceAtw extends EventEmitter {
                 this.holidayModeControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Holiday Mode Control`);
                 this.holidayModeControlSensorService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.holidayModeEnabled;
+                        const state = this.accessory.holidayMode.Enabled;
                         return state;
                     })
                 accessory.addService(this.holidayModeControlSensorService);
@@ -1209,7 +1213,7 @@ class DeviceAtw extends EventEmitter {
                 this.holidayModeSensorService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Holiday Mode State`);
                 this.holidayModeSensorService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.holidayModeActive;
+                        const state = this.accessory.holidayMode.Active;
                         return state;
                     })
                 accessory.addService(this.holidayModeSensorService);
@@ -1672,12 +1676,10 @@ class DeviceAtw extends EventEmitter {
                     const scheduleEnabled = deviceData.ScheduleEnabled;
                     const schedulesOnServer = deviceData.Schedule ?? [];
                     const scenesOnServer = deviceData.Scenes ?? [];
-                    const holidayMode = deviceData.Device.HolidayMode;
-                    const holidayModeEnabled = accountTypeMelcloud ? holidayMode : deviceData.HolidayMode?.Enabled;
-                    const holidayModeActive = deviceData.HolidayMode?.Active ?? false;
 
                     //protection
                     const frostProtection = deviceData.FrostProtection ?? {};
+                    const holidayMode = deviceData.HolidayMode ?? {};
 
                     //device info
                     const supportsStanbyMode = deviceData.Device[supportStandbyKey];
@@ -1759,7 +1761,10 @@ class DeviceAtw extends EventEmitter {
                     const obj = {
                         presets: presetsOnServer,
                         schedules: schedulesOnServer,
+                        scheduleEnabled: scheduleEnabled,
                         scenes: scenesOnServer,
+                        frostProtection: frostProtection,
+                        holidayMode: holidayMode,
                         power: power,
                         inStandbyMode: inStandbyMode,
                         unitStatus: unitStatus,
@@ -1786,11 +1791,6 @@ class DeviceAtw extends EventEmitter {
                         temperatureUnit: TemperatureDisplayUnits[this.accountInfo.useFahrenheit ? 1 : 0],
                         isConnected: isConnected,
                         isInError: isInError,
-                        frostProtection: frostProtection,
-                        scheduleEnabled: scheduleEnabled,
-                        holidayModeEnabled: holidayModeEnabled,
-                        holidayModeActive: holidayModeActive,
-                        scheduleEnabled: scheduleEnabled,
                         zones: [],
                         zonesSensors: []
                     };
@@ -2189,7 +2189,7 @@ class DeviceAtw extends EventEmitter {
                     if (this.frostProtectionSupport && frostProtection.Enabled !== null) {
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.Active, frostProtection.Enabled);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.CurrentHeaterCoolerState, frostProtection.Active ? 2 : 1);
-                        this.frostProtectionControlService?.updateCharacteristic(Characteristic.TargetHeaterCoolerState, frostProtection.Active ? 2 : 1);
+                        this.frostProtectionControlService?.updateCharacteristic(Characteristic.TargetHeaterCoolerState, 0);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.CoolingThresholdTemperature, frostProtection.Max);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.HeatingThresholdTemperature, frostProtection.Min);
@@ -2198,10 +2198,10 @@ class DeviceAtw extends EventEmitter {
                     }
 
                     //holiday mode
-                    if (this.holidayModeSupport && holidayModeEnabled !== null) {
-                        this.holidayModeControlService?.updateCharacteristic(Characteristic.On, holidayModeEnabled);
-                        this.holidayModeControlSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayModeEnabled);
-                        this.holidayModeSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayModeActive);
+                    if (this.holidayModeSupport && holidayMode.Enabled !== null) {
+                        this.holidayModeControlService?.updateCharacteristic(Characteristic.On, holidayMode.Enabled);
+                        this.holidayModeControlSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayMode.Enabled);
+                        this.holidayModeSensorService?.updateCharacteristic(Characteristic.ContactSensorState, holidayMode.Active);
                     }
 
                     //presets
@@ -2286,7 +2286,7 @@ class DeviceAtw extends EventEmitter {
                                     button.state = power ? (operationMode === 1) : false;
                                     break;
                                 case 53: //HOLIDAY
-                                    button.state = power ? (holidayModeEnabled === true) : false;
+                                    button.state = power ? (holidayMode.Enabled === true) : false;
                                     break;
                                 case 10: //ALL ZONES PHYSICAL LOCK CONTROL
                                     button.state = power ? (prohibitZone1 === true && prohibitHotWater === true && prohibitZone2 === true) : false;

package/src/functions.js

@@ -238,28 +238,44 @@ class Functions extends EventEmitter {
         );
     }
 
-    async adjustTempProtection(oldMin, oldMax, newValue, type, minRangeMin, maxRangeMin, minRangeMax, maxRangeMax) {
-        let min = oldMin;
-        let max = oldMax;
+    async adjustTempProtection(currentMin, currentMax, value, type, minRangeMin, maxRangeMin, minRangeMax, maxRangeMax) {
+        let min = currentMin;
+        let max = currentMax;
 
         if (type === "min") {
-            // użytkownik zmienia MIN
-            min = Math.min(Math.max(newValue, minRangeMin), maxRangeMin);
+            min = Math.min(Math.max(value, minRangeMin), maxRangeMin);
 
-            // jeśli różnica jest za mała → podnieś MAX
-            if (max - min < 2) {
+            if (min > currentMin && max - min < 2) {
                 max = Math.min(min + 2, maxRangeMax);
+
+                // jeśli max uderza w górną granicę → obniż min o 2
+                if (max === maxRangeMax && max - min < 2) {
+                    min = Math.max(min - 2, minRangeMin);
+                }
+
+                return { min, max };
             }
+
+            // min maleje → zwracamy tylko min
+            return { min, max };
         }
 
         if (type === "max") {
-            // użytkownik zmienia MAX
-            max = Math.min(Math.max(newValue, minRangeMax), maxRangeMax);
+            max = Math.min(Math.max(value, minRangeMax), maxRangeMax);
 
-            // jeśli różnica jest za mała → obniż MIN
-            if (max - min < 2) {
+            if (max < currentMax && max - min < 2) {
                 min = Math.max(max - 2, minRangeMin);
+
+                // jeśli min uderza w dolną granicę → podbij max o 2
+                if (min === minRangeMin && max - min < 2) {
+                    max = Math.min(max + 2, maxRangeMax);
+                }
+
+                return { min, max };
             }
+
+            // max rośnie → zwracamy tylko max
+            return { min, max };
         }
 
         return { min, max };

package/src/melcloudata.js

@@ -24,6 +24,7 @@ class MelCloudAta extends EventEmitter {
         //set default values
         this.deviceData = {};
         this.client = melcloud.client;
+        this.lock = false;
 
         //handle melcloud events
         let deviceData = null;
@@ -196,6 +197,7 @@ class MelCloudAta extends EventEmitter {
             let method = null
             let payload = {};
             let path = '';
+            let update = false;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {
@@ -248,6 +250,7 @@ class MelCloudAta extends EventEmitter {
                             };
                             method = 'POST';
                             path = ApiUrlsHome.PostProtectionFrost;
+                            update = true;
                             break;
                         case 'overheatprotection':
                             payload = {
@@ -258,6 +261,7 @@ class MelCloudAta extends EventEmitter {
                             };
                             method = 'POST';
                             path = ApiUrlsHome.PostProtectionOverheat;
+                            update = true;
                             break;
                         case 'holidaymode':
                             payload = {
@@ -273,6 +277,7 @@ class MelCloudAta extends EventEmitter {
                             payload = { enabled: deviceData.ScheduleEnabled };
                             method = 'PUT';
                             path = ApiUrlsHome.PutScheduleEnabled.replace('deviceid', deviceData.DeviceID);
+                            update = true;
                             break;
                         case 'scene':
                             method = 'PUT';
@@ -309,7 +314,12 @@ class MelCloudAta extends EventEmitter {
                     //send payload
                     if (this.logDebug) this.emit('debug', `Send data: ${JSON.stringify(payload, null, 2)}`);
                     await this.client(path, { method: method, data: payload });
-                    this.update(deviceData);
+
+                    if (update) {
+                        setTimeout(() => {
+                            this.emit('deviceState', deviceData);
+                        }, 500);
+                    }
 
                     return true;
                 default:
@@ -319,12 +329,6 @@ class MelCloudAta extends EventEmitter {
             throw new Error(`Send data error: ${error.message}`);
         }
     }
-
-    update(deviceData) {
-        setTimeout(() => {
-            this.emit('deviceState', deviceData)
-        }, 500);
-    }
 }
 
 export default MelCloudAta;

package/src/melcloudatw.js

@@ -197,6 +197,7 @@ class MelCloudAtw extends EventEmitter {
             let method = null
             let payload = {};
             let path = '';
+            let update = false;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {
@@ -241,6 +242,17 @@ class MelCloudAtw extends EventEmitter {
                     return true;
                 case "melcloudhome":
                     switch (flag) {
+                        case 'frostprotection':
+                            payload = {
+                                enabled: deviceData.FrostProtection.Enabled,
+                                min: deviceData.FrostProtection.Min,
+                                max: deviceData.FrostProtection.Max,
+                                units: { ATA: [deviceData.DeviceID] }
+                            };
+                            method = 'POST';
+                            path = ApiUrlsHome.PostProtectionFrost;
+                            update = true;
+                            break;
                         case 'holidaymode':
                             payload = {
                                 enabled: deviceData.HolidayMode.Enabled,
@@ -255,6 +267,7 @@ class MelCloudAtw extends EventEmitter {
                             payload = { enabled: deviceData.ScheduleEnabled };
                             method = 'PUT';
                             path = ApiUrlsHome.PutScheduleEnabled.replace('deviceid', deviceData.DeviceID);
+                            update = true;
                             break;
                         case 'scene':
                             method = 'PUT';
@@ -284,6 +297,12 @@ class MelCloudAtw extends EventEmitter {
                     if (this.logDebug) this.emit('debug', `Send data: ${JSON.stringify(payload, null, 2)}`);
                     await this.client(path, { method: method, data: payload });
 
+                    if (update) {
+                        setTimeout(() => {
+                            this.emit('deviceState', deviceData);
+                        }, 500);
+                    }
+
                     return true;
                 default:
                     return;