homebridge-melcloud-control 4.4.0-beta.8 → 4.4.0

package/CHANGELOG.md

@@ -28,13 +28,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - added possibility to set frost protection min/max temperaure (ATA, ATW)
 - added possibility to set overheat protection min/max temperture (ATA)
-- bump dependencies
-- cleanup
-
-# [4.3.16] - (09.12.2025)
-
-## Changes
-
 - stability and performance improvements
 - moved MQTT to v5
 - bump dependencies

package/index.js

@@ -90,7 +90,7 @@ class MelCloudPlatform {
 										melcloud = new MelCloud(account, accountFile, buildingsFile, true);
 										break;
 									case 'melcloudhome':
-										timmers = [{ name: 'connect', sampling: 3300000 }, { name: 'checkDevicesList', sampling: 3000 }];
+										timmers = [{ name: 'connect', sampling: 3300000 }, { name: 'checkDevicesList', sampling: 5000 }];
 										melcloud = new MelCloudHome(account, accountFile, buildingsFile, true);
 										break;
 									default:

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.4.0-beta.8",
+  "version": "4.4.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceatw.js

@@ -1115,8 +1115,10 @@ class DeviceAtw extends EventEmitter {
                     })
                     .onSet(async (value) => {
                         try {
-                            deviceData.FrostProtection.Max = value;
-                            if (this.logInfo) this.emit('info', `Set frost protection max. temperature: ${value}${this.accessory.temperatureUnit}`);
+                            let { min, max } = await this.functions.adjustTempProtection(deviceData.FrostProtection.Min, deviceData.FrostProtection.Max, value, 'max', 4, 14, 6, 16);
+                            deviceData.FrostProtection.Min = min;
+                            deviceData.FrostProtection.Max = max;
+                            if (this.logInfo) this.emit('info', `Set frost protection max. temperature: ${max}${this.accessory.temperatureUnit}`);
                             await this.melCloudAta.send(this.accountType, this.displayType, deviceData, 'frostprotection');
                         } catch (error) {
                             if (this.logWarn) this.emit('warn', `Set frost protection max. temperature error: ${error}`);
@@ -1134,8 +1136,10 @@ class DeviceAtw extends EventEmitter {
                     })
                     .onSet(async (value) => {
                         try {
-                            deviceData.FrostProtection.Min = value;
-                            if (this.logInfo) this.emit('info', `Set frost protection min. temperature: ${value}${this.accessory.temperatureUnit}`);
+                            let { min, max } = await this.functions.adjustTempProtection(deviceData.FrostProtection.Min, deviceData.FrostProtection.Max, value, 'min', 4, 14, 6, 16);
+                            deviceData.FrostProtection.Min = min;
+                            deviceData.FrostProtection.Max = max;
+                            if (this.logInfo) this.emit('info', `Set frost protection min. temperature: ${min}${this.accessory.temperatureUnit}`);
                             await this.melCloudAta.send(this.accountType, this.displayType, deviceData, 'frostprotection');
                         } catch (error) {
                             if (this.logWarn) this.emit('warn', `Set frost protection min. temperature error: ${error}`);
@@ -2189,7 +2193,7 @@ class DeviceAtw extends EventEmitter {
                     if (this.frostProtectionSupport && frostProtection.Enabled !== null) {
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.Active, frostProtection.Enabled);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.CurrentHeaterCoolerState, frostProtection.Active ? 2 : 1);
-                        this.frostProtectionControlService?.updateCharacteristic(Characteristic.TargetHeaterCoolerState, frostProtection.Active ? 2 : 1);
+                        this.frostProtectionControlService?.updateCharacteristic(Characteristic.TargetHeaterCoolerState, 0);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.CoolingThresholdTemperature, frostProtection.Max);
                         this.frostProtectionControlService?.updateCharacteristic(Characteristic.HeatingThresholdTemperature, frostProtection.Min);

package/src/functions.js

@@ -237,38 +237,45 @@ class Functions extends EventEmitter {
             })
         );
     }
+
     async adjustTempProtection(oldMin, oldMax, newValue, type, minRangeMin, maxRangeMin, minRangeMax, maxRangeMax) {
         let min = oldMin;
         let max = oldMax;
 
         if (type === "min") {
-            // clamp MIN
             min = Math.min(Math.max(newValue, minRangeMin), maxRangeMin);
 
-            // ensure difference → raise max if needed
-            if (max - min < 2) {
+            if (min > oldMin && max - min < 2) {
                 max = Math.min(min + 2, maxRangeMax);
-            }
 
-            // if still too small difference → lower min
-            if (max - min < 2) {
-                min = Math.max(max - 2, minRangeMin);
+                // jeśli max uderza w górną granicę → obniż min o 2
+                if (max === maxRangeMax && max - min < 2) {
+                    min = Math.max(min - 2, minRangeMin);
+                }
+
+                return { min, max };
             }
+
+            // min maleje → zwracamy tylko min
+            return { min, max };
         }
 
         if (type === "max") {
-            // clamp MAX
             max = Math.min(Math.max(newValue, minRangeMax), maxRangeMax);
 
-            // ensure difference → lower min if needed
-            if (max - min < 2) {
+            if (max < oldMax && max - min < 2) {
                 min = Math.max(max - 2, minRangeMin);
-            }
 
-            // if still too small difference → raise max
-            if (max - min < 2) {
-                max = Math.min(min + 2, maxRangeMax);
+                // jeśli min uderza w dolną granicę → podbij max o 2
+                if (min === minRangeMin && max - min < 2) {
+                    max = Math.min(max + 2, maxRangeMax);
+                }
+
+                return { min, max };
             }
+
+            // max rośnie → zwracamy tylko max
+            return { min, max };
         }
 
         return { min, max };

package/src/melcloudata.js

@@ -24,6 +24,7 @@ class MelCloudAta extends EventEmitter {
         //set default values
         this.deviceData = {};
         this.client = melcloud.client;
+        this.lock = false;
 
         //handle melcloud events
         let deviceData = null;
@@ -196,6 +197,7 @@ class MelCloudAta extends EventEmitter {
             let method = null
             let payload = {};
             let path = '';
+            let update = false;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {
@@ -248,6 +250,7 @@ class MelCloudAta extends EventEmitter {
                             };
                             method = 'POST';
                             path = ApiUrlsHome.PostProtectionFrost;
+                            update = true;
                             break;
                         case 'overheatprotection':
                             payload = {
@@ -258,6 +261,7 @@ class MelCloudAta extends EventEmitter {
                             };
                             method = 'POST';
                             path = ApiUrlsHome.PostProtectionOverheat;
+                            update = true;
                             break;
                         case 'holidaymode':
                             payload = {
@@ -273,6 +277,7 @@ class MelCloudAta extends EventEmitter {
                             payload = { enabled: deviceData.ScheduleEnabled };
                             method = 'PUT';
                             path = ApiUrlsHome.PutScheduleEnabled.replace('deviceid', deviceData.DeviceID);
+                            update = true;
                             break;
                         case 'scene':
                             method = 'PUT';
@@ -309,7 +314,12 @@ class MelCloudAta extends EventEmitter {
                     //send payload
                     if (this.logDebug) this.emit('debug', `Send data: ${JSON.stringify(payload, null, 2)}`);
                     await this.client(path, { method: method, data: payload });
-                    this.update(deviceData);
+
+                    if (update) {
+                        setTimeout(() => {
+                            this.emit('deviceState', deviceData);
+                        }, 500);
+                    }
 
                     return true;
                 default:
@@ -319,12 +329,6 @@ class MelCloudAta extends EventEmitter {
             throw new Error(`Send data error: ${error.message}`);
         }
     }
-
-    update(deviceData) {
-        setTimeout(() => {
-            this.emit('deviceState', deviceData)
-        }, 500);
-    }
 }
 
 export default MelCloudAta;

package/src/melcloudatw.js

@@ -197,6 +197,7 @@ class MelCloudAtw extends EventEmitter {
             let method = null
             let payload = {};
             let path = '';
+            let update = false;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {
@@ -241,6 +242,17 @@ class MelCloudAtw extends EventEmitter {
                     return true;
                 case "melcloudhome":
                     switch (flag) {
+                        case 'frostprotection':
+                            payload = {
+                                enabled: deviceData.FrostProtection.Enabled,
+                                min: deviceData.FrostProtection.Min,
+                                max: deviceData.FrostProtection.Max,
+                                units: { ATA: [deviceData.DeviceID] }
+                            };
+                            method = 'POST';
+                            path = ApiUrlsHome.PostProtectionFrost;
+                            update = true;
+                            break;
                         case 'holidaymode':
                             payload = {
                                 enabled: deviceData.HolidayMode.Enabled,
@@ -255,6 +267,7 @@ class MelCloudAtw extends EventEmitter {
                             payload = { enabled: deviceData.ScheduleEnabled };
                             method = 'PUT';
                             path = ApiUrlsHome.PutScheduleEnabled.replace('deviceid', deviceData.DeviceID);
+                            update = true;
                             break;
                         case 'scene':
                             method = 'PUT';
@@ -284,6 +297,12 @@ class MelCloudAtw extends EventEmitter {
                     if (this.logDebug) this.emit('debug', `Send data: ${JSON.stringify(payload, null, 2)}`);
                     await this.client(path, { method: method, data: payload });
 
+                    if (update) {
+                        setTimeout(() => {
+                            this.emit('deviceState', deviceData);
+                        }, 500);
+                    }
+
                     return true;
                 default:
                     return;