homebridge-melcloud-control 4.3.9-beta.8 → 4.3.9

package/CHANGELOG.md

@@ -22,6 +22,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Do not use Homebridge UI > v5.5.0 because of break config.json
 
+# [4.3.9] - (01.12.2025)
+
+## Changes
+
+- stability and performance improvements
+- fix vane H/V display wrong state
+- cleanup
+
 # [4.3.8] - (29.11.2025)
 
 ## Changes

package/index.js

@@ -140,7 +140,7 @@ class MelCloudPlatform {
 									//chack device is not disabled in config
 									const displayType = device.displayType > 0;
 									if (!displayType) {
-										if (logLevel.warn) log.warn(`${accountName}, ${deviceTypeString}, ${deviceName}, disabled in config, will not be published in Home app.`);
+										if (logLevel.warn) log.warn(`${accountName}, ${deviceTypeString}, ${deviceName}, disabled in configuration, will not be published in the Home app.`);
 										continue;
 									}
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.9-beta.8",
+  "version": "4.3.9",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/constants.js

@@ -58,15 +58,21 @@ export const TemperatureDisplayUnits = ["°C", "°F"];
 
 export const AirConditioner = {
     SystemMapEnumToString: { 0: "Air Conditioner Off", 1: "Air Conditioner On", 2: "Air Conditioner Offline" },
-    OperationModeMapStringToEnum: { "0": 0, "Heat": 1, "Dry": 2, "Cool": 3, "4": 7, "5": 8, "6": 6, "Fan": 7, "Automatic": 8, "Isee Heat": 9, "Isee Dry": 10, "Isee Cool": 11 },
+    OperationModeMapStringToEnum: { "0": 0, "Heat": 1, "Dry": 2, "Cool": 3, "4": 4, "5": 5, "6": 6, "Fan": 7, "Automatic": 8, "Isee Heat": 9, "Isee Dry": 10, "Isee Cool": 11 },
     OperationModeMapEnumToString: { 0: "0", 1: "Heat", 2: "Dry", 3: "Cool", 4: "4", 5: "5", 6: "6", 7: "Fan", 8: "Automatic", 9: "Isee Heat", 10: "Isee Dry", 11: "Isee Cool" },
-    FanSpeedMapStringToEnum: { "Auto": 0, "One": 1, "Two": 2, "Three": 3, "Four": 4, "Five": 5 },
+    OperationModeMapEnumToEnumWs: { 0: 0, 1: 1, 2: 2, 3: 3, 4: 7, 5: 8, 6: 9, 7: 10, 8: 11 },
+    FanSpeedMapStringToEnum: { "Auto": 0, "One": 1, "Two": 2, "Three": 3, "Four": 4, "Five": 5, "0": 0, "1": 1, "2": 2, "3": 3, "4": 4, "5": 5 },
     FanSpeedMapEnumToString: { 0: "Auto", 1: "One", 2: "Two", 3: "Three", 4: "Four", 5: "Five" },
+    SetFanSpeedMapStringToEnum: { "Auto": 0, "One": 1, "Two": 2, "Three": 3, "Four": 4, "Five": 5, "0": 0, "1": 1, "2": 2, "3": 3, "4": 4, "5": 5 },
+    SetFanSpeedMapEnumToString: { 0: "Auto", 1: "One", 2: "Two", 3: "Three", 4: "Four", 5: "Five" },
+    AktualFanSpeedMapStringToEnum: { "Auto": 0, "One": 1, "Two": 2, "Three": 3, "Four": 4, "Five": 5, "0": 0, "1": 1, "2": 2, "3": 3, "4": 4, "5": 5 },
     AktualFanSpeedMapEnumToString: { 0: "Quiet", 1: "One", 2: "Two", 3: "Three", 4: "Four", 5: "Five" },
     VaneVerticalDirectionMapStringToEnum: { "Auto": 0, "One": 1, "Two": 2, "Three": 3, "Four": 4, "Five": 5, "Six": 6, "Swing": 7 },
     VaneVerticalDirectionMapEnumToString: { 0: "Auto", 1: "One", 2: "Two", 3: "Three", 4: "Four", 5: "Five", 6: "Six", 7: "Swing" },
+    VaneVerticalDirectionMapEnumToEnumWs: { 6: 7 },
     VaneHorizontalDirectionMapStringToEnum: { "Auto": 0, "Left": 1, "LeftCentre": 2, "Centre": 3, "RightCentre": 4, "Right": 5, "Six": 6, "Seven": 7, "Split": 8, "Nine": 9, "Ten": 10, "Eleven": 11, "Swing": 12 },
     VaneHorizontalDirectionMapEnumToString: { 0: "Auto", 1: "Left", 2: "LeftCentre", 3: "Centre", 4: "RightCentre", 5: "Right", 6: "Six", 7: "Seven", 8: "Split", 9: "Nine", 10: "Ten", 11: "Eleven", 12: "Swing" },
+    VaneHorizontalDirectionMapEnumToEnumWs: { 7: 12 },
     AirDirectionMapEnumToString: { 0: "Auto", 1: "Swing" },
     CurrentOperationModeMapEnumToStringHeatherCooler: { 0: "Inactive", 1: "Idle", 2: "Heating", 3: "Cooling" },
     CurrentOperationModeMapEnumToStringThermostat: { 0: "Inactive", 1: "Heating", 2: "Cooling" },

package/src/deviceata.js

@@ -439,7 +439,8 @@ class DeviceAta extends EventEmitter {
                     if (supportsSwingFunction) {
                         melCloudService.getCharacteristic(Characteristic.SwingMode)
                             .onGet(async () => {
-                                //Vane Horizontal: Auto, 1, 2, 3, 4, 5, 6, 7 = Sp;it, 12 = Swing //Vertical: Auto, 1, 2, 3, 4, 5, 7 = Swing
+                                //Vane Horizontal: Auto, 1, 2, 3, 4, 5, 6, 7 = Split, 12 = Swing //Vertical: Auto, 1, 2, 3, 4, 5, 7 = Swing
+                                //Home Vane Horizontal: Auto, 1, 2, 3, 4, 5, 6, 7 = Swing, 8 = Split //Vertical: Auto, 1, 2, 3, 4, 5, 6 = Swing
                                 const value = this.accessory.currentSwingMode;
                                 return value;
                             })
@@ -1396,11 +1397,11 @@ class DeviceAta extends EventEmitter {
                     const supportsDry = deviceData.Device[supportDryKey];
                     const supportsCool1 = deviceData.Device[supportCoolKey];
                     const supportsCool = this.coolDryFanMode >= 1 && supportsCool1;
-                    const numberOfFanSpeeds = supportsFanSpeed ? deviceData.Device.NumberOfFanSpeeds : 0;
-                    const minTempHeat = 10;
-                    const maxTempHeat = 31;
-                    const minTempCoolDryAuto = 16;
-                    const maxTempCoolDryAuto = 31;
+                    const numberOfFanSpeeds = deviceData.Device.NumberOfFanSpeeds;
+                    const minTempHeat = deviceData.Device.MinTempHeat ?? 10;
+                    const maxTempHeat = deviceData.Device.MaxTempHeat ?? 31;
+                    const minTempCoolDryAuto = deviceData.Device.MinTempAutomatic ?? 16;
+                    const maxTempCoolDryAuto = deviceData.Device.MaxTempAutomatic ?? 31;
 
                     //device state
                     const power = deviceData.Device.Power ?? false;

package/src/melcloudata.js

@@ -24,18 +24,23 @@ class MelCloudAta extends EventEmitter {
 
         //set default values
         this.deviceData = {};
-        this.headers = {}
+        this.headers = {};
 
         //handle melcloud events
         let deviceData = null;
         melcloud.on('devicesList', async (devicesData) => {
-            this.headers = devicesData.Headers;
-            deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
-            if (!deviceData) return;
-            deviceData.Scenes = devicesData.Scenes ?? [];
+            try {
+                this.headers = devicesData.Headers;
+                deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+                if (!deviceData) return;
+                deviceData.Scenes = devicesData.Scenes ?? [];
 
-            //update state
-            await this.updateState(deviceData);
+                //update state
+                if (this.logDebug) this.emit('debug', `Request update settings: ${JSON.stringify(deviceData.Device, null, 2)}`);
+                await this.updateState(deviceData);
+            } catch (error) {
+                if (this.logError) this.emit('error', `Request process message error: ${error}`);
+            }
         }).on('webSocket', async (parsedMessage) => {
             try {
                 const messageData = parsedMessage?.[0]?.Data;
@@ -65,6 +70,8 @@ class MelCloudAta extends EventEmitter {
                                         deviceData.Device[key] = value;
                                     }
                                 }
+
+                                if (this.logDebug) this.emit('debug', `WS update settings: ${JSON.stringify(deviceData.Device, null, 2)}`);
                                 updateState = true;
                                 break;
                             case 'unitHolidayModeTriggered':
@@ -78,31 +85,38 @@ class MelCloudAta extends EventEmitter {
                                 updateState = true;
                                 break;
                             default:
-                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${parsedMessage}`);
                                 return;
                         }
                         break;
                     default:
-                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${parsedMessage}`);
                         return;
                 }
 
                 //update state
-                if (updateState) await this.updateState(deviceData);
+                if (updateState) await this.updateState(deviceData, 'ws');
             } catch (error) {
                 if (this.logError) this.emit('error', `Web socket process message error: ${error}`);
             }
         });
     }
 
-    async updateState(deviceData) {
+    async updateState(deviceData, type) {
         try {
             if (this.accountType === 'melcloudhome') {
-                deviceData.Device.OperationMode = AirConditioner.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
-                deviceData.Device.ActualFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.ActualFanSpeed] ?? deviceData.Device.ActualFanSpeed;
-                deviceData.Device.SetFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.SetFanSpeed] ?? deviceData.Device.SetFanSpeed;
-                deviceData.Device.VaneHorizontalDirection = AirConditioner.VaneHorizontalDirectionMapStringToEnum[deviceData.Device.VaneHorizontalDirection] ?? deviceData.Device.VaneHorizontalDirection
-                deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapStringToEnum[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
+
+                if (type === 'ws') {
+                    deviceData.Device.OperationMode = AirConditioner.OperationModeMapEnumToEnumWs[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
+                    deviceData.Device.VaneHorizontalDirection = AirConditioner.VaneHorizontalDirectionMapEnumToEnumWs[deviceData.Device.VaneHorizontalDirection] ?? deviceData.Device.VaneHorizontalDirection;
+                    deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapEnumToEnumWs[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
+                } else {
+                    deviceData.Device.OperationMode = AirConditioner.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
+                    deviceData.Device.ActualFanSpeed = AirConditioner.AktualFanSpeedMapStringToEnum[deviceData.Device.ActualFanSpeed] ?? deviceData.Device.ActualFanSpeed;
+                    deviceData.Device.SetFanSpeed = AirConditioner.SetFanSpeedMapStringToEnum[deviceData.Device.SetFanSpeed] ?? deviceData.Device.SetFanSpeed;
+                    deviceData.Device.VaneHorizontalDirection = AirConditioner.VaneHorizontalDirectionMapStringToEnum[deviceData.Device.VaneHorizontalDirection] ?? deviceData.Device.VaneHorizontalDirection;
+                    deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapStringToEnum[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
+                }
 
                 //read default temps
                 const temps = await this.functions.readData(this.defaultTempsFile, true);
@@ -224,7 +238,7 @@ class MelCloudAta extends EventEmitter {
                     }
 
                     if (this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
-                    
+
                     await axios(path, {
                         method: 'POST',
                         baseURL: ApiUrls.BaseURL,
@@ -313,7 +327,7 @@ class MelCloudAta extends EventEmitter {
                     //sens payload
                     headers['Content-Type'] = 'application/json; charset=utf-8';
                     headers.Origin = ApiUrlsHome.Origin;
-                    if (!this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
+                    if (this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
 
                     await axios(path, {
                         method: method,

package/src/melcloudatw.js

@@ -29,20 +29,20 @@ class MelCloudAtw extends EventEmitter {
         //handle melcloud events
         let deviceData = null;
         melcloud.on('devicesList', async (devicesData) => {
-            this.headers = devicesData.Headers;
-            deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
-            if (!deviceData) return;
-            deviceData.Scenes = devicesData.Scenes ?? [];
-
-            //update state
-            await this.updateState(deviceData);
-        }).on('message', async (message) => {
             try {
-                const parsedMessage = JSON.parse(message);
-                const stringifyMessage = JSON.stringify(parsedMessage, null, 2);
-                if (this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
-                if (parsedMessage.message === 'Forbidden') return;
+                this.headers = devicesData.Headers;
+                deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+                if (!deviceData) return;
+                deviceData.Scenes = devicesData.Scenes ?? [];
 
+                //update state
+                if (this.logDebug) this.emit('debug', `Request update settings: ${JSON.stringify(deviceData.Device, null, 2)}`);
+                await this.updateState(deviceData);
+            } catch (error) {
+                if (this.logError) this.emit('error', `Request process message error: ${error}`);
+            }
+        }).on('webSocket', async (parsedMessage) => {
+            try {
                 const messageData = parsedMessage?.[0]?.Data;
                 if (!messageData || !deviceData) return;
 
@@ -51,15 +51,27 @@ class MelCloudAtw extends EventEmitter {
                 switch (unitId) {
                     case this.deviceId:
                         const messageType = parsedMessage[0].messageType;
+                        const settings = this.functions.parseArrayNameValue(messageData.settings);
                         switch (messageType) {
                             case 'unitStateChanged':
-                                const settings = Object.fromEntries(
-                                    messageData.settings.map(({ name, value }) => {
-                                        let parsedValue = this.functions.convertValue(value);
-                                        return [name, parsedValue];
-                                    })
-                                );
-                                Object.assign(deviceData.Device, settings);
+
+                                //update values
+                                for (const [key, value] of Object.entries(settings)) {
+                                    if (!this.functions.isValidValue(value)) continue;
+
+                                    //update holiday mode
+                                    if (key === 'HolidayMode') {
+                                        deviceData.HolidayMode.Enabled = value;
+                                        continue;
+                                    }
+
+                                    //update device settings
+                                    if (key in deviceData.Device) {
+                                        deviceData.Device[key] = value;
+                                    }
+                                }
+
+                                if (this.logDebug) this.emit('debug', `WS update settings: ${JSON.stringify(deviceData.Device, null, 2)}`);
                                 updateState = true;
                                 break;
                             case 'unitHolidayModeTriggered':
@@ -73,24 +85,24 @@ class MelCloudAtw extends EventEmitter {
                                 updateState = true;
                                 break;
                             default:
-                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${parsedMessage}`);
                                 return;
                         }
                         break;
                     default:
-                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${parsedMessage}`);
                         return;
                 }
 
                 //update state
-                if (updateState) await this.updateState(deviceData);
+                if (updateState) await this.updateState(deviceData, 'ws');
             } catch (error) {
                 if (this.logError) this.emit('error', `Web socket process message error: ${error}`);
             }
         });
     }
 
-    async updateState(deviceData) {
+    async updateState(deviceData, type) {
         try {
             if (this.accountType === 'melcloudhome') {
                 deviceData.Device.OperationMode = HeatPump.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
@@ -228,7 +240,7 @@ class MelCloudAtw extends EventEmitter {
                     }
 
                     if (this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
-                    
+
                     await axios(path, {
                         method: 'POST',
                         baseURL: ApiUrls.BaseURL,

package/src/melclouderv.js

@@ -29,13 +29,18 @@ class MelCloudErv extends EventEmitter {
         //handle melcloud events
         let deviceData = null;
         melcloud.on('devicesList', async (devicesData) => {
-            this.headers = devicesData.Headers;
-            deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
-            if (!deviceData) return;
-            deviceData.Scenes = devicesData.Scenes ?? [];
+            try {
+                this.headers = devicesData.Headers;
+                deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+                if (!deviceData) return;
+                deviceData.Scenes = devicesData.Scenes ?? [];
 
-            //update state
-            await this.updateState(deviceData);
+                //update state
+                if (this.logDebug) this.emit('debug', `Request update settings: ${JSON.stringify(deviceData.Device, null, 2)}`);
+                await this.updateState(deviceData);
+            } catch (error) {
+                if (this.logError) this.emit('error', `Request process message error: ${error}`);
+            }
         }).on('webSocket', async (parsedMessage) => {
             try {
                 const messageData = parsedMessage?.[0]?.Data;
@@ -65,6 +70,8 @@ class MelCloudErv extends EventEmitter {
                                         deviceData.Device[key] = value;
                                     }
                                 }
+
+                                if (this.logDebug) this.emit('debug', `WS update settings: ${JSON.stringify(deviceData.Device, null, 2)}`);
                                 updateState = true;
                                 break;
                             case 'unitHolidayModeTriggered':
@@ -78,24 +85,24 @@ class MelCloudErv extends EventEmitter {
                                 updateState = true;
                                 break;
                             default:
-                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${parsedMessage}`);
                                 return;
                         }
                         break;
                     default:
-                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${parsedMessage}`);
                         return;
                 }
 
                 //update state
-                if (updateState) await this.updateState(deviceData);
+                if (updateState) await this.updateState(deviceData, 'ws');
             } catch (error) {
                 if (this.logError) this.emit('error', `Web socket process message error: ${error}`);
             }
         });
     }
 
-    async updateState(deviceData) {
+    async updateState(deviceData, type) {
         try {
             if (this.accountType === 'melcloudhome') {
                 //read default temps
@@ -233,7 +240,7 @@ class MelCloudErv extends EventEmitter {
                     }
 
                     if (this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
-                    
+
                     await axios(path, {
                         method: 'POST',
                         baseURL: ApiUrls.BaseURL,

package/src/melcloudhome.js

@@ -135,24 +135,13 @@ class MelCloudHome extends EventEmitter {
 
             const devices = buildingsList.flatMap(building => {
                 // Funkcja kapitalizująca klucze obiektu
-                const capitalizeKeys = obj =>
-                    Object.fromEntries(
-                        Object.entries(obj).map(([key, value]) => [
-                            key.charAt(0).toUpperCase() + key.slice(1),
-                            value
-                        ])
-                    );
+                const capitalizeKeys = obj => Object.fromEntries(Object.entries(obj).map(([key, value]) => [key.charAt(0).toUpperCase() + key.slice(1), value]));
 
                 // Rekurencyjna kapitalizacja kluczy w obiekcie lub tablicy
                 const capitalizeKeysDeep = obj => {
                     if (Array.isArray(obj)) return obj.map(capitalizeKeysDeep);
                     if (obj && typeof obj === 'object') {
-                        return Object.fromEntries(
-                            Object.entries(obj).map(([key, value]) => [
-                                key.charAt(0).toUpperCase() + key.slice(1),
-                                capitalizeKeysDeep(value)
-                            ])
-                        );
+                        return Object.fromEntries(Object.entries(obj).map(([key, value]) => [key.charAt(0).toUpperCase() + key.slice(1), capitalizeKeysDeep(value)]));
                     }
                     return obj;
                 };
@@ -252,7 +241,7 @@ class MelCloudHome extends EventEmitter {
                         })
                         .on('message', (message) => {
                             const parsedMessage = JSON.parse(message);
-                            if (!this.logDebug) this.emit('debug', `Incoming message: ${JSON.stringify(parsedMessage, null, 2)}`);
+                            if (this.logDebug) this.emit('debug', `Incoming message: ${JSON.stringify(parsedMessage, null, 2)}`);
                             if (parsedMessage.message === 'Forbidden') return;
 
                             this.emit('webSocket', parsedMessage);