homebridge-melcloud-control 4.3.9-beta.5 → 4.3.9-beta.7

package/homebridge-ui/public/index.html

@@ -255,15 +255,15 @@
           if (device.Type === 3) devicesInMelCloudByType.erv.push(device);
         });
 
-        account.ataDevices = (account.ataDevices ?? []).filter(d => String(d.id) !== "0");
-        account.atwDevices = (account.atwDevices ?? []).filter(d => String(d.id) !== "0");
-        account.ervDevices = (account.ervDevices ?? []).filter(d => String(d.id) !== "0");
+        account.ataDevices = (account.ataDevices ?? []).filter(d => String(d.id) !== '0');
+        account.atwDevices = (account.atwDevices ?? []).filter(d => String(d.id) !== '0');
+        account.ervDevices = (account.ervDevices ?? []).filter(d => String(d.id) !== '0');
 
         const removedAta = removeStaleDevices(account.ataDevices, devicesInMelCloudByType.ata);
         const removedAtw = removeStaleDevices(account.atwDevices, devicesInMelCloudByType.atw);
         const removedErv = removeStaleDevices(account.ervDevices, devicesInMelCloudByType.erv);
 
-        const handleDevices = (devicesInMelCloud, devicesInConfig, typeString, newDevices, newPresets, newSchedules, newScenes) => {
+        const handleDevices = (devicesInMelCloud, devicesInConfig, deviceTypeString, newDevices, newPresets, newSchedules, newScenes) => {
           try {
             const configDevicesMap = new Map(devicesInConfig.map(dev => [String(dev.id), dev]));
 
@@ -276,7 +276,7 @@
                 deviceInConfig = {
                   id: deviceId,
                   type: device.Type,
-                  typeString,
+                  deviceTypeString,
                   displayType: 0,
                   name: device.DeviceName
                 };
@@ -290,10 +290,9 @@
 
                 // === Process presets ===
                 const presetsInMelCloud = device.Presets || [];
-                const presetsInConfig = (deviceInConfig.presets ?? []).filter(p => String(p.id) !== "0");
+                const presetsInConfig = (deviceInConfig.presets ?? []).filter(p => String(p.id) !== '0');
                 const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
 
-                let addedNewPreset = false;
                 presetsInMelCloud.forEach((preset, index) => {
                   const presetId = String(preset.ID);
                   if (!presetIds.has(presetId)) {
@@ -306,20 +305,8 @@
                     presetsInConfig.push(presetObj);
                     newPresets.push(presetObj);
                     presetIds.add(presetId);
-                    addedNewPreset = true;
                   }
                 });
-
-                // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
-                if (addedNewPreset) {
-                  const beforeCount = presetsInConfig.length;
-                  deviceInConfig.presets = presetsInConfig;
-                  const removedCount = beforeCount - deviceInConfig.presets.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder preset from device ${device.DeviceID}`, 'yellow');
-                  }
-                }
               }
 
               //only for melcloudhome
@@ -327,10 +314,9 @@
 
                 // === Process schedules ===
                 const schedulesInMelCloud = device.Schedule || [];
-                const schedulesInConfig = (deviceInConfig.schedules ?? []).filter(s => String(s.id) !== "0");
+                const schedulesInConfig = (deviceInConfig.schedules ?? []).filter(s => String(s.id) !== '0');
                 const scheduleIds = new Set(schedulesInConfig.map(s => String(s.id)));
 
-                let addedNewSchedule = false;
                 schedulesInMelCloud.forEach((schedule, index) => {
                   const scheduleId = String(schedule.Id);
                   if (!scheduleIds.has(scheduleId)) {
@@ -343,26 +329,13 @@
                     schedulesInConfig.push(scheduleObj);
                     newSchedules.push(scheduleObj);
                     scheduleIds.add(scheduleId);
-                    addedNewSchedule = true;
                   }
                 });
 
-                // === Remove placeholder schedules (id === '0') if new ones were added ===
-                if (addedNewSchedule) {
-                  const beforeCount = schedulesInConfig.length;
-                  deviceInConfig.schedules = schedulesInConfig;
-                  const removedCount = beforeCount - deviceInConfig.schedules.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder schedule from device ${device.DeviceID}`, 'yellow');
-                  }
-                }
-
                 // === Process scenes ===
-                const scenesInConfig = (deviceInConfig.scenes ?? []).filter(s => String(s.id) !== "0");
+                const scenesInConfig = (deviceInConfig.scenes ?? []).filter(s => String(s.id) !== '0');
                 const sceneIds = new Set(scenesInConfig.map(s => String(s.id)));
 
-                let addedNewScenes = false;
                 scenesInMelCloud.forEach((scene, index) => {
                   const sceneId = String(scene.Id);
                   if (!sceneIds.has(sceneId)) {
@@ -375,20 +348,8 @@
                     scenesInConfig.push(sceneObj);
                     newScenes.push(sceneObj);
                     sceneIds.add(sceneId);
-                    addedNewScenes = true;
                   }
                 });
-
-                // === Remove placeholder scenes (id === '0') if new ones were added ===
-                if (addedNewScenes) {
-                  const beforeCount = scenesInConfig.length;
-                  deviceInConfig.scenes = scenesInConfig;
-                  const removedCount = beforeCount - deviceInConfig.scenes.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder scene from device ${device.DeviceID}`, 'yellow');
-                  }
-                }
               }
             });
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.9-beta.5",
+  "version": "4.3.9-beta.7",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/melcloudata.js

@@ -110,7 +110,7 @@ class MelCloudAta extends EventEmitter {
                 deviceData.Device.DefaultCoolingSetTemperature = temps?.defaultCoolingSetTemperature ?? 24;
 
             }
-            if (this.logDebug) this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`);
+            if (!this.logDebug) this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`);
 
             //device
             const serialNumber = deviceData.SerialNumber || '4.0.0';
@@ -313,7 +313,7 @@ class MelCloudAta extends EventEmitter {
                     //sens payload
                     headers['Content-Type'] = 'application/json; charset=utf-8';
                     headers.Origin = ApiUrlsHome.Origin;
-                    if (this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
+                    if (!this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);
 
                     await axios(path, {
                         method: method,