homebridge-melcloud-control 4.3.9-beta.3 → 4.3.9-beta.5

package/homebridge-ui/public/index.html

@@ -211,7 +211,7 @@
 
       for (let i = configDevices.length - 1; i >= 0; i--) {
         const device = configDevices[i];
-        if (device.id !== "0" && !melcloudIds.includes(device.id)) {
+        if (!melcloudIds.includes(device.id)) {
           removedDevices.push(device);
           configDevices.splice(i, 1);
         }
@@ -255,9 +255,9 @@
           if (device.Type === 3) devicesInMelCloudByType.erv.push(device);
         });
 
-        account.ataDevices ??= [];
-        account.atwDevices ??= [];
-        account.ervDevices ??= [];
+        account.ataDevices = (account.ataDevices ?? []).filter(d => String(d.id) !== "0");
+        account.atwDevices = (account.atwDevices ?? []).filter(d => String(d.id) !== "0");
+        account.ervDevices = (account.ervDevices ?? []).filter(d => String(d.id) !== "0");
 
         const removedAta = removeStaleDevices(account.ataDevices, devicesInMelCloudByType.ata);
         const removedAtw = removeStaleDevices(account.atwDevices, devicesInMelCloudByType.atw);
@@ -278,11 +278,7 @@
                   type: device.Type,
                   typeString,
                   displayType: 0,
-                  name: device.DeviceName,
-                  presets: [],
-                  schedules: [],
-                  scenes: [],
-                  buttonsSensors: []
+                  name: device.DeviceName
                 };
                 devicesInConfig.push(deviceInConfig);
                 newDevices.push(deviceInConfig);
@@ -294,7 +290,7 @@
 
                 // === Process presets ===
                 const presetsInMelCloud = device.Presets || [];
-                const presetsInConfig = deviceInConfig.presets || [];
+                const presetsInConfig = (deviceInConfig.presets ?? []).filter(p => String(p.id) !== "0");
                 const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
 
                 let addedNewPreset = false;
@@ -317,7 +313,7 @@
                 // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
                 if (addedNewPreset) {
                   const beforeCount = presetsInConfig.length;
-                  deviceInConfig.presets = presetsInConfig.filter(p => String(p.id) !== '0');
+                  deviceInConfig.presets = presetsInConfig;
                   const removedCount = beforeCount - deviceInConfig.presets.length;
 
                   if (removedCount > 0 && removedCount < beforeCount) {
@@ -331,7 +327,7 @@
 
                 // === Process schedules ===
                 const schedulesInMelCloud = device.Schedule || [];
-                const schedulesInConfig = deviceInConfig.schedules || [];
+                const schedulesInConfig = (deviceInConfig.schedules ?? []).filter(s => String(s.id) !== "0");
                 const scheduleIds = new Set(schedulesInConfig.map(s => String(s.id)));
 
                 let addedNewSchedule = false;
@@ -354,7 +350,7 @@
                 // === Remove placeholder schedules (id === '0') if new ones were added ===
                 if (addedNewSchedule) {
                   const beforeCount = schedulesInConfig.length;
-                  deviceInConfig.schedules = schedulesInConfig.filter(s => String(s.id) !== '0');
+                  deviceInConfig.schedules = schedulesInConfig;
                   const removedCount = beforeCount - deviceInConfig.schedules.length;
 
                   if (removedCount > 0 && removedCount < beforeCount) {
@@ -363,7 +359,7 @@
                 }
 
                 // === Process scenes ===
-                const scenesInConfig = deviceInConfig.scenes || [];
+                const scenesInConfig = (deviceInConfig.scenes ?? []).filter(s => String(s.id) !== "0");
                 const sceneIds = new Set(scenesInConfig.map(s => String(s.id)));
 
                 let addedNewScenes = false;
@@ -386,7 +382,7 @@
                 // === Remove placeholder scenes (id === '0') if new ones were added ===
                 if (addedNewScenes) {
                   const beforeCount = scenesInConfig.length;
-                  deviceInConfig.scenes = scenesInConfig.filter(s => String(s.id) !== '0');
+                  deviceInConfig.scenes = scenesInConfig;
                   const removedCount = beforeCount - deviceInConfig.scenes.length;
 
                   if (removedCount > 0 && removedCount < beforeCount) {
@@ -397,8 +393,7 @@
             });
 
             // Return filtered devicesInConfig to make sure upstream code uses it
-            const filteredDevices = devicesInConfig.filter(d => String(d.id) !== '0');
-            return filteredDevices;
+            return devicesInConfig;
           } catch (error) {
             updateInfo('info', `Error while processing device: ${JSON.stringify(error)}`, 'red');
           }
@@ -433,7 +428,7 @@
         updateInfo('info', `Prepare config error ${JSON.stringify(error)}`, 'red');
         document.getElementById('logIn').className = "btn btn-secondary";
       } finally {
-        //document.getElementById('logIn').className = "btn btn-secondary";
+        document.getElementById('logIn').className = "btn btn-secondary";
         homebridge.hideSpinner();
       }
     });

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.9-beta.3",
+  "version": "4.3.9-beta.5",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",