homebridge-melcloud-control 4.3.6 → 4.3.7-beta.0

package/index.js

@@ -45,6 +45,7 @@ class MelCloudPlatform {
 					continue;
 				}
 				accountsName.push(accountName);
+				const accountRefreshInterval = (account.refreshInterval ?? 120) * 1000
 
 				//log config
 				const logLevel = {
@@ -75,9 +76,6 @@ class MelCloudPlatform {
 				const accountFile = `${prefDir}/${accountName}_Account`;
 				const buildingsFile = `${prefDir}/${accountName}_Buildings`;
 
-				//set account refresh interval
-				const accountRefreshInterval = (account.refreshInterval ?? 120) * 1000
-
 				try {
 					//create impulse generator
 					const impulseGenerator = new ImpulseGenerator()
@@ -106,32 +104,23 @@ class MelCloudPlatform {
 									.on('error', (msg) => log.error(`${accountName}, ${msg}`));
 
 								//connect
-								let accountInfo;
-								try {
-									accountInfo = await melcloud.connect();
-									if (!accountInfo.State) {
-										if (logLevel.warn) log.warn(`${accountName}, ${accountInfo.Info}`);
-										return;
-									}
-								} catch (error) {
-									if (logLevel.error) log.error(`${accountName}, Connect error: ${error.message ?? error}`);
+								const accountInfo = await melcloud.connect();
+								if (!accountInfo.State) {
+									if (logLevel.warn) log.warn(`${accountName}, ${accountInfo.Info}`);
 									return;
 								}
 								if (logLevel.success) log.success(`${accountName}, ${accountInfo.Info}`);
 
 								//check devices list
-								let melcloudDevicesList;
-								try {
-									melcloudDevicesList = await melcloud.checkDevicesList();
-									if (!melcloudDevicesList.State) {
-										if (logLevel.warn) log.warn(`${accountName}, ${melcloudDevicesList.Info}`);
-										return;
-									}
-								} catch (error) {
-									if (logLevel.error) log.error(`${accountName}, Check devices list error: ${error.message ?? error}`);
+								const melcloudDevicesList = await melcloud.checkDevicesList();
+								if (!melcloudDevicesList.State) {
+									if (logLevel.warn) log.warn(`${accountName}, ${melcloudDevicesList.Info}`);
 									return;
 								}
 								if (logLevel.debug) log.info(melcloudDevicesList.Info);
+
+								//start account impulse generator
+								await melcloud.impulseGenerator.state(true, timmers, false);
 								await new Promise(r => setTimeout(r, 1000));
 
 								//configured devices
@@ -209,9 +198,6 @@ class MelCloudPlatform {
 
 								//stop start impulse generator
 								await impulseGenerator.state(false);
-
-								//start account impulse generator
-								await melcloud.impulseGenerator.state(true, timmers, false);
 							} catch (error) {
 								if (logLevel.error) log.error(`${accountName}, Start impulse generator error, ${error.message ?? error}, trying again.`);
 							}

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.6",
+  "version": "4.3.7-beta.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/melcloudata.js

@@ -26,6 +26,7 @@ class MelCloudAta extends EventEmitter {
         this.deviceData = {};
         this.headers = {}
 
+        //handle melcloud events
         let deviceData = null;
         melcloud.on('devicesList', async (devicesData) => {
             this.headers = devicesData.Headers;
@@ -186,7 +187,6 @@ class MelCloudAta extends EventEmitter {
             let payload = {};
             let path = '';
             let headers = this.headers;
-            let updateState = true;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {

package/src/melcloudatw.js

@@ -26,6 +26,7 @@ class MelCloudAtw extends EventEmitter {
         this.deviceData = {};
         this.headers = {};
 
+        //handle melcloud events
         let deviceData = null;
         melcloud.on('devicesList', async (devicesData) => {
             this.headers = devicesData.Headers;
@@ -190,7 +191,6 @@ class MelCloudAtw extends EventEmitter {
             let payload = {};
             let path = '';
             let headers = this.headers;
-            let updateState = true;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {

package/src/melclouderv.js

@@ -26,6 +26,7 @@ class MelCloudErv extends EventEmitter {
         this.deviceData = {};
         this.headers = {};
 
+        //handle melcloud events
         let deviceData = null;
         melcloud.on('devicesList', async (devicesData) => {
             this.headers = devicesData.Headers;
@@ -179,7 +180,6 @@ class MelCloudErv extends EventEmitter {
             let payload = {};
             let path = '';
             let headers = this.headers;
-            let updateState = true;
             switch (accountType) {
                 case "melcloud":
                     switch (flag) {