homebridge-melcloud-control 4.3.3-beta.9 → 4.3.4-beta.0

package/CHANGELOG.md

@@ -22,6 +22,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Do not use Homebridge UI > v5.5.0 because of break config.json
 
+# [4.3.3] - (22.11.2025)
+
+## Changes
+
+- fix [#224](https://github.com/grzegorz914/homebridge-melcloud-control/issues/224)
+- fix presets report wrong state
+- fix schedules assign to the config
+- stability improvements
+- bump dependencies
+- cleanup
+
 # [4.3.2] - (21.11.2025)
 
 ## Changes

package/config.schema.json

@@ -2640,24 +2640,24 @@
                           }
                         },
                         {
-                          "title": "Schedules",
+                          "title": "Scenes",
                           "type": "section",
-                          "description": "Section for setup device schedules",
+                          "description": "Section for setup device scenes",
                           "expandable": true,
                           "expanded": false,
                           "items": [
                             {
-                              "key": "accounts[].ataDevices[].schedules",
+                              "key": "accounts[].ataDevices[].scenes",
                               "type": "tabarray",
                               "title": "{{ value.name }}",
                               "items": [
                                 {
-                                  "key": "accounts[].ataDevices[].schedules[].id",
+                                  "key": "accounts[].ataDevices[].scenes[].id",
                                   "readonly": true
                                 },
-                                "accounts[].ataDevices[].schedules[].displayType",
-                                "accounts[].ataDevices[].schedules[].name",
-                                "accounts[].ataDevices[].schedules[].namePrefix"
+                                "accounts[].ataDevices[].scenes[].displayType",
+                                "accounts[].ataDevices[].scenes[].name",
+                                "accounts[].ataDevices[].scenes[].namePrefix"
                               ]
                             }
                           ],
@@ -2666,24 +2666,24 @@
                           }
                         },
                         {
-                          "title": "Scenes",
+                          "title": "Schedules",
                           "type": "section",
-                          "description": "Section for setup device scenes",
+                          "description": "Section for setup device schedules",
                           "expandable": true,
                           "expanded": false,
                           "items": [
                             {
-                              "key": "accounts[].ataDevices[].scenes",
+                              "key": "accounts[].ataDevices[].schedules",
                               "type": "tabarray",
                               "title": "{{ value.name }}",
                               "items": [
                                 {
-                                  "key": "accounts[].ataDevices[].scenes[].id",
+                                  "key": "accounts[].ataDevices[].schedules[].id",
                                   "readonly": true
                                 },
-                                "accounts[].ataDevices[].scenes[].displayType",
-                                "accounts[].ataDevices[].scenes[].name",
-                                "accounts[].ataDevices[].scenes[].namePrefix"
+                                "accounts[].ataDevices[].schedules[].displayType",
+                                "accounts[].ataDevices[].schedules[].name",
+                                "accounts[].ataDevices[].schedules[].namePrefix"
                               ]
                             }
                           ],
@@ -2813,24 +2813,24 @@
                           }
                         },
                         {
-                          "title": "Schedules",
+                          "title": "Scenes",
                           "type": "section",
-                          "description": "Section for setup device schedules",
+                          "description": "Section for setup device scenes",
                           "expandable": true,
                           "expanded": false,
                           "items": [
                             {
-                              "key": "accounts[].atwDevices[].schedules",
+                              "key": "accounts[].atwDevices[].scenes",
                               "type": "tabarray",
                               "title": "{{ value.name }}",
                               "items": [
                                 {
-                                  "key": "accounts[].atwDevices[].schedules[].id",
+                                  "key": "accounts[].atwDevices[].scenes[].id",
                                   "readonly": true
                                 },
-                                "accounts[].atwDevices[].schedules[].displayType",
-                                "accounts[].atwDevices[].schedules[].name",
-                                "accounts[].atwDevices[].schedules[].namePrefix"
+                                "accounts[].atwDevices[].scenes[].displayType",
+                                "accounts[].atwDevices[].scenes[].name",
+                                "accounts[].atwDevices[].scenes[].namePrefix"
                               ]
                             }
                           ],
@@ -2839,24 +2839,24 @@
                           }
                         },
                         {
-                          "title": "Scenes",
+                          "title": "Schedules",
                           "type": "section",
-                          "description": "Section for setup device scenes",
+                          "description": "Section for setup device schedules",
                           "expandable": true,
                           "expanded": false,
                           "items": [
                             {
-                              "key": "accounts[].atwDevices[].scenes",
+                              "key": "accounts[].atwDevices[].schedules",
                               "type": "tabarray",
                               "title": "{{ value.name }}",
                               "items": [
                                 {
-                                  "key": "accounts[].atwDevices[].scenes[].id",
+                                  "key": "accounts[].atwDevices[].schedules[].id",
                                   "readonly": true
                                 },
-                                "accounts[].atwDevices[].scenes[].displayType",
-                                "accounts[].atwDevices[].scenes[].name",
-                                "accounts[].atwDevices[].scenes[].namePrefix"
+                                "accounts[].atwDevices[].schedules[].displayType",
+                                "accounts[].atwDevices[].schedules[].name",
+                                "accounts[].atwDevices[].schedules[].namePrefix"
                               ]
                             }
                           ],
@@ -2991,24 +2991,24 @@
                           }
                         },
                         {
-                          "title": "Schedules",
+                          "title": "Scenes",
                           "type": "section",
-                          "description": "Section for setup device schedules",
+                          "description": "Section for setup device scenes",
                           "expandable": true,
                           "expanded": false,
                           "items": [
                             {
-                              "key": "accounts[].ervDevices[].schedules",
+                              "key": "accounts[].ervDevices[].scenes",
                               "type": "tabarray",
                               "title": "{{ value.name }}",
                               "items": [
                                 {
-                                  "key": "accounts[].ervDevices[].schedules[].id",
+                                  "key": "accounts[].ervDevices[].scenes[].id",
                                   "readonly": true
                                 },
-                                "accounts[].ervDevices[].schedules[].displayType",
-                                "accounts[].ervDevices[].schedules[].name",
-                                "accounts[].ervDevices[].schedules[].namePrefix"
+                                "accounts[].ervDevices[].scenes[].displayType",
+                                "accounts[].ervDevices[].scenes[].name",
+                                "accounts[].ervDevices[].scenes[].namePrefix"
                               ]
                             }
                           ],
@@ -3017,24 +3017,24 @@
                           }
                         },
                         {
-                          "title": "Scenes",
+                          "title": "Schedules",
                           "type": "section",
-                          "description": "Section for setup device scenes",
+                          "description": "Section for setup device schedules",
                           "expandable": true,
                           "expanded": false,
                           "items": [
                             {
-                              "key": "accounts[].ervDevices[].scenes",
+                              "key": "accounts[].ervDevices[].schedules",
                               "type": "tabarray",
                               "title": "{{ value.name }}",
                               "items": [
                                 {
-                                  "key": "accounts[].ervDevices[].scenes[].id",
+                                  "key": "accounts[].ervDevices[].schedules[].id",
                                   "readonly": true
                                 },
-                                "accounts[].ervDevices[].scenes[].displayType",
-                                "accounts[].ervDevices[].scenes[].name",
-                                "accounts[].ervDevices[].scenes[].namePrefix"
+                                "accounts[].ervDevices[].schedules[].displayType",
+                                "accounts[].ervDevices[].schedules[].name",
+                                "accounts[].ervDevices[].schedules[].namePrefix"
                               ]
                             }
                           ],

package/homebridge-ui/public/index.html

@@ -249,11 +249,11 @@
           const newDevices = { ata: [], ataPresets: [], ataSchedules: [], atw: [], atwPresets: [], atwSchedules: [], erv: [], ervPresets: [], ervSchedules: [], scenes: [] };
           const devicesByType = { ata: [], atw: [], erv: [] };
 
-          response.Devices.forEach(d => {
-            d.Scenes = response.Scenes ?? [];
-            if (d.Type === 0) devicesByType.ata.push(d);
-            if (d.Type === 1) devicesByType.atw.push(d);
-            if (d.Type === 3) devicesByType.erv.push(d);
+          response.Devices.forEach(device => {
+            device.Scenes = response.Scenes ?? [];
+            if (device.Type === 0) devicesByType.ata.push(device);
+            if (device.Type === 1) devicesByType.atw.push(device);
+            if (device.Type === 3) devicesByType.erv.push(device);
           });
 
           account.ataDevices ??= [];
@@ -295,105 +295,112 @@
                   configDevicesMap.set(deviceId, deviceInConfig);
                 }
 
-                // === Process presets/schedules ===
-                const presets = device.Presets || [];
-                const presetsInConfig = deviceInConfig.presets || [];
-                const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
-
-                let addedNewPreset = false;
-                presets.forEach((preset, index) => {
-                  const presetId = String(preset.ID);
-                  if (!presetIds.has(presetId)) {
-                    const presetObj = {
-                      id: presetId,
-                      displayType: 0,
-                      name: preset.NumberDescription || `Preset ${index}`,
-                      namePrefix: false
-                    };
-                    presetsInConfig.push(presetObj);
-                    newPresets.push(presetObj);
-                    presetIds.add(presetId);
-                    addedNewPreset = true;
-                  }
-                });
-
-                // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
-                if (addedNewPreset) {
-                  const beforeCount = presetsInConfig.length;
-                  deviceInConfig.presets = presetsInConfig.filter(p => String(p.id) !== '0');
-                  const removedCount = beforeCount - deviceInConfig.presets.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder preset from device ${device.DeviceID}`, 'yellow');
+                //only for melcloud
+                if (account.type === 'melcloud') {
+
+                  // === Process presets ===
+                  const presetsInMelCloud = device.Presets || [];
+                  const presetsInConfig = deviceInConfig.presets || [];
+                  const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
+
+                  let addedNewPreset = false;
+                  presetsInMelCloud.forEach((preset, index) => {
+                    const presetId = String(preset.ID);
+                    if (!presetIds.has(presetId)) {
+                      const presetObj = {
+                        id: presetId,
+                        displayType: 0,
+                        name: preset.NumberDescription || `Preset ${index}`,
+                        namePrefix: false
+                      };
+                      presetsInConfig.push(presetObj);
+                      newPresets.push(presetObj);
+                      presetIds.add(presetId);
+                      addedNewPreset = true;
+                    }
+                  });
+
+                  // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
+                  if (addedNewPreset) {
+                    const beforeCount = presetsInConfig.length;
+                    deviceInConfig.presets = presetsInConfig.filter(p => String(p.id) !== '0');
+                    const removedCount = beforeCount - deviceInConfig.presets.length;
+
+                    if (removedCount > 0 && removedCount < beforeCount) {
+                      updateInfo('info2', `Removed ${removedCount} placeholder preset from device ${device.DeviceID}`, 'yellow');
+                    }
                   }
                 }
 
-                // === Process presets/schedules ===
-                const schedules = device.Schedules || [];
-                const schedulesInConfig = deviceInConfig.schedules || [];
-                const scheduleIds = new Set(schedulesInConfig.map(s => String(s.id)));
-
-                let addedNewSchedule = false;
-                schedules.forEach((schedule, index) => {
-                  const scheduleId = String(schedule.Id);
-                  if (!scheduleIds.has(scheduleId)) {
-                    const presetObj = {
-                      id: scheduleId,
-                      displayType: 0,
-                      name: `Schedule ${index}`,
-                      namePrefix: false
-                    };
-                    schedulesInConfig.push(presetObj);
-                    newPresets.push(presetObj);
-                    scheduleIds.add(scheduleId);
-                    addedNewSchedule = true;
+                //only for melcloudhome
+                if (account.type === 'melcloudhome') {
+
+                  // === Process schedules ===
+                  const schedulesInMelCloud = device.Schedule || [];
+                  const schedulesInConfig = deviceInConfig.schedules || [];
+                  const scheduleIds = new Set(schedulesInConfig.map(s => String(s.id)));
+
+                  let addedNewSchedule = false;
+                  schedulesInMelCloud.forEach((schedule, index) => {
+                    const scheduleId = String(schedule.Id);
+                    if (!scheduleIds.has(scheduleId)) {
+                      const scheduleObj = {
+                        id: scheduleId,
+                        displayType: 0,
+                        name: `Schedule ${index}`,
+                        namePrefix: false
+                      };
+                      schedulesInConfig.push(scheduleObj);
+                      newSchedules.push(scheduleObj);
+                      scheduleIds.add(scheduleId);
+                      addedNewSchedule = true;
+                    }
+                  });
+
+                  // === Remove placeholder schedules (id === '0') if new ones were added ===
+                  if (addedNewSchedule) {
+                    const beforeCount = schedulesInConfig.length;
+                    deviceInConfig.schedules = schedulesInConfig.filter(s => String(s.id) !== '0');
+                    const removedCount = beforeCount - deviceInConfig.schedules.length;
+
+                    if (removedCount > 0 && removedCount < beforeCount) {
+                      updateInfo('info2', `Removed ${removedCount} placeholder schedule from device ${device.DeviceID}`, 'yellow');
+                    }
                   }
-                });
 
-                // === Remove placeholder schedules (id === '0') if new ones were added ===
-                if (addedNewSchedule) {
-                  const beforeCount = schedulesInConfig.length;
-                  deviceInConfig.schedules = schedulesInConfig.filter(s => String(s.id) !== '0');
-                  const removedCount = beforeCount - deviceInConfig.schedules.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder schedule from device ${device.DeviceID}`, 'yellow');
+                  // === Process scenes ===
+                  const scenesInMelCloud = device.Scenes || [];
+                  const scenesInConfig = deviceInConfig.scenes || [];
+                  const sceneIds = new Set(scenesInConfig.map(s => String(s.id)));
+
+                  let addedNewScenes = false;
+                  scenesInMelCloud.forEach((scene, index) => {
+                    const sceneId = String(scene.Id);
+                    if (!sceneIds.has(sceneId)) {
+                      const sceneObj = {
+                        id: sceneId,
+                        displayType: 0,
+                        name: scene.Name || `Scene ${index}`,
+                        namePrefix: false
+                      };
+                      scenesInConfig.push(sceneObj);
+                      newScenes.push(sceneObj);
+                      sceneIds.add(sceneId);
+                      addedNewScenes = true;
+                    }
+                  });
+
+                  // === Remove placeholder scenes (id === '0') if new ones were added ===
+                  if (addedNewScenes) {
+                    const beforeCount = scenesInConfig.length;
+                    deviceInConfig.scenes = scenesInConfig.filter(s => String(s.id) !== '0');
+                    const removedCount = beforeCount - deviceInConfig.scenes.length;
+
+                    if (removedCount > 0 && removedCount < beforeCount) {
+                      updateInfo('info2', `Removed ${removedCount} placeholder scene from device ${device.DeviceID}`, 'yellow');
+                    }
                   }
                 }
-
-                // === Process scenes ===
-                const scenes = device.Scenes || [];
-                const scenesInConfig = deviceInConfig.scenes || [];
-                const sceneIds = new Set(scenesInConfig.map(s => String(s.id)));
-
-                let addedNewScenes = false;
-                scenes.forEach((scene, index) => {
-                  const sceneId = String(scene.Id);
-                  if (!sceneIds.has(sceneId)) {
-                    const sceneObj = {
-                      id: sceneId,
-                      displayType: 0,
-                      name: scene.Name || `Scene ${index}`,
-                      namePrefix: false
-                    };
-                    scenesInConfig.push(sceneObj);
-                    newScenes.push(sceneObj);
-                    sceneIds.add(sceneId);
-                    addedNewScenes = true;
-                  }
-                });
-
-                // === Remove placeholder scenes (id === '0') if new ones were added ===
-                if (addedNewScenes) {
-                  const beforeCount = scenesInConfig.length;
-                  deviceInConfig.scenes = scenesInConfig.filter(s => String(s.id) !== '0');
-                  const removedCount = beforeCount - deviceInConfig.scenes.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder scene from device ${device.DeviceID}`, 'yellow');
-                  }
-                }
-
               });
 
               // Return filtered devicesInConfig to make sure upstream code uses it
@@ -418,17 +425,19 @@
             updateInfo('info', 'No changes detected.', 'white');
           } else {
             if (newDevicesCount)
-              updateInfo('info', `Found new devices: ATA: ${newDevices.ata.length}, ATW: ${newDevices.atw.length}, ERV: ${newDevices.erv.length}.`, 'green');
-            if (newPresetsCount || newScenesCount || newSchedulesCount)
-              updateInfo('info1', `Found new ${account.type === 'melcloud' ? 'presets' : 'schedules'}: ATA: ${account.type === 'melcloud' ? newDevices.ataPresets.length : newDevices.ataSchedules.length}, ATW: ${account.type === 'melcloud' ? newDevices.atwPresets.length : newDevices.atwSchedules.length}, ERV: ${account.type === 'melcloud' ? newDevices.ervPresets.length : newDevices.ervSchedules.length}, Scenes: ${newDevices.scenes.length}.`, 'green');
+              updateInfo('info', `Found new devices: ${newDevices.ata.length ? `ATA: ${newDevices.ata.length},` : ''} ${newDevices.atw.length ? `ATW: ${newDevices.atw.length},` : ''} ${newDevices.erv.length ? `ERV: ${newDevices.erv.length},` : ''}.`, 'green');
+            if (newPresetsCount)
+              updateInfo('info1', `Found new presets: ${newDevices.ataPresets.length ? `ATA: ${newDevices.ataPresets.length},` : ''} ${newDevices.atwPresets.length ? `ATW: ${newDevices.atwPresets.length},` : ''} ${newDevices.ervPresets.length ? `ERV: ${newDevices.ervPresets.length}` : ''}.`, 'green');
+            if (newScenesCount || newSchedulesCount)
+              updateInfo('info1', `Found new ${newSchedulesCount ? `schedules:` : ''} ${newDevices.ataSchedules.length ? `ATA: ${newDevices.ataSchedules.length},` : ''} ${newDevices.atwSchedules.length ? `ATW: ${newDevices.atwSchedules.length},` : ''}  ${newDevices.ervSchedules.length ? `ERV: ${newDevices.ervSchedules.length},` : ''} ${newScenesCount ? `scenes: ${newScenesCount}` : ''}.`, 'green');
             if (removedDevicesCount)
-              updateInfo('info2', `Removed devices: ATA: ${removedAta.length}, ATW: ${removedAtw.length}, ERV: ${removedErv.length}.`, 'orange');
+              updateInfo('info2', `Removed devices: ${removedAta.length ? `ATA: ${removedAta.length},` : ''} ${removedAtw.length ? `ATW: ${removedAtw.length},` : ''} ${removedErv.length ? `ERV: ${removedErv.length}` : ''}.`, 'orange');
           }
 
           await homebridge.updatePluginConfig(pluginConfig);
           await homebridge.savePluginConfig(pluginConfig);
         } catch (error) {
-          updateInfo('info', `Connect error ${JSON.stringify(error)}`, 'red');
+          updateInfo('info', `Prepare config error ${JSON.stringify(error)}`, 'red');
           document.getElementById('logIn').className = "btn btn-secondary";
         } finally {
           document.getElementById('logIn').className = "btn btn-secondary";

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.3-beta.9",
+  "version": "4.3.4-beta.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",
@@ -35,7 +35,7 @@
     "node": "^20 || ^22 || ^24 || ^25"
   },
   "dependencies": {
-    "@homebridge/plugin-ui-utils": "^2.1.1",
+    "@homebridge/plugin-ui-utils": "^2.1.2",
     "async-mqtt": "^2.6.3",
     "axios": "^1.13.2",
     "express": "^5.1.0",

package/src/deviceata.js

@@ -915,7 +915,7 @@ class DeviceAta extends EventEmitter {
                         presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                         presetControlSensorService.getCharacteristic(characteristicType)
                             .onGet(async () => {
-                                const state = this.accessory.scheduleEnabled;
+                                const state = preset.state;
                                 return state;
                             })
                         this.presetControlSensorServices.push(presetControlSensorService);

package/src/deviceatw.js

@@ -1230,7 +1230,7 @@ class DeviceAtw extends EventEmitter {
                         presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                         presetControlSensorService.getCharacteristic(characteristicType)
                             .onGet(async () => {
-                                const state = this.accessory.scheduleEnabled;
+                                const state = preset.state;
                                 return state;
                             })
                         this.presetControlSensorServices.push(presetControlSensorService);

package/src/deviceerv.js

@@ -842,7 +842,7 @@ class DeviceErv extends EventEmitter {
                         presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                         presetControlSensorService.getCharacteristic(characteristicType)
                             .onGet(async () => {
-                                const state = this.accessory.scheduleEnabled;
+                                const state = preset.state;
                                 return state;
                             })
                         this.presetControlSensorServices.push(presetControlSensorService);

package/src/functions.js

@@ -167,5 +167,16 @@ class Functions extends EventEmitter {
         else if (!isNaN(v) && v !== "") parsedValue = Number(v);
         return parsedValue;
     }
+
+    parseArrayNameValue(data) {
+        if (!Array.isArray(data)) return {};
+
+        return Object.fromEntries(
+            data.map(({ name, value }) => {
+                const parsedValue = this.convertValue(value);
+                return [name, parsedValue];
+            })
+        );
+    }
 }
 export default Functions

package/src/melcloud.js

@@ -143,7 +143,7 @@ class MelCloud extends EventEmitter {
                 data: payload
             });
             const account = accountData.data;
-            const loginData = account.LoginData ?? [];
+            const loginData = account.LoginData ?? {};
             const contextKey = loginData.ContextKey;
 
             const safeConfig = {

package/src/melcloudata.js

@@ -76,8 +76,8 @@ class MelCloudAta extends EventEmitter {
                 deviceData.Device.OperationMode = AirConditioner.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
                 deviceData.Device.ActualFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.ActualFanSpeed] ?? deviceData.Device.ActualFanSpeed;
                 deviceData.Device.SetFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.SetFanSpeed] ?? deviceData.Device.SetFanSpeed;
-                deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapStringToEnum[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
                 deviceData.Device.VaneHorizontalDirection = AirConditioner.VaneHorizontalDirectionMapStringToEnum[deviceData.Device.VaneHorizontalDirection] ?? deviceData.Device.VaneHorizontalDirection
+                deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapStringToEnum[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
 
                 //read default temps
                 const temps = await this.functions.readData(this.defaultTempsFile, true);
@@ -151,14 +151,15 @@ class MelCloudAta extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            if (!deviceData) return;
             deviceData.Scenes = devicesData.Scenes ?? [];
 
             //web cocket connection
             if (this.accountType === 'melcloudhome' && !this.connecting && !this.socketConnected) {
                 this.connecting = true;
 
-                const url = `${ApiUrlsHome.WebSocketURL}${devicesData.WebSocketOptions.Hash}`;
                 try {
+                    const url = `${ApiUrlsHome.WebSocketURL}${devicesData.WebSocketOptions.Hash}`;
                     const socket = new WebSocket(url, { headers: devicesData.WebSocketOptions.Headers })
                         .on('error', (error) => {
                             if (this.logError) this.emit('error', `Socket error: ${error}`);
@@ -188,7 +189,6 @@ class MelCloudAta extends EventEmitter {
                         .on('message', async (message) => {
                             const parsedMessage = JSON.parse(message);
                             const stringifyMessage = JSON.stringify(parsedMessage, null, 2);
-                            if (!this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
                             if (parsedMessage.message === 'Forbidden') return;
 
                             const messageData = parsedMessage?.[0]?.Data;
@@ -198,16 +198,33 @@ class MelCloudAta extends EventEmitter {
                             const unitId = messageData?.id;
                             switch (unitId) {
                                 case this.deviceId:
+                                    if (!this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
                                     const messageType = parsedMessage[0].messageType;
+                                    const settings = this.functions.parseArrayNameValue(messageData.settings);
                                     switch (messageType) {
                                         case 'unitStateChanged':
-                                            const settings = Object.fromEntries(
-                                                messageData.settings.map(({ name, value }) => {
-                                                    let parsedValue = this.functions.convertValue(value);
-                                                    return [name, parsedValue];
-                                                })
-                                            );
-                                            Object.assign(deviceData.Device, settings);
+
+                                            //update values
+                                            for (const [key, value] of Object.entries(settings)) {
+                                                if (!this.functions.isValidValue(value)) continue;
+
+                                                //update holiday mode
+                                                if (key === 'HolidayMode') {
+                                                    deviceData.HolidayMode.Enabled = value;
+                                                    continue;
+                                                }
+
+                                                //update device settings
+                                                if (key in deviceData.Device) {
+                                                    deviceData.Device[key] = value;
+                                                }
+                                            }
+                                            updateState = true;
+                                            break;
+                                        case 'unitHolidayModeTriggered':
+                                            deviceData.Device.Power = settings.Power;
+                                            deviceData.HolidayMode.Enabled = settings.HolidayMode;
+                                            deviceData.HolidayMode.Active = messageData.active;
                                             updateState = true;
                                             break;
                                         case 'unitWifiSignalChanged':
@@ -215,12 +232,12 @@ class MelCloudAta extends EventEmitter {
                                             updateState = true;
                                             break;
                                         default:
-                                            if (!this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                            if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
                                             return;
                                     }
                                     break;
                                 default:
-                                    if (!this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                                    if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
                                     return;
                             }
 
@@ -329,6 +346,7 @@ class MelCloudAta extends EventEmitter {
                             method = 'POST';
                             path = ApiUrlsHome.PostHolidayMode;
                             headers.Referer = ApiUrlsHome.Referers.PostHolidayMode.replace('deviceid', deviceData.DeviceID);
+                            updateState = false;
                             break;
                         case 'schedule':
                             payload = { enabled: deviceData.ScheduleEnabled };
@@ -368,8 +386,7 @@ class MelCloudAta extends EventEmitter {
                             path = ApiUrlsHome.PutAta.replace('deviceid', deviceData.DeviceID);
                             headers.Referer = ApiUrlsHome.Referers.PutDeviceSettings;
                             updateState = false;
-                            this.socket.send(JSON.stringify([{ "messageType": "unitStateChanged", "Data": { "id": "ef333525-2699-4290-af5a-2922566676da", "unitType": "ata", "settings": [{ "name": "Power", "value": deviceData.Device.Power }] } }]));
-                            return;
+                            break;
                     }
 
                     //sens payload

package/src/melcloudatw.js

@@ -145,6 +145,7 @@ class MelCloudAtw extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            if (!deviceData) return;
             deviceData.Scenes = devicesData.Scenes ?? [];
 
             //web cocket connection

package/src/melclouderv.js

@@ -60,6 +60,7 @@ class MelCloudErv extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            if (!deviceData) return;
             if (this.accountType === 'melcloudhome') {
                 deviceData.Scenes = devicesData.Scenes ?? [];
 

package/src/melcloudhome.js

@@ -142,7 +142,6 @@ class MelCloudHome extends EventEmitter {
                 const createDevice = (device, type) => {
                     // Settings już kapitalizowane w nazwach
                     const settingsArray = device.Settings || [];
-
                     const settingsObject = Object.fromEntries(
                         settingsArray.map(({ name, value }) => {
                             let parsedValue = this.functions.convertValue(value);