homebridge-melcloud-control 4.3.3-beta.2 → 4.3.3-beta.21

package/CHANGELOG.md

@@ -22,6 +22,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Do not use Homebridge UI > v5.5.0 because of break config.json
 
+# [4.3.2] - (xx.11.2025)
+
+## Changes
+
+- fix presets report wrong state
+- stability improvements
+- bump dependencies
+- cleanup
+
 # [4.3.2] - (21.11.2025)
 
 ## Changes

package/homebridge-ui/public/index.html

@@ -250,7 +250,7 @@
           const devicesByType = { ata: [], atw: [], erv: [] };
 
           response.Devices.forEach(d => {
-            d.Scenes = response.Scenes ?? [];
+            d.Scenes = Array.isArray(response.Scenes) ? [...response.Scenes] : [];
             if (d.Type === 0) devicesByType.ata.push(d);
             if (d.Type === 1) devicesByType.atw.push(d);
             if (d.Type === 3) devicesByType.erv.push(d);

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.3-beta.2",
+  "version": "4.3.3-beta.21",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",
@@ -35,7 +35,7 @@
     "node": "^20 || ^22 || ^24 || ^25"
   },
   "dependencies": {
-    "@homebridge/plugin-ui-utils": "^2.1.1",
+    "@homebridge/plugin-ui-utils": "^2.1.2",
     "async-mqtt": "^2.6.3",
     "axios": "^1.13.2",
     "express": "^5.1.0",

package/src/deviceata.js

@@ -915,7 +915,7 @@ class DeviceAta extends EventEmitter {
                         presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                         presetControlSensorService.getCharacteristic(characteristicType)
                             .onGet(async () => {
-                                const state = this.accessory.scheduleEnabled;
+                                const state = preset.state;
                                 return state;
                             })
                         this.presetControlSensorServices.push(presetControlSensorService);

package/src/deviceatw.js

@@ -1230,7 +1230,7 @@ class DeviceAtw extends EventEmitter {
                         presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                         presetControlSensorService.getCharacteristic(characteristicType)
                             .onGet(async () => {
-                                const state = this.accessory.scheduleEnabled;
+                                const state = preset.state;
                                 return state;
                             })
                         this.presetControlSensorServices.push(presetControlSensorService);

package/src/deviceerv.js

@@ -842,7 +842,7 @@ class DeviceErv extends EventEmitter {
                         presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                         presetControlSensorService.getCharacteristic(characteristicType)
                             .onGet(async () => {
-                                const state = this.accessory.scheduleEnabled;
+                                const state = preset.state;
                                 return state;
                             })
                         this.presetControlSensorServices.push(presetControlSensorService);

package/src/functions.js

@@ -167,5 +167,16 @@ class Functions extends EventEmitter {
         else if (!isNaN(v) && v !== "") parsedValue = Number(v);
         return parsedValue;
     }
+
+    parseArrayNameValue(data) {
+        if (!Array.isArray(data)) return {};
+
+        return Object.fromEntries(
+            data.map(({ name, value }) => {
+                const parsedValue = this.convertValue(value);
+                return [name, parsedValue];
+            })
+        );
+    }
 }
 export default Functions

package/src/melcloud.js

@@ -143,7 +143,7 @@ class MelCloud extends EventEmitter {
                 data: payload
             });
             const account = accountData.data;
-            const loginData = account.LoginData ?? [];
+            const loginData = account.LoginData ?? {};
             const contextKey = loginData.ContextKey;
 
             const safeConfig = {

package/src/melcloudata.js

@@ -76,8 +76,8 @@ class MelCloudAta extends EventEmitter {
                 deviceData.Device.OperationMode = AirConditioner.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
                 deviceData.Device.ActualFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.ActualFanSpeed] ?? deviceData.Device.ActualFanSpeed;
                 deviceData.Device.SetFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.SetFanSpeed] ?? deviceData.Device.SetFanSpeed;
-                deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapStringToEnum[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
                 deviceData.Device.VaneHorizontalDirection = AirConditioner.VaneHorizontalDirectionMapStringToEnum[deviceData.Device.VaneHorizontalDirection] ?? deviceData.Device.VaneHorizontalDirection
+                deviceData.Device.VaneVerticalDirection = AirConditioner.VaneVerticalDirectionMapStringToEnum[deviceData.Device.VaneVerticalDirection] ?? deviceData.Device.VaneVerticalDirection;
 
                 //read default temps
                 const temps = await this.functions.readData(this.defaultTempsFile, true);
@@ -151,6 +151,7 @@ class MelCloudAta extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            if (!deviceData) return;
             deviceData.Scenes = devicesData.Scenes ?? [];
 
             //web cocket connection
@@ -188,7 +189,6 @@ class MelCloudAta extends EventEmitter {
                         .on('message', async (message) => {
                             const parsedMessage = JSON.parse(message);
                             const stringifyMessage = JSON.stringify(parsedMessage, null, 2);
-                            if (this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
                             if (parsedMessage.message === 'Forbidden') return;
 
                             const messageData = parsedMessage?.[0]?.Data;
@@ -198,16 +198,32 @@ class MelCloudAta extends EventEmitter {
                             const unitId = messageData?.id;
                             switch (unitId) {
                                 case this.deviceId:
+                                    if (!this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
                                     const messageType = parsedMessage[0].messageType;
+                                    const settings = this.functions.parseArrayNameValue(messageData.settings);
                                     switch (messageType) {
                                         case 'unitStateChanged':
-                                            const settings = Object.fromEntries(
-                                                messageData.settings.map(({ name, value }) => {
-                                                    let parsedValue = this.functions.convertValue(value);
-                                                    return [name, parsedValue];
-                                                })
-                                            );
-                                            Object.assign(deviceData.Device, settings);
+
+                                            //update values
+                                            for (const [key, value] of Object.entries(settings)) {
+                                                if (!this.functions.isValidValue(value)) continue;
+
+                                                if (key === 'HolidayMode') {
+                                                    deviceData.HolidayMode.Enabled = value;
+                                                    continue;
+                                                }
+
+                                                //skip HolidayMode, update generic device fields
+                                                if (key in deviceData.Device) {
+                                                    deviceData.Device[key] = value;
+                                                }
+                                            }
+                                            updateState = true;
+                                            break;
+                                        case 'unitHolidayModeTriggered':
+                                            deviceData.Device.Power = settings.Power;
+                                            deviceData.HolidayMode.Enabled = settings.HolidayMode;
+                                            deviceData.HolidayMode.Active = messageData.active;
                                             updateState = true;
                                             break;
                                         case 'unitWifiSignalChanged':
@@ -215,12 +231,12 @@ class MelCloudAta extends EventEmitter {
                                             updateState = true;
                                             break;
                                         default:
-                                            if (!this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                            if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
                                             return;
                                     }
                                     break;
                                 default:
-                                    if (!this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                                    if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
                                     return;
                             }
 
@@ -329,6 +345,7 @@ class MelCloudAta extends EventEmitter {
                             method = 'POST';
                             path = ApiUrlsHome.PostHolidayMode;
                             headers.Referer = ApiUrlsHome.Referers.PostHolidayMode.replace('deviceid', deviceData.DeviceID);
+                            updateState = false;
                             break;
                         case 'schedule':
                             payload = { enabled: deviceData.ScheduleEnabled };
@@ -368,14 +385,7 @@ class MelCloudAta extends EventEmitter {
                             path = ApiUrlsHome.PutAta.replace('deviceid', deviceData.DeviceID);
                             headers.Referer = ApiUrlsHome.Referers.PutDeviceSettings;
                             updateState = false;
-                            this.socket.send(JSON.stringify([{
-                                messageType: 'setUnitSettings',
-                                Data: {
-                                    id: deviceData.DeviceID,
-                                    settings: payload
-                                }
-                            }]));
-                            return;
+                            break;
                     }
 
                     //sens payload

package/src/melcloudatw.js

@@ -145,6 +145,7 @@ class MelCloudAtw extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            if (!deviceData) return;
             deviceData.Scenes = devicesData.Scenes ?? [];
 
             //web cocket connection

package/src/melclouderv.js

@@ -60,6 +60,7 @@ class MelCloudErv extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            if (!deviceData) return;
             if (this.accountType === 'melcloudhome') {
                 deviceData.Scenes = devicesData.Scenes ?? [];
 

package/src/melcloudhome.js

@@ -142,7 +142,6 @@ class MelCloudHome extends EventEmitter {
                 const createDevice = (device, type) => {
                     // Settings już kapitalizowane w nazwach
                     const settingsArray = device.Settings || [];
-
                     const settingsObject = Object.fromEntries(
                         settingsArray.map(({ name, value }) => {
                             let parsedValue = this.functions.convertValue(value);