homebridge-melcloud-control 4.3.2-beta.9 → 4.3.2

package/CHANGELOG.md

@@ -22,6 +22,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Do not use Homebridge UI > v5.5.0 because of break config.json
 
+# [4.3.2] - (21.11.2025)
+
+## Changes
+
+- stability improvements
+- cleanup
+
 # [4.3.0] - (20.11.2025)
 
 ## Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.2-beta.9",
+  "version": "4.3.2",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/functions.js

@@ -160,13 +160,12 @@ class Functions extends EventEmitter {
         return v !== undefined && v !== null && !(typeof v === 'number' && Number.isNaN(v));
     }
 
-    convertValue(value, name) {
-        let parsedValue = value;
-        if (value === "True") parsedValue = true;
-        else if (value === "False") parsedValue = false;
-        else if (!isNaN(value) && value !== "") parsedValue = Number(value);
-        return [name, parsedValue];
+    convertValue(v) {
+        let parsedValue = v;
+        if (v === "True") parsedValue = true;
+        else if (v === "False") parsedValue = false;
+        else if (!isNaN(v) && v !== "") parsedValue = Number(v);
+        return parsedValue;
     }
-
 }
 export default Functions

package/src/melcloudata.js

@@ -127,8 +127,8 @@ class MelCloudAta extends EventEmitter {
             }
 
             //check state changes
-            const deviceDataHasNotChanged = JSON.stringify(deviceData) === JSON.stringify(this.deviceData);
-            if (deviceDataHasNotChanged) return;
+            const deviceDataNotChanged = JSON.stringify(deviceData) === JSON.stringify(this.deviceData);
+            if (deviceDataNotChanged) return;
             this.deviceData = deviceData;
 
             //emit info
@@ -139,7 +139,7 @@ class MelCloudAta extends EventEmitter {
 
             return true;
         } catch (error) {
-            throw new Error(`Check state error: ${error.message}`);
+            throw new Error(`Update state error: ${error.message}`);
         };
     };
 
@@ -195,7 +195,7 @@ class MelCloudAta extends EventEmitter {
                             const messageData = parsedMessage?.[0]?.Data;
                             if (!messageData) return;
 
-                            let updateDeviceState = false;
+                            let updateState = false;
                             const unitId = messageData?.id;
                             switch (unitId) {
                                 case this.deviceId:
@@ -204,35 +204,37 @@ class MelCloudAta extends EventEmitter {
                                         case 'unitStateChanged':
                                             const settings = Object.fromEntries(
                                                 messageData.settings.map(({ name, value }) => {
-                                                    let parsedValue = this.functions.convertValue(value, name);
-                                                    return parsedValue;
+                                                    let parsedValue = this.functions.convertValue(value);
+                                                    return [name, parsedValue];
                                                 })
                                             );
                                             Object.assign(deviceData.Device, settings);
-                                            updateDeviceState = true;
+                                            updateState = true;
                                             break;
                                         case 'unitWifiSignalChanged':
                                             deviceData.Rssi = messageData.rssi;
-                                            updateDeviceState = true;
+                                            updateState = true;
                                             break;
                                         default:
-                                            if (!this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                            if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
                                             return;
                                     }
                                     break;
                                 default:
-                                    if (!this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                                    if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
                                     return;
                             }
 
-                            if (updateDeviceState) await this.updateState(deviceData);
+                            //update state
+                            if (updateState) await this.updateState(deviceData);
                         });
                 } catch (error) {
                     if (this.logError) this.emit('error', `Socket connection failed: ${error}`);
                     this.cleanupSocket();
                 }
             }
-            if (this.logDebug) this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`);
+
+            //update state
             await this.updateState(deviceData);
 
             return true;
@@ -382,7 +384,7 @@ class MelCloudAta extends EventEmitter {
                         data: payload
                     });
 
-                    await this.updateData(deviceData, updateState);
+                    this.updateData(deviceData, updateState);
                     return true;
                 default:
                     return;
@@ -393,9 +395,9 @@ class MelCloudAta extends EventEmitter {
         }
     }
 
-    async updateData(deviceData, updateState = true) {
+    updateData(deviceData, updateState = true) {
         this.locks = true;
-        if (updateState) await this.updateState(deviceData);
+        if (updateState) this.emit('deviceState', deviceData);
 
         setTimeout(() => {
             this.locks = false

package/src/melcloudhome.js

@@ -145,7 +145,7 @@ class MelCloudHome extends EventEmitter {
 
                     const settingsObject = Object.fromEntries(
                         settingsArray.map(({ name, value }) => {
-                            let parsedValue = this.functions.convertValue(value, name);
+                            let parsedValue = this.functions.convertValue(value);
                             const key = name.charAt(0).toUpperCase() + name.slice(1);
                             return [key, parsedValue];
                         })