homebridge-melcloud-control 4.3.2-beta.11 → 4.3.2-beta.12

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.2-beta.11",
+  "version": "4.3.2-beta.12",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/functions.js

@@ -160,13 +160,12 @@ class Functions extends EventEmitter {
         return v !== undefined && v !== null && !(typeof v === 'number' && Number.isNaN(v));
     }
 
-    convertValue(value) {
-        let parsedValue = value;
-        if (value === "True") parsedValue = true;
-        else if (value === "False") parsedValue = false;
-        else if (!isNaN(value) && value !== "") parsedValue = Number(value);
+    convertValue(v) {
+        let parsedValue = v;
+        if (v === "True") parsedValue = true;
+        else if (v === "False") parsedValue = false;
+        else if (!isNaN(v) && v !== "") parsedValue = Number(v);
         return parsedValue;
     }
-
 }
 export default Functions

package/src/melcloudata.js

@@ -149,6 +149,15 @@ class MelCloudAta extends EventEmitter {
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
             deviceData.Scenes = devicesData.Scenes ?? [];
 
+            //check state changes
+            const deviceDataChanged = JSON.stringify(deviceData) !== JSON.stringify(this.deviceData);
+            if (deviceDataChanged) {
+                this.deviceData = deviceData;
+
+                //update state
+                await this.updateState(deviceData);
+            }
+
             //web cocket connection
             if (this.accountType === 'melcloudhome' && !this.connecting && !this.socketConnected) {
                 this.connecting = true;
@@ -229,14 +238,6 @@ class MelCloudAta extends EventEmitter {
                 }
             }
 
-            //check state changes
-            const deviceDataHasNotChanged = JSON.stringify(deviceData) === JSON.stringify(this.deviceData);
-            if (deviceDataHasNotChanged) return;
-            this.deviceData = deviceData;
-
-            //update state
-            await this.updateState(deviceData);
-
             return true;
         } catch (error) {
             throw new Error(`Check state error: ${error.message}`);