homebridge-melcloud-control 4.3.2-beta.10 → 4.3.2-beta.12

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.2-beta.10",
+  "version": "4.3.2-beta.12",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/functions.js

@@ -160,13 +160,12 @@ class Functions extends EventEmitter {
         return v !== undefined && v !== null && !(typeof v === 'number' && Number.isNaN(v));
     }
 
-    convertValue(value) {
-        let parsedValue = value;
-        if (value === "True") parsedValue = true;
-        else if (value === "False") parsedValue = false;
-        else if (!isNaN(value) && value !== "") parsedValue = Number(value);
+    convertValue(v) {
+        let parsedValue = v;
+        if (v === "True") parsedValue = true;
+        else if (v === "False") parsedValue = false;
+        else if (!isNaN(v) && v !== "") parsedValue = Number(v);
         return parsedValue;
     }
-
 }
 export default Functions

package/src/melcloudata.js

@@ -126,11 +126,6 @@ class MelCloudAta extends EventEmitter {
                 this.emit('mqtt', 'State', deviceData.Device);
             }
 
-            //check state changes
-            const deviceDataHasNotChanged = JSON.stringify(deviceData) === JSON.stringify(this.deviceData);
-            if (deviceDataHasNotChanged) return;
-            this.deviceData = deviceData;
-
             //emit info
             this.emit('deviceInfo', indoor.model, outdoor.model, serialNumber, firmwareAppVersion);
 
@@ -154,6 +149,15 @@ class MelCloudAta extends EventEmitter {
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
             deviceData.Scenes = devicesData.Scenes ?? [];
 
+            //check state changes
+            const deviceDataChanged = JSON.stringify(deviceData) !== JSON.stringify(this.deviceData);
+            if (deviceDataChanged) {
+                this.deviceData = deviceData;
+
+                //update state
+                await this.updateState(deviceData);
+            }
+
             //web cocket connection
             if (this.accountType === 'melcloudhome' && !this.connecting && !this.socketConnected) {
                 this.connecting = true;
@@ -195,7 +199,7 @@ class MelCloudAta extends EventEmitter {
                             const messageData = parsedMessage?.[0]?.Data;
                             if (!messageData) return;
 
-                            let updateDeviceState = false;
+                            let updateState = false;
                             const unitId = messageData?.id;
                             switch (unitId) {
                                 case this.deviceId:
@@ -209,11 +213,11 @@ class MelCloudAta extends EventEmitter {
                                                 })
                                             );
                                             Object.assign(deviceData.Device, settings);
-                                            updateDeviceState = true;
+                                            updateState = true;
                                             break;
                                         case 'unitWifiSignalChanged':
                                             deviceData.Rssi = messageData.rssi;
-                                            updateDeviceState = true;
+                                            updateState = true;
                                             break;
                                         default:
                                             if (!this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
@@ -226,17 +230,13 @@ class MelCloudAta extends EventEmitter {
                             }
 
                             //update state
-                            if (updateDeviceState) await this.updateState(deviceData);
+                            if (updateState) await this.updateState(deviceData);
                         });
                 } catch (error) {
                     if (this.logError) this.emit('error', `Socket connection failed: ${error}`);
                     this.cleanupSocket();
                 }
             }
-            if (this.logDebug) this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`);
-
-            //update state
-            await this.updateState(deviceData);
 
             return true;
         } catch (error) {