homebridge-melcloud-control 4.3.2-beta.0 → 4.3.2-beta.10

package/README.md

@@ -91,6 +91,7 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
       * Shedule active.
       * Scene control.
       * In standby.
+      * Is connected.
       * Error.
 * Heat Pump:
   * Heater Cooler:
@@ -148,6 +149,7 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
       * Shedule active.
       * Scene control.
       * In standby.
+      * Is connected.
       * Error.
 * Energy Recovery Ventilation Lossnay:
   * Heater Cooler:
@@ -186,6 +188,7 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
       * Shedule active.
       * Scene control.
       * In standby.
+      * Is connected.
       * Error.
 
 ### HOME app current device mode display

package/config.schema.json

@@ -1287,6 +1287,15 @@
                       "functionBody": "return model.accounts[arrayIndices[0]].type === 'melcloudhome';"
                     }
                   },
+                  "frostProtectionSupport": {
+                    "title": "Frost Protection Support",
+                    "type": "boolean",
+                    "default": false,
+                    "description": "This enable extra frost protection control and sensors to use with automations in HomeKit app.",
+                    "condition": {
+                      "functionBody": "return model.accounts[arrayIndices[0]].type === 'melcloudhome';"
+                    }
+                  },
                   "refreshInterval": {
                     "title": "Refresh Interval",
                     "type": "integer",
@@ -2769,6 +2778,7 @@
                           "items": [
                             "accounts[].atwDevices[].hideZone",
                             "accounts[].atwDevices[].name",
+                            "accounts[].atwDevices[].frostProtectionSupport",
                             "accounts[].atwDevices[].holidayModeSupport",
                             "accounts[].atwDevices[].refreshInterval"
                           ],

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.2-beta.0",
+  "version": "4.3.2-beta.10",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -649,7 +649,7 @@ class DeviceAta extends EventEmitter {
                         return state;
                     })
                 accessory.addService(this.roomTemperatureSensorService);
-            };
+            }
 
             if (this.temperatureOutdoorSensor && supportsOutdoorTemperature && this.accessory.outdoorTemperature !== null) {
                 if (this.logDebug) this.emit('debug', `Prepare outdoor temperature sensor service`);
@@ -662,7 +662,7 @@ class DeviceAta extends EventEmitter {
                         return state;
                     })
                 accessory.addService(this.outdoorTemperatureSensorService);
-            };
+            }
 
             //in standby sensor
             if (this.inStandbySensor && this.accessory.inStandbyMode !== null) {
@@ -922,7 +922,7 @@ class DeviceAta extends EventEmitter {
                         accessory.addService(presetControlSensorService);
                     }
                 });
-            };
+            }
 
             //schedules services
             if (this.schedules.length > 0 && this.accessory.scheduleEnabled !== null) {
@@ -996,7 +996,7 @@ class DeviceAta extends EventEmitter {
                         accessory.addService(scheduleSensorService);
                     }
                 });
-            };
+            }
 
             //scenes
             if (this.scenes.length > 0) {
@@ -1055,7 +1055,7 @@ class DeviceAta extends EventEmitter {
                         accessory.addService(sceneControlSensorService);
                     }
                 });
-            };
+            }
 
             //buttons services
             if (this.buttons.length > 0) {
@@ -1318,7 +1318,7 @@ class DeviceAta extends EventEmitter {
                         accessory.addService(buttonControlSensorService);
                     }
                 });
-            };
+            }
 
             return accessory;
         } catch (error) {
@@ -1690,7 +1690,7 @@ class DeviceAta extends EventEmitter {
                             //sensor
                             if (preset.displayType < 7) this.presetControlSensorServices?.[i]?.updateCharacteristic(characteristicType, preset.state);
                         });
-                    };
+                    }
 
                     ///schedules
                     if (this.schedules.length > 0 && scheduleEnabled !== null) {
@@ -1710,7 +1710,7 @@ class DeviceAta extends EventEmitter {
                             //sensor
                             if (schedule.displayType < 7) this.scheduleSensorServices?.[i]?.updateCharacteristic(characteristicType, schedule.state);
                         });
-                    };
+                    }
 
                     //scenes
                     if (this.scenes.length > 0) {
@@ -1727,7 +1727,7 @@ class DeviceAta extends EventEmitter {
                             //sensor
                             if (scene.displayType < 7) this.sceneControlSensorServices?.[i]?.updateCharacteristic(characteristicType, scene.state);
                         });
-                    };
+                    }
 
                     //buttons
                     if (this.buttons.length > 0) {
@@ -1851,7 +1851,7 @@ class DeviceAta extends EventEmitter {
                             //sensor
                             if (button.displayType < 7) this.buttonControlSensorServices?.[i]?.updateCharacteristic(characteristicType, button.state);
                         });
-                    };
+                    }
 
                     //log current state
                     if (this.logInfo) {
@@ -1868,7 +1868,8 @@ class DeviceAta extends EventEmitter {
                         if (supportsSwingFunction) this.emit('info', `Air direction: ${AirConditioner.AirDirectionMapEnumToString[obj.currentSwingMode]}`);
                         this.emit('info', `Temperature display unit: ${obj.temperatureUnit}`);
                         this.emit('info', `Lock physical controls: ${obj.lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
-                    };
+                        if (this.accountType === 'melcloudhome') this.emit('info', `Signal strength: ${deviceData.Rssi}dBm`);
+                    }
                 })
                 .on('success', (success) => this.emit('success', success))
                 .on('info', (info) => this.emit('info', info))

package/src/deviceatw.js

@@ -44,6 +44,7 @@ class DeviceAtw extends EventEmitter {
         this.inStandbySensor = device.inStandbySensor || false;
         this.connectSensor = device.connectSensor || false;
         this.errorSensor = device.errorSensor || false;
+        this.frostProtectionSupport = device.frostProtectionSupport || false;
         this.holidayModeSupport = device.holidayModeSupport || false;
         this.presets = this.accountType === 'melcloud' ? (device.presets || []).filter(preset => (preset.displayType ?? 0) > 0 && preset.id !== '0') : [];
         this.schedules = this.accountType === 'melcloudhome' ? (device.schedules || []).filter(schedule => (schedule.displayType ?? 0) > 0 && schedule.id !== '0') : [];
@@ -851,7 +852,7 @@ class DeviceAtw extends EventEmitter {
                             break;
                     };
                 });
-            };
+            }
 
             //sensor services
             if (zonesSensorsCount > 0) {
@@ -1022,7 +1023,7 @@ class DeviceAtw extends EventEmitter {
                             break;
                     };
                 });
-            };
+            }
 
             //in standby sensor
             if (this.inStandbySensor && this.accessory.inStandbyMode !== null) {
@@ -1066,6 +1067,53 @@ class DeviceAtw extends EventEmitter {
                 accessory.addService(this.errorService);
             }
 
+            //frost protection
+            if (this.frostProtectionSupport && this.accessory.frostProtectionEnabled !== null) {
+                //control
+                if (this.logDebug) this.emit('debug', `Prepare frost protection control service`);
+                this.frostProtectionControlService = new Service.Switch(`${serviceName} Frost Protection`, `frostProtectionControlService${deviceId}`);
+                this.frostProtectionControlService.addOptionalCharacteristic(Characteristic.ConfiguredName);
+                this.frostProtectionControlService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Frost Protection`);
+                this.frostProtectionControlService.getCharacteristic(Characteristic.On)
+                    .onGet(async () => {
+                        const state = this.accessory.frostProtectionEnabled;
+                        return state;
+                    })
+                    .onSet(async (state) => {
+                        try {
+                            deviceData.FrostProtection.Enabled = state;
+                            if (this.logInfo) this.emit('info', `Frost protection: ${state ? 'Enabled' : 'Disabled'}`);
+                            await this.melCloudAta.send(this.accountType, this.displayType, deviceData, 'frostprotection');
+                        } catch (error) {
+                            if (this.logWarn) this.emit('warn', `Set frost protection error: ${error}`);
+                        };
+                    });
+                accessory.addService(this.frostProtectionControlService);
+
+                if (this.logDebug) this.emit('debug', `Prepare frost protection control sensor service`);
+                this.frostProtectionControlSensorService = new Service.ContactSensor(`${serviceName} Frost Protection Control`, `frostProtectionControlSensorService${deviceId}`);
+                this.frostProtectionControlSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
+                this.frostProtectionControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Frost Protection Control`);
+                this.frostProtectionControlSensorService.getCharacteristic(Characteristic.ContactSensorState)
+                    .onGet(async () => {
+                        const state = this.accessory.frostProtectionEnabled;
+                        return state;
+                    })
+                accessory.addService(this.frostProtectionControlSensorService);
+
+                //sensor
+                if (this.logDebug) this.emit('debug', `Prepare frost protection service`);
+                this.frostProtectionSensorService = new Service.ContactSensor(`${serviceName} Frost Protection`, `frostProtectionSensorService${deviceId}`);
+                this.frostProtectionSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
+                this.frostProtectionSensorService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} Frost Protection`);
+                this.frostProtectionSensorService.getCharacteristic(Characteristic.ContactSensorState)
+                    .onGet(async () => {
+                        const state = this.accessory.frostProtectionActive;
+                        return state;
+                    })
+                accessory.addService(this.frostProtectionSensorService);
+            }
+
             //holiday mode
             if (this.holidayModeSupport && this.accessory.holidayModeEnabled !== null) {
                 //control
@@ -1189,7 +1237,7 @@ class DeviceAtw extends EventEmitter {
                         accessory.addService(presetControlSensorService);
                     }
                 });
-            };
+            }
 
             //schedules services
             if (this.schedules.length > 0 && this.accessory.scheduleEnabled !== null) {
@@ -1263,7 +1311,7 @@ class DeviceAtw extends EventEmitter {
                         accessory.addService(scheduleSensorService);
                     }
                 });
-            };
+            }
 
             //scenes
             if (this.scenes.length > 0) {
@@ -1322,7 +1370,7 @@ class DeviceAtw extends EventEmitter {
                         accessory.addService(sceneControlSensorService);
                     }
                 });
-            };
+            }
 
             //buttons services
             if (this.buttons.length > 0) {
@@ -1517,7 +1565,7 @@ class DeviceAtw extends EventEmitter {
                         accessory.addService(buttonControlSensorService);
                     }
                 });
-            };
+            }
 
             return accessory;
         } catch (error) {
@@ -1574,6 +1622,10 @@ class DeviceAtw extends EventEmitter {
                     const holidayModeEnabled = accountTypeMelcloud ? holidayMode : deviceData.HolidayMode?.Enabled;
                     const holidayModeActive = deviceData.HolidayMode?.Active ?? false;
 
+                    //protection
+                    const frostProtectionEnabled = deviceData.FrostProtection?.Enabled;
+                    const frostProtectionActive = deviceData.FrostProtection?.Active ?? false;
+
                     //device info
                     const supportsStanbyMode = deviceData.Device[supportStandbyKey];
                     const supportsHeatPump = ![1, 2, 3, 4, 5, 6, 7, 15].includes(this.hideZone);
@@ -1681,6 +1733,8 @@ class DeviceAtw extends EventEmitter {
                         temperatureUnit: TemperatureDisplayUnits[this.accountInfo.useFahrenheit ? 1 : 0],
                         isConnected: isConnected,
                         isInError: isInError,
+                        frostProtectionEnabled: frostProtectionEnabled,
+                        frostProtectionActive: frostProtectionActive,
                         scheduleEnabled: scheduleEnabled,
                         holidayModeEnabled: holidayModeEnabled,
                         holidayModeActive: holidayModeActive,
@@ -1947,39 +2001,40 @@ class DeviceAtw extends EventEmitter {
                             let operationModeText = '';
                             switch (i) {
                                 case caseHeatPump: //Heat Pump - HEAT, COOL, OFF
-                                    this.emit('info', `${heatPumpName}, Power: ${power ? 'On' : 'Off'}`)
-                                    this.emit('info', `${heatPumpName}, Operation mode: ${HeatPump.SystemMapEnumToString[unitStatus]}`);
-                                    this.emit('info', `${heatPumpName},'Outdoor temperature: ${roomTemperature}${obj.temperatureUnit}`);
-                                    this.emit('info', `${heatPumpName}, Temperature display unit: ${obj.temperatureUnit}`);
-                                    this.emit('info', `${heatPumpName}, Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
+                                    this.emit('info', `Power: ${power ? 'On' : 'Off'}`)
+                                    this.emit('info', `Operation mode: ${HeatPump.SystemMapEnumToString[unitStatus]}`);
+                                    this.emit('info', `Outdoor temperature: ${roomTemperature}${obj.temperatureUnit}`);
+                                    this.emit('info', `Temperature display unit: ${obj.temperatureUnit}`);
+                                    this.emit('info', `Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
+                                    if (this.accountType === 'melcloudhome') this.emit('info', `Signal strength: ${deviceData.Rssi}dBm`);
                                     break;
                                 case caseZone1: //Zone 1 - HEAT THERMOSTAT, HEAT FLOW, HEAT CURVE, COOL THERMOSTAT, COOL FLOW, FLOOR DRY UP
                                     operationModeText = idleZone1 ? HeatPump.ZoneOperationMapEnumToString[6] : HeatPump.ZoneOperationMapEnumToString[operationModeZone1];
-                                    this.emit('info', `${zone1Name}, Operation mode: ${operationModeText}`);
-                                    this.emit('info', `${zone1Name}, Temperature: ${roomTemperature}${obj.temperatureUnit}`);
-                                    this.emit('info', `${zone1Name}, Target temperature: ${setTemperature}${obj.temperatureUnit}`)
-                                    this.emit('info', `${zone1Name}, Temperature display unit: ${obj.temperatureUnit}`);
-                                    this.emit('info', `${zone1Name}, Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
+                                    this.emit('info', `Operation mode: ${operationModeText}`);
+                                    this.emit('info', `Temperature: ${roomTemperature}${obj.temperatureUnit}`);
+                                    this.emit('info', `Target temperature: ${setTemperature}${obj.temperatureUnit}`)
+                                    this.emit('info', `Temperature display unit: ${obj.temperatureUnit}`);
+                                    this.emit('info', `Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
                                     break;
                                 case caseHotWater: //Hot Water - AUTO, HEAT NOW
                                     operationModeText = operationMode === 1 ? HeatPump.ForceDhwMapEnumToString[1] : HeatPump.ForceDhwMapEnumToString[forcedHotWaterMode ? 1 : 0];
-                                    this.emit('info', `${hotWaterName}, Operation mode: ${operationModeText}`);
-                                    this.emit('info', `${hotWaterName}, Temperature: ${roomTemperature}${obj.temperatureUnit}`);
-                                    this.emit('info', `${hotWaterName}, Target temperature: ${setTemperature}${obj.temperatureUnit}`)
-                                    this.emit('info', `${hotWaterName}, Temperature display unit: ${obj.temperatureUnit}`);
-                                    this.emit('info', `${hotWaterName}, Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
+                                    this.emit('info', `Operation mode: ${operationModeText}`);
+                                    this.emit('info', `Temperature: ${roomTemperature}${obj.temperatureUnit}`);
+                                    this.emit('info', `Target temperature: ${setTemperature}${obj.temperatureUnit}`)
+                                    this.emit('info', `Temperature display unit: ${obj.temperatureUnit}`);
+                                    this.emit('info', `Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
                                     break;
                                 case caseZone2: //Zone 2 - HEAT THERMOSTAT, HEAT FLOW, HEAT CURVE, COOL THERMOSTAT, COOL FLOW, FLOOR DRY UP
                                     operationModeText = idleZone2 ? HeatPump.ZoneOperationMapEnumToString[6] : HeatPump.ZoneOperationMapEnumToString[operationModeZone2];
-                                    this.emit('info', `${zone2Name}, Operation mode: ${operationModeText}`);
-                                    this.emit('info', `${zone2Name}, Temperature: ${roomTemperature}${obj.temperatureUnit}`);
-                                    this.emit('info', `${zone2Name}, Target temperature: ${setTemperature}${obj.temperatureUnit}`)
-                                    this.emit('info', `${zone2Name}, Temperature display unit: ${obj.temperatureUnit}`);
-                                    this.emit('info', `${zone2Name}, Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
+                                    this.emit('info', `Operation mode: ${operationModeText}`);
+                                    this.emit('info', `Temperature: ${roomTemperature}${obj.temperatureUnit}`);
+                                    this.emit('info', `Target temperature: ${setTemperature}${obj.temperatureUnit}`)
+                                    this.emit('info', `Temperature display unit: ${obj.temperatureUnit}`);
+                                    this.emit('info', `Lock physical controls: ${lockPhysicalControl ? 'Locked' : 'Unlocked'}`);
                                     break;
                             };
-                        };
-                    };
+                        }
+                    }
 
                     //update sensors characteristics
                     for (let i = 0; i < zonesSensorsCount; i++) {
@@ -2064,7 +2119,7 @@ class DeviceAtw extends EventEmitter {
                                     break;
                             };
                         };
-                    };
+                    }
                     this.accessory = obj;
 
                     //update services
@@ -2078,6 +2133,13 @@ class DeviceAtw extends EventEmitter {
                     this.connectService?.updateCharacteristic(Characteristic.ContactSensorState, isConnected);
                     this.errorService?.updateCharacteristic(Characteristic.ContactSensorState, isInError);
 
+                    //frost protection
+                    if (this.frostProtectionSupport && frostProtectionEnabled !== null) {
+                        this.frostProtectionControlService?.updateCharacteristic(Characteristic.On, frostProtectionEnabled);
+                        this.frostProtectionControlSensorService?.updateCharacteristic(Characteristic.ContactSensorState, frostProtectionEnabled);
+                        this.frostProtectionSensorService?.updateCharacteristic(Characteristic.ContactSensorState, frostProtectionActive);
+                    }
+
                     //holiday mode
                     if (this.holidayModeSupport && holidayModeEnabled !== null) {
                         this.holidayModeControlService?.updateCharacteristic(Characteristic.On, holidayModeEnabled);
@@ -2112,7 +2174,7 @@ class DeviceAtw extends EventEmitter {
                             //sensor
                             if (preset.displayType < 7) this.presetControlSensorServices?.[i]?.updateCharacteristic(characteristicType, preset.state);
                         });
-                    };
+                    }
 
                     ///schedules
                     if (this.schedules.length > 0 && scheduleEnabled !== null) {
@@ -2132,7 +2194,7 @@ class DeviceAtw extends EventEmitter {
                             //sensor
                             if (schedule.displayType < 7) this.scheduleSensorServices?.[i]?.updateCharacteristic(characteristicType, schedule.state);
                         });
-                    };
+                    }
 
                     //scenes
                     if (this.scenes.length > 0) {
@@ -2149,7 +2211,7 @@ class DeviceAtw extends EventEmitter {
                             //sensor
                             if (scene.displayType < 7) this.sceneControlSensorServices?.[i]?.updateCharacteristic(characteristicType, scene.state);
                         });
-                    };
+                    }
 
                     //buttons
                     if (this.buttons.length > 0) {
@@ -2237,7 +2299,7 @@ class DeviceAtw extends EventEmitter {
                             //sensor
                             if (button.displayType < 7) this.buttonControlSensorServices?.[i]?.updateCharacteristic(characteristicType, button.state);
                         });
-                    };
+                    }
                 })
                 .on('success', (success) => this.emit('success', success))
                 .on('info', (info) => this.emit('info', info))

package/src/deviceerv.js

@@ -586,7 +586,7 @@ class DeviceErv extends EventEmitter {
                         return state;
                     })
                 accessory.addService(this.roomTemperatureSensorService);
-            };
+            }
 
             //temperature sensor service supply
             if (this.temperatureSupplySensor && supportsSupplyTemperature && this.accessory.supplyTemperature !== null) {
@@ -600,7 +600,7 @@ class DeviceErv extends EventEmitter {
                         return state;
                     })
                 accessory.addService(this.supplyTemperatureSensorService);
-            };
+            }
 
             //temperature sensor service outdoor
             if (this.temperatureOutdoorSensor && supportsOutdoorTemperature && this.accessory.outdoorTemperature !== null) {
@@ -614,7 +614,7 @@ class DeviceErv extends EventEmitter {
                         return state;
                     })
                 accessory.addService(this.outdoorTemperatureSensorService);
-            };
+            }
 
             //core maintenance
             if (this.accessory.coreMaintenanceRequired !== null) {
@@ -849,7 +849,7 @@ class DeviceErv extends EventEmitter {
                         accessory.addService(presetControlSensorService);
                     }
                 });
-            };
+            }
 
             //schedules services
             if (this.schedules.length > 0 && this.accessory.scheduleEnabled !== null) {
@@ -923,7 +923,7 @@ class DeviceErv extends EventEmitter {
                         accessory.addService(scheduleSensorService);
                     }
                 });
-            };
+            }
 
             //scenes
             if (this.scenes.length > 0) {
@@ -982,7 +982,7 @@ class DeviceErv extends EventEmitter {
                         accessory.addService(sceneControlSensorService);
                     }
                 });
-            };
+            }
 
             //buttons services
             if (this.buttons.length > 0) {
@@ -1118,7 +1118,7 @@ class DeviceErv extends EventEmitter {
                         accessory.addService(buttonControlSensorService);
                     }
                 });
-            };
+            }
 
             return accessory;
         } catch (error) {
@@ -1454,7 +1454,7 @@ class DeviceErv extends EventEmitter {
                             //sensor
                             if (preset.displayType < 7) this.presetControlSensorServices?.[i]?.updateCharacteristic(characteristicType, preset.state);
                         });
-                    };
+                    }
 
                     ///schedules
                     if (this.schedules.length > 0 && scheduleEnabled !== null) {
@@ -1474,7 +1474,7 @@ class DeviceErv extends EventEmitter {
                             //sensor
                             if (schedule.displayType < 7) this.scheduleSensorServices?.[i]?.updateCharacteristic(characteristicType, schedule.state);
                         });
-                    };
+                    }
 
                     //scenes
                     if (this.scenes.length > 0) {
@@ -1491,7 +1491,7 @@ class DeviceErv extends EventEmitter {
                             //sensor
                             if (scene.displayType < 7) this.sceneControlSensorServices?.[i]?.updateCharacteristic(characteristicType, scene.state);
                         });
-                    };
+                    }
 
                     //buttons
                     if (this.buttons.length > 0) {
@@ -1552,7 +1552,7 @@ class DeviceErv extends EventEmitter {
                             //sensor
                             if (button.displayType < 7) this.buttonControlSensorServices?.[i]?.updateCharacteristic(characteristicType, button.state);
                         });
-                    };
+                    }
 
                     //log current state
                     if (this.logInfo) {
@@ -1571,7 +1571,8 @@ class DeviceErv extends EventEmitter {
                         if (supportsCO2Sensor) this.emit('info', `CO2 level: ${roomCO2Level} ppm`);
                         if (supportsPM25Sensor) this.emit('info', `PM2.5 air quality: ${Ventilation.PM25AirQualityMapEnumToString[pM25AirQuality]}`);
                         if (supportsPM25Sensor) this.emit('info', `PM2.5 level: ${pM25Level} µg/m`);
-                    };
+                        if (this.accountType === 'melcloudhome') this.emit('info', `Signal strength: ${deviceData.Rssi}dBm`);
+                    }
                 })
                 .on('success', (success) => this.emit('success', success))
                 .on('info', (info) => this.emit('info', info))

package/src/functions.js

@@ -160,5 +160,13 @@ class Functions extends EventEmitter {
         return v !== undefined && v !== null && !(typeof v === 'number' && Number.isNaN(v));
     }
 
+    convertValue(value) {
+        let parsedValue = value;
+        if (value === "True") parsedValue = true;
+        else if (value === "False") parsedValue = false;
+        else if (!isNaN(value) && value !== "") parsedValue = Number(value);
+        return parsedValue;
+    }
+
 }
 export default Functions

package/src/melcloudata.js

@@ -70,17 +70,8 @@ class MelCloudAta extends EventEmitter {
         this.socketConnected = false;
     }
 
-    async checkState() {
+    async updateState(deviceData) {
         try {
-
-            //read device info from file
-            const devicesData = await this.functions.readData(this.devicesFile, true);
-            if (!devicesData) return;
-
-            this.headers = devicesData.Headers;
-            const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
-            deviceData.Scenes = devicesData.Scenes ?? [];
-
             if (this.accountType === 'melcloudhome') {
                 deviceData.Device.OperationMode = AirConditioner.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
                 deviceData.Device.ActualFanSpeed = AirConditioner.FanSpeedMapStringToEnum[deviceData.Device.ActualFanSpeed] ?? deviceData.Device.ActualFanSpeed;
@@ -93,87 +84,6 @@ class MelCloudAta extends EventEmitter {
                 deviceData.Device.DefaultHeatingSetTemperature = temps?.defaultHeatingSetTemperature ?? 20;
                 deviceData.Device.DefaultCoolingSetTemperature = temps?.defaultCoolingSetTemperature ?? 24;
 
-                //web cocket connection
-                if (!this.connecting && !this.socketConnected) {
-                    this.connecting = true;
-
-                    const url = `${ApiUrlsHome.WebSocketURL}${devicesData.WebSocketOptions.Hash}`;
-                    try {
-                        const socket = new WebSocket(url, { headers: devicesData.WebSocketOptions.Headers })
-                            .on('error', (error) => {
-                                if (this.logError) this.emit('error', `Socket error: ${error}`);
-                                socket.close();
-                            })
-                            .on('close', () => {
-                                if (this.logDebug) this.emit('debug', `Socket closed`);
-                                this.cleanupSocket();
-                            })
-                            .on('open', () => {
-                                this.socket = socket;
-                                this.socketConnected = true;
-                                this.connecting = false;
-                                if (this.logSuccess) this.emit('success', `Socket Connect Success`);
-
-                                // heartbeat
-                                this.heartbeat = setInterval(() => {
-                                    if (socket.readyState === socket.OPEN) {
-                                        if (this.logDebug) this.emit('debug', `Socket send heartbeat`);
-                                        socket.ping();
-                                    }
-                                }, 30000);
-                            })
-                            .on('pong', () => {
-                                if (this.logDebug) this.emit('debug', `Socket received heartbeat`);
-                            })
-                            .on('message', (message) => {
-                                const parsedMessage = JSON.parse(message);
-                                const stringifyMessage = JSON.stringify(parsedMessage, null, 2);
-                                if (this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
-                                if (parsedMessage.message === 'Forbidden') return;
-
-                                const messageData = parsedMessage?.[0]?.Data;
-                                if (!messageData) return;
-
-                                let updateDeviceState = false;
-                                const unitId = messageData?.id;
-                                switch (unitId) {
-                                    case this.deviceId:
-                                        const messageType = parsedMessage[0].messageType;
-                                        switch (messageType) {
-                                            case 'unitStateChanged':
-                                                const settings = Object.fromEntries(
-                                                    messageData.settings.map(({ name, value }) => {
-                                                        let parsedValue = value;
-                                                        if (value === "True") parsedValue = true;
-                                                        else if (value === "False") parsedValue = false;
-                                                        else if (!isNaN(value) && value !== "") parsedValue = Number(value);
-                                                        return [name, parsedValue];
-                                                    })
-                                                );
-                                                Object.assign(deviceData.Device, settings);
-                                                updateDeviceState = true;
-                                                break;
-                                            case 'unitWifiSignalChanged':
-                                                Object.assign(deviceData, messageData.rssi);
-                                                updateDeviceState = true;
-                                                break;
-                                            default:
-                                                if (this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
-                                                return;
-                                        }
-                                        break;
-                                    default:
-                                        if (this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
-                                        return;
-                                }
-
-                                if (updateDeviceState) this.emit('deviceState', deviceData);
-                            });
-                    } catch (error) {
-                        if (this.logError) this.emit('error', `Socket connection failed: ${error}`);
-                        this.cleanupSocket();
-                    }
-                }
             }
             if (this.logDebug) this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`);
 
@@ -233,6 +143,107 @@ class MelCloudAta extends EventEmitter {
         };
     };
 
+    async checkState() {
+        try {
+
+            //read device info from file
+            const devicesData = await this.functions.readData(this.devicesFile, true);
+            if (!devicesData) return;
+
+            this.headers = devicesData.Headers;
+            const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+            deviceData.Scenes = devicesData.Scenes ?? [];
+
+            //web cocket connection
+            if (this.accountType === 'melcloudhome' && !this.connecting && !this.socketConnected) {
+                this.connecting = true;
+
+                const url = `${ApiUrlsHome.WebSocketURL}${devicesData.WebSocketOptions.Hash}`;
+                try {
+                    const socket = new WebSocket(url, { headers: devicesData.WebSocketOptions.Headers })
+                        .on('error', (error) => {
+                            if (this.logError) this.emit('error', `Socket error: ${error}`);
+                            socket.close();
+                        })
+                        .on('close', () => {
+                            if (this.logDebug) this.emit('debug', `Socket closed`);
+                            this.cleanupSocket();
+                        })
+                        .on('open', () => {
+                            this.socket = socket;
+                            this.socketConnected = true;
+                            this.connecting = false;
+                            if (this.logSuccess) this.emit('success', `Socket Connect Success`);
+
+                            // heartbeat
+                            this.heartbeat = setInterval(() => {
+                                if (socket.readyState === socket.OPEN) {
+                                    if (this.logDebug) this.emit('debug', `Socket send heartbeat`);
+                                    socket.ping();
+                                }
+                            }, 30000);
+                        })
+                        .on('pong', () => {
+                            if (this.logDebug) this.emit('debug', `Socket received heartbeat`);
+                        })
+                        .on('message', async (message) => {
+                            const parsedMessage = JSON.parse(message);
+                            const stringifyMessage = JSON.stringify(parsedMessage, null, 2);
+                            if (this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
+                            if (parsedMessage.message === 'Forbidden') return;
+
+                            const messageData = parsedMessage?.[0]?.Data;
+                            if (!messageData) return;
+
+                            let updateDeviceState = false;
+                            const unitId = messageData?.id;
+                            switch (unitId) {
+                                case this.deviceId:
+                                    const messageType = parsedMessage[0].messageType;
+                                    switch (messageType) {
+                                        case 'unitStateChanged':
+                                            const settings = Object.fromEntries(
+                                                messageData.settings.map(({ name, value }) => {
+                                                    let parsedValue = this.functions.convertValue(value);
+                                                    return [name, parsedValue];
+                                                })
+                                            );
+                                            Object.assign(deviceData.Device, settings);
+                                            updateDeviceState = true;
+                                            break;
+                                        case 'unitWifiSignalChanged':
+                                            deviceData.Rssi = messageData.rssi;
+                                            updateDeviceState = true;
+                                            break;
+                                        default:
+                                            if (!this.logDebug) this.emit('debug', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
+                                            return;
+                                    }
+                                    break;
+                                default:
+                                    if (!this.logDebug) this.emit('debug', `Incoming unknown unit id: ${stringifyMessage}`);
+                                    return;
+                            }
+
+                            //update state
+                            if (updateDeviceState) await this.updateState(deviceData);
+                        });
+                } catch (error) {
+                    if (this.logError) this.emit('error', `Socket connection failed: ${error}`);
+                    this.cleanupSocket();
+                }
+            }
+            if (this.logDebug) this.emit('debug', `Device Data: ${JSON.stringify(deviceData, null, 2)}`);
+
+            //update state
+            await this.updateState(deviceData);
+
+            return true;
+        } catch (error) {
+            throw new Error(`Check state error: ${error.message}`);
+        };
+    };
+
     async send(accountType, displayType, deviceData, flag, flagData) {
         try {
             let method = null
@@ -374,7 +385,7 @@ class MelCloudAta extends EventEmitter {
                         data: payload
                     });
 
-                    this.updateData(deviceData, updateState);
+                    await this.updateData(deviceData, updateState);
                     return true;
                 default:
                     return;
@@ -385,9 +396,9 @@ class MelCloudAta extends EventEmitter {
         }
     }
 
-    updateData(deviceData, updateState = true) {
+    async updateData(deviceData, updateState = true) {
         this.locks = true;
-        if (updateState) this.emit('deviceState', deviceData);
+        if (updateState) await this.updateState(deviceData);
 
         setTimeout(() => {
             this.locks = false

package/src/melcloudhome.js

@@ -145,11 +145,7 @@ class MelCloudHome extends EventEmitter {
 
                     const settingsObject = Object.fromEntries(
                         settingsArray.map(({ name, value }) => {
-                            let parsedValue = value;
-                            if (value === "True") parsedValue = true;
-                            else if (value === "False") parsedValue = false;
-                            else if (!isNaN(value) && value !== "") parsedValue = Number(value);
-
+                            let parsedValue = this.functions.convertValue(value);
                             const key = name.charAt(0).toUpperCase() + name.slice(1);
                             return [key, parsedValue];
                         })