homebridge-melcloud-control 4.3.0-beta.44 → 4.3.0-beta.46

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.3.0-beta.44",
+  "version": "4.3.0-beta.46",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/melcloudata.js

@@ -91,6 +91,12 @@ class MelCloudAta extends EventEmitter {
 
             this.headers = devicesData.Headers;
             const deviceData = devicesData.Devices.find(device => device.DeviceID === this.deviceId);
+
+            //check state changes
+            const deviceDataHasNotChanged = JSON.stringify(deviceData) === JSON.stringify(this.deviceData);
+            if (deviceDataHasNotChanged) return;
+            this.deviceData = deviceData;
+
             if (this.accountType === 'melcloudhome') {
                 deviceData.Scenes = devicesData.Scenes ?? [];
                 deviceData.Device.OperationMode = AirConditioner.OperationModeMapStringToEnum[deviceData.Device.OperationMode] ?? deviceData.Device.OperationMode;
@@ -136,7 +142,9 @@ class MelCloudAta extends EventEmitter {
                             })
                             .on('message', (message) => {
                                 const parsedMessage = JSON.parse(message);
-                                if (!this.logDebug) this.emit('warn', `Incoming message: ${JSON.stringify(parsedMessage, null, 2)}`);
+                                const stringifyMessage = JSON.stringify(parsedMessage, null, 2);
+                                if (this.logDebug) this.emit('debug', `Incoming message: ${stringifyMessage}`);
+                                if (parsedMessage.message === 'Forbidden') return;
 
                                 const messageData = parsedMessage?.[0]?.Data;
                                 const unitId = messageData?.id;
@@ -157,19 +165,18 @@ class MelCloudAta extends EventEmitter {
 
                                                 this.emit('deviceState', deviceData);
                                                 break;
-                                            case 'unitWiFiChanged':
-                                                const state = Object.fromEntries(messageData.settings.map(s => [s.name, s.value]));
-                                                Object.assign(deviceData.Device, state);
+                                            case 'unitWifiSignalChanged':
+                                                Object.assign(deviceData, messageData.rssi);
 
                                                 this.emit('deviceState', deviceData);
                                                 break;
                                             default:
-                                                if (this.logWarn) this.emit('warn', `Incoming unknown message type: ${messageType}`);
+                                                if (this.logWarn) this.emit('warn', `Unit ${unitId}, received unknown message type: ${stringifyMessage}`);
                                                 return;
                                         }
                                         break;
                                     default:
-                                        if (this.logWarn) this.emit('warn', `Incoming unknown unit id: ${unitId}`);
+                                        if (this.logWarn) this.emit('warn', `Incoming unknown unit id: ${stringifyMessage}`);
                                         return;
                                 }
                             });
@@ -220,11 +227,6 @@ class MelCloudAta extends EventEmitter {
                 this.emit('mqtt', 'State', deviceData.Device);
             }
 
-            //check state changes
-            const deviceDataHasNotChanged = JSON.stringify(deviceData) === JSON.stringify(this.deviceData);
-            if (deviceDataHasNotChanged) return;
-            this.deviceData = deviceData;
-
             //emit info
             this.emit('deviceInfo', indoor.model, outdoor.model, serialNumber, firmwareAppVersion);
 
@@ -365,6 +367,7 @@ class MelCloudAta extends EventEmitter {
                             break;
                     }
 
+                    //sens payload
                     this.headers['Content-Type'] = 'application/json; charset=utf-8';
                     this.headers.Origin = ApiUrlsHome.Origin;
                     if (this.logDebug) this.emit('debug', `Send Data: ${JSON.stringify(payload, null, 2)}`);