homebridge-melcloud-control 4.2.6-beta.15 → 4.2.6-beta.17

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.2.6-beta.15",
+  "version": "4.2.6-beta.17",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -1541,7 +1541,6 @@ class DeviceAta extends EventEmitter {
                                 obj.currentFanSpeed = speeds[setFanSpeed];
                                 obj.fanSpeedSetPropsMaxValue = supportsAutomaticFanSpeed ? max + 1 : max;
                             }
-                            this.accessory = obj;
 
                             //create characteristics
                             characteristics.push(
@@ -1615,7 +1614,6 @@ class DeviceAta extends EventEmitter {
                             obj.operationModeSetPropsMinValue = 0
                             obj.operationModeSetPropsMaxValue = supportsAuto && supportsHeat ? 3 : !supportsAuto && supportsHeat ? 2 : supportsAuto && !supportsHeat ? 3 : 2;
                             obj.operationModeSetPropsValidValues = supportsAuto && supportsHeat ? [0, 1, 2, 3] : !supportsAuto && supportsHeat ? [0, 1, 2] : supportsAuto && !supportsHeat ? [0, 2, 3] : [0, 2];
-                            this.accessory = obj;
 
                             //create characteristics
                             characteristics.push(
@@ -1627,6 +1625,7 @@ class DeviceAta extends EventEmitter {
                             );
                             break;
                     };
+                    this.accessory = obj;
 
                     //update services
                     for (const { type, value } of characteristics) {

package/src/deviceatw.js

@@ -99,9 +99,9 @@ class DeviceAtw extends EventEmitter {
         }
 
         this.functions = new Functions(this.logWarn, this.logError, this.logDebug)
-                    .on('warn', warn => this.emit('warn', warn))
-                    .on('error', error => this.emit('error', error))
-                    .on('debug', debug => this.emit('debug', debug));
+            .on('warn', warn => this.emit('warn', warn))
+            .on('error', error => this.emit('error', error))
+            .on('debug', debug => this.emit('debug', debug));
 
         //device data
         this.deviceData = {};
@@ -1913,12 +1913,6 @@ class DeviceAtw extends EventEmitter {
                                 break;
                         };
 
-                        //update services
-                        for (const { type, value } of characteristics) {
-                            if (!this.functions.isValidValue(value)) continue;
-                            this.melCloudService?.[i]?.updateCharacteristic(type, value);
-                        }
-
                         //add every zone to array
                         const zone = {
                             name: name,
@@ -2061,6 +2055,12 @@ class DeviceAtw extends EventEmitter {
                     };
                     this.accessory = obj;
 
+                    //update services
+                    for (const { type, value } of characteristics) {
+                        if (!this.functions.isValidValue(value)) continue;
+                        this.melCloudService?.[i]?.updateCharacteristic(type, value);
+                    }
+
                     //other sensors
                     this.inStandbyService?.updateCharacteristic(Characteristic.ContactSensorState, inStandbyMode);
                     this.connectService?.updateCharacteristic(Characteristic.ContactSensorState, isConnected);

package/src/deviceerv.js

@@ -1320,7 +1320,6 @@ class DeviceErv extends EventEmitter {
                                 obj.fanSpeed = speeds[setFanSpeed];
                                 obj.fanSpeedSetPropsMaxValue = supportsAutomaticFanSpeed ? max + 1 : max;
                             }
-                            this.accessory = obj;
 
                             //create characteristics
                             characteristics.push(
@@ -1371,15 +1370,6 @@ class DeviceErv extends EventEmitter {
                             obj.operationModeSetPropsMinValue = supportsAutoVentilationMode ? 0 : 0;
                             obj.operationModeSetPropsMaxValue = supportsAutoVentilationMode ? 3 : 2;
                             obj.operationModeSetPropsValidValues = supportsAutoVentilationMode ? (supportsBypassVentilationMode ? [0, 1, 2, 3] : [0, 2, 3]) : (supportsBypassVentilationMode ? [0, 1, 2] : [0, 2]);
-                            this.accessory = obj;
-
-                            //update characteristics
-                            this.melCloudService
-                                ?.updateCharacteristic(Characteristic.CurrentHeatingCoolingState, obj.currentOperationMode)
-                                .updateCharacteristic(Characteristic.TargetHeatingCoolingState, obj.targetOperationMode)
-                                .updateCharacteristic(Characteristic.CurrentTemperature, roomTemperature)
-                                .updateCharacteristic(Characteristic.TargetTemperature, setTemperature)
-                                .updateCharacteristic(Characteristic.TemperatureDisplayUnits, obj.useFahrenheit);
 
                             //create characteristics
                             characteristics.push(
@@ -1392,6 +1382,8 @@ class DeviceErv extends EventEmitter {
                             break;
                     };
 
+                    this.accessory = obj;
+
                     //update services
                     for (const { type, value } of characteristics) {
                         if (!this.functions.isValidValue(value)) continue;