homebridge-melcloud-control 4.2.5-beta.3 → 4.2.5-beta.4

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.2.5-beta.3",
+  "version": "4.2.5-beta.4",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceatw.js

@@ -1378,9 +1378,6 @@ class DeviceAtw extends EventEmitter {
                     //get button mode
                     const mode = button.mode;
 
-                    //get button display type
-                    const displayType = button.displayType;
-
                     //get button name
                     const name = button.name;
 
@@ -1394,10 +1391,10 @@ class DeviceAtw extends EventEmitter {
                     //control
                     if (button.displayType > 3) {
                         if (this.logDebug) this.emit('debug', `Prepare button control ${name} service`);
-                        const buttonControlService = new serviceType(serviceName, `buttonControlService${deviceId} ${i}`);
+                        const buttonControlService = new serviceType(serviceName1, `buttonControlService${deviceId} ${i}`);
                         buttonControlService.addOptionalCharacteristic(Characteristic.ConfiguredName);
                         buttonControlService.setCharacteristic(Characteristic.ConfiguredName, serviceName1);
-                        buttonControlService.getCharacteristic(characteristicType)
+                        buttonControlService.getCharacteristic(Characteristic.On)
                             .onGet(async () => {
                                 const state = button.state;
                                 return state;
@@ -1552,9 +1549,9 @@ class DeviceAtw extends EventEmitter {
 
                     //sensor
                     if (this.logDebug) this.emit('debug', `Prepare button control sensor ${name} service`);
-                    const buttonControlSensorService = new serviceType(serviceName, `buttonControlSensorService${deviceId} ${i}`);
+                    const buttonControlSensorService = new serviceType(serviceName1, `buttonControlSensorService${deviceId} ${i}`);
                     buttonControlSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
-                    buttonControlSensorService.setCharacteristic(Characteristic.ConfiguredName, serviceName);
+                    buttonControlSensorService.setCharacteristic(Characteristic.ConfiguredName, serviceName1);
                     buttonControlSensorService.getCharacteristic(characteristicType)
                         .onGet(async () => {
                             const state = button.state;

package/src/deviceerv.js

@@ -983,12 +983,12 @@ class DeviceErv extends EventEmitter {
                     const mode = button.mode;
 
                     //get button name
-                    const buttonName = button.name;
+                    const name = button.name;
 
                     //get button name prefix
                     const namePrefix = button.namePrefix;
 
-                    const serviceName1 = namePrefix ? `${accessoryName} ${buttonName}` : buttonName;
+                    const serviceName1 = namePrefix ? `${accessoryName} ${name}` : name;
                     const serviceType = button.serviceType;
                     const characteristicType = button.characteristicType;
 
@@ -1082,7 +1082,7 @@ class DeviceErv extends EventEmitter {
                                             break;
                                     };
 
-                                    if (this.logInfo) this.emit('info', `${state ? `Set: ${buttonName}` : `Unset: ${buttonName}, Set: ${button.previousValue}`}`);
+                                    if (this.logInfo) this.emit('info', `${state ? `Set: ${name}` : `Unset: ${name}, Set: ${button.previousValue}`}`);
                                     await this.melCloudErv.send(this.accountType, this.displayType, deviceData, flag);
                                 } catch (error) {
                                     if (this.logWarn) this.emit('warn', `Set button error: ${error}`);
@@ -1094,9 +1094,9 @@ class DeviceErv extends EventEmitter {
 
                     //sensor
                     if (this.logDebug) this.emit('debug', `Prepare button control sensor ${name} service`);
-                    const buttonControlSensorService = new serviceType(serviceName, `buttonControlSensorService${deviceId} ${i}`);
+                    const buttonControlSensorService = new serviceType(serviceName1, `buttonControlSensorService${deviceId} ${i}`);
                     buttonControlSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
-                    buttonControlSensorService.setCharacteristic(Characteristic.ConfiguredName, serviceName);
+                    buttonControlSensorService.setCharacteristic(Characteristic.ConfiguredName, serviceName1);
                     buttonControlSensorService.getCharacteristic(characteristicType)
                         .onGet(async () => {
                             const state = button.state;