homebridge-melcloud-control 4.2.3-beta.58 → 4.2.3-beta.59

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.2.3-beta.58",
+  "version": "4.2.3-beta.59",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -911,7 +911,7 @@ class DeviceAta extends EventEmitter {
 
                     //sensor
                     if (this.logDebug) this.emit('debug', `Prepare preset control sensor s${name}  ervice`);
-                    const presetControlSensorService = new serviceType(`${serviceName1} Control`, `presetControlSensorService${deviceId} ${i}`);
+                    const presetControlSensorService = new serviceType(serviceName1, `presetControlSensorService${deviceId} ${i}`);
                     presetControlSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
                     presetControlSensorService.setCharacteristic(Characteristic.ConfiguredName, `${serviceName1} Control`);
                     presetControlSensorService.getCharacteristic(characteristicType)
@@ -944,7 +944,7 @@ class DeviceAta extends EventEmitter {
                     if (i === 0) {
                         if (schedule.displayType > 3) {
                             if (this.logDebug) this.emit('debug', `Prepare schedule control ${name} service`);
-                            this.scheduleControlService = new Service.Switch(`${serviceName1} Control`, `scheduleControlService${deviceId} ${i}`);
+                            this.scheduleControlService = new Service.Switch(serviceName1, `scheduleControlService${deviceId} ${i}`);
                             this.scheduleControlService.addOptionalCharacteristic(Characteristic.ConfiguredName);
                             this.scheduleControlService.setCharacteristic(Characteristic.ConfiguredName, serviceName1);
                             this.scheduleControlService.getCharacteristic(Characteristic.On)
@@ -1630,6 +1630,7 @@ class DeviceAta extends EventEmitter {
                     if (this.presets.length > 0) {
                         this.presets.forEach((preset, i) => {
                             const presetData = presetsOnServer.find(p => p.ID === preset.id);
+                            const characteristicType = preset.characteristicType;
 
                             preset.state = presetData ? (presetData.Power === power
                                 && presetData.SetTemperature === setTemperature
@@ -1638,7 +1639,6 @@ class DeviceAta extends EventEmitter {
                                 && presetData.VaneVerticalDirection === vaneVerticalDirection
                                 && presetData.FanSpeed === setFanSpeed) : false;
 
-                            const characteristicType = preset.characteristicType;
                             if (preset.displayType > 3) {
                                 this.presetControlServices?.[i]?.updateCharacteristic(Characteristic.On, preset.state);
                             }
@@ -1650,8 +1650,8 @@ class DeviceAta extends EventEmitter {
                     if (this.schedules.length > 0 && scheduleEnabled !== null) {
                         this.schedules.forEach((schedule, i) => {
                             const scheduleData = schedulesOnServer.find(s => s.Id === schedule.id);
-                            schedule.state = scheduleEnabled ? scheduleData.Enabled ?? false : false;
                             const characteristicType = schedule.characteristicType;
+                            schedule.state = scheduleEnabled ? scheduleData.Enabled ?? false : false;
 
                             //control
                             if (i === 0) {
@@ -1662,7 +1662,7 @@ class DeviceAta extends EventEmitter {
                             }
 
                             //sensors
-                            this.schedulesServices?.[i]?.updateCharacteristic(characteristicType, schedule.state);
+                            this.scheduleSensorServices?.[i]?.updateCharacteristic(characteristicType, schedule.state);
                         });
                     };