homebridge-melcloud-control 4.2.2-beta.11 → 4.2.2-beta.13

package/README.md

@@ -245,8 +245,8 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
 | `ataDevices[].autoDryFanMode` | Here select the operatiing mode for `Auto`, if this mode is not supported, it will be disabled.. |
 | `ataDevices[].temperatureSensor` | This enable extra `Room` temperature sensor to use with automations in HomeKit app. |
 | `ataDevices[].temperatureOutdoorSensor` | This enable extra `Outdoor` temperature sensor to use with automations in HomeKit app. |
-| `ataDevices[].inStandbySensor` | This enable `In Standby` sensor to use with automations in HomeKit app. |
-| `ataDevices[].connectSensor` | This enable `Connect` sensor to use with automations in HomeKit app. |
+| `ataDevices[].inStandbySensor` | This enable `In Standby Mode` sensor to use with automations in HomeKit app. |
+| `ataDevices[].connectSensor` | This enable `Connect State` sensor to use with automations in HomeKit app. |
 | `ataDevices[].errorSensor` | This enable `Error` sensor to use with automations in HomeKit app. |
 | `ataDevices[].frostProtectionSupport` | This enable extra `Frost Protectio` control and sensors to use with automations in HomeKit app. |
 | `ataDevices[].overheatProtectionSupport` | This enable extra `Overheat Protection` control and sensors to use with automations in HomeKit app. |
@@ -281,8 +281,8 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
 | `atwDevices[].temperatureReturnWaterTankSensor` | This enable extra `Return Water Tank` temperature sensor to use with automations in HomeKit app. |
 | `atwDevices[].temperatureFlowZone2Sensor` | This enable extra `Flow Zone 2` temperature sensor to use with automations in HomeKit app. |
 | `atwDevices[].temperatureReturnZone2Sensor` | This enable extra `Return Zone 2` temperature sensor to use with automations in HomeKit app. |
-| `atwDevices[].inStandbySensor` | This enable `In Standby` sensor to use with automations in HomeKit app. |
-| `atwDevices[].connectSensor` | This enable `Connect` sensor to use with automations in HomeKit app. |
+| `atwDevices[].inStandbySensor` | This enable `In Standby Mode` sensor to use with automations in HomeKit app. |
+| `atwDevices[].connectSensor` | This enable `Connect State` sensor to use with automations in HomeKit app. |
 | `atwDevices[].errorSensor` | This enable `Error` sensors to use with automations in HomeKit app. |
 | `atwDevices[].holidayModeSupport` | This enable extra `Holiday Mode` control and sensors to use with automations in HomeKit app. |
 | `atwDevices[].refreshInterval` | Here set the background devices state refresh time in (sec), default `5s`. |
@@ -308,8 +308,8 @@ Homebridge plugin for Air Conditioner, Heat Pump and Energy Recovery Ventilation
 | `ervDevices[].temperatureSensor` | This enable extra `Room` temperature sensor to use with automations in HomeKit app. |
 | `ervDevices[].temperatureOutdoorSensor` | This enable extra `Outdoor` temperature sensor to use with automations in HomeKit app. |
 | `ervDevices[].temperatureSupplySensor` | This enable extra `Supply` temperature sensor to use with automations in HomeKit app. |
-| `atwDevices[].inStandbySensor` | This enable `In Standby` sensor to use with automations in HomeKit app. |
-| `ervDevices[].connectSensor` | This enable `Connect` sensor to use with automations in HomeKit app. |
+| `atwDevices[].inStandbySensor` | This enable `In Standby Mode` sensor to use with automations in HomeKit app. |
+| `ervDevices[].connectSensor` | This enable `Connect State` sensor to use with automations in HomeKit app. |
 | `ervDevices[].errorSensor` | This enable `Error` sensors to use with automations in HomeKit app. |
 | `ervDevices[].holidayModeSupport` | This enable extra `Holiday Mode` control and sensors to use with automations in HomeKit app. |
 | `ervDevices[].refreshInterval` | Here set the background devices state refresh time in (sec), default `5s`. |

package/config.schema.json

@@ -405,7 +405,7 @@
                     "title": "Connect",
                     "type": "boolean",
                     "default": false,
-                    "description": "This enable connect sensor to use with automations in HomeKit app."
+                    "description": "This enable connect state sensor to use with automations in HomeKit app."
                   },
                   "errorSensor": {
                     "title": "Error",
@@ -1129,7 +1129,7 @@
                     "title": "Connect",
                     "type": "boolean",
                     "default": false,
-                    "description": "This enable connect sensor to use with automations in HomeKit app."
+                    "description": "This enable connect state sensor to use with automations in HomeKit app."
                   },
                   "errorSensor": {
                     "title": "Error",
@@ -1613,7 +1613,7 @@
                     "title": "Connect",
                     "type": "boolean",
                     "default": false,
-                    "description": "This enable connect sensor to use with automations in HomeKit app."
+                    "description": "This enable connect state sensor to use with automations in HomeKit app."
                   },
                   "errorSensor": {
                     "title": "Error",

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.2.2-beta.11",
+  "version": "4.2.2-beta.13",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -665,7 +665,7 @@ class DeviceAta extends EventEmitter {
                 this.inStandbyService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} In Standby`);
                 this.inStandbyService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.isConnected;
+                        const state = this.accessory.inStandbyMode;
                         return state;
                     })
                 accessory.addService(this.inStandbyService);
@@ -1268,6 +1268,7 @@ class DeviceAta extends EventEmitter {
                     const hideDryModeControl = deviceData.HideDryModeControl ?? false;
 
                     //device info
+                    const supportsStanbyMode = deviceData.Device[supportStandbyKey];
                     const supportsAutomaticFanSpeed = deviceData.Device.HasAutomaticFanSpeed ?? false;
                     const supportsAirDirectionFunction = deviceData.Device[supportAirDirectionKey];
                     const supportsSwingFunction = deviceData.Device[supportSwingKey];
@@ -1282,7 +1283,6 @@ class DeviceAta extends EventEmitter {
                     const supportsCool1 = deviceData.Device[supportCoolKey];
                     const supportsCool = this.coolDryFanMode >= 1 && supportsCool1;
                     const numberOfFanSpeeds = supportsFanSpeed ? deviceData.Device.NumberOfFanSpeeds : 0;
-                    const supportsStanbyMode = deviceData.Device[supportStandbyKey];
                     const minTempHeat = 10;
                     const maxTempHeat = 31;
                     const minTempCoolDryAuto = 16;
@@ -1406,7 +1406,6 @@ class DeviceAta extends EventEmitter {
                                     if (this.logWarn) this.emit('warn', `Unknown operating mode: ${operationMode}`);
                             }
 
-
                             obj.currentOperationMode = !power ? 0 : (inStandbyMode ? 1 : obj.currentOperationMode);
                             obj.operationModeSetPropsMinValue = supportsAuto && supportsHeat ? 0 : !supportsAuto && supportsHeat ? 1 : supportsAuto && !supportsHeat ? 0 : 2;
                             obj.operationModeSetPropsMaxValue = 2
@@ -1491,7 +1490,6 @@ class DeviceAta extends EventEmitter {
                                     break;
                             }
 
-
                             obj.currentOperationMode = !power ? 0 : obj.currentOperationMode;
                             obj.targetOperationMode = !power ? 0 : obj.targetOperationMode;
                             obj.operationModeSetPropsMinValue = 0

package/src/deviceatw.js

@@ -1077,7 +1077,7 @@ class DeviceAtw extends EventEmitter {
                 this.inStandbyService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} In Standby`);
                 this.inStandbyService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.isConnected;
+                        const state = this.accessory.inStandbyMode;
                         return state;
                     })
                 accessory.addService(this.inStandbyService);
@@ -1514,6 +1514,7 @@ class DeviceAtw extends EventEmitter {
                     const holidayModeActive = deviceData.HolidayMode?.Active ?? false;
 
                     //device info
+                    const supportsStanbyMode = deviceData.Device[supportStandbyKey];
                     const supportsHeatPump = ![1, 2, 3, 4, 5, 6, 7, 15].includes(this.hideZone);
                     const supportsZone1 = ![2, 3, 4, 8, 9, 10, 11, 15].includes(this.hideZone);
                     const supportsHotWaterTank = ![3, 5, 6, 9, 10, 12, 13, 15].includes(this.hideZone) && deviceData.Device.HasHotWaterTank;
@@ -1525,7 +1526,6 @@ class DeviceAtw extends EventEmitter {
                     const minSetTemperature = deviceData.Device.MinSetTemperature ?? 10;
                     const maxSetTemperature = deviceData.Device.MaxSetTemperature ?? 30;
                     const maxTankTemperature = deviceData.Device.MaxTankTemperature ?? 70;
-                    const supportsStanbyMode = deviceData.Device[supportStandbyKey];
 
                     //zones
                     let currentZoneCase = 0;

package/src/deviceerv.js

@@ -699,7 +699,7 @@ class DeviceErv extends EventEmitter {
                 this.inStandbyService.setCharacteristic(Characteristic.ConfiguredName, `${accessoryName} In Standby`);
                 this.inStandbyService.getCharacteristic(Characteristic.ContactSensorState)
                     .onGet(async () => {
-                        const state = this.accessory.isConnected;
+                        const state = this.accessory.inStandbyMode;
                         return state;
                     })
                 accessory.addService(this.inStandbyService);
@@ -1067,6 +1067,7 @@ class DeviceErv extends EventEmitter {
                     const hideOutdoorTemperature = deviceData.HideOutdoorTemperature;
 
                     //device info
+                    const supportsStanbyMode = deviceData.Device[supportStandbyKey];
                     const supportsCoolOperationMode = deviceData.Device.HasCoolOperationMode ?? false;
                     const supportsHeatOperationMode = deviceData.Device.HasHeatOperationMode ?? false;
                     const supportsAutoOperationMode = deviceData.Device.HasAutoOperationMode ?? false;
@@ -1074,7 +1075,6 @@ class DeviceErv extends EventEmitter {
                     const supportsSupplyTemperature = deviceData.Device.HasSupplyTemperature ?? false;
                     const supportsOutdoorTemperature = deviceData.Device.HasOutdoorTemperature ?? false;
                     const supportsCO2Sensor = deviceData.Device.HasCO2Sensor ?? false;
-                    const supportsStanbyMode = deviceData.Device[supportStandbyKey];
                     const roomCO2Level = deviceData.Device.RoomCO2Level ?? false;
                     const roomCO2Detected = supportsCO2Sensor && roomCO2Level > 1000 ? true : false;
                     const supportsPM25Sensor = deviceData.Device.HasPM25Sensor ?? false;
@@ -1084,11 +1084,11 @@ class DeviceErv extends EventEmitter {
                     const supportsAutoVentilationMode = deviceData.Device.HasAutoVentilationMode ?? false;
                     const supportsBypassVentilationMode = deviceData.Device.HasBypassVentilationMode ?? false;
                     const supportsAutomaticFanSpeed = deviceData.Device.HasAutomaticFanSpeed ?? false;
-                    const coreMaintenanceRequired = deviceData.Device.CoreMaintenanceRequired;
-                    const filterMaintenanceRequired = deviceData.Device.FilterMaintenanceRequired;
                     const actualVentilationMode = deviceData.Device.ActualVentilationMode;
                     const numberOfFanSpeeds = deviceData.Device.NumberOfFanSpeeds;
                     const supportsFanSpeed = numberOfFanSpeeds > 0;
+                    const coreMaintenanceRequired = deviceData.Device.CoreMaintenanceRequired;
+                    const filterMaintenanceRequired = deviceData.Device.FilterMaintenanceRequired;
                     const temperatureIncrement = deviceData.Device[tempStepKey] ?? 1;
                     const minTempHeat = 10;
                     const maxTempHeat = 31;

package/src/melcloud.js

@@ -283,10 +283,7 @@ class MelCloud extends EventEmitter {
                     if (device.FrostProtection) device.FrostProtection = { ...capitalizeKeys(device.FrostProtection || {}) };
                     if (device.OverheatProtection) device.OverheatProtection = { ...capitalizeKeys(device.OverheatProtection || {}) };
                     if (device.HolidayMode) device.HolidayMode = { ...capitalizeKeys(device.HolidayMode || {}) };
-
-                    if (Array.isArray(device.Schedule)) {
-                        device.Schedule = device.Schedule.map(capitalizeKeysDeep);
-                    }
+                    if (Array.isArray(device.Schedule)) device.Schedule = device.Schedule.map(capitalizeKeysDeep);
 
                     // Usuń stare pola Settings i Capabilities
                     const { Settings, Capabilities, Id, GivenDisplayName, ...rest } = device;

package/src/melcloudata.js

@@ -102,9 +102,7 @@ class MelCloudAta extends EventEmitter {
             }, { indoor: {}, outdoor: {} });
 
             //display info if units are not configured in MELCloud service
-            if (unitsCount === 0) {
-                if (this.logDebug) this.emit('debug', `Units are not configured in MELCloud service`);
-            };
+            if (unitsCount === 0 && this.logDebug) if (this.logDebug) this.emit('debug', `Units are not configured in MELCloud service`);
 
             //restFul
             if (this.restFulEnabled) {

package/src/melcloudatw.js

@@ -93,9 +93,7 @@ class MelCloudAtw extends EventEmitter {
             }, { indoor: {}, outdoor: {} });
 
             //display info if units are not configured in MELCloud service
-            if (unitsCount === 0) {
-                if (this.logDebug) this.emit('debug', `Units are not configured in MELCloud service`);
-            };
+            if (unitsCount === 0 && this.logDebug) if (this.logDebug) this.emit('debug', `Units are not configured in MELCloud service`);
 
             //restFul
             if (this.restFulEnabled) {

package/src/melclouderv.js

@@ -96,9 +96,7 @@ class MelCloudErv extends EventEmitter {
             }, { indoor: {}, outdoor: {} });
 
             //display info if units are not configured in MELCloud service
-            if (unitsCount === 0) {
-                if (this.logDebug) this.emit('debug', `Units are not configured in MELCloud service`);
-            };
+            if (unitsCount === 0 && this.logDebug) if (this.logDebug) this.emit('debug', `Units are not configured in MELCloud service`);
 
             //restFul
             if (this.restFulEnabled) {