homebridge-melcloud-control 4.10.9 → 4.10.10-beta.0

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.10.9",
+  "version": "4.10.10-beta.0",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -385,7 +385,7 @@ class DeviceAta extends EventEmitter {
                             .setProps({
                                 minValue: this.accessory.fanSpeedSetPropsMinValue,
                                 maxValue: this.accessory.fanSpeedSetPropsMaxValue,
-                                minStep: this.accessory.fanSpeedSetPropsMinStep
+                                minStep: 1
                             })
                             .onGet(async () => {
                                 const value = this.accessory.currentFanSpeed;
@@ -396,12 +396,11 @@ class DeviceAta extends EventEmitter {
                                     const payload = {};
                                     const fanKeySet = accountTypeMelCloud ? 'fanSpeed' : 'setFanSpeed';
                                     const max = numberOfFanSpeeds;
-                                    const minFanSpeed = supportsAutomaticFanSpeed ? 0 : 1;
-                                    // Reverse-map from 0-100 HomeKit scale to raw fan speed level
-                                    const rawFanSpeed = value === 0 ? 0 : Math.max(minFanSpeed, Math.min(max, Math.round((value / 100) * max)));
+                                    const minValue = supportsAutomaticFanSpeed ? 0 : 1;
+                                    const clampedValue = Math.min(Math.max(value, minValue), max);
 
-                                    payload[fanKeySet] = rawFanSpeed;
-                                    if (this.logInfo) this.emit('info', `Set fan speed mode: ${AirConditioner.FanSpeedMapEnumToString[rawFanSpeed]}`);
+                                    payload[fanKeySet] = clampedValue;
+                                    if (this.logInfo) this.emit('info', `Set fan speed mode: ${AirConditioner.FanSpeedMapEnumToString[clampedValue]}`);
                                     await this.melCloudAta.send(this.accountType, this.displayType, deviceData, payload, AirConditioner.EffectiveFlags.SetFanSpeed);
                                 } catch (error) {
                                     if (this.logWarn) this.emit('warn', `Set fan speed mode error: ${error}`);
@@ -1646,16 +1645,16 @@ class DeviceAta extends EventEmitter {
 
                             //fan speed mode
                             if (supportsFanSpeed) {
-                                const max = numberOfFanSpeeds;
-                                const minRaw = supportsAutomaticFanSpeed ? 0 : 1;
-                                const rawFanSpeed = Math.min(Math.max(setFanSpeed, minRaw), max);
-                                // Scale raw fan speed to 0-100 HomeKit range
-                                const scaledFanSpeed = rawFanSpeed === 0 ? 0 : Math.round((rawFanSpeed / max) * 100);
-
-                                obj.currentFanSpeed = scaledFanSpeed;
-                                obj.fanSpeedSetPropsMinValue = 0;
-                                obj.fanSpeedSetPropsMaxValue = 100;
-                                obj.fanSpeedSetPropsMinStep = Math.round(100 / max);
+                                // ograniczamy wartość do zakresu API
+                                const minValue = supportsAutomaticFanSpeed ? 0 : 1;
+                                const maxValue = max;
+
+                                // zabezpieczenie przed out-of-bounds
+                                const clampedValue = Math.min(Math.max(setFanSpeed, minValue), maxValue);
+
+                                obj.currentFanSpeed = clampedValue;
+                                obj.fanSpeedSetPropsMinValue = minValue;
+                                obj.fanSpeedSetPropsMaxValue = maxValue;
                             }
 
                             //create characteristics