homebridge-melcloud-control 4.10.20-beta.2 → 4.10.20-beta.3

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.10.20-beta.2",
+  "version": "4.10.20-beta.3",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -319,6 +319,14 @@ class DeviceAta extends EventEmitter {
                                     const max = numberOfFanSpeeds;
                                     const minValue = supportsAutomaticFanSpeed ? 0 : 1;
                                     const clampedValue = Math.min(Math.max(value, minValue), max);
+
+                                    //Apple Home always resends its own remembered (non-zero) fan speed together with Active when powering on from off
+                                    //Auto (0) can't be represented on that dial, so ignore this phantom value while the unit is off and currently in Auto
+                                    if (!this.accessory.power && this.accessory.currentFanSpeed === 0 && clampedValue !== 0) {
+                                        if (this.logDebug) this.emit('debug', `Ignore set fan speed while powering on from Auto: ${clampedValue}`);
+                                        return;
+                                    }
+
                                     const payload = { setFanSpeed: clampedValue };
                                     if (this.logInfo) this.emit('info', `Set fan speed mode: ${AirConditioner.FanSpeedMapEnumToString[clampedValue]}`);
                                     await this.melCloudAta.send(this.accountType, this.displayType, deviceData, payload, AirConditioner.EffectiveFlags.SetFanSpeed);

package/src/deviceerv.js

@@ -274,17 +274,23 @@ class DeviceErv extends EventEmitter {
                                 minStep: 1
                             })
                             .onGet(async () => {
-                                const value = this.accessory.fanSpeed;
+                                const value = this.accessory.currentFanSpeed;
                                 return value;
                             })
                             .onSet(async (value) => {
                                 try {
-                                    const payload = {};
                                     const max = numberOfFanSpeeds;
                                     const minValue = supportsAutomaticFanSpeed ? 0 : 1;
                                     const clampedValue = Math.min(Math.max(value, minValue), max);
 
-                                     payload.setFanSpeed = clampedValue;
+                                    //Apple Home always resends its own remembered (non-zero) fan speed together with Active when powering on from off
+                                    //Auto (0) can't be represented on that dial, so ignore this phantom value while the unit is off and currently in Auto
+                                    if (!this.accessory.power && this.accessory.currentFanSpeed === 0 && clampedValue !== 0) {
+                                        if (this.logDebug) this.emit('debug', `Ignore set fan speed while powering on from Auto: ${clampedValue}`);
+                                        return;
+                                    }
+
+                                    const payload = { setFanSpeed: clampedValue };
                                     if (this.logInfo) this.emit('info', `Set fan speed mode: ${Ventilation.FanSpeedMapEnumToString[clampedValue]}`);
                                     await this.melCloudErv.send(this.accountType, this.displayType, deviceData, payload, Ventilation.EffectiveFlags.SetFanSpeed);
                                 } catch (error) {
@@ -1215,7 +1221,7 @@ class DeviceErv extends EventEmitter {
                                 { type: Characteristic.TemperatureDisplayUnits, value: obj.useFahrenheit },
                             );
 
-                            if (supportsFanSpeed) characteristics.push({ type: Characteristic.RotationSpeed, value: obj.fanSpeed });
+                            if (supportsFanSpeed) characteristics.push({ type: Characteristic.RotationSpeed, value: obj.currentFanSpeed });
                             if (supportsCoolOperationMode) characteristics.push({ type: Characteristic.CoolingThresholdTemperature, value: Math.max(ventilationMode === 2 ? defaultCoolingSetTemperature : setTemperature, minTempCoolDryAuto) });
                             if (supportsHeatOperationMode) characteristics.push({ type: Characteristic.HeatingThresholdTemperature, value: Math.max(ventilationMode === 2 ? defaultHeatingSetTemperature : setTemperature, minTempHeat) });
                             break;