homebridge-melcloud-control 4.1.3-beta.14 → 4.1.3-beta.15

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.3-beta.14",
+  "version": "4.1.3-beta.15",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -798,15 +798,15 @@ class DeviceAta extends EventEmitter {
                         accessory.addService(this.schedulesControlService);
 
                         if (this.logDebug) this.emit('debug', `Prepare schedule control sensor service`);
-                        this.scheduleSensorService = new Service.ContactSensor(serviceNameSchedule, `Schedule Control Sensor ${deviceId}`);
-                        this.scheduleSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
-                        this.scheduleSensorService.setCharacteristic(Characteristic.ConfiguredName, serviceNameSchedule);
-                        this.scheduleSensorService.getCharacteristic(Characteristic.ContactSensorState)
+                        this.schedulesControlSensorService = new Service.ContactSensor(serviceNameSchedule, `Schedule Control Sensor ${deviceId}`);
+                        this.schedulesControlSensorService.addOptionalCharacteristic(Characteristic.ConfiguredName);
+                        this.schedulesControlSensorService.setCharacteristic(Characteristic.ConfiguredName, serviceNameSchedule);
+                        this.schedulesControlSensorService.getCharacteristic(Characteristic.ContactSensorState)
                             .onGet(async () => {
                                 const state = this.accessory.scheduleEnabled;
                                 return state;
                             })
-                        accessory.addService(this.scheduleSensorService);
+                        accessory.addService(this.schedulesControlSensorService);
                     }
 
                     //sensors
@@ -1104,8 +1104,6 @@ class DeviceAta extends EventEmitter {
                     this.deviceData = deviceData;
 
                     //keys
-                    const presetsIdKey = this.accountType === 'melcloud' ? 'ID' : 'Id';
-                    const setTempKey = this.accountType === 'melcloud' ? 'SetTemperature' : 'SetPoint';
                     const fanKey = this.accountType === 'melcloud' ? 'FanSpeed' : 'SetFanSpeed';
                     const tempStepKey = this.accountType === 'melcloud' ? 'TemperatureIncrement' : 'HasHalfDegreeIncrements';
                     const errorKey = this.accountType === 'melcloud' ? 'HasError' : 'IsInError';
@@ -1374,7 +1372,7 @@ class DeviceAta extends EventEmitter {
                     //update presets state
                     if (this.presets.length > 0) {
                         this.presets.forEach((preset, i) => {
-                            const presetData = presetsOnServer.find(p => p[presetsIdKey] === preset.id);
+                            const presetData = presetsOnServer.find(p => p.ID === preset.id);
 
                             preset.state = presetData ? (presetData.Power === power
                                 && presetData.SetTemperature === setTemperature
@@ -1392,10 +1390,13 @@ class DeviceAta extends EventEmitter {
                     if (this.schedules.length > 0 && scheduleEnabled !== null) {
                         this.schedules.forEach((schedule, i) => {
                             //control
-                            if (i === 0) this.schedulesControlService?.updateCharacteristic(Characteristic.On, scheduleEnabled);
+                            if (i === 0) {
+                                this.schedulesControlService?.updateCharacteristic(Characteristic.On, scheduleEnabled);
+                                this.schedulesControlSensorService?.updateCharacteristic(Characteristic.ContactSensorState, scheduleEnabled);
+                            }
 
                             //sensors
-                            const scheduleData = schedulesOnServer.find(s => s[presetsIdKey] === schedule.id);
+                            const scheduleData = schedulesOnServer.find(s => s.Id === schedule.id);
                             schedule.state = scheduleEnabled ? scheduleData.Enabled ?? false : false;
 
                             const characteristicType = schedule.characteristicType;