homebridge-melcloud-control 4.1.2-beta.80 → 4.1.2-beta.81

package/homebridge-ui/public/index.html

@@ -255,9 +255,9 @@
             if (d.Type === 3) devicesByType.erv.push(d);
           });
 
-          account.ataDevices = (account.ataDevices || []).filter(d => String(d.id) !== '0');
-          account.atwDevices = (account.atwDevices || []).filter(d => String(d.id) !== '0');
-          account.ervDevices = (account.ervDevices || []).filter(d => String(d.id) !== '0');
+          account.ataDevices ??= [];
+          account.atwDevices ??= [];
+          account.ervDevices ??= [];
 
           const removedAta = removeStaleDevices(account.ataDevices, devicesByType.ata);
           const removedAtw = removeStaleDevices(account.atwDevices, devicesByType.atw);
@@ -265,7 +265,7 @@
 
           const handleDevices = (devicesInMelCloud, devicesInConfig, typeString, newArr, newPresets) => {
             try {
-              const configDevicesMap = new Map(devicesInConfig.map(dev => [dev.id, dev]));
+              const configDevicesMap = new Map(devicesInConfig.map(dev => [String(dev.id), dev]));
               const isMelcloud = account.type === 'melcloud';
 
               const idKey = isMelcloud ? 'ID' : 'Id';
@@ -276,6 +276,17 @@
                 const deviceId = String(device.DeviceID);
                 let deviceInConfig = configDevicesMap.get(deviceId);
 
+                // === Remove placeholder devices with id '0' before adding new ===
+                const beforeDevicesCount = devicesInConfig.length;
+                devicesInConfig = devicesInConfig.filter(d => String(d.id) !== '0');
+                if (devicesInConfig.length !== beforeDevicesCount) {
+                  updateInfo('info2', `Removed placeholder devices with id '0'`, 'yellow');
+
+                  // Rebuild map after filtering
+                  configDevicesMap.clear();
+                  devicesInConfig.forEach(dev => configDevicesMap.set(String(dev.id), dev));
+                }
+
                 // === Create device if missing ===
                 if (!deviceInConfig) {
                   deviceInConfig = {
@@ -295,9 +306,11 @@
 
                 // === Process presets/schedules ===
                 const presets = device[typeKey] || [];
-                const presetsInConfig = (deviceInConfig[typeKey1] || []).filter(p => String(p.id) !== '0');
+                const presetsInConfig = deviceInConfig[typeKey1] || [];
                 const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
 
+                let addedNewPreset = false;
+
                 presets.forEach((preset, index) => {
                   const presetId = String(preset[idKey]);
                   if (!presetIds.has(presetId)) {
@@ -310,8 +323,20 @@
                     presetsInConfig.push(presetObj);
                     newPresets.push(presetObj);
                     presetIds.add(presetId);
+                    addedNewPreset = true;
                   }
                 });
+
+                // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
+                if (addedNewPreset) {
+                  const beforeCount = presetsInConfig.length;
+                  deviceInConfig[typeKey1] = presetsInConfig.filter(p => String(p.id) !== '0');
+                  const removedCount = beforeCount - deviceInConfig[typeKey1].length;
+
+                  if (removedCount > 0 && removedCount < beforeCount) {
+                    updateInfo('info2', `Removed ${removedCount} placeholder ${typeKey1} from device ${device.DeviceID}`, 'yellow');
+                  }
+                }
               });
 
               // Return filtered devicesInConfig to make sure upstream code uses it

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.80",
+  "version": "4.1.2-beta.81",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",