homebridge-melcloud-control 4.1.2-beta.72 → 4.1.2-beta.74

package/homebridge-ui/public/index.html

@@ -212,7 +212,7 @@
 
         for (let i = configDevices.length - 1; i >= 0; i--) {
           const device = configDevices[i];
-          if (device.id !== "0" && !melcloudIds.includes(device.id)) {
+          if (!melcloudIds.includes(device.id)) {
             removedDevices.push(device);
             configDevices.splice(i, 1);
           }
@@ -230,6 +230,7 @@
 
       document.getElementById('logIn').addEventListener('click', async () => {
         await homebridge.updatePluginConfig(pluginConfig);
+        await homebridge.savePluginConfig(pluginConfig);
 
         document.getElementById(`logIn`).className = "btn btn-primary";
         updateInfo('info', '', 'white');
@@ -248,21 +249,21 @@
 
           // Initialize devices arrays
           const newDevices = { ata: [], ataPresets: [], atw: [], atwPresets: [], erv: [], ervPresets: [] };
-          const melcloud = { ata: [], atw: [], erv: [] };
+          const melcloudDevices = { ata: [], atw: [], erv: [] };
 
           response.Devices.forEach(d => {
-            if (d.Type === 0) melcloud.ata.push(d);
-            if (d.Type === 1) melcloud.atw.push(d);
-            if (d.Type === 3) melcloud.erv.push(d);
+            if (d.Type === 0) melcloudDevices.ata.push(d);
+            if (d.Type === 1) melcloudDevices.atw.push(d);
+            if (d.Type === 3) melcloudDevices.erv.push(d);
           });
 
           account.ataDevices = (account.ataDevices || []).filter(d => String(d.id) !== '0');
           account.atwDevices = (account.atwDevices || []).filter(d => String(d.id) !== '0');
           account.ervDevices = (account.ervDevices || []).filter(d => String(d.id) !== '0');
 
-          const removedAta = removeStaleDevices(account.ataDevices, melcloud.ata);
-          const removedAtw = removeStaleDevices(account.atwDevices, melcloud.atw);
-          const removedErv = removeStaleDevices(account.ervDevices, melcloud.erv);
+          const removedAta = removeStaleDevices(account.ataDevices, melcloudDevices.ata);
+          const removedAtw = removeStaleDevices(account.atwDevices, melcloudDevices.atw);
+          const removedErv = removeStaleDevices(account.ervDevices, melcloudDevices.erv);
 
           const handleDevices = (devicesInMelCloud, devicesInConfig, typeString, newArr, newPresets) => {
             try {
@@ -274,8 +275,7 @@
               const typeKey1 = isMelcloud ? 'presets' : 'schedules';
 
               devicesInMelCloud.forEach(device => {
-                const deviceId = String(device.DeviceID);
-                let deviceInConfig = configDevicesMap.get(deviceId);
+                let deviceInConfig = configDevicesMap.get(device.DeviceID);
 
                 // === Create device if missing ===
                 if (!deviceInConfig) {
@@ -291,15 +291,15 @@
                   };
                   devicesInConfig.push(deviceInConfig);
                   newArr.push(deviceInConfig);
-                  configDevicesMap.set(deviceId, deviceInConfig);
+                  configDevicesMap.set(device.DeviceID, deviceInConfig);
                 }
 
                 // === Process presets/schedules ===
-                const presets = device[typeKey] || [];
+                const presetsInMelcloud = device[typeKey] || [];
                 const presetsInConfig = (deviceInConfig[typeKey1] || []).filter(p => String(p.id) !== '0');
                 const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
 
-                presets.forEach((preset, index) => {
+                presetsInMelcloud.forEach((preset, index) => {
                   const presetId = String(preset[idKey]);
                   if (!presetIds.has(presetId)) {
                     const presetObj = {
@@ -322,9 +322,9 @@
             }
           };
 
-          account.ataDevices = handleDevices(melcloud.ata, account.ataDevices, "Air Conditioner", newDevices.ata, newDevices.ataPresets);
-          account.atwDevices = handleDevices(melcloud.atw, account.atwDevices, "Heat Pump", newDevices.atw, newDevices.atwPresets);
-          account.ervDevices = handleDevices(melcloud.erv, account.ervDevices, "Energy Recovery Ventilation", newDevices.erv, newDevices.ervPresets);
+          account.ataDevices = handleDevices(melcloudDevices.ata, account.ataDevices, "Air Conditioner", newDevices.ata, newDevices.ataPresets);
+          account.atwDevices = handleDevices(melcloudDevices.atw, account.atwDevices, "Heat Pump", newDevices.atw, newDevices.atwPresets);
+          account.ervDevices = handleDevices(melcloudDevices.erv, account.ervDevices, "Energy Recovery Ventilation", newDevices.erv, newDevices.ervPresets);
 
           const newDevicesCount = newDevices.ata.length + newDevices.atw.length + newDevices.erv.length;
           const newPresetsCount = newDevices.ataPresets.length + newDevices.atwPresets.length + newDevices.ervPresets.length;

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.72",
+  "version": "4.1.2-beta.74",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",