homebridge-melcloud-control 4.1.2-beta.67 → 4.1.2-beta.69

package/homebridge-ui/public/index.html

@@ -255,9 +255,9 @@
             if (d.Type === 3) devicesByType.erv.push(d);
           });
 
-          account.ataDevices ??= [];
-          account.atwDevices ??= [];
-          account.ervDevices ??= [];
+          account.ataDevices = (account.ataDevices || []).filter(d => String(d.id) !== '0');
+          account.atwDevices = (account.atwDevices || []).filter(d => String(d.id) !== '0');
+          account.ervDevices = (account.ervDevices || []).filter(d => String(d.id) !== '0');
 
           const removedAta = removeStaleDevices(account.ataDevices, devicesByType.ata);
           const removedAtw = removeStaleDevices(account.atwDevices, devicesByType.atw);
@@ -265,14 +265,13 @@
 
           const handleDevices = (devicesInMelCloud, devicesInConfig, typeString, newArr, newPresets) => {
             try {
-              const configDevicesMap = new Map(devicesInConfig.map(dev => [String(dev.id), dev]));
+              const configDevicesMap = new Map(devicesInConfig.map(dev => [dev.id, dev]));
               const isMelcloud = account.type === 'melcloud';
 
               const idKey = isMelcloud ? 'ID' : 'Id';
               const typeKey = isMelcloud ? 'Presets' : 'Schedule';
               const typeKey1 = isMelcloud ? 'presets' : 'schedules';
 
-              let addedNewDevice = false;
               devicesInMelCloud.forEach(device => {
                 const deviceId = String(device.DeviceID);
                 let deviceInConfig = configDevicesMap.get(deviceId);
@@ -292,27 +291,13 @@
                   devicesInConfig.push(deviceInConfig);
                   newArr.push(deviceInConfig);
                   configDevicesMap.set(deviceId, deviceInConfig);
-                  addedNewDevice = true;
-                }
-
-                // === Remove placeholder devices (id === '0') if new ones were added ===
-                if (addedNewDevice) {
-                  const beforeCount = devicesInConfig.length;
-                  deviceInConfig = devicesInConfig.filter(d => String(d.id) !== '0');
-                  const removedCount = beforeCount - deviceInConfig.length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info1', `Removed ${removedCount} placeholder from device ${device.DeviceID}`, 'yellow');
-                  }
                 }
 
                 // === Process presets/schedules ===
                 const presets = device[typeKey] || [];
-                const presetsInConfig = deviceInConfig[typeKey1] || [];
+                const presetsInConfig = (deviceInConfig[typeKey1] || []).filter(p => String(p.id) !== '0');
                 const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
 
-                let addedNewPreset = false;
-
                 presets.forEach((preset, index) => {
                   const presetId = String(preset[idKey]);
                   if (!presetIds.has(presetId)) {
@@ -325,20 +310,8 @@
                     presetsInConfig.push(presetObj);
                     newPresets.push(presetObj);
                     presetIds.add(presetId);
-                    addedNewPreset = true;
                   }
                 });
-
-                // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
-                if (addedNewPreset) {
-                  const beforeCount = presetsInConfig.length;
-                  deviceInConfig[typeKey1] = presetsInConfig.filter(p => String(p.id) !== '0');
-                  const removedCount = beforeCount - deviceInConfig[typeKey1].length;
-
-                  if (removedCount > 0 && removedCount < beforeCount) {
-                    updateInfo('info2', `Removed ${removedCount} placeholder ${typeKey1} from device ${device.DeviceID}`, 'yellow');
-                  }
-                }
               });
 
               // Return filtered devicesInConfig to make sure upstream code uses it

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.67",
+  "version": "4.1.2-beta.69",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",