homebridge-melcloud-control 4.1.2-beta.65 → 4.1.2-beta.67

package/homebridge-ui/public/index.html

@@ -272,21 +272,11 @@
               const typeKey = isMelcloud ? 'Presets' : 'Schedule';
               const typeKey1 = isMelcloud ? 'presets' : 'schedules';
 
+              let addedNewDevice = false;
               devicesInMelCloud.forEach(device => {
                 const deviceId = String(device.DeviceID);
                 let deviceInConfig = configDevicesMap.get(deviceId);
 
-                // === Remove placeholder devices with id '0' before adding new ===
-                const beforeDevicesCount = devicesInConfig.length;
-                devicesInConfig = devicesInConfig.filter(d => String(d.id) !== '0');
-                if (devicesInConfig.length !== beforeDevicesCount) {
-                  updateInfo('info2', `Removed placeholder devices with id '0'`, 'yellow');
-
-                  // Rebuild map after filtering
-                  configDevicesMap.clear();
-                  devicesInConfig.forEach(dev => configDevicesMap.set(String(dev.id), dev));
-                }
-
                 // === Create device if missing ===
                 if (!deviceInConfig) {
                   deviceInConfig = {
@@ -302,6 +292,18 @@
                   devicesInConfig.push(deviceInConfig);
                   newArr.push(deviceInConfig);
                   configDevicesMap.set(deviceId, deviceInConfig);
+                  addedNewDevice = true;
+                }
+
+                // === Remove placeholder devices (id === '0') if new ones were added ===
+                if (addedNewDevice) {
+                  const beforeCount = devicesInConfig.length;
+                  deviceInConfig = devicesInConfig.filter(d => String(d.id) !== '0');
+                  const removedCount = beforeCount - deviceInConfig.length;
+
+                  if (removedCount > 0 && removedCount < beforeCount) {
+                    updateInfo('info1', `Removed ${removedCount} placeholder from device ${device.DeviceID}`, 'yellow');
+                  }
                 }
 
                 // === Process presets/schedules ===
@@ -367,12 +369,11 @@
 
           await homebridge.updatePluginConfig(pluginConfig);
           await homebridge.savePluginConfig(pluginConfig);
-          document.getElementById('logIn').className = "btn btn-secondary";
-
         } catch (error) {
           updateInfo('info', `Connect error ${JSON.stringify(error)}`, 'red');
           document.getElementById('logIn').className = "btn btn-secondary";
         } finally {
+          document.getElementById('logIn').className = "btn btn-secondary";
           homebridge.hideSpinner();
         }
       });

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.65",
+  "version": "4.1.2-beta.67",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/melcloudatw.js

@@ -23,7 +23,6 @@ class MelCloudAtw extends EventEmitter {
 
         //set default values
         this.devicesData = {};
-        this.headers = {};
 
         //lock flags
         this.locks = {
@@ -60,7 +59,6 @@ class MelCloudAtw extends EventEmitter {
                 return null;
             }
             const deviceData = devicesData.find(device => device.DeviceID === this.deviceId);
-            this.headers = deviceData.Headers;
 
             if (this.accountType === 'melcloudhome') {
                 deviceData.SerialNumber = deviceData.DeviceID || '4.0.0';
@@ -155,7 +153,7 @@ class MelCloudAtw extends EventEmitter {
                         method: 'POST',
                         baseURL: ApiUrls.BaseURL,
                         timeout: 10000,
-                        headers: this.headers,
+                        headers: deviceData.Headers,
                         withCredentials: true
                     });
 
@@ -193,7 +191,7 @@ class MelCloudAtw extends EventEmitter {
                         method: 'PUT',
                         baseURL: ApiUrlsHome.BaseURL,
                         timeout: 10000,
-                        headers: this.headers,
+                        headers: deviceData.Headers,
                         withCredentials: true
                     });
 

package/src/melclouderv.js

@@ -23,7 +23,6 @@ class MelCloudErv extends EventEmitter {
 
         //set default values
         this.devicesData = {};
-        this.headers = {};
 
         //lock flags
         this.locks = {
@@ -60,7 +59,6 @@ class MelCloudErv extends EventEmitter {
                 return null;
             }
             const deviceData = devicesData.find(device => device.DeviceID === this.deviceId);
-            this.headers = deviceData.Headers;
 
             if (this.accountType === 'melcloudhome') {
                 deviceData.SerialNumber = deviceData.DeviceID || '4.0.0';
@@ -144,7 +142,7 @@ class MelCloudErv extends EventEmitter {
                         method: 'POST',
                         baseURL: ApiUrls.BaseURL,
                         timeout: 10000,
-                        headers: this.headers,
+                        headers: deviceData.Headers,
                         withCredentials: true
                     });
 
@@ -197,7 +195,7 @@ class MelCloudErv extends EventEmitter {
                         method: 'PUT',
                         baseURL: ApiUrlsHome.BaseURL,
                         timeout: 10000,
-                        headers: this.headers,
+                        headers: deviceData.Headers,
                         withCredentials: true
                     });