homebridge-melcloud-control 4.1.2-beta.44 → 4.1.2-beta.46

package/homebridge-ui/public/index.html

@@ -256,11 +256,28 @@
           const handleDevices = (devicesInMelCloud, devicesInConfig, typeString, newArr, newPresets) => {
             try {
               const configDevicesMap = new Map(devicesInConfig.map(dev => [String(dev.id), dev]));
+              const isMelcloud = account.type === 'melcloud';
+
+              const idKey = isMelcloud ? 'ID' : 'Id';
+              const typeKey = isMelcloud ? 'Presets' : 'Schedule';
+              const typeKey1 = isMelcloud ? 'presets' : 'schedules';
 
               devicesInMelCloud.forEach(device => {
                 const deviceId = String(device.DeviceID);
                 let deviceInConfig = configDevicesMap.get(deviceId);
 
+                // === Remove placeholder devices with id '0' before adding new ===
+                const beforeDevicesCount = devicesInConfig.length;
+                devicesInConfig = devicesInConfig.filter(d => String(d.id) !== '0');
+                if (devicesInConfig.length !== beforeDevicesCount) {
+                  updateInfo('info2', `Removed placeholder devices with id '0'`, 'yellow');
+
+                  // Rebuild map after filtering
+                  configDevicesMap.clear();
+                  devicesInConfig.forEach(dev => configDevicesMap.set(String(dev.id), dev));
+                }
+
+                // === Create device if missing ===
                 if (!deviceInConfig) {
                   deviceInConfig = {
                     id: device.DeviceID,
@@ -277,14 +294,13 @@
                   configDevicesMap.set(deviceId, deviceInConfig);
                 }
 
-                const idKey = account.type === 'melcloud' ? 'ID' : 'Id';
-                const typeKey = account.type === 'melcloud' ? 'Presets' : 'Schedule';
-                const typeKey1 = account.type === 'melcloud' ? 'presets' : 'schedules';
+                // === Process presets/schedules ===
                 const presets = device[typeKey] || [];
-
                 const presetsInConfig = deviceInConfig[typeKey1] || [];
                 const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
 
+                let addedNewPreset = false;
+
                 presets.forEach((preset, index) => {
                   const presetId = String(preset[idKey]);
                   if (!presetIds.has(presetId)) {
@@ -297,11 +313,27 @@
                     presetsInConfig.push(presetObj);
                     newPresets.push(presetObj);
                     presetIds.add(presetId);
+                    addedNewPreset = true;
                   }
                 });
+
+                // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
+                if (addedNewPreset) {
+                  const beforeCount = presetsInConfig.length;
+                  deviceInConfig[typeKey1] = presetsInConfig.filter(p => String(p.id) !== '0');
+                  const removedCount = beforeCount - deviceInConfig[typeKey1].length;
+
+                  if (removedCount > 0 && removedCount < beforeCount) {
+                    updateInfo('info2', `Removed ${removedCount} placeholder ${typeKey1} from device ${device.DeviceID}`, 'yellow');
+                  }
+                }
               });
+
+              // Return filtered devicesInConfig to make sure upstream code uses it
+              return devicesInConfig;
+
             } catch (error) {
-              updateInfo('info1', `Error while processing device: ${error.message || error}`, 'red');
+              updateInfo('info', `Error while processing device: ${JSON.stringify(error)}`, 'red');
             }
           };
 
@@ -329,8 +361,7 @@
           document.getElementById('logIn').className = "btn btn-secondary";
 
         } catch (error) {
-          updateInfo('info', 'Connect error.', 'yellow');
-          updateInfo('info1', `${JSON.stringify(error)}`, 'red');
+          updateInfo('info', `Connect error ${JSON.stringify(error)}`, 'red');
           document.getElementById('logIn').className = "btn btn-secondary";
         } finally {
           homebridge.hideSpinner();

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.44",
+  "version": "4.1.2-beta.46",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",