homebridge-melcloud-control 4.1.2-beta.43 → 4.1.2-beta.45

package/homebridge-ui/public/index.html

@@ -254,47 +254,75 @@
           const removedErv = removeStaleDevices(account.ervDevices, devicesByType.erv);
 
           const handleDevices = (devicesInMelCloud, devicesInConfig, typeString, newArr, newPresets) => {
-            devicesInMelCloud.forEach(device => {
-              const deviceObj = {
-                id: device.DeviceID,
-                type: device.Type,
-                typeString,
-                displayType: 0,
-                name: device.DeviceName,
-                presets: [],
-                schedules: [],
-                buttonsSensors: []
-              };
-
-              if (!devicesInConfig.some(dev => String(dev.id) === device.DeviceID)) {
-                devicesInConfig.push(deviceObj);
-                newArr.push(deviceObj);
-              }
-
-              const deviceInConfig = devicesInConfig.find(dev => String(dev.id) === device.DeviceID);
-              if (deviceInConfig) {
-                const idKey = account.type === 'melcloud' ? 'ID' : 'Id';
-                const typeKey = account.type === 'melcloud' ? 'Presets' : 'Schedule';
-                const typeKey1 = account.type === 'melcloud' ? 'presets' : 'schedules';
-                const presets = device[typeKey] || [];
-                presets.forEach((preset, index) => {
-                  const presetObj = {
-                    id: preset[idKey],
+            try {
+              const configDevicesMap = new Map(devicesInConfig.map(dev => [String(dev.id), dev]));
+              const isMelcloud = account.type === 'melcloud';
+
+              const idKey = isMelcloud ? 'ID' : 'Id';
+              const typeKey = isMelcloud ? 'Presets' : 'Schedule';
+              const typeKey1 = isMelcloud ? 'presets' : 'schedules';
+
+              devicesInMelCloud.forEach(device => {
+                const deviceId = String(device.DeviceID);
+                let deviceInConfig = configDevicesMap.get(deviceId);
+
+                // === Create device if missing ===
+                if (!deviceInConfig) {
+                  deviceInConfig = {
+                    id: device.DeviceID,
+                    type: device.Type,
+                    typeString,
                     displayType: 0,
-                    name: preset.NumberDescription || `Schedule ${index}`,
-                    namePrefix: false
+                    name: device.DeviceName,
+                    presets: [],
+                    schedules: [],
+                    buttonsSensors: []
                   };
+                  devicesInConfig.push(deviceInConfig);
+                  newArr.push(deviceInConfig);
+                  configDevicesMap.set(deviceId, deviceInConfig);
+                }
+
+                // === Process presets/schedules ===
+                const presets = device[typeKey] || [];
+                const presetsInConfig = deviceInConfig[typeKey1] || [];
+                const presetIds = new Set(presetsInConfig.map(p => String(p.id)));
+
+                let addedNewPreset = false;
 
-                  const presetsInConfig = deviceInConfig[typeKey1] || [];
-                  if (!presetsInConfig.some(pres => String(pres.id) === preset[idKey])) {
+                presets.forEach((preset, index) => {
+                  const presetId = String(preset[idKey]);
+                  if (!presetIds.has(presetId)) {
+                    const presetObj = {
+                      id: presetId,
+                      displayType: 0,
+                      name: preset.NumberDescription || `Schedule ${index}`,
+                      namePrefix: false
+                    };
                     presetsInConfig.push(presetObj);
                     newPresets.push(presetObj);
+                    presetIds.add(presetId);
+                    addedNewPreset = true;
                   }
                 });
-              }
-            });
+
+                // === Remove placeholder presets/schedules (id === '0') if new ones were added ===
+                if (addedNewPreset) {
+                  const beforeCount = presetsInConfig.length;
+                  deviceInConfig[typeKey1] = presetsInConfig.filter(p => String(p.id) !== '0');
+                  const removedCount = beforeCount - deviceInConfig[typeKey1].length;
+
+                  if (removedCount > 0 && removedCount < beforeCount) {
+                    updateInfo('info', `Removed ${removedCount} placeholder ${typeKey1} from device ${device.DeviceID}`, 'yellow');
+                  }
+                }
+              });
+            } catch (error) {
+              updateInfo('info', `Error while processing device: ${error.message || error}`, 'red');
+            }
           };
 
+
           handleDevices(devicesByType.ata, account.ataDevices, "Air Conditioner", newDevices.ata, newDevices.ataPresets);
           handleDevices(devicesByType.atw, account.atwDevices, "Heat Pump", newDevices.atw, newDevices.atwPresets);
           handleDevices(devicesByType.erv, account.ervDevices, "Energy Recovery Ventilation", newDevices.erv, newDevices.ervPresets);

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.43",
+  "version": "4.1.2-beta.45",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",