homebridge-melcloud-control 4.1.2-beta.20 → 4.1.2-beta.4

package/homebridge-ui/public/index.html

@@ -224,6 +224,8 @@
 
       document.getElementById('logIn').addEventListener('click', async () => {
         document.getElementById(`logIn`).className = "btn btn-primary";
+
+        updateInfo('info', 'Connecting...', 'yellow');
         homebridge.showSpinner();
 
         try {

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.1.2-beta.20",
+  "version": "4.1.2-beta.4",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",

package/src/deviceata.js

@@ -766,7 +766,7 @@ class DeviceAta extends EventEmitter {
                         })
                         .onSet(async (state) => {
                             try {
-                                const fanKey = this.accountType === 'melcloud' ? 'FanSpeed' : 'SetFanSpeed';
+                                const key = this.accountType === 'melcloud' ? 'FanSpeed' : 'SetFanSpeed';
                                 let effectiveFlags = null;
                                 switch (mode) {
                                     case 0: //POWER ON,OFF
@@ -1018,7 +1018,7 @@ class DeviceAta extends EventEmitter {
 
                     //keys
                     const presetsKey = this.accountType === 'melcloud' ? 'Presets' : 'Schedule';
-                    const presetsIdKey = this.accountType === 'melcloud' ? 'ID' : 'Id';
+                    const presetsIdKey = accountType === 'melcloud' ? 'ID' : 'Id';
                     const setTempKey = this.accountType === 'melcloud' ? 'SetTemperature' : 'SetPoint';
                     const fanKey = this.accountType === 'melcloud' ? 'FanSpeed' : 'SetFanSpeed';
                     const tempStepKey = this.accountType === 'melcloud' ? 'TemperatureIncrement' : 'HasHalfDegreeIncrements';
@@ -1035,12 +1035,12 @@ class DeviceAta extends EventEmitter {
                     const presetsOnServer = deviceData[presetsKey] ?? [];
 
                     //protection
-                    const frostProtectionEnabled = deviceData.FrostProtection?.Enabled;
-                    const frostProtectionActive = deviceData.FrostProtection?.Active;
-                    const overheatProtectionEnabled = deviceData.OverheatProtection?.Enabled;
-                    const overheatProtectionActive = deviceData.OverheatProtection?.Active;
-                    const holidayModeEnabled = deviceData.HolidayMode?.Enabled;
-                    const holidayModeActive = deviceData.HolidayMode?.Active;
+                    const frostProtectionEnabled = deviceData.FrostProtection?.enabled;
+                    const frostProtectionActive = deviceData.FrostProtection?.active;
+                    const overheatProtectionEnabled = deviceData.OverheatProtection?.enabled;
+                    const overheatProtectionActive = deviceData.OverheatProtection?.active;
+                    const holidayModeEnabled = deviceData.HolidayMode?.enabled;
+                    const holidayModeActive = deviceData.HolidayMode?.active;
                     const scheduleEnabled = deviceData.ScheduleEnabled;
 
                     //device control

package/src/melcloud.js

@@ -235,67 +235,51 @@ class MelCloud extends EventEmitter {
             if (this.logDebug) this.emit('debug', `Buildings list saved`);
 
             const devices = buildingsList.flatMap(building => {
-                // Funkcja kapitalizująca klucze obiektu
-                const capitalizeKeys = obj =>
-                    Object.fromEntries(
-                        Object.entries(obj).map(([key, value]) => [
-                            key.charAt(0).toUpperCase() + key.slice(1),
-                            value
-                        ])
-                    );
-
-                // Rekurencyjna kapitalizacja kluczy w obiekcie lub tablicy
+                // Rekurencyjna funkcja kapitalizująca klucze w całym obiekcie (bezpieczna)
                 const capitalizeKeysDeep = obj => {
-                    if (Array.isArray(obj)) return obj.map(capitalizeKeysDeep);
-                    if (obj && typeof obj === 'object') {
+                    if (Array.isArray(obj)) {
+                        return obj.map(item => capitalizeKeysDeep(item));
+                    } else if (obj && typeof obj === 'object' && obj.constructor === Object) {
                         return Object.fromEntries(
-                            Object.entries(obj).map(([key, value]) => [
-                                key.charAt(0).toUpperCase() + key.slice(1),
-                                capitalizeKeysDeep(value)
-                            ])
+                            Object.entries(obj).map(([key, value]) => {
+                                const safeKey = typeof key === 'string'
+                                    ? key.charAt(0).toUpperCase() + key.slice(1)
+                                    : key;
+                                return [safeKey, capitalizeKeysDeep(value)];
+                            })
                         );
                     }
                     return obj;
                 };
 
                 // Funkcja tworząca finalny obiekt Device
-                const createDevice = (device, type) => {
-                    // Settings już kapitalizowane w nazwach
-                    const settingsArray = device.Settings || [];
+                const createDevice = (device, type, headers = {}) => {
+                    const settingsArray = Array.isArray(device.Settings) ? device.Settings : [];
 
                     const settingsObject = Object.fromEntries(
-                        settingsArray.map(({ name, value }) => {
-                            let parsedValue = value;
-                            if (value === "True") parsedValue = true;
-                            else if (value === "False") parsedValue = false;
-                            else if (!isNaN(value) && value !== "") parsedValue = Number(value);
-
-                            const key = name.charAt(0).toUpperCase() + name.slice(1);
-                            return [key, parsedValue];
-                        })
+                        settingsArray
+                            .filter(item => item && typeof item.name === 'string') // 🔒 tylko poprawne wpisy
+                            .map(({ name, value }) => {
+                                let parsedValue = value;
+                                if (value === "True") parsedValue = true;
+                                else if (value === "False") parsedValue = false;
+                                else if (typeof value === 'string' && !isNaN(Number(value)) && value.trim() !== "") parsedValue = Number(value);
+
+                                const key = name.charAt(0).toUpperCase() + name.slice(1);
+                                return [key, parsedValue];
+                            })
                     );
 
-                    // Scal Capabilities + Settings + DeviceType w Device
                     const deviceObject = {
-                        ...capitalizeKeys(device.Capabilities || {}),
+                        ...capitalizeKeysDeep(device.Capabilities || {}),
                         ...settingsObject,
                         DeviceType: type
                     };
 
-                    // Kapitalizacja brakujących obiektów/tablic
-                    if (device.FrostProtection) device.FrostProtection = { ...capitalizeKeys(device.FrostProtection || {}) };
-                    if (device.OverheatProtection) device.OverheatProtection = { ...capitalizeKeys(device.OverheatProtection || {}) };
-                    if (device.HolidayMode) device.HolidayMode = { ...capitalizeKeys(device.HolidayMode || {}) };
-
-                    if (Array.isArray(device.Schedule)) {
-                        device.Schedule = device.Schedule.map(capitalizeKeysDeep);
-                    }
-
-                    // Usuń stare pola Settings i Capabilities
                     const { Settings, Capabilities, Id, GivenDisplayName, ...rest } = device;
 
                     return {
-                        ...rest,
+                        ...capitalizeKeysDeep(rest),
                         Type: type,
                         DeviceID: Id,
                         DeviceName: GivenDisplayName,
@@ -304,13 +288,14 @@ class MelCloud extends EventEmitter {
                     };
                 };
 
+                // Mapowanie urządzeń
                 return [
-                    ...(building.airToAirUnits || []).map(d => createDevice(capitalizeKeys(d), 0)),
-                    ...(building.airToWaterUnits || []).map(d => createDevice(capitalizeKeys(d), 1)),
-                    ...(building.airToVentilationUnits || []).map(d => createDevice(capitalizeKeys(d), 3))
+                    ...(building.airToAirUnits || []).map(d => createDevice(capitalizeKeysDeep(d), 0)),
+                    ...(building.airToWaterUnits || []).map(d => createDevice(capitalizeKeysDeep(d), 1)),
+                    ...(building.airToVentilationUnits || []).map(d => createDevice(capitalizeKeysDeep(d), 3))
                 ];
-            });
 
+            });
 
             const devicesCount = devices.length;
             if (devicesCount === 0) {