homebridge-melcloud-control 4.0.0-beta.86 → 4.0.0-beta.88

package/homebridge-ui/public/index.html

@@ -97,15 +97,29 @@
   <script>
     (async () => {
       const pluginConfig = await homebridge.getPluginConfig();
+
+      // Ensure proper structure on load
       if (!pluginConfig.length) {
-        pluginConfig.push({});
+        pluginConfig.push({ accounts: [] });
         await homebridge.updatePluginConfig(pluginConfig);
         homebridge.showSchemaForm();
         return;
       }
+      pluginConfig[0].accounts ??= [];
+
+      // Deep clone to prevent shared arrays
+      if (Array.isArray(pluginConfig?.[0]?.accounts)) {
+        pluginConfig[0].accounts = pluginConfig[0].accounts.map(acc => ({
+          ...acc,
+          ataDevices: Array.isArray(acc.ataDevices) ? [...acc.ataDevices] : [],
+          devices: Array.isArray(acc.devices) ? [...acc.devices] : [],
+          buildings: Array.isArray(acc.buildings) ? [...acc.buildings] : [],
+        }));
+      }
 
       this.accountIndex = 0;
       const accountsCount = pluginConfig[0].accounts.length;
+
       for (let i = 0; i < accountsCount; i++) {
         const acc = pluginConfig[0].accounts[i];
         const button = document.createElement("button");
@@ -131,20 +145,25 @@
           document.getElementById('logIn').disabled = !(acc.name && acc.user && acc.passwd && acc.language && acc.displayType);
         });
 
-        if (i === accountsCount - 1) document.getElementById(`button0`).click();
+        if (i === accountsCount - 1 && accountsCount > 0)
+          document.getElementById(`button0`).click();
+
         this.accountIndex = i;
       }
 
       document.getElementById('melCloudAccount').style.display = 'block';
+
+      // Safe update
       document.getElementById('configForm').addEventListener('input', async () => {
         const acc = pluginConfig[0].accounts[this.accountIndex];
+        if (!acc) return;
         acc.name = document.querySelector('#name').value;
         acc.user = document.querySelector('#user').value;
         acc.passwd = document.querySelector('#passwd').value;
         acc.language = document.querySelector('#language').value;
         acc.displayType = document.querySelector('#displayType').value;
 
-        document.getElementById('logIn').disabled = !(acc.name && acc.user && acc.passwd && acc.languaged && acc.displayType);
+        document.getElementById('logIn').disabled = !(acc.name && acc.user && acc.passwd && acc.language && acc.displayType);
 
         await homebridge.updatePluginConfig(pluginConfig);
         await homebridge.savePluginConfig(pluginConfig);
@@ -200,16 +219,6 @@
         document.getElementById(`logIn`).className = "btn btn-primary";
         updateInfo('info', 'Connecting...', 'yellow');
 
-        // Ensure each account has independent device arrays (avoid shared references)
-        if (Array.isArray(pluginConfig?.[0]?.accounts)) {
-          pluginConfig[0].accounts = pluginConfig[0].accounts.map(acc => ({
-            ...acc,
-            ataDevices: Array.isArray(acc.ataDevices) ? structuredClone(acc.ataDevices) : [],
-            atwDevices: Array.isArray(acc.atwDevices) ? structuredClone(acc.atwDevices) : [],
-            ervDevices: Array.isArray(acc.ervDevices) ? structuredClone(acc.ervDevices) : []
-          }));
-        }
-
         try {
           const acc = pluginConfig[0].accounts[this.accountIndex];
           const payload = { accountName: acc.name, user: acc.user, passwd: acc.passwd, language: acc.language, displayType: acc.displayType };
@@ -233,13 +242,9 @@
           const removedAtw = removeStaleDevices(acc.atwDevices, devicesByType.atw);
           const removedErv = removeStaleDevices(acc.ervDevices, devicesByType.erv);
 
-          // Function to handle device & presets
-          // Function to handle devices & presets safely (deep cloning)
           const handleDevices = (devicesInCloud, devicesInConfig, typeString, newArr, newPresets) => {
             devicesInCloud.forEach(device => {
               const { DeviceID: id, Type: type, DeviceName: name, Presets: presets = [] } = device;
-
-              // Create a cloned device object
               const devObj = structuredClone({
                 id,
                 type,
@@ -250,13 +255,11 @@
                 buttonsSensors: []
               });
 
-              // Add device if not exists
               if (!devicesInConfig.some(d => d.id === id)) {
                 devicesInConfig.push(devObj);
-                newArr.push(structuredClone(devObj)); // also clone into new devices list
+                newArr.push(structuredClone(devObj));
               }
 
-              // Add presets safely
               presets.forEach(preset => {
                 const p = structuredClone({
                   id: preset.ID,
@@ -274,12 +277,10 @@
             });
           };
 
-          // Call for each device type
           handleDevices(devicesByType.ata, acc.ataDevices, "Air Conditioner", newDevices.ata, newDevices.ataPresets);
           handleDevices(devicesByType.atw, acc.atwDevices, "Heat Pump", newDevices.atw, newDevices.atwPresets);
           handleDevices(devicesByType.erv, acc.ervDevices, "Energy Recovery Ventilation", newDevices.erv, newDevices.ervPresets);
 
-          // Summary info
           const newDevicesCount = newDevices.ata.length + newDevices.atw.length + newDevices.erv.length;
           const newPresetsCount = newDevices.ataPresets.length + newDevices.atwPresets.length + newDevices.ervPresets.length;
           const removedDevicesCount = removedAta.length + removedAtw.length + removedErv.length;
@@ -295,12 +296,10 @@
               updateInfo('info2', `Removed devices: ATA: ${removedAta.length}, ATW: ${removedAtw.length}, ERV: ${removedErv.length}.`, 'orange');
           }
 
-          //  Correct save (must be array)
           await homebridge.updatePluginConfig(pluginConfig);
           await homebridge.savePluginConfig(pluginConfig);
           document.getElementById('logIn').className = "btn btn-secondary";
 
-
         } catch (error) {
           updateInfo('info', 'Check Your credentials data and try again.', 'yellow');
           updateInfo('info1', `Error: ${JSON.stringify(error)}`, 'red');

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.0.0-beta.86",
+  "version": "4.0.0-beta.88",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",