homebridge-melcloud-control 4.0.0-beta.82 → 4.0.0-beta.84

package/homebridge-ui/public/index.html

@@ -146,8 +146,8 @@
 
         document.getElementById('logIn').disabled = !(acc.name && acc.user && acc.passwd && acc.languaged && acc.displayType);
 
-        await homebridge.updatePluginConfig(acc);
-        await homebridge.savePluginConfig(acc);
+        await homebridge.updatePluginConfig(pluginConfig);
+        await homebridge.savePluginConfig(pluginConfig);
       });
 
       // --- Config Button Toggle ---
@@ -179,7 +179,7 @@
 
         for (let i = configDevices.length - 1; i >= 0; i--) {
           const device = configDevices[i];
-          if (device.id !== 0 && !melcloudIds.includes(device.id)) {
+          if (device.id !== "0" && !melcloudIds.includes(device.id)) {
             removedDevices.push(device);
             configDevices.splice(i, 1);
           }
@@ -224,33 +224,52 @@
           const removedErv = removeStaleDevices(acc.ervDevices, devicesByType.erv);
 
           // Function to handle device & presets
+          // Function to handle devices & presets safely (deep cloning)
           const handleDevices = (devicesInCloud, devicesInConfig, typeString, newArr, newPresets) => {
             devicesInCloud.forEach(device => {
               const { DeviceID: id, Type: type, DeviceName: name, Presets: presets = [] } = device;
-              const devObj = { id, type, typeString, name, displayMode: 1, presets: [], buttonsSensors: [] };
+
+              // Create a cloned device object
+              const devObj = structuredClone({
+                id,
+                type,
+                typeString,
+                name,
+                displayMode: 1,
+                presets: [],
+                buttonsSensors: []
+              });
+
+              // Add device if not exists
               if (!devicesInConfig.some(d => d.id === id)) {
                 devicesInConfig.push(devObj);
-                newArr.push(devObj);
+                newArr.push(structuredClone(devObj)); // also clone into new devices list
               }
-              presets.forEach(p => {
-                p.id = p.ID;
-                p.name = p.NumberDescription;
-                p.displayType = 0;
-                p.namePrefix = false;
+
+              // Add presets safely
+              presets.forEach(preset => {
+                const p = structuredClone({
+                  id: preset.ID,
+                  name: preset.NumberDescription,
+                  displayType: 0,
+                  namePrefix: false
+                });
+
                 const devConfig = devicesInConfig.find(d => d.id === id);
-                if (devConfig && !devConfig.presets.some(x => x.id === p.ID)) {
+                if (devConfig && !devConfig.presets.some(x => x.id === p.id)) {
                   devConfig.presets.push(p);
-                  newPresets.push(p);
+                  newPresets.push(structuredClone(p));
                 }
               });
             });
           };
 
+          // Call for each device type
           handleDevices(devicesByType.ata, acc.ataDevices, "Air Conditioner", newDevices.ata, newDevices.ataPresets);
           handleDevices(devicesByType.atw, acc.atwDevices, "Heat Pump", newDevices.atw, newDevices.atwPresets);
-          handleDevices(devicesByType.erv, acc.ervDevices, "Energy Recovery ventiltion", newDevices.erv, newDevices.ervPresets);
+          handleDevices(devicesByType.erv, acc.ervDevices, "Energy Recovery Ventilation", newDevices.erv, newDevices.ervPresets);
 
-          // Display summary
+          // Summary info
           const newDevicesCount = newDevices.ata.length + newDevices.atw.length + newDevices.erv.length;
           const newPresetsCount = newDevices.ataPresets.length + newDevices.atwPresets.length + newDevices.ervPresets.length;
           const removedDevicesCount = removedAta.length + removedAtw.length + removedErv.length;
@@ -258,15 +277,20 @@
           if (!newDevicesCount && !newPresetsCount && !removedDevicesCount) {
             updateInfo('info', 'No changes detected.', 'white');
           } else {
-            if (newDevicesCount) updateInfo('info', `Found new devices: ATA: ${newDevices.ata.length}, ATW: ${newDevices.atw.length}, ERV: ${newDevices.erv.length}.`, 'green');
-            if (newPresetsCount) updateInfo('info1', `Found new presets: ATA: ${newDevices.ataPresets.length}, ATW: ${newDevices.atwPresets.length}, ERV: ${newDevices.ervPresets.length}.`, 'green');
-            if (removedDevicesCount) updateInfo('info2', `Removed devices: ATA: ${removedAta.length}, ATW: ${removedAtw.length}, ERV: ${removedErv.length}.`, 'orange');
+            if (newDevicesCount)
+              updateInfo('info', `Found new devices: ATA: ${newDevices.ata.length}, ATW: ${newDevices.atw.length}, ERV: ${newDevices.erv.length}.`, 'green');
+            if (newPresetsCount)
+              updateInfo('info1', `Found new presets: ATA: ${newDevices.ataPresets.length}, ATW: ${newDevices.atwPresets.length}, ERV: ${newDevices.ervPresets.length}.`, 'green');
+            if (removedDevicesCount)
+              updateInfo('info2', `Removed devices: ATA: ${removedAta.length}, ATW: ${removedAtw.length}, ERV: ${removedErv.length}.`, 'orange');
           }
 
+          //  Correct save (must be array)
           await homebridge.updatePluginConfig(pluginConfig);
           await homebridge.savePluginConfig(pluginConfig);
           document.getElementById('logIn').className = "btn btn-secondary";
 
+
         } catch (error) {
           updateInfo('info', 'Check Your credentials data and try again.', 'yellow');
           updateInfo('info1', `Error: ${JSON.stringify(error)}`, 'red');

package/package.json

@@ -1,7 +1,7 @@
 {
   "displayName": "MELCloud Control",
   "name": "homebridge-melcloud-control",
-  "version": "4.0.0-beta.82",
+  "version": "4.0.0-beta.84",
   "description": "Homebridge plugin to control Mitsubishi Air Conditioner, Heat Pump and Energy Recovery Ventilation.",
   "license": "MIT",
   "author": "grzegorz914",